| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| tansell | llnz, ping me when you have a moment or two | 00:34 |
|---|---|---|
| llnz | now is fine | 00:34 |
| llnz | tansell: ping | 00:36 |
| tansell | llnz, pong | 00:58 |
| tansell | Greywhind, ping? | 01:09 |
| tansell | we totally missed our meeting | 01:10 |
| Greywhind | tansell: oh, true | 01:10 |
| tansell | Greywhind, where is the media stuff at? | 01:10 |
| Greywhind | tansell: i've dealt with all the comments on issue 10002 | 01:10 |
| Greywhind | tansell: i've started a bit on the other ones | 01:10 |
| llnz | brb, reboot to linux | 01:11 |
| *** llnz has quit IRC | 01:11 | |
| Greywhind | tansell: the reason the binds aren't part of the mixin is that the mixin would then have to define the OnMediaUpdate, which always deals with panel-specific stuff, so there's no real common code there | 01:12 |
| Greywhind | tansell: and DownloadAbortEvents aren't needed by any of the panels, only by the downloads window | 01:12 |
| tansell | Greywhind, it can define an empty OnMediaUpdate | 01:12 |
| Greywhind | tansell: true | 01:12 |
| tansell | Greywhind, the DownloadAbortEvents means download of some media failed | 01:12 |
| tansell | it's never going to arrive | 01:12 |
| tansell | so if you waiting on it - that's not going to work | 01:13 |
| Greywhind | tansell: right, but the panels don't wait, they just display something else and then, if it happens to eventually arrive, they update the display | 01:13 |
| tansell | It shouldn't say "waiting" if it's been aborted | 01:14 |
| *** llnz has joined #tp | 01:15 | |
| tansell | and I think your mistaken on the lack of commonality in OnMediaUpdate | 01:15 |
| Greywhind | tansell: they each call their own functions when the media update happens. | 01:16 |
| tansell | got the code handy? | 01:17 |
| Greywhind | some update a single object, some update everything, etc. | 01:17 |
| Greywhind | for panelInfo: | 01:17 |
| Greywhind | def OnMediaUpdate(self, evt): | 01:17 |
| Greywhind | if (self.current == -1): | 01:17 |
| Greywhind | return | 01:17 |
| Greywhind | self.OnSelectObject(self.application.cache.objects[self.current]) | 01:17 |
| Greywhind | whereas for SystemIcons: | 01:17 |
| Greywhind | def OnMediaUpdate(self, evt): self.UpdateAll() | 01:17 |
| Greywhind | self.UpdateAll() | 01:17 |
| Greywhind | for panelPicture, it's completely different | 01:18 |
| Greywhind | so i could add the binds and an empty method to the mixin, but it won't decrease the code much | 01:19 |
| Greywhind | i'll do it if you think that's a good idea though | 01:19 |
| tansell | you upload the latest version? | 01:22 |
| Greywhind | tansell: not yet, still working on the changes | 01:22 |
| *** jmtan has joined #tp | 01:23 | |
| tansell | okay | 01:28 |
| llnz | bbl | 01:47 |
| * llnz wanders off to NZ python users group meeting | 01:47 | |
| *** llnz has quit IRC | 01:47 | |
| alanp | ezod: ping | 01:48 |
| alanp | ezod: I don't seem to get the same warnings as you, am building with -Wall | 01:49 |
| Greywhind | tansell: any idea what might be causing this error | 01:55 |
| Greywhind | Traceback (most recent call last): | 01:55 |
| Greywhind | File "./tpclient-pywx", line 130, in Post | 01:55 |
| Greywhind | function(event) | 01:55 |
| Greywhind | File "libtpclient-py/tp/client/threads.py", line 892, in OnMediaDownloadDone | 01:55 |
| Greywhind | if self.CheckURL(evt.file): | 01:55 |
| Greywhind | File "/usr/lib/python2.6/site-packages/wx-2.8-gtk2-unicode/wx/_core.py", line 14524, in __getattr__ | 01:55 |
| Greywhind | raise PyDeadObjectError(self.attrStr % self._name) | 01:55 |
| Greywhind | PyDeadObjectError: The C++ part of the FoldPanel object has been deleted, attribute access no longer allowed. | 01:56 |
| tansell | your accessing an object which the C++ side thinks as been deleted | 01:57 |
| Greywhind | hm | 01:59 |
| Greywhind | it never did that before... | 01:59 |
| Greywhind | oh, got it | 02:02 |
| Greywhind | tansell: http://codereview.mithis.com/10002 | 02:13 |
| tpb | Title: Issue 10002: Added threaded downloading, fixed up code in media.py - Code Review (at codereview.mithis.com) | 02:13 |
| Greywhind | tansell: http://codereview.mithis.com/9001 | 02:16 |
| tpb | Title: Issue 9001: Improved media support by centralizing media calls and adding a download manager. - Code Review (at codereview.mithis.com) | 02:16 |
| *** jmtan1 has joined #tp | 02:51 | |
| *** nebajoth_ has joined #tp | 02:56 | |
| *** jmtan has quit IRC | 03:07 | |
| *** nebajoth has quit IRC | 03:09 | |
| *** Greywhind has quit IRC | 03:19 | |
| *** nash has quit IRC | 03:22 | |
| *** jmtan1 has quit IRC | 04:23 | |
| *** alanp has quit IRC | 05:14 | |
| *** alanp has joined #tp | 05:15 | |
| *** nebajoth_ is now known as nebaway | 05:15 | |
| *** jernejovc has joined #tp | 05:37 | |
| *** alanp has quit IRC | 06:00 | |
| *** nebajothz has joined #tp | 06:04 | |
| *** alanp has joined #tp | 06:06 | |
| *** nebaway has quit IRC | 06:17 | |
| CIA-26 | epyon tpserver-cpp-refactor * r1d171d8ae2a2 /tpserver/ (adminconnection.cpp adminlogger.cpp adminlogger.h): AdminLogger now holds a shared pointer, and has no more dangerous methods | 07:16 |
| CIA-26 | epyon tpserver-cpp-refactor * r939042e99536 /tpserver/ (playeragent.cpp playeragent.h): PlayerAgent doesn't need getConnection | 07:16 |
| CIA-26 | epyon tpserver-cpp-refactor * r9dea2dba2c5c /tpserver/playeragent.cpp: PlayerAgent minor cleanups | 07:16 |
| epyon | ls | 07:17 |
| epyon | damn wrong window ^_^ | 07:17 |
| * tansell beats his head against stupid daylight savings issues | 07:47 | |
| *** tansell-laptop has joined #tp | 07:53 | |
| CIA-26 | epyon tpserver-cpp-refactor * r58edb4444af3 /tpserver/ (playeragent.cpp playerview.cpp playerview.h): PlayerAgent vs PlayerView -- moved get* frame processing to player agent | 08:16 |
| CIA-26 | epyon tpserver-cpp-refactor * r712d4a8bfd4a /tpserver/ (objecttypemanager.cpp objecttypemanager.h playeragent.cpp): OrderType processing moved to PlayerAgent | 08:16 |
| *** cherez1 has joined #tp | 08:44 | |
| *** cherez has quit IRC | 08:44 | |
| CIA-26 | epyon tpserver-cpp-refactor * rf7d4e31a1c91 /tpserver/ (ordermanager.cpp ordermanager.h playeragent.cpp): OrderManager getOrderTypeIds frame processing moved to PlayerAgent | 09:00 |
| CIA-26 | epyon tpserver-cpp-refactor * ra9a6ab4198d0 /tpserver/ (4 files): PlayerAgent now takes a shared_ptr to PlayerConnection -- internally it's stored as a weak_ptr, but converted to shared_ptr on processing | 09:00 |
| CIA-26 | epyon tpserver-cpp-refactor * r938678e7fe90 /tpserver/ (playeragent.h playerconnection.cpp playerconnection.h): PlayerAgent now held as a shared_ptr | 09:00 |
| epyon | yay, weak_ptr FTW | 09:00 |
| CIA-26 | epyon tpserver-cpp-refactor * rcaf2d43c2f4d /tpserver/ (logging.cpp logging.h logsink.h): Logging now holds shared_ptr's to LogSinks | 09:17 |
| CIA-26 | epyon tpserver-cpp-refactor * rd93a970baac5 /tpserver/ (adminconnection.cpp adminconnection.h): AdminLogging fixed | 09:17 |
| epyon | ls | 09:29 |
| epyon | damn :P | 09:29 |
| *** tuna-fish has quit IRC | 10:32 | |
| *** mithro has quit IRC | 10:32 | |
| *** tansell-laptop has quit IRC | 10:36 | |
| *** bddebian has joined #tp | 10:42 | |
| *** jmtan has joined #tp | 10:48 | |
| *** mithro has joined #tp | 10:52 | |
| *** tansell-laptop has joined #tp | 10:59 | |
| *** Greywhind has joined #tp | 11:18 | |
| tote | damn list arguments are kinda hard :/ | 13:32 |
| *** Erroneous has joined #tp | 13:41 | |
| *** alanp_ has joined #tp | 14:33 | |
| *** DTRemenak has quit IRC | 14:51 | |
| *** DTRemenak has joined #tp | 14:53 | |
| *** alanp__ has joined #tp | 15:01 | |
| *** alanp_ has quit IRC | 15:17 | |
| *** alanp__ has quit IRC | 15:46 | |
| *** nebajoth has joined #tp | 16:01 | |
| *** llnz has joined #tp | 16:13 | |
| *** nebajothz has quit IRC | 16:17 | |
| CIA-26 | alanp tpserver-cpp-mtsec * r63ca44072ac9 /modules/games/mtsec/ (6 files): Various cleanups. | 16:27 |
| llnz | morning all | 16:30 |
| *** bddebian has quit IRC | 16:32 | |
| CIA-26 | alanp tpserver-cpp-mtsec * rb93abfea3398 /modules/games/mtsec/xmlimport.cpp: xmlimport.cpp warning fix | 16:38 |
| alanp | hey llnz | 16:39 |
| llnz | hi alanp | 16:39 |
| alanp | weird warning | 16:41 |
| alanp | uint32_t damage = fleet->getDamage(); | 16:41 |
| alanp | uint32_t Fleet::getDamage() const{ | 16:41 |
| alanp | uint32_t damageNeeded = static_cast<uint32_t>(ds->getDesign(shipNumber)->getPropertyValue(hpPropID)); | 16:41 |
| alanp | if (damage >= damageNeeded) { | 16:41 |
| alanp | gives double -> uint32_t warning on damage >= damageNeeded | 16:42 |
| alanp | what did i screw up here? | 16:42 |
| llnz | umm... | 16:44 |
| llnz | not sure, that line looks alright | 16:44 |
| alanp | i thought so too | 16:44 |
| * alanp will ignore for now | 16:45 | |
| CIA-26 | joelboh tpclient-pyweb * r8cc57f55b0d2 / (backend/middleman.py frontend/scripts/map.js): List argument type is now working. | 16:59 |
| CIA-26 | alanp tpserver-cpp-mtsec * r22e7ffb6a705 /modules/games/mtsec/avacombat.cpp: My eyes are playing tricks on me, fixed pesky warning. | 17:06 |
| *** tuna-fish has joined #tp | 18:25 | |
| *** tuna-fish has quit IRC | 18:30 | |
| epyon | Anyone know a linux tool to count non-comment lines of code? | 19:41 |
| tansell-laptop | epyon, sloccount | 19:42 |
| llnz | sloccount | 19:42 |
| tansell-laptop | llnz, snap! | 19:42 |
| llnz | it powers our sloc page | 19:42 |
| epyon | thanks! | 19:43 |
| epyon | llnz: can you run sloccount on the main tpserver and tell me just the loc (without tinyxml)? Just academic curiosity | 19:45 |
| llnz | i don't have access to source currently, sorry | 19:46 |
| epyon | tansell-laptop: ? | 19:46 |
| llnz | epyon: btw, the last time i checked, avahi and mzscheme were broken | 19:46 |
| epyon | llnz: I know | 19:47 |
| llnz | ok | 19:47 |
| epyon | I'll fix them right after I come back from vacation | 19:48 |
| epyon | mysqlpersistence is also broken, but it's only a couple of fixes | 19:48 |
| epyon | there are tests to be made after I finish the current part anyway. | 19:49 |
| epyon | also integration of the mtsec branch | 19:49 |
| epyon | I'm sure it will be easier for me to integrate alanp's code than for him to integrate it into mine :> | 19:50 |
| alanp | uh oh | 19:54 |
| *** tansell-laptop has quit IRC | 20:00 | |
| *** mithro has quit IRC | 20:00 | |
| *** Vadtec has quit IRC | 20:13 | |
| epyon | tansell, llnz : (Not so) final report published, maybe you'd like to take a look :) | 20:18 |
| llnz | will do shortly | 20:18 |
| epyon | http://tp.chaosforge.org/ | 20:19 |
| tpb | Title: Thousand Parsec - GSoC 2009 (at tp.chaosforge.org) | 20:19 |
| epyon | btw, llnz, I'd like to have some tracker for the further work on the refactor branch (once GSoC is over I'll need some more organization to the tasks ahead to motivate me) -- those TP have such services, or should I rollup my own? | 20:23 |
| epyon | I don't want to mess up the google code one, if I did it'd have like 95% tasks related to the refactor branch -_- | 20:24 |
| llnz | tracker? as in bug or ticket tracking? | 20:24 |
| llnz | just use the google one, noone else does | 20:24 |
| epyon | heh, that doesn't sound much positive :P | 20:25 |
| epyon | the sad thing is that I realized that I almost completely failed on the original objectives :/ | 20:26 |
| *** tansell-laptop has joined #tp | 20:34 | |
| *** Greywhind has quit IRC | 20:49 | |
| *** jnengland77 has joined #tp | 20:58 | |
| *** jmtan has quit IRC | 21:13 | |
| *** Vadtec has joined #tp | 21:22 | |
| *** bddebian has joined #tp | 21:39 | |
| *** Erroneous has quit IRC | 23:02 | |
| *** Greywhind has joined #tp | 23:06 | |
| Greywhind | tansell: ping? | 23:06 |
| CIA-26 | landon tpclient-pyogre * r60bab7b6ee7f /src/battlemanager.py: Starts playing automatically | 23:48 |
| CIA-26 | landon tpclient-pyogre * rec2ab60906d5 /src/ (battlemanager.py participant.py): Added a better lock checker since the frame listeners generally don't have access to the battle manager | 23:48 |
| CIA-26 | landon tpclient-pyogre * rf1af11d848b5 /src/ (battlemanager.py move.py): Moving now locks properly\! | 23:48 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!