*** tpb has joined #symbiflow | 00:00 | |
*** adjtm has joined #symbiflow | 00:08 | |
*** adjtm_ has quit IRC | 00:09 | |
*** HeHemEmE has quit IRC | 00:22 | |
wallacejohn | ZirconiumX: Yes, that is the end goal. To clarify, are you suggesting update all scripts (50ish, not all Python2) in a single pull request? Is that too much change for a single pull request? | 00:39 |
---|---|---|
ZirconiumX | My personal criteria is not about size but completeness | 00:40 |
ZirconiumX | I don't see much point in having a state where only *some* files are Py2 | 00:40 |
wallacejohn | Makes sense. I will update and test all of the scripts before submitting a pull request. | 00:44 |
*** wallacejohn has quit IRC | 00:50 | |
*** wallacejohn has joined #symbiflow | 00:59 | |
*** wallacejohn has quit IRC | 01:08 | |
*** wallacejohn has joined #symbiflow | 01:21 | |
*** _whitelogger has quit IRC | 01:30 | |
*** _whitelogger has joined #symbiflow | 01:32 | |
*** citypw has joined #symbiflow | 01:50 | |
*** az0re has joined #symbiflow | 01:56 | |
*** _whitelogger has quit IRC | 02:21 | |
*** _whitelogger has joined #symbiflow | 02:23 | |
*** Alaa501 has joined #symbiflow | 05:17 | |
*** _whitelogger has quit IRC | 05:36 | |
*** _whitelogger has joined #symbiflow | 05:38 | |
*** wallacejohn has quit IRC | 06:00 | |
*** OmniMancer has joined #symbiflow | 06:07 | |
*** Alaa501 has quit IRC | 06:36 | |
*** _whitelogger has quit IRC | 06:54 | |
*** _whitelogger has joined #symbiflow | 06:56 | |
*** Bertl_oO is now known as Bertl_zZ | 07:20 | |
*** OmniMancer has quit IRC | 12:34 | |
*** adjtm_ has joined #symbiflow | 12:58 | |
*** adjtm has quit IRC | 13:00 | |
*** Bertl_zZ is now known as Bertl | 13:02 | |
*** citypw has quit IRC | 13:08 | |
*** citypw has joined #symbiflow | 13:15 | |
*** Bertl is now known as Bertl_oO | 15:58 | |
*** ljungk has joined #symbiflow | 16:00 | |
ljungk | Hey, does the Project X-ray stuff work with the Digilent CMOD A-7 board? It uses the same Artix-7 35T that the Arty has. | 16:02 |
sf-slack | <acomodi> ljungk: Yes, if it is an a35T then support is already there. What may be missing is just the pin mapping. What exact part does the CMOD A-7 have? | 16:07 |
*** ljungk has quit IRC | 16:08 | |
sf-slack | <karl.ljungkvist> @acomodi It has this part: XC7A35T-1CPG236C | 16:08 |
*** ljungk has joined #symbiflow | 16:11 | |
sf-slack | <acomodi> @karl.ljungkvist Ok, so I think there should be no problem with it and is ready to be used | 16:11 |
*** citypw has quit IRC | 16:41 | |
*** Bertl_oO is now known as Bertl | 17:03 | |
*** Bertl is now known as Bertl_oO | 17:19 | |
mithro | ZirconiumX: Smaller pull requests are better, easier to convert one script at a time | 17:32 |
ZirconiumX | mithro: what's the difference between 50 script conversions and 50 script conversions? | 18:34 |
hackerfoo | ZirconiumX: The difference is that you can pipeline smaller PRs :) | 18:40 |
ZirconiumX | That's what commits are for | 18:40 |
hackerfoo | I agree, I'd rather do a single PR with incremental reviews, but most people won't do this. They only want to look at a PR once. | 18:42 |
hackerfoo | e.g. release early and release often applied to PRs. | 18:43 |
hackerfoo | I'd like to use a PR more as a subscription to work in progress. | 18:46 |
*** tpb has joined #symbiflow | 19:20 | |
*** OmniMancer has joined #symbiflow | 20:27 | |
*** OmniMancer has quit IRC | 20:32 | |
*** OmniMancer has joined #symbiflow | 20:33 | |
*** wallacejohn has joined #symbiflow | 21:06 | |
wallacejohn | mithro, ZirconiumX, hackerfoo: Regarding the pull request discussion, I'm going to try submitting smaller PRs as I go. I've converted and tested only a handful of scripts so far, so probably better for me as a beginner to get something in the pull request pipeline before I've put too much work into my first contribution. | 21:11 |
hackerfoo | wallacejohn: Sounds good | 21:12 |
mithro | wallacejohn: Always good to ask the person who owns the repository you are submitting too... | 21:12 |
wallacejohn | mithro: still new to github -- looks like the vtr-verilog-to-routing repo is owned by a group/org, is that correct? is the owner active on this channel? | 21:19 |
*** OmniMancer has quit IRC | 21:19 | |
mithro | kmurray in #vtr-dev would be the right person, but I'm pretty sure we can say that he would prefer small pull requests | 21:20 |
*** kuldeep has joined #symbiflow | 23:35 | |
*** HEGAZY has joined #symbiflow | 23:48 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!