Tuesday, 2009-02-03

*** tpb has joined #melange00:00
*** dmitrig01|afk has quit IRC01:07
*** dmitrig01|afk has joined #melange01:07
*** ChanServ sets mode: +v dmitrig01|afk01:07
*** mithro has quit IRC01:10
*** dmitrig01|afk has quit IRC01:27
*** dmitrig01|afk has joined #melange01:28
*** ChanServ sets mode: +v dmitrig01|afk01:28
*** dmitrig01|afk is now known as dmitrig0101:29
*** penyaskito has quit IRC01:30
*** dmitrig01 has quit IRC01:45
*** madrazr has quit IRC01:46
*** mithro has joined #melange02:02
*** ChanServ sets mode: +v mithro02:02
*** scorche has quit IRC03:23
*** scorche has joined #melange03:23
*** scorche has quit IRC04:04
*** scorche has joined #melange04:04
*** mithro has quit IRC04:49
*** MatthewWilkes has joined #melange05:28
*** scorche has quit IRC05:55
*** scorche has joined #melange05:55
*** MatthewWilkes has quit IRC06:50
*** MatthewWilkes has joined #melange06:56
*** MatthewWilkes has quit IRC07:04
*** MatthewWilkes has joined #melange07:10
*** MatthewWilkes has quit IRC07:34
*** MatthewWilkes has joined #melange07:39
*** solydzajs has joined #melange07:52
*** ChanServ sets mode: +o solydzajs07:52
*** Lennie has joined #melange07:57
*** ChanServ sets mode: +v Lennie07:57
*** solydzajs has quit IRC08:00
*** MatthewWilkes has quit IRC08:00
*** MatthewWilkes has joined #melange08:02
*** madrazr has joined #melange08:19
*** MatthewWilkes is now known as mwilkes|lunch08:35
*** Merio has joined #melange08:48
madrazrLennie: Hi :)08:56
*** mwilkes|lunch is now known as MatthewWilkes09:17
MatthewWilkesafternoon Lennie09:22
Lenniehi MatthewWilkes09:22
Lennielets see09:33
Lenniehouse heroes09:33
Lennieor big bang theory09:33
LennieI'll take a small break, BBT it is. bbl09:33
*** Lennie is now known as Lennie|Gone09:33
MatthewWilkesLennie|Gone: Good call.  You seen the IT Crowd?09:34
Lennie|GoneI've seen it a few times09:35
Lennie|GoneI dont follow it though09:35
Lennie|Gonebut its nice :D09:35
Lennie|Goneanyhow bbl09:35
*** SRabbelier has joined #melange09:53
*** ChanServ sets mode: +v SRabbelier09:53
SRabbelierMerio: ping09:56
MerioSRabbelier: pong :)10:00
SRabbelierMerio: I applied your patch, but it looks weird :-./10:00
MerioSRabbelier: what appens?10:00
SRabbelierMerio: he completion shows up as a regular (dotted) list just below the input box in for example site setting10:01
MerioSRabbelier: is the thickbox in the /jquery path?10:02
SRabbelierMerio: I tried adding thickbox, but maybe I did somethign wrong somehow10:02
Lennie|Goneyou added thickbox and the pictures :D?10:02
Lennie|Gonealso a IE7 fix needs to be applied :P?10:02
*** Lennie|Gone is now known as Lennie10:02
SRabbelierLennie|Gone: yup10:02
Lennie(not that you are using IE7)10:02
Lenniebut still10:02
SRabbelierMerio: perhaps you can send it as one patch (inlcuding thickbox)?10:03
MerioSRabbelier: ok, is there a problem if I'm sending it in 4 hours or such? (coding for exam as yesterday) :)10:04
SRabbelierMerio: sure, no hurries10:05
MerioSRabbelier: ok, I'll do :) Also I'll change the behavior to multiple:false and showing the link id instead of the title (I'm going to see if both of them can be searchable) so it become a more "real" patch :)10:08
SRabbelierLennie: What is the point in being able to check if someone has an incative role? Isn't it supposed to be impossible to do anything if your role i inactive?10:40
SRabbelierMerio: ah, awesome :)10:40
Lenniedata retention10:40
Lennieyou need to be able to see your last years student10:40
Lenniebut you cant edit stuff10:40
SRabbelierLennie: but... inactive == no longer able to do anything?10:41
SRabbelierLennie: or is that invalid?10:41
Lennieinvalid is kicked cant do stuff10:41
Lennieinactive is can't change stuff :D10:41
SRabbelierLennie: mhh, ok10:41
SRabbelierLennie: so the new checkHasRole will be ~ a copy/paste of the old one, only with the 'status': 'active', line removed?10:41
SRabbelierLennie: mhhh, no10:42
SRabbelierLennie: just needs to check it's active or inactive, yes?10:42
Lenniesince edit == active only10:42
SRabbelierLennie: so should checkHasRole check for inactive, or also allow active?10:43
Lenniedepends on what this checkHasRole does10:43
SRabbelierLennie: I dunno, what should it do?10:43
Lenniedoes it check if the role belongs to the group given in django_args?10:43
SRabbelierLennie: should it?10:44
SRabbelierLennie: you weren't very clear in your commit msg10:44
LennieWe need one that just checks if you have a role for the given logic10:44
Lenniethat's active10:45
Lennieone that uses django_args to see if you have a role for the group_mentioned in it that is either active/inactive10:45
Lennieand one that is active only10:45
SRabbelierLennie: so 'checkHasRole, 'checkHasActiveRole', 'checkHasRoleForGroup', and 'checkHasActiveRoleForGroup'10:45
Lennieshould be fine10:46
Lennieyou can make the one call the other internally :)10:46
SRabbelierLennie: sounds like they could all call one function10:46
Lennieinternally please10:46
Lennieso from the view it's clear what happens10:46
SRabbelierLennie: that's what I was suggesting10:46
*** Lennie is now known as Lennie|Gone11:11
*** Lennie|Gone is now known as Lennie12:01
*** Lennie is now known as Lennie|Food12:06
*** madrazr1 has joined #melange12:37
*** madrazr has quit IRC12:38
*** madrazr1 is now known as madrazr12:38
*** MatthewWilkes has quit IRC12:45
*** MatthewWilkes has joined #melange12:55
*** madrazr has quit IRC13:06
*** madrazr has joined #melange14:03
*** MatthewWilkes has quit IRC14:17
*** Lennie|Food is now known as Lennie14:25
*** madrazr has quit IRC14:47
MerioSRabbelier: I'm going to output the diff patch (thickbox included). Send you in your private email?15:01
SRabbelierMerio: sure, np :)15:01
MerioSRabbelier: sent :) Now you can see the documents being searched for "link_id (title)", but only the link_id will be inside the textbox when you choose one doc15:08
SRabbelierMerio: very nice!15:08
MerioSRabbelier: so now I look in the JSON for "link_id" and "title", we need to generalize that for other things beside docs :)15:09
SRabbelierMerio: yes, we do :)15:10
MerioSRabbelier: however, if you've time try to see if it works now15:10
SRabbelierMerio: I will!15:10
*** MatthewWilkes has joined #melange15:20
*** penyaskito has joined #melange15:47
*** Merio has quit IRC16:10
Lennienn all :)16:45
*** Lennie has quit IRC16:46
*** Merio has joined #melange16:50
SRabbelierMerio: ping17:10
SRabbelierMerio: patching file soc/templates/soc/templatetags/_as_table_row.html17:11
SRabbelierpatch: **** malformed patch at line 1575: Index: soc/templates/soc/base.html17:11
MerioSRabbelier: ops... let me see :)17:12
SRabbelierMerio: :)17:12
MerioHmm strange17:13
SRabbelierMerio: I applied it from /soc with patch -p017:14
SRabbelierfrom /app17:14
SRabbelierMerio: I also tried 'git apply -p0' but same results :)17:14
MerioSRabbelier: sent another time... try again ;)17:22
SRabbelierMerio: ok!17:22
SRabbelierMerio: fancy!17:41
SRabbelierMerio: it works now, very nice box too17:41
MerioSRabbelier: great :)17:46
SRabbelierMerio: I'll review the code tomorrow and apply :)17:46
MerioSRabbelier: ok :) Please remember that now works only in the documents... so perhaps we'll need to port all the scripts inclusions only when appropriate (and not in base)17:47
SRabbelierMerio: ah, yes17:47
SRabbelierMerio: I'd point that out during review :P17:48
MerioSRabbelier: Perfect :)17:48
SRabbelierMerio: at least, I'd like to think that :P17:48
MerioSRabbelier: I'll be online tomorrow, so you can contact me for everything if useful. Perhaps we can try to do some lazy loading as well17:49
SRabbelierMerio: ok! I will :)17:49
MerioGoing home to sleep a bit ;) Good night all :)17:57
SRabbelierMerio: ok man, g'night :)17:57
MerioSRabbelier: g'night :)17:58
*** Merio has quit IRC17:58
*** lisppaste9 has quit IRC18:34
lhSRabbelier: ping18:39
SRabbelierlh: pong18:40
*** lisppaste9 has joined #melange18:40
lhSRabbelier: so the select your backup administrator when creating a club application is borked18:45
lhlogging a bug now18:45
SRabbelierlh: ok, will ook into it tomorrow18:45
SRabbelierlh: Merio fixed the selector thingy though, so that's awesome18:45
SRabbelierlh: going to bed now :)18:48
lhSRabbelier: no worries, i am surprised you answered. :) thanks dear and sleep well. :)18:48
lhoh and tell lennie i got his poster - you'll see him before i do18:48
SRabbelierlh: ^___^, thanks, I will18:49
SRabbelierlh: will do18:49
*** SRabbelier has quit IRC18:49
tlarsenlh: I will cut another Melange official release when issue 182 is fixed.18:53
tlarsenlh: Then, I can quickly cut a new official Google release and get it up on socghop.18:53
tlarsenlh: That bug had appeared in a related form some time ago (with a different selector, I think).  I thought it was fixed by now, but it appears to be in a new place.18:53
tlarsenlh: Ah, here it is:  http://code.google.com/p/soc/issues/detail?id=16018:54
tpb<http://ln-s.net/2o4w> (at code.google.com)18:54
lhI also noted it was related to another issue possibly, http://code.google.com/p/soc/issues/detail?id=16918:56
tpbTitle: Issue 169 - soc - Cannot view all of the User list when selecting a backup admin - Google Code (at code.google.com)18:56
lhnoted in the issue report.18:56
lhThat bug is blocking me doing further testing for now, but I have a start on some stuff I can document.18:56
* lh goes to a meeting18:56
tlarsenlh: We've been promised by the committers that Document will not break.  :)18:56
lhtlarsen: that's fine, i still intend to publish FAQs on code.google.com/soc/ for now.19:08
tlarsenlh: OK.19:09
* lh goes back to meeting, stops being distracted19:09
tlarsenlh: We need to get the Club stuff fixed and get a real ToS before we can point people at socghop to play with it anyway.19:09
lhi am working on the tos, stay tuned. as soon as i get blessing from legal, then life is good.19:13
* lh goes back to meeting again again19:13
*** tlarsen has quit IRC20:13
*** lh has quit IRC20:31
*** mithro has joined #melange22:29
*** ChanServ sets mode: +v mithro22:29
*** dmitrig01|afk has joined #melange22:39
*** ChanServ sets mode: +v dmitrig01|afk22:39
*** MatthewWilkes has quit IRC22:48
*** johndbritton has joined #melange23:06
*** dmitrig01|afk is now known as dmitrig0123:10
*** madrazr has joined #melange23:13

Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!