Friday, 2009-01-23

*** tpb has joined #melange00:00
*** dmitrig01|afk has joined #melange01:14
*** ChanServ sets mode: +v dmitrig01|afk01:14
*** mithro has quit IRC01:15
*** dmitrig01|afk is now known as dmitrig0101:33
*** dmitrig01 has quit IRC02:14
*** solydzajs has joined #melange03:23
*** ChanServ sets mode: +o solydzajs03:23
*** no_mind has left #melange03:28
*** solydzajs has quit IRC03:45
*** solydzajs has joined #melange03:46
*** ChanServ sets mode: +o solydzajs03:46
*** solydzajs has quit IRC03:56
*** r0bby has quit IRC03:57
*** lisppaste9 has quit IRC03:57
*** durin42 has quit IRC03:57
*** Landon has quit IRC03:57
*** r0bby has joined #melange03:58
*** lisppaste9 has joined #melange03:58
*** Landon has joined #melange03:58
*** durin42 has joined #melange03:58
*** irc.freenode.net sets mode: +v durin4203:58
*** Lennie has joined #melange04:09
*** ChanServ sets mode: +v Lennie04:09
*** MatthewWilkes has joined #melange04:45
*** MatthewWilkes has quit IRC04:47
*** MatthewWilkes has joined #melange04:47
*** solydzajs has joined #melange05:45
*** ChanServ sets mode: +o solydzajs05:45
*** Merio has joined #melange06:04
*** MatthewWilkes has quit IRC06:08
*** MatthewWilkes has joined #melange06:09
*** mithro has joined #melange06:23
*** ChanServ sets mode: +v mithro06:23
*** mithro has quit IRC06:36
*** mithro has joined #melange06:37
*** ChanServ sets mode: +v mithro06:37
Lenniephew07:07
LennieI'm glad that's pushed :P07:07
Lennietime for lunch :D07:07
Lenniebyebye07:07
*** Lennie has quit IRC07:07
*** SRabbelier has joined #melange07:10
*** ChanServ sets mode: +v SRabbelier07:10
*** MatthewWilkes has quit IRC07:39
*** solydzajs has quit IRC07:58
*** solydzajs has joined #melange07:59
*** ChanServ sets mode: +o solydzajs07:59
*** Merio has quit IRC07:59
*** Lennie has joined #melange10:01
*** ChanServ sets mode: +v Lennie10:01
Lenniesolydzajs10:01
Lennieyou around?10:02
solydzajsLennie: yes10:02
solydzajsLennie: what's up ?10:03
Lenniejust wondering if you want to discuss the patch :p?10:03
Lenniebefore you have to go in 30 min10:03
solydzajsyou will be online after match ?10:03
LennieI might be10:04
solydzajsok what time ?10:04
Lennieno idea10:04
Lennieit's an away match10:04
solydzajsbefore midnight ?10:04
Lennieprobably yes10:04
SRabbelierlol :P10:04
Lenniebut I can't guarantee you anything :P10:04
solydzajsok let's discuss then10:04
solydzajsI will commit my timeline bug fix then too10:05
Lenniefine by me10:05
Lenniehttp://code.google.com/p/googleappengine/issues/detail?id=100710:05
tpb<http://ln-s.net/2kao> (at code.google.com)10:05
Lenniestar the issue:P10:05
SRabbelierlol10:05
Lennieshameless plug ^_^10:06
solydzajsI did that already10:06
solydzajs:-)10:06
solydzajswhen you posted it10:06
Lenniehehe10:06
Lennieso you are the 2nd star :P10:06
SRabbelierI'm the third :P10:07
solydzajs:D10:07
solydzajsok bbl10:07
Lenniebye10:07
*** tlarsen has joined #melange10:48
*** ChanServ sets mode: +o tlarsen10:48
*** mib_6jkrz3 has joined #melange10:55
*** atulagrwl has joined #Melange10:55
*** mib_6jkrz3 has quit IRC10:57
*** dmitrig01|afk has joined #melange11:16
*** ChanServ sets mode: +v dmitrig01|afk11:16
*** Merio has joined #melange11:17
*** dmitrig01|afk has quit IRC11:24
*** solydzajs has quit IRC12:07
*** solydzajs has joined #melange12:08
*** ChanServ sets mode: +o solydzajs12:08
*** no_mind has joined #melange12:17
no_mindhi12:18
Lenniehi12:27
*** mithro has quit IRC12:38
*** penyaskito has quit IRC12:41
*** tanoku has joined #melange12:44
Lenniebyebye, time to build a wobot SRabbelier :P12:52
*** Lennie has quit IRC12:53
*** mrs_spearce has joined #melange13:08
*** mrs_spearce has left #melange13:10
*** Merio has quit IRC13:58
*** atulagrwl has quit IRC15:03
SRabbeliersolydzajs, tlarsen: ping15:03
tlarsenSRabbelier: hello15:03
SRabbeliertlarsen: I have finished the final-last stage of a 'reference picker' :)15:03
tlarsenSRabbelier: OK.15:04
SRabbeliertlarsen: there is one downside15:04
tlarsenSRabbelier: Which is?15:04
SRabbeliertlarsen: in order to know what 'picker' to redirect to, I need to include an extra attribute in the model15:05
SRabbeliertlarsen: that is, for the soc.models.presence.Presence one, I have:   home.redirect_url = 'document'15:05
tlarsenCan you just attach that attribute to the property?15:05
SRabbelierand also   tos.redirect_url = 'document'15:05
tlarsenSRabbelier: That seems OK to me.15:05
SRabbeliertlarsen: for group_app, we have backup_admin.redirect_url = 'user'15:06
tlarsenSRabbelier: Is it not possible to determine the reference type from the ReferenceProperty, though?15:06
SRabbeliertlarsen: well, I can get to the property, but I guess you already knew that since Im retrieving redirect_url and all15:06
SRabbeliertlarsen: the problem is, the ReferenceProprty only holds reference_class=...15:07
SRabbelierand then another model instance15:07
SRabbelierwhat we could instead do15:07
SRabbelieris store the redirect_url as a property in the model15:07
tlarsenIsn't reference_class enough?15:07
SRabbelierI need to somehow translate from reference_class to reference_url, (so from soc.models.Document to 'document')15:07
tlarsenWhy not add a constant to the Document Model class?15:08
SRabbeliertlarsen: that would work15:08
SRabbeliertlarsen: that's why I'm asking mostly15:08
tlarsenI think this is currently in the logic class right now, though, right?15:08
SRabbeliertlarsen: if you'd rather have that, or as a property to the model15:08
SRabbeliertlarsen: in view even15:08
SRabbeliertlarsen: as the url_name field15:08
tlarsenOne nice thing about adding it as an attribute to the property is that its absence would mean "don't use a picker".15:08
tlarsenThe presence of the attribute (found with hasattr()) would indicate that a picker should be used.15:09
SRabbeliertlarsen: exactly, that's how I do it currently15:09
tlarsenSo, I think I like your idea of adding it as an attribute to the ReferenceProperty.15:09
tlarsenOnly ReferenceProperties that want a picker UI used would specify the additional attribute.15:09
SRabbeliertlarsen: it does mean we repeat the url a gazzillion times though15:09
SRabbelierif we ever change from 'document' to 'doc' as url_name we have to replace it everywhere15:10
tlarsenI don't see how to avoid that while also not ending up with circular imports.15:10
SRabbeliertlarsen: how would you do it ignoring circular imports?15:10
tlarsenMaybe you need a constant in soc.models.document.Document that says what it is, and then say foo_ref.selector_url = soc.models.document.Document.REDIRECT_URL15:11
tlarsen(I'm just making the names up, I haven't thought about it enough...)15:11
SRabbeliertlarsen: another way to specify whether we want a picker15:11
SRabbeliertlarsen: is to say 'only make one if the field name ends in link_id'15:11
SRabbelierthat's what I did first15:11
SRabbelierso home_link_id15:11
tlarsenThe Model class that contains the ReferenceProperty is importing soc.models.document anyway, to get the Document class for the reference_class argument.15:11
SRabbelieris translated to 'home'15:11
tlarsenUgh, no.15:12
SRabbelierok :)15:12
tlarsenDon't use name-of-field stuff.15:12
tlarsenSo, here is what I would suggest:15:12
SRabbelierwhat you said above makes sense15:12
tlarsen1) Take all of these constant strings and put them in the Model classes.15:12
tlarsen2) when setting the "redirect_url" (or whatever the attribute ends up being called) of a ReferenceProperty (in order to cause a pick-list UI to be used), just access that constant from the Model class15:13
SRabbelierok15:13
SRabbeliercan do :)15:13
tlarsen3) maybe update the logic class to get the constant from the Model, since it is importing the Model class anyway.15:13
SRabbeliershould be no more than 5 minutes of work :)15:13
tlarsenThat way, the information only appears in the Model class module.15:13
* SRabbelier nods15:13
SRabbelierok, sure :)15:13
tlarsenThis improves the DRY without adding any dependencies that weren't already there.15:14
SRabbelieryup, very nice15:14
tlarsenConstant stuff, text messages (like example_text, help_text) stick to the model.  Other stuff gets it from there.15:14
tlarsenYou need not do this with *all* of the string constants in a logic class.  Just the ones that are ending up used *outside* of that logic class.15:15
SRabbelier:D15:15
SRabbelierI like not having to do a lot of work :P15:15
tlarsenSRabbelier: Yeah, you make *massive* refactorings of the code base look so *easy*.  :)15:17
SRabbelierhehe, that's what I'm good at though15:18
SRabbelierfinding abstractions15:18
SRabbelierit's hard to come up with them beforehand15:18
SRabbelierI would have never thought of the whole params thing at the start15:18
SRabbelierI'd probably have told you it's a retarded idea :P15:18
tlarsenYeah, that is why code gets cut-and-pasted first, as a prototyping step.15:19
SRabbelier^__^15:19
tlarsenThen, you pay off the technical debt that is accumulating in the codebase by refactoring (and writing tests, which we *aren't* doing).15:19
SRabbeliertlarsen: if I get my internship, a large part will be writing us a test suite :)15:20
tlarsenSRabbelier: Any idea who would be your intern host?15:20
SRabbeliertlarsen: spearce is willing to be a host15:21
SRabbeliertlarsen: he put my resume in the internal recommendation thing15:21
SRabbeliertlarsen: I hope I hear back from Google before end of next month though... I need to know what's up about that time15:22
SRabbeliertlarsen: omg, it's working15:30
SRabbeliertlarsen: document picker: SUCCESS!15:30
tlarsenSRabbelier: you are going to use it for the "home" and "tos" selection in Site settings (and other Presence), right?15:31
SRabbeliertlarsen: it's already working for those :D15:32
tlarsenSRabbelier: Nice.15:32
SRabbeliertlarsen:  20 files changed, 202 insertions(+), 41 deletions(-)16:03
*** tlarsen has left #melange16:03
SRabbelierfull commitdiff: full16:04
SRabbelierhttp://pastebin.com/m1f58bb6d16:04
tpbTitle: pastebin - collaborative debugging tool (at pastebin.com)16:04
SRabbeliersolydzajs: ping16:25
*** Lennie has joined #melange16:54
*** ChanServ sets mode: +v Lennie16:54
solydzajsSRabbelier: pong17:40
SRabbeliersolydzajs: wb17:40
SRabbeliersolydzajs: we have a (limited) document picker17:40
solydzajsSRabbelier: reading back log17:44
SRabbeliersolydzajs: ok :)17:52
solydzajsSRabbelier: reading done :-)18:00
solydzajsSRabbelier: congrats on document picker, I will go thru review in a minute18:00
solydzajsSRabbelier: what's next ?18:00
SRabbeliersolydzajs: uhm... good question18:03
solydzajsSRabbelier: Orgs ?18:04
SRabbeliersolydzajs: Lennie is working on that18:05
Lennie?18:06
Lennieyeah18:06
LennieI am doing important stuff for the orgs yeah18:06
Lenniebut not directly yet18:06
solydzajsSRabbelier: can you do program visibility on/off switch ?18:07
solydzajsSRabbelier: that shouldn't take too long18:07
SRabbeliersolydzajs: what should it do?18:08
solydzajsSRabbelier: in the program settings you should have on/off switch that indicates whether program is visible for anybody other than Hosts and Developers18:08
solydzajsSRabbelier: basically Leslie can create GHOP 2009 or GSoC 2009 and all the public views, sidebars etc should not be accessible if the program visibility is off18:09
SRabbeliersolydzajs: ok...18:09
SRabbeliersolydzajs: I'll look into that18:09
solydzajsSRabbelier: I don't expect that too take long, you ?18:10
SRabbelierdunno18:10
SRabbeliermight be a lot of work18:10
solydzajsSRabbelier: investigate and let me know how long it will take you, we might have more important tasks18:12
solydzajsif you think it will take too long18:12
SRabbeliersolydzajs: ok18:13
solydzajsSRabbelier: thx18:13
*** mrs_spearce has joined #melange18:47
*** mrs_spearce has left #melange18:47
*** Lennie has quit IRC19:07
*** solydzajs_ has joined #melange19:59
*** mithro has joined #melange20:07
*** ChanServ sets mode: +v mithro20:07
*** mithro has quit IRC20:12
*** mithro_ has joined #melange20:12
*** ChanServ sets mode: +v mithro_20:12
*** SRabbelier has quit IRC20:13
*** solydzajs has quit IRC20:17
*** penyaskito has joined #melange20:29
*** tanoku has quit IRC22:02
*** mithro_ has quit IRC22:26
*** mithro has joined #melange23:09
*** ChanServ sets mode: +v mithro23:09
*** mithro has quit IRC23:11
*** mithro_ has joined #melange23:11
*** ChanServ sets mode: +v mithro_23:11
*** bono8106 has joined #melange23:30
*** bono8106 has left #melange23:32
*** mithro_ has quit IRC23:32
*** bono8106 has joined #melange23:34
*** danderson has joined #melange23:35
*** ChanServ sets mode: +o danderson23:35
* danderson waves23:35
* no_mind waves back at danderson23:35
dandersonhmm, quiet a this time of day23:37
no_mindyup23:37
dandersonprobably a sign I should get to bed, when I turn up after the US people leave :P23:37
* danderson is in Europe23:37
no_mindit must be night on that side of atlantic23:37
dandersonhere it's close to daybreak, a couple of hours to go23:38
*** bono8106 has left #melange23:41
no_mindhere its already broad daylight...23:46

Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!