*** tpb <[email protected]> has joined #litex | 00:00 | |
*** Degi_ <[email protected]> has joined #litex | 03:59 | |
*** Degi <[email protected]> has quit IRC (Ping timeout: 260 seconds) | 03:59 | |
*** Degi_ is now known as Degi | 03:59 | |
*** yosys-questions <[email protected]> has quit IRC (Quit: Ping timeout (120 seconds)) | 05:09 | |
*** FabM <FabM!~FabM@2a03:d604:103:600:8348:f6d9:6891:39ae> has joined #litex | 07:01 | |
*** pftbest <[email protected]> has quit IRC (Remote host closed the connection) | 08:17 | |
*** pftbest <[email protected]> has joined #litex | 08:18 | |
leons | florent: it was a lot of work but I've finally got the Packetizer/Depacketizer fuzzed with a decent test suite and all known edge cases properly handled and fixed | 08:19 |
---|---|---|
leons | However I'm still not sure about how they should behave if there is no last_be signal. | 08:20 |
leons | Currently, the Packetizer will simply throw away leftovers of a data word once last is asserted and no last_be signal is present. Is that expected? | 08:21 |
leons | I would have expected it to output the entire rest of the data, plus some trailing garbage (which is fine if the protocol which the Packetizer/Depacketizer is used for has its own internal length checks, etc.) | 08:22 |
leons | So if no last_be signal is present, I would have expected it to behave just as if last_be had the highest bit set | 08:23 |
leons | What do you think? | 08:23 |
*** C-Man <[email protected]> has quit IRC (Ping timeout: 260 seconds) | 08:27 | |
_florent_ | G33KatWork: good you found what you were looking for. There is still not that much documentation but you can generally indeed find more complex examples while looking at the different cores/projects. | 08:49 |
_florent_ | G33KatWork: I'm trying to list different design using Migen/LiteX here to also users to find inspiration when things are not documented: https://github.com/enjoy-digital/litex/wiki/Projects | 08:50 |
_florent_ | https://github.com/enjoy-digital/litex/wiki/Tutorials-Resources | 08:50 |
*** _franck_5 <[email protected]> has joined #litex | 08:54 | |
_florent_ | leons: Great, thanks for looking at this. Sorry I will probably need to review carefully the code to answer the questions since I wrote it a few years ago don't remember details | 08:54 |
_florent_ | leons: If you can update the PR with the additional tests, I'll review it very soon | 08:55 |
*** _franck_ <[email protected]> has quit IRC (Ping timeout: 240 seconds) | 08:56 | |
*** _franck_5 is now known as _franck_ | 08:56 | |
*** _franck_8 <[email protected]> has joined #litex | 09:01 | |
*** _franck_ <[email protected]> has quit IRC (Ping timeout: 260 seconds) | 09:03 | |
*** _franck_8 is now known as _franck_ | 09:03 | |
*** TMM_ <[email protected]> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.) | 09:19 | |
*** TMM_ <[email protected]> has joined #litex | 09:19 | |
*** q3k <q3k!q3k@hswaw/infra/q3k> has quit IRC (Ping timeout: 252 seconds) | 09:23 | |
*** C-Man <[email protected]> has joined #litex | 09:47 | |
*** Coldberg <[email protected]> has joined #litex | 12:55 | |
*** C-Man <[email protected]> has quit IRC (Ping timeout: 252 seconds) | 12:58 | |
*** futarisIRCcloud <[email protected]> has joined #litex | 13:12 | |
*** FabM <FabM!~FabM@armadeus/team/FabM> has quit IRC (Remote host closed the connection) | 13:41 | |
*** FabM <FabM!~FabM@2a03:d604:103:600:8348:f6d9:6891:39ae> has joined #litex | 13:42 | |
leons | florent: done. If there's any questions, for instance why I've done something in a particular way, please don't hesitate to ask | 14:40 |
leons | Sorry it took this long, there once again were edge cases I've discovered | 14:40 |
leons | But now, finally, all defined tests pass | 14:41 |
*** michalsieron <[email protected]> has joined #litex | 15:50 | |
*** _franck_4 <[email protected]> has joined #litex | 16:12 | |
*** _franck_ <[email protected]> has quit IRC (Ping timeout: 265 seconds) | 16:14 | |
*** _franck_4 is now known as _franck_ | 16:14 | |
*** _franck_9 <[email protected]> has joined #litex | 17:09 | |
*** _franck_ <[email protected]> has quit IRC (Ping timeout: 245 seconds) | 17:11 | |
*** _franck_9 is now known as _franck_ | 17:11 | |
*** yosys-questions <[email protected]> has joined #litex | 17:11 | |
*** FabM <FabM!~FabM@armadeus/team/FabM> has quit IRC (Quit: Leaving) | 18:25 | |
*** Martoni42 <Martoni42!~Martoni@2a03:d604:103:600:2ad2:44ff:fe23:2f72> has joined #litex | 18:38 | |
*** michalsieron <[email protected]> has quit IRC (Ping timeout: 260 seconds) | 19:05 | |
*** Martoni42 <Martoni42!~Martoni@2a03:d604:103:600:2ad2:44ff:fe23:2f72> has quit IRC (Ping timeout: 260 seconds) | 19:37 | |
*** TMM_ <[email protected]> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.) | 22:48 | |
*** TMM_ <[email protected]> has joined #litex | 22:48 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!