| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| *** Agon has quit IRC | 00:54 | |
| *** verhoevenv has quit IRC | 01:28 | |
| *** mithro has joined #tp | 02:18 | |
| *** tansell-laptop has joined #tp | 02:37 | |
| *** nash has joined #tp | 02:55 | |
| *** nash has quit IRC | 03:19 | |
| *** nash has joined #tp | 04:02 | |
| StupidIncarnate | mithro? | 04:12 |
|---|---|---|
| llnz | bbl | 04:43 |
| *** llnz has quit IRC | 04:43 | |
| mithro | StupidIncarnate: pong? | 05:37 |
| StupidIncarnate | mithro: hey, so i looked at the design dialog, but it's kind of buggy still so i'm not sure I get it | 05:38 |
| StupidIncarnate | it displays the stats of the ships and what types of ships you can make I suppose | 05:38 |
| mithro | in what way is it buggy? | 05:39 |
| StupidIncarnate | i tried to create a new design, but when I used the ship hull, it said it was full, and wehn I tried using another hull, it crashed. | 05:39 |
| mithro | what crashed? the server or the client? | 05:40 |
| StupidIncarnate | the client | 05:41 |
| StupidIncarnate | like when I go to freight, select freight hull and duplicate, it crashes | 05:42 |
| mithro | what's the exact reproducable procedure? | 05:42 |
| StupidIncarnate | go to designs. Select the Fright design, select the freight hull, hit duplicate | 05:44 |
| *** bisc has joined #tp | 05:45 | |
| StupidIncarnate | and you can't edit the freighthull? | 05:45 |
| StupidIncarnate | and when you do edit one of the ships, what are you supposed to be able to edit? that's my biggest confusion | 05:45 |
| StupidIncarnate | mithro, i'm using the tp04 version from github | 05:50 |
| mithro | StupidIncarnate: mtsec? | 05:52 |
| StupidIncarnate | ya | 05:52 |
| mithro | can you log a proper bug report please? | 05:53 |
| StupidIncarnate | wait is minisec diff from mtsec? | 05:53 |
| StupidIncarnate | i'm on minisec | 05:55 |
| mithro | yes minisec is different from mtsec | 05:56 |
| StupidIncarnate | and mtsec was the one where designs worked? | 05:56 |
| mithro | yes | 05:57 |
| StupidIncarnate | ok I"ll try that out | 05:57 |
| tansell-laptop | and I can't reproduce any crash - it does error out when I try and duplicate a design in Minisec (because you can't create designs in minisec) | 05:58 |
| StupidIncarnate | the box with a red icon and nothing in it? that's what I got ya. Guess it's not technically a crash, but it does close game window | 05:59 |
| tansell-laptop | bisc, the design window needs some work too | 05:59 |
| bisc | tansell-laptop: yes, I have it in mind. | 05:59 |
| bisc | mithro, tansell-laptop: need your opinion on http://codereview.mithis.com/78001/show. I need this fix (or anything you suggest instead of it) for my current work on orders. | 06:01 |
| tansell-laptop | I'm not sure what this fix does | 06:04 |
| bisc | tansell-laptop: in current version there's a bug: you select a planet in System panel -- and it's not selected in Starmap. I've found out that it's because the father system is not correclty determined at overlay.py:332. And fixed it. It works, but I'm not sure if it's absolutely correct. | 06:06 |
| tansell-laptop | can you explain further? | 06:07 |
| bisc | tansell-laptop: ok, let me refresh my memory about this. | 06:09 |
| StupidIncarnate | are you supposed to be able to create ships on your planet in mtsec? | 06:11 |
| tansell-laptop | yes | 06:22 |
| StupidIncarnate | i seem unable to. the drop menu's blank | 06:24 |
| bisc | tansell-laptop: We observe the class SysteLevelOverlay, which is a dictionary objectid -> icon. The cycle at overlay.py:332 is supposed to find the parent (system) for a planet, given the fact that they can be several-level nested. The code assumes that there's no key = universeid. This assumption is incorrest, as self[0] exists and equals to empty list [], | 06:31 |
| tansell-laptop | StupidIncarnate, that is weird | 06:36 |
| StupidIncarnate | ya, I load it up, select my planet and can't find anything to build in the order's queue | 06:38 |
| StupidIncarnate | the ship operations loads up fine | 06:39 |
| bisc | tansell-laptop: you should note that self[planetid] equals to empty list as well, that's why we need to check that id != 0 | 06:47 |
| tansell-laptop | hrm.... | 07:21 |
| *** cahirwpz has joined #tp | 07:27 | |
| tansell-laptop | hello cahirwpz | 07:38 |
| tansell-laptop | you've been away a long time | 07:38 |
| cahirwpz | hi tansell | 07:38 |
| cahirwpz | yeah - I'm not used to IRC | 07:39 |
| cahirwpz | I mostly communicate by Jabber / e-mail, so in most cases I just forget to lauch IRC client when I start work. | 07:42 |
| cahirwpz | tansell, do you have some questions regarding my work and its progress as documented on http://cahir.eisp.pl/doku.php?id=en:gsoc2010 ? | 07:46 |
| tpb | Title: en:gsoc2010 [Krystian Bacławski Wiki] (at cahir.eisp.pl) | 07:46 |
| cahirwpz | tansell-laptop, I reckon our communication looks bad, I have a lot of questions about the code / design that I'm forced to answer myself, do you have any ideas how to improve it ? | 07:55 |
| tansell-laptop | cahirwpz, I have loads of questions | 07:59 |
| tansell-laptop | so where are you up to? | 08:02 |
| tansell-laptop | basically I have very little idea what you are actually doing | 08:04 |
| cahirwpz | well... firstly... you probably should read my wiki | 08:05 |
| cahirwpz | there's a brief summary what I did lately | 08:06 |
| cahirwpz | today I'm going to document current "sprint" | 08:06 |
| cahirwpz | ... so where am I ? | 08:06 |
| cahirwpz | I'm at refactoring rules code, I sorted out things with Object classes and I still need to improve structure of Order classes hierarchy | 08:07 |
| cahirwpz | database has undergone huge changes and I'm still get clues (mosty from rules source code) how it really should be organized | 08:08 |
| cahirwpz | *getting | 08:09 |
| tansell-laptop | cahirwpz, so it worries me that your making large changes without consulting with me first | 08:09 |
| cahirwpz | also I added and I'm still adding functional tests | 08:09 |
| cahirwpz | tansell-laptop, well I tried to contact you a few times, asked questions to llnz, and came to conclusion I cannot wait with every question (and I suppose most of my questions are quite hard to answer) | 08:11 |
| tansell-laptop | how did you try contacting me? | 08:12 |
| cahirwpz | being here at #tp between 10-14 CEST ? | 08:12 |
| cahirwpz | tansell-laptop, the more important thing for now is to check whether I'm going in good direction | 08:14 |
| cahirwpz | maybe we should do a code review (but I'm afraid it will be really long) ? | 08:14 |
| cahirwpz | BTW. my plan is to finish refactoring before 12th of July, and implement all features in second phase | 08:17 |
| tansell-laptop | so your wiki page doesn't really give me a great idea what you are actually doing | 08:19 |
| tansell-laptop | cahirwpz, have you seen what bisc has been doing? | 08:20 |
| cahirwpz | what should I do to improve its comprehensibility for you? | 08:20 |
| tansell-laptop | so I would like it broken down into chunks discussing each chunk | 08:22 |
| cahirwpz | tansell, you understand in this case wiki's maintenance will be a huge overhead and I'm probably not able to explain every idea which is captured in code ? | 08:25 |
| tansell-laptop | Take a look at Bisc's blog http://ruchkin.wordpress.com/ | 08:27 |
| tpb | Title: biscs Blog (at ruchkin.wordpress.com) | 08:27 |
| tansell-laptop | he's also been publishing regluar code reviews at codeview.mithis.com for me to look at | 08:28 |
| tansell-laptop | and comment on | 08:28 |
| cahirwpz | the problem is my work is more similar to chainsaw / shotgun surgery than doing small changes regularly | 08:30 |
| cahirwpz | I cannot fix one thing without breaking a few others | 08:30 |
| cahirwpz | when code refactoring is finished I will get back to usual healthy way of working | 08:33 |
| tansell-laptop | cahirwpz, so what/how are you refactoring | 08:36 |
| tansell-laptop | and you should really be discussing large refactoring with me | 08:36 |
| *** null_000 has joined #tp | 08:38 | |
| null_000 | morning all | 08:38 |
| cahirwpz | tansell-laptop, I understand that every more serious discussion should be discussed with you - I only hope to make our communication more frequent | 08:39 |
| cahirwpz | hi null_000 | 08:39 |
| null_000 | hi cahirwpz | 08:40 |
| tansell-laptop | cahirwpz, so what's this refactoring you are doing then? | 08:41 |
| cahirwpz | tansell-laptop, well... it's not easy to tell what has undergone refactoring - I suppose tp.server.bases is almost finished (I suppose only Order has left), tp.server.db too, tp.server.rules are partially refactored | 08:42 |
| cahirwpz | tansell-laptop, It would be better if I pushed all my changes and we start talking with live code | 08:42 |
| tansell-laptop | you can push them to github | 08:43 |
| cahirwpz | yeah - I need to cleanup my local repository and push all commits - wait for a while | 08:44 |
| cahirwpz | tansell-laptop, wait for a moment longer - my git repo is broken O.o (broken link) | 08:59 |
| bisc | tansell-laptop: can you answer a quick question: do we want to place a red arrow at (0, 0, 0) when the Universe is selected in System panel? Or should we leave the arrow in its place? or hide it? | 09:00 |
| tansell-laptop | bisc, I think we should place it at 0,0,0? | 09:05 |
| tansell-laptop | what do you think? | 09:05 |
| bisc | tansell-laptop: It think that universe is not an interactive object in player's opinion now. We should have consistency about it in client. Two options: 1) If it IS an interactive object, then is should be accessible on common rules with planets and systems 2) If it isn't, then is shouldn't be selected at any time. | 09:09 |
| bisc | tansell-laptop: we want the first option | 09:09 |
| cahirwpz | tansell-laptop, ok - I pushed changes | 09:09 |
| bisc | tansell-laptop: so, we probably should select Universe when player clicks on starmap background (in normal mode) -- that's right? | 09:10 |
| bisc | tansell-laptop: and, in that case, place arrow at (0,0,0) | 09:11 |
| bisc | ? | 09:11 |
| cahirwpz | tansell-laptop, tpserver-py / tp / server / bases / Component.py is good example how code after refactoring will look like | 09:14 |
| cahirwpz | tansell-laptop, tpserver-py / tp / server / rules / minisecplus / __init__.py - here's cool example how proper SQLAlchemy usage can simplify creating / modyfing game objects | 09:15 |
| tansell-laptop | bisc, I think the first option is probably the best | 09:20 |
| tansell-laptop | bisc, nothing stops the universe from containing useful information | 09:20 |
| bisc | tansell-laptop: yes, I agree. What do you think about clicking background and selecting universe on this event? Doesn't it break some of your expectations? | 09:21 |
| tansell-laptop | bisc, not sure - give it a go and see if it makes sense? | 09:21 |
| tansell-laptop | cahirwpz, can you link me to the full url? | 09:23 |
| tansell-laptop | cahirwpz, can you convert to using a daily post on a blog rather then the wiki? | 09:24 |
| tansell-laptop | It shouldn't take you more then 10-15 minutes a day to write it up | 09:25 |
| cahirwpz | http://github.com/cahirwpz/tpserver-py/blob/master/tp/server/rules/minisecplus/__init__.py | 09:26 |
| tpb | <http://ln-s.net/7Bgj> (at github.com) | 09:26 |
| cahirwpz | http://github.com/cahirwpz/tpserver-py/blob/master/tp/server/bases/Component.py | 09:27 |
| tpb | <http://ln-s.net/7Bgm> (at github.com) | 09:27 |
| bisc | tansell-laptop: okay. will try once. You know, in many strategy games the selection mechanism works in similar way: you click on background and selection is dropped. In our case, it can't drop and most logically sensible choice is selecting universe. | 09:28 |
| *** llnz has joined #tp | 09:30 | |
| cahirwpz | tansell-laptop, I'm better at writing code than writing about code - I doubt if I'm able to writing anything reasonable withing 10-15 minutes :/ | 09:30 |
| cahirwpz | tansell-laptop, upper part of my wiki page works exactly like blog (blog plugin) | 09:32 |
| cahirwpz | tansell-laptop, what do you think about the code samples ? | 09:37 |
| *** Agon has joined #tp | 09:48 | |
| *** nash has quit IRC | 10:26 | |
| *** Agon has quit IRC | 10:28 | |
| *** bisc has quit IRC | 10:28 | |
| * llnz wanders off | 10:31 | |
| llnz | later all | 10:31 |
| *** llnz has quit IRC | 10:31 | |
| *** Agon has joined #tp | 10:34 | |
| *** bisc has joined #tp | 10:34 | |
| *** bisc has joined #tp | 10:34 | |
| *** accAgon has joined #tp | 10:52 | |
| *** Agon has quit IRC | 10:54 | |
| *** accAgon has quit IRC | 10:59 | |
| *** nash has joined #tp | 12:38 | |
| *** peres has joined #tp | 13:07 | |
| *** Epyon has joined #tp | 13:08 | |
| *** Epyon has left #tp | 13:08 | |
| *** Agon has joined #tp | 14:03 | |
| *** bisc has quit IRC | 14:10 | |
| null_000 | alanp: ping | 14:24 |
| *** verhoevenv has joined #tp | 14:41 | |
| *** Epyon has joined #tp | 15:09 | |
| *** Epyon has left #tp | 15:09 | |
| *** Agon has quit IRC | 15:30 | |
| *** Agon has joined #tp | 15:33 | |
| null_000 | alanp: ping again | 15:35 |
| *** nash has quit IRC | 16:29 | |
| *** Agon has quit IRC | 16:30 | |
| alanp | null_000: hello | 16:39 |
| alanp | null_000: sorry i missed you yesterday | 16:39 |
| null_000 | alanp: so got any work done? | 16:40 |
| alanp | null_000: going to take a look at the problems this afternoon, have the day off | 16:40 |
| null_000 | playing MTSec without colonisation is kind of boring so please try to get it working | 16:42 |
| null_000 | can't do much more work in this state | 16:43 |
| alanp | k | 16:45 |
| *** null_000 has quit IRC | 17:08 | |
| *** peres has quit IRC | 17:32 | |
| *** Agon has joined #tp | 18:41 | |
| *** llnz has joined #tp | 20:11 | |
| llnz | morning all | 20:12 |
| Agon | hello llnz | 20:20 |
| llnz | hi Agon, how are you going? | 20:21 |
| Agon | fine, I have something to show you, nice (unfinished) selection boxes for objects. | 20:23 |
| llnz | cool | 20:25 |
| Agon | llnz: http://marcelha.wordpress.com/2010/07/05/starmap-got-interactive/ | 21:05 |
| tpb | <http://ln-s.net/7Bwt> (at marcelha.wordpress.com) | 21:05 |
| llnz | cool | 21:07 |
| llnz | how does it look with many planets close together? such as the Sol/Terra system in minisec? | 21:07 |
| Agon | I don't know, I have problems converting and adjusting the int64 position datas to double values. This will be the next thing on my todolist. | 21:09 |
| llnz | ok | 21:10 |
| *** cahirwpz has quit IRC | 21:53 | |
| *** cahirwpz has joined #tp | 21:59 | |
| llnz | afk | 22:00 |
| *** cahirwpz has quit IRC | 22:19 | |
| *** Agon has quit IRC | 22:27 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!