*** tpb has joined #tp | 00:00 | |
*** ChanServ sets mode: +o tpb | 00:00 | |
*** nash has joined #tp | 00:33 | |
*** mithro has joined #tp | 00:54 | |
*** tuna-fish has joined #tp | 01:12 | |
*** tuna-fish has quit IRC | 01:28 | |
*** StupidIncarnate has joined #tp | 01:43 | |
*** Epyon has quit IRC | 01:48 | |
*** Epyon has joined #tp | 01:56 | |
*** glew has quit IRC | 03:20 | |
*** StupidIncarnate has quit IRC | 04:10 | |
llnz | bbl | 04:36 |
---|---|---|
*** llnz has quit IRC | 04:36 | |
*** bisc has joined #tp | 05:19 | |
bisc | mithro: ping | 05:23 |
tansell | bisc, pong | 05:25 |
tansell | bisc, sup? | 05:25 |
bisc | sorry for that silent period, have been fixing issues with my education issues. haven't got even enough time to sleep :) | 05:26 |
bisc | don't worry, I won't be behaving in that way when coding period starts | 05:26 |
bisc | have a couple of questions. | 05:27 |
bisc | which tool do you use to work with xrc? xrced always shows errors at client's resources | 05:28 |
bisc | 2) there are classes with "Mixin" suffix. what does this suffix indicate? | 05:32 |
bisc | 3) how is functionality spread between libtpclient-py and tpclient-py? what this libtpclient for in global terms? | 05:35 |
tansell | we use a custom xrced | 05:36 |
tansell | libtpclient-py is code which is shared between all clients | 05:36 |
tansell | not sure what your second question is | 05:37 |
*** JLP has quit IRC | 05:39 | |
bisc | about second question -- classes like usernameMixIn, ShiftMixIn, winBaseMixIn -- what's their naming for? | 05:41 |
*** llnz has joined #tp | 05:45 | |
tansell | mixin classes are not whole implimentations in themselves, they need to be mixed with proper classes to work | 05:53 |
*** nash has quit IRC | 05:57 | |
*** JLP has joined #tp | 05:57 | |
*** JLP has joined #tp | 05:57 | |
bisc | ah, I see, like abstract classes in C++. thanks. | 06:01 |
bisc | tansell: is libtpproto-py used by this client? | 06:04 |
*** JLP_ has joined #tp | 06:06 | |
tansell | libtpproto-py is used by libtpclient-py | 06:06 |
*** JLP has quit IRC | 06:06 | |
bisc | so, when fixing bugs of tpclient-pywx, I'm not likely to edit code in libtpclient or libtpproto, as they should be client-independent? | 06:16 |
*** llnz has quit IRC | 06:17 | |
tansell | bisc, depends on what you are fixing | 06:20 |
bisc | things related to displaying information, errors notification and gui logic. | 06:22 |
bisc | anyway, if I get into libtpclient-py code, I'll need to verify that all clients are still compatible with my changes? | 06:22 |
*** nash has joined #tp | 06:25 | |
*** llnz has joined #tp | 06:27 | |
llnz | yes! full screen smooth video again! go nouveau! | 06:28 |
tansell | bisc, pretty much | 06:33 |
tansell | bisc, we probably need to sit down sometime and figure out what you are going to do first | 06:36 |
tansell | bisc, probably sometime soon would be good | 06:37 |
tansell | Epyon, ping? | 06:43 |
bisc | tansell: okay. when is it convenient for you? | 06:44 |
tansell | bisc, what's your timezone again? | 06:51 |
bisc | gmt+4. | 06:51 |
tansell | llnz, I would like to discuss how we proceed with Epyon's work as well | 06:51 |
llnz | sure | 06:51 |
tansell | bisc, does this look right? | 06:53 |
tansell | http://www.timeanddate.com/worldclock/meetingtime.html?day=5&month=5&year=2010&p1=0&p2=240&p3=166&p4=-1 | 06:53 |
tpb | Title: The World Clock Meeting Planner - Results (at www.timeanddate.com) | 06:53 |
bisc | tansell: yes | 06:54 |
tansell | great | 06:54 |
tansell | bisc, how about 12:00 noon your time? | 06:55 |
tansell | http://www.timeanddate.com/worldclock/meetingdetails.html?year=2010&month=5&day=5&hour=8&min=0&sec=0&p1=240&p2=166 | 06:55 |
tpb | Title: The World Clock Meeting Planner - Details (at www.timeanddate.com) | 06:55 |
bisc | tansell: sounds good. how long will it take? | 06:55 |
tansell | about an hour and we should probably do it atleast once a week | 06:56 |
bisc | very well then. meet you in an hour. | 06:58 |
tansell | okay | 07:00 |
cahirwpz | good morning all | 07:41 |
bisc | hi | 07:42 |
bisc | tansell: meeting time is coming. what I've been doing is wandering through code, reading docs for wxwidgets & python. I've seen several bugs and I can reproduce the one with not consistent error message for wrong password. Not that it was my direct goal; I tried to understand code and its structure. | 08:02 |
tansell-laptop | bisc, currently in another meeting which is running overtime | 08:06 |
bisc | ok, never mind | 08:07 |
*** Agon has joined #tp | 08:10 | |
tansell-laptop | bisc, okay | 08:14 |
tansell-laptop | bisc, you still about? | 08:14 |
bisc | tansell-laptop: yes, I'm here | 08:15 |
llnz | hi Agon | 08:15 |
tansell | okay | 08:16 |
tansell | bisc, so lets set some expectations first | 08:16 |
tansell | bisc, I'm expecting that you'll work on the tp04 branch, the tp03 branch is dead | 08:16 |
llnz | Agon: to answer your earlier question, definitely once coding start, when possible before hand | 08:16 |
Agon | hello | 08:17 |
Agon | llnz: okay | 08:17 |
tansell | bisc, tpclient-pywx is pretty fragile and really hard to test - your going to run into many, many bugs | 08:17 |
tansell | bisc, we need to support three platforms in order of priority - Linux, Windows and Mac | 08:18 |
tansell | bisc, hand coding in pixel sizes and similar might seem like a good idea - but it'll drive you mad as they get ignored by various other platforms | 08:19 |
tansell | plus you'll need to maintain three sets, one for each platform | 08:19 |
tansell | so we have been making an effort to move away from needing any hard coding of sizes | 08:19 |
bisc | tansell, I see. I haven't met any hardcoding in pixels -- sizers are there. | 08:22 |
bisc | the wxpython code should be platform-independent (in case of using sizers and other high-level stuff), right? | 08:24 |
tansell | bisc, we also spent quite a bit of effort converting to using xrcd format as well | 08:24 |
tansell | (rather then hand coded building of frames) | 08:24 |
tansell | bisc, in theory wxWidgets is platform-independent | 08:25 |
tansell | in practice you still end up with a lot of hard coding | 08:25 |
cahirwpz | tansell: I've just moved my sources to github: git://github.com/cahirwpz/tptests-py.git | 08:25 |
tansell | cahirwpz, great | 08:26 |
tansell | cahirwpz, we should organise a weekly meeting too | 08:26 |
bisc | tansell: what is xrcd like? what's difference between xrc? | 08:26 |
tansell | sorry I meant xrc | 08:27 |
cahirwpz | tansell: sure | 08:27 |
bisc | tansell: ah, I see. And is there much to be converted to xrc? can you point out a class or two? | 08:27 |
tansell | bisc, I'm pretty sure that greywhind got most of it - but if you do find some hand coded stuff, it should be converted | 08:28 |
tansell | cahirwpz, how about this time yesterday? | 08:28 |
bisc | tansell: ok, if I find some hardcorded interfaces, we'll discuss it. | 08:29 |
bisc | I have access to linux and windows, but not mac. | 08:30 |
tansell | bisc, that is a common problem sadly :( | 08:31 |
bisc | tansell: anything I can do with it, like creating a virtual machine? | 08:31 |
tansell | bisc, I wouldn't worry to much at the moment while your just getting started | 08:32 |
bisc | tansell: do you have any docs in wiki or somewhere else, like "programmers reference", to get familiar with all these classes | 08:35 |
bisc | or, maybe, I can generate it? | 08:35 |
tansell | bisc, nope! | 08:37 |
tansell | bisc, there isn't much documentation | 08:38 |
bisc | and everything I can get is in source files? | 08:38 |
tansell | yes | 08:39 |
bisc | what do you think about idea of writing a couple of wiki pages about programming structure of tp04 client? | 08:39 |
tansell | I don't really have the time | 08:40 |
bisc | well, I mean I could do that simultaneously to examining code | 08:40 |
tansell | bisc, sure | 08:41 |
bisc | tansell: where should it be placed? somewhere in http://www.thousandparsec.net/wiki/Clients/Tpclient-pywx? | 08:42 |
tansell | http://www.thousandparsec.net/wiki/Tpclient-pywx looks okay | 08:44 |
bisc | tansell: may I borrow some ideas or coding tricks from tp03 branch? it should theoretically be more stable | 08:46 |
tansell | bisc, the tp04 branch was based on the tp03 branch | 08:47 |
tansell | so there shouldn't be anything useful left in that branch | 08:48 |
bisc | tansell: yeah, understood. | 08:48 |
bisc | tansell: what's the ruleset, most suitable for developing and debugging this client? | 08:50 |
*** nash has quit IRC | 08:53 | |
tansell | bisc, your going to have to test will all the rulesets | 08:55 |
tansell | bisc, sadly no easy way to do so | 08:55 |
bisc | I'll have to loop "for each ruleset { start_server_for_ruleset; start_clients; play_and_note_bugs; stop_server }" ? | 08:57 |
tansell | bisc, yeah | 09:07 |
tansell | dinner time here I'll be back in an hour | 09:07 |
bisc | tansell: bon appetit | 09:07 |
bisc | tansell: added our weekly meeting to our calendar. please see if time for you is 18.00 | 09:09 |
*** Epyon has quit IRC | 09:21 | |
* llnz wanders off | 09:29 | |
llnz | later all | 09:29 |
*** llnz has quit IRC | 09:29 | |
*** null_000 has joined #tp | 09:47 | |
cahirwpz | tansell: I'm busy at Tuesdays till the end of June | 10:14 |
tansell | cahirwpz, so when is good for you? | 10:25 |
cahirwpz | tansell: I suppose Thursday or Friday would be better | 10:27 |
tansell | I would rather not do friday, as I have things to do on 6:00pm on a friday :) | 10:27 |
cahirwpz | ahh - time shift :) | 10:28 |
cahirwpz | ok - let it be at Thursdays | 10:28 |
tansell | It'll have to be earlier on thursday | 10:30 |
cahirwpz | there's ~20:30 at your location now ? | 10:32 |
tansell | how about http://www.timeanddate.com/worldclock/fixedtime.html?day=6&month=5&year=2010&hour=16&min=30&sec=0&p1=240 | 10:33 |
tpb | Title: The Fixed Time World Clock (at www.timeanddate.com) | 10:33 |
cahirwpz | 8:30 AM is too early as for me | 10:34 |
cahirwpz | what about Wednesday ? | 10:37 |
tansell | at what time? | 10:37 |
cahirwpz | http://www.timeanddate.com/worldclock/fixedtime.html?day=6&month=5&year=2010&hour=10&min=30&sec=0&p1=262 | 10:41 |
tpb | Title: The Fixed Time World Clock (at www.timeanddate.com) | 10:41 |
cahirwpz | or later | 10:41 |
cahirwpz | http://codereview.mithis.com/15001/show | 10:43 |
tpb | Title: Issue 15001: Header fix, iteration over GroupStructure, Enumeration to string. - Code Review (at codereview.mithis.com) | 10:43 |
tansell | cahirwpz, can you please split that into 3 patches? | 10:47 |
tansell | cahirwpz, your change to the Header stuff is wrong | 10:49 |
tansell | self.objects.Header = objects_auto._makeHeader('TP\x04\x00') | 10:49 |
cahirwpz | hmm... what about version field in protocol.xml file ? | 10:49 |
tansell | TP <protocol version> <frame version> | 10:50 |
tansell | cahirwpz, I'm not sure I can make that time very often | 10:50 |
cahirwpz | ok - I figured out how to upload diffs for single files | 10:55 |
cahirwpz | ok - patches are ready now to be reviewed | 11:02 |
tansell | okay | 11:02 |
tansell | please link me | 11:02 |
cahirwpz | umm... do you mean - I want you to send me links to patches ? :) | 11:04 |
tansell | cahirwpz, link to the code reviews | 11:07 |
cahirwpz | http://codereview.mithis.com/16001/show, http://codereview.mithis.com/17001/show, http://codereview.mithis.com/18001/show, http://codereview.mithis.com/19001/show | 11:08 |
tpb | Title: Issue 19001: EnumerationStructure can be now converted to string representing its value. - Code Review (at codereview.mithis.com) | 11:08 |
cahirwpz | I've a few questions regarding libtpproto2-py | 11:08 |
cahirwpz | I get "Features" response from server - it should be represented as list of enums, however it's list of integers | 11:10 |
cahirwpz | is it proper behaviour or information about type is lost somewhere? | 11:11 |
cahirwpz | also I think it'd be a good idea to put timestamp (modtime) into separate type - for instance TimestampStructure | 11:12 |
cahirwpz | oh... there's actually something called DateTimeStructure... | 11:15 |
tansell | cahirwpz, it's no longer a modtime in tp04 | 11:19 |
tansell | it's a serial number | 11:19 |
cahirwpz | how about enumeration on lists? | 11:22 |
tansell | hrm? | 11:24 |
tansell | cahirwpz, comments published | 11:26 |
cahirwpz | Sending request: | 11:26 |
cahirwpz | Version: 3.0 | 11:26 |
cahirwpz | Sequence: 4 | 11:26 |
cahirwpz | Type: GetFeatures | 11:26 |
cahirwpz | Length: 0 | 11:26 |
cahirwpz | Received response: | 11:26 |
cahirwpz | Version: 3.0 | 11:26 |
cahirwpz | Sequence: 4 | 11:26 |
cahirwpz | Type: Features | 11:26 |
cahirwpz | Length: 48 | 11:27 |
cahirwpz | Features: [3, 5, 65536, 65537, 65538, 65540, 65541, 65542, 65543, 65539, 1000] | 11:27 |
cahirwpz | "Features" field in response is list of integers instead of list of enumerations | 11:27 |
tansell | cahirwpz, so that seems like a bug right? | 11:28 |
cahirwpz | I suppose so... "Code" field in "Fail" response is EnumerationStructure: | 11:29 |
cahirwpz | Received response: | 11:29 |
cahirwpz | Version: 3.0 | 11:29 |
cahirwpz | Sequence: 100 | 11:29 |
cahirwpz | Type: Fail | 11:29 |
cahirwpz | Length: 27 | 11:29 |
cahirwpz | Code: UnavailablePermanently | 11:29 |
cahirwpz | Result: "Service unavalible." | 11:29 |
cahirwpz | which is what I expected | 11:30 |
cahirwpz | maybe iterator in ListProxy returns just values instead of structures | 11:33 |
cahirwpz | what is the procedure with reviews - if I don't have any remarks and I reckon your comments reasonable then what should I do ? | 11:36 |
tansell-laptop | cahirwpz, make the changes, upload the new patch over the old one ask me for a LGTM | 11:39 |
tansell-laptop | once you have a LGTM, you then commit the patch | 11:40 |
cahirwpz | ok :) | 11:40 |
cahirwpz | tansell: BB in ~2h | 11:48 |
CIA-29 | mithro libtpproto2-py * rf0f6c895a4b8 /tests/teststructureaccess.py: Test enumerations inside lists. | 11:48 |
tansell-laptop | I'll probably be gone by then | 11:48 |
cahirwpz | bye then | 11:49 |
*** cahirwpz has quit IRC | 11:49 | |
bisc | tansell-laptop: see you | 11:51 |
*** mithro has quit IRC | 12:22 | |
ezod | ~seen glew | 13:45 |
tpb | ezod: glew was last seen in #tp 1 day, 13 hours, 50 minutes, and 29 seconds ago: <glew> ezod: hey ezod | 13:45 |
*** bisc has quit IRC | 13:51 | |
*** bisc has joined #tp | 13:51 | |
*** cahirwpz has joined #tp | 15:09 | |
*** null_000 has quit IRC | 15:28 | |
*** null_000 has joined #tp | 15:33 | |
*** null_000 has quit IRC | 16:01 | |
*** cahirwpz has quit IRC | 16:26 | |
*** bisc has quit IRC | 16:59 | |
*** StupidIncarnate has joined #tp | 17:51 | |
*** null_000 has joined #tp | 18:03 | |
*** null_000 has quit IRC | 18:44 | |
*** null_0001 has joined #tp | 18:44 | |
*** Agon has quit IRC | 18:51 | |
*** Agon-laptop has joined #tp | 18:57 | |
*** StupidIncarnate has quit IRC | 19:33 | |
*** hollunder has joined #tp | 19:36 | |
hollunder | evening. that ogre client doesn't work on Linux? | 19:36 |
*** glew has joined #tp | 20:31 | |
*** llnz has joined #tp | 20:38 | |
*** null_0001 has quit IRC | 20:58 | |
*** hollunder has left #tp | 21:09 | |
*** StupidIncarnate has joined #tp | 21:29 | |
*** glew has quit IRC | 21:40 | |
*** Agon-laptop has quit IRC | 22:11 | |
*** StupidIncarnate has quit IRC | 22:19 | |
*** Vadtec has quit IRC | 22:59 | |
*** welterde has quit IRC | 23:01 | |
*** Vadtec_ has quit IRC | 23:01 | |
*** tansell-laptop has quit IRC | 23:01 | |
*** tansell-laptop has joined #tp | 23:01 | |
*** welterde has joined #tp | 23:14 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!