*** tpb has joined #tp | 00:00 | |
*** ChanServ sets mode: +o tpb | 00:00 | |
*** jmtan has quit IRC | 00:11 | |
*** ezod has quit IRC | 00:18 | |
*** llnz has joined #tp | 00:18 | |
*** ezod has joined #tp | 00:18 | |
tansell | ezod, ping? | 00:22 |
---|---|---|
ezod | tansell: pong | 00:23 |
tansell | ezod, how did the thing on the weekend go? | 00:23 |
ezod | it went well, decent turnout | 00:24 |
ezod | we talked about wombat ;) | 00:25 |
tansell | ahh | 00:31 |
*** jnengland77 has joined #tp | 00:31 | |
ezod | some TP discussion as well, got a few people who are going to check it out | 00:33 |
ezod | actually, a number of people asked about the shirt at other times during the day i was wearing it | 00:34 |
*** JLP has joined #tp | 00:34 | |
*** JLP has joined #tp | 00:34 | |
tansell | ezod, ha | 00:35 |
tansell | it's almost time to do another run of tshirts I think | 00:44 |
ezod | i could use one somewhat smaller ;) | 00:47 |
tansell | I'll keep that in mind when I do an order | 00:49 |
*** nash has joined #tp | 00:52 | |
*** glew has quit IRC | 01:06 | |
*** glew has joined #tp | 01:17 | |
*** glew has quit IRC | 01:36 | |
llnz | bbl, hopefully | 01:46 |
*** llnz has quit IRC | 01:46 | |
*** mithro has joined #tp | 01:56 | |
*** Epyon has joined #tp | 03:25 | |
*** Epyon has quit IRC | 03:59 | |
*** StupidIncarnate has joined #tp | 05:13 | |
*** tradedaemon has joined #tp | 05:25 | |
*** StupidIncarnate has quit IRC | 05:27 | |
*** jnengland77 has quit IRC | 05:36 | |
*** tradedaemon has quit IRC | 05:57 | |
*** llnz has joined #tp | 06:03 | |
*** cahirwpz has joined #tp | 06:53 | |
*** nash has quit IRC | 07:29 | |
cahirwpz | mithro: ping? | 07:44 |
tansell | cahirwpz, pong? | 07:44 |
cahirwpz | tansell: hi, I found another bug in Header.py | 07:45 |
tansell | shoot? | 07:45 |
cahirwpz | and managed to decode packets from server - so now I have working client | 07:46 |
tansell | yay! | 07:46 |
cahirwpz | where can I put a git diff for a review ? | 07:46 |
cahirwpz | and I'd also want you to look into mentioned client as I found some other bugs (in libtpproto2-py) which I'm unable to fix for now | 07:47 |
tansell | codereview.mithis.com | 07:48 |
tansell | or upload to github.com | 07:49 |
cahirwpz | ok - uploaded diff | 07:54 |
tansell | to codereview? | 07:54 |
cahirwpz | yes | 07:55 |
cahirwpz | http://codereview.mithis.com/13001/show | 07:55 |
tpb | Title: Issue 13001: Packet length bug + enable packet creation from wire. - Code Review (at codereview.mithis.com) | 07:55 |
cahirwpz | seems that git does not create diffs for new files that just have been added to repo... | 08:10 |
cahirwpz | maybe I'll send you the code by e-mail ? | 08:10 |
cahirwpz | ok - finally I managed to upload test client to code review | 08:14 |
cahirwpz | http://codereview.mithis.com/14001/show | 08:15 |
tpb | Title: Issue 14001: Test client. - Code Review (at codereview.mithis.com) | 08:15 |
cahirwpz | mithro: bug is triggered by tp.tests.protocol.PacketFormatter function | 08:18 |
cahirwpz | mithro: if I had to guess I'd look for it somewhere in tp.netlib.structures.List | 08:24 |
tansell | what is the | 08:31 |
tansell | #{{{ | 08:31 |
tansell | #}}} for? | 08:31 |
cahirwpz | vim folding | 08:32 |
tansell | vim can fold in normal python formatting last time I looked | 08:36 |
cahirwpz | got used to this method - probably it's only a matter of taste | 08:37 |
tansell | cahirwpz, I would prefer not to pollute the files with stuff specific to one client | 08:38 |
tansell | cahirwpz, what is with this massive logging module? | 08:38 |
cahirwpz | I learnt to use extensive logging while debugging network apps - it's partially copied from my private sources - lots of stuff was removed from this module | 08:40 |
cahirwpz | what do you have in mind by "polluting" ? | 08:40 |
tansell | cahirwpz, extra stuff which is not python | 08:40 |
tansell | or useful comments | 08:40 |
cahirwpz | ahh... you're not the first person which has strong feelings against manual folding ;-) | 08:41 |
tansell | I have no problems against manual folding - just needing comments in the file for manual folding :) | 08:41 |
tansell | cahirwpz, have you seen the inbuilt logging module in Python? | 08:42 |
cahirwpz | I'll look for another method | 08:42 |
cahirwpz | yes - I've seen - this is Twistedish method for logging | 08:43 |
cahirwpz | actually it's not recommended to use logging module with Twisted | 08:43 |
tansell | cahirwpz, why? | 08:44 |
tansell | the logging module is nothing more then an interface really | 08:44 |
cahirwpz | don't know exactly - probably because of interaction with twisted.reactor | 08:47 |
cahirwpz | generally it's Twisted way to do the logging - probably they had good reasons to reimplement logging | 08:48 |
tansell | cahirwpz, can you wrap the twisted logging methods in something that looks like logging? | 08:48 |
cahirwpz | hmm... Twisted has wrapper imitating logging module | 08:49 |
tansell | cahirwpz, already? | 08:52 |
cahirwpz | http://twistedmatrix.com/documents/current/core/howto/logging.html | 08:52 |
tpb | <http://ln-s.net/6NCl> (at twistedmatrix.com) | 08:52 |
cahirwpz | can we focus on finding the source of bugs ;-) | 08:52 |
cahirwpz | brb | 08:52 |
tansell | cahirwpz, probably not tonight, I'm still at work and I have plans after | 08:53 |
tansell | I'll see how late it is when I finish up | 08:53 |
tansell | cahirwpz, sorry about that | 08:54 |
cahirwpz | ok - I understand | 09:03 |
cahirwpz | please run tp-tests-client to reproduce bug(s) | 09:03 |
cahirwpz | you should get sth similar to: | 09:05 |
cahirwpz | Sending request: | 09:05 |
cahirwpz | Version: 3 | 09:05 |
cahirwpz | Sequence: 3 | 09:05 |
cahirwpz | Type: GETFEATURES | 09:05 |
cahirwpz | Length: 0 | 09:05 |
cahirwpz | Sending binary: 54503033000000030000001900000000 | 09:05 |
cahirwpz | Received binary: 54503033000000030000001a000000300000000b00000003000000050001000000010001000100020001000400010005000100060001000700010003000003e8 | 09:05 |
cahirwpz | AttributeError: No value defined for length | 09:06 |
cahirwpz | AttributeError: 'NewPacket' object has no attribute '__features' | 09:06 |
cahirwpz | Received response: | 09:06 |
cahirwpz | Version: 3 | 09:06 |
cahirwpz | Sequence: 3 | 09:06 |
cahirwpz | Type: FEATURES | 09:06 |
cahirwpz | Length: BUG??? | 09:06 |
cahirwpz | Features: BUG??? | 09:06 |
* llnz wanders off | 09:20 | |
llnz | later all | 09:20 |
*** llnz has quit IRC | 09:20 | |
*** cahirwpz has quit IRC | 09:25 | |
*** Agon-laptop has joined #tp | 09:28 | |
*** mithro has quit IRC | 09:29 | |
*** cahirwpz has joined #tp | 09:51 | |
*** mithro has joined #tp | 10:26 | |
*** null_000 has joined #tp | 13:30 | |
*** mithro has quit IRC | 13:47 | |
*** Epyon has joined #tp | 14:58 | |
*** Epyon has quit IRC | 15:26 | |
*** Epyon has joined #tp | 15:48 | |
*** Agon-laptop has quit IRC | 16:34 | |
*** StupidIncarnate has joined #tp | 18:45 | |
*** tuna-fish has quit IRC | 18:48 | |
*** StupidIncarnate has quit IRC | 19:23 | |
*** Agon-laptop has joined #tp | 19:30 | |
*** Agon-laptop has quit IRC | 19:36 | |
*** Agon-laptop has joined #tp | 19:36 | |
*** llnz has joined #tp | 20:17 | |
*** Epyon has quit IRC | 20:32 | |
llnz | morning all | 20:33 |
ezod | ~seen glew | 20:37 |
tpb | ezod: glew was last seen in #tp 4 days, 20 hours, 7 minutes, and 22 seconds ago: <glew> tansell, but other than that looking forward to gsoc | 20:37 |
ezod | hi llns | 20:37 |
ezod | llnz* | 20:37 |
llnz | hi ezod | 20:38 |
*** Epyon has joined #tp | 20:39 | |
llnz | ahh | 20:40 |
llnz | think i just found the cause of the bug | 20:41 |
llnz | the priority queue is sorted backwards to the way we want it | 20:44 |
*** glew has joined #tp | 21:38 | |
llnz | ezod: ping | 21:51 |
llnz | hi glew | 21:51 |
alanp | hrm | 22:23 |
ezod | llnz: pong | 22:36 |
ezod | hey glew | 22:36 |
llnz | :-) | 22:39 |
*** null_000 has quit IRC | 22:40 | |
llnz | afk | 22:46 |
*** JLP has quit IRC | 22:58 | |
*** JLP has joined #tp | 22:58 | |
*** JLP has joined #tp | 22:58 | |
*** Agon-laptop has quit IRC | 22:59 | |
*** JLP has quit IRC | 23:21 | |
*** JLP has joined #tp | 23:29 | |
*** JLP has joined #tp | 23:29 | |
glew | llnz: hey llnz | 23:54 |
glew | ezod: hey ezod | 23:54 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!