| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| *** shenki_ is now known as shenki | 00:15 | |
| *** JLafont has joined #tp | 00:39 | |
| *** jmtan has joined #tp | 00:39 | |
| *** JLafont_ has quit IRC | 00:40 | |
| *** JLafont_ has joined #tp | 00:41 | |
| *** JL has joined #tp | 00:47 | |
| *** jernejovc_ has joined #tp | 00:50 | |
| *** JLafont_ has quit IRC | 01:00 | |
| *** JL has quit IRC | 01:04 | |
| *** jernejovc has quit IRC | 01:04 | |
| *** JLafont has quit IRC | 01:09 | |
| llnz | bbl | 01:15 |
|---|---|---|
| *** llnz has quit IRC | 01:15 | |
| Greywhind | mithro: http://codereview.mithis.com/5001 | 01:34 |
| tpb | Title: Issue 5001: Created folding panel view for panelInfo, with panels for each type of information. - Code Review (at codereview.mithis.com) | 01:34 |
| *** tansell-laptop has quit IRC | 02:00 | |
| *** nash has quit IRC | 02:43 | |
| *** greenlion has joined #tp | 02:53 | |
| *** jmtan has quit IRC | 03:17 | |
| *** Greywhind has quit IRC | 03:48 | |
| *** Erroneous has joined #tp | 04:10 | |
| *** llnz has joined #tp | 04:13 | |
| *** DTRemenak|RDP has quit IRC | 04:18 | |
| cherez | tansell: Ping? | 04:45 |
| Landon | oh wow its almost 5 already o.O | 05:41 |
| *** ezod has quit IRC | 05:54 | |
| *** JLafont has joined #tp | 07:05 | |
| *** mithro has quit IRC | 07:50 | |
| *** jmtan has joined #tp | 07:59 | |
| *** alanp_ has joined #tp | 08:45 | |
| *** peres has joined #tp | 09:04 | |
| * llnz wanders off | 09:23 | |
| llnz | later all | 09:23 |
| *** llnz has quit IRC | 09:23 | |
| *** epyon has joined #tp | 09:59 | |
| *** jmtan has quit IRC | 10:03 | |
| *** ezod has joined #tp | 10:08 | |
| CIA-23 | epyon tpserver-cpp-refactor * r3cba348e057c /tpserver/ (4 files): | 10:30 |
| CIA-23 | Exception classes for system and tls exceptions | 10:30 |
| CIA-23 | * badly needed since forever | 10:30 |
| CIA-23 | * due to the way that tls connection inherits tsp connection, the | 10:30 |
| CIA-23 | exceptions also need to be inherited | 10:30 |
| CIA-23 | * exception handling and throwing will follow | 10:30 |
| *** jernejovc_ is now known as jernejovc | 10:42 | |
| CIA-23 | epyon tpserver-cpp-refactor * r87d063c3232f /tpserver/ (4 files): Corrections in exception definitions | 10:48 |
| CIA-23 | epyon tpserver-cpp-refactor * ra2721061e00a /tpserver/Makefile.am: Exceptions in makefile.am | 10:48 |
| *** peres has quit IRC | 11:06 | |
| CIA-23 | epyon tpserver-cpp-refactor * r0d0752048ca4 /tpserver/ (playerhttpconn.cpp playertcpconn.cpp systemexception.cpp): Exception handling for underlyingRead/Write | 11:12 |
| CIA-23 | epyon tpserver-cpp-refactor * rff309d3118b3 /tpserver/ (tcpconnection.cpp tcpconnection.h): New class layer for TCP connections | 11:46 |
| CIA-23 | epyon tpserver-cpp-refactor * r3c8f27cd671a /tpserver/ (9 files): New class layer for TCP connections implemented | 11:46 |
| epyon | bzwbk.pl | 11:54 |
| epyon | darn wrong chan ^^ | 11:55 |
| *** mithro has joined #tp | 12:18 | |
| *** Greywhind has joined #tp | 12:41 | |
| *** verhoevenv has joined #tp | 12:46 | |
| mithro | Greywhind: LGTM | 12:54 |
| Greywhind | mithro: ok, cool :) | 13:00 |
| *** cherez has quit IRC | 13:07 | |
| *** gau_veldt has quit IRC | 13:07 | |
| *** gau_veldt has joined #tp | 13:08 | |
| *** tuna-fish has joined #tp | 13:08 | |
| *** cherez has joined #tp | 13:08 | |
| *** JLP has joined #tp | 13:09 | |
| *** JLP_ has quit IRC | 13:09 | |
| *** Erroneous is now known as DTRemenak | 13:15 | |
| *** Erroneous has joined #tp | 13:44 | |
| *** tuna-fish has quit IRC | 14:41 | |
| *** alanp_ has quit IRC | 15:07 | |
| * epyon kills copy-paste code | 15:36 | |
| CIA-23 | epyon tpserver-cpp-refactor * r2f8aef3e5646 /tpserver/ (8 files): | 15:57 |
| CIA-23 | Connection massive refactoring part 1 | 15:57 |
| CIA-23 | * moved a LOT common AdminTcp and PlayerTcp code into TcpConnection | 15:57 |
| CIA-23 | * a lot more to come! | 15:57 |
| CIA-23 | epyon tpserver-cpp-refactor * rec8cbb0652f0 /tpserver/ (9 files): | 16:15 |
| CIA-23 | Connection refactoring | 16:15 |
| CIA-23 | * moved version to tcpconnection | 16:15 |
| CIA-23 | * moved sendFrame to tcpconnection | 16:15 |
| CIA-23 | epyon tpserver-cpp-refactor * r3f9a7d4f4192 /tpserver/ (6 files): | 16:15 |
| CIA-23 | Connection massive refactoring part 2 | 16:15 |
| CIA-23 | * moved more duplicate code into tcp connection | 16:15 |
| CIA-23 | * probably some classes will cease to exist O.o | 16:16 |
| epyon | what is sequence in frames? | 16:29 |
| CIA-23 | epyon tpserver-cpp-refactor * rda70d4e5f75f /tpserver/ (17 files): | 16:48 |
| CIA-23 | Connection massive refactoring part 3 | 16:48 |
| CIA-23 | * removed AdminTcp and PlayerTcp connections altogether | 16:48 |
| CIA-23 | * phew, a blob of duplicate code got squashed, rejoice! | 16:48 |
| *** LeftBehind has joined #tp | 17:03 | |
| *** LeftBehind has left #tp | 17:03 | |
| mhilmi | gargh | 17:03 |
| * mhilmi shoots himself | 17:03 | |
| CIA-23 | epyon tpserver-cpp-refactor * r04b2942f5c37 /tpserver/ (8 files): | 17:27 |
| CIA-23 | Connection massive refactoring part 4 | 17:27 |
| CIA-23 | * moved process to tcpconnection | 17:27 |
| CIA-23 | * made members of tcpconnection as private as possible | 17:27 |
| CIA-23 | * eyeing duplicate code in Admin and Player connection | 17:27 |
| CIA-23 | epyon tpserver-cpp-refactor * rbca839ef6764 /tpserver/ (4 files): | 18:10 |
| CIA-23 | Connection massive refactoring part 5 | 18:10 |
| CIA-23 | * moved common authentication code to getAuth | 18:10 |
| *** greenlion has quit IRC | 18:13 | |
| CIA-23 | epyon tpserver-cpp-refactor * r629b015726a3 /tpserver/ (4 files): | 18:32 |
| CIA-23 | Connection massive refactoring part 5 | 18:32 |
| CIA-23 | * player agent creation now strict | 18:32 |
| CIA-23 | * frames in player connection login have their own functions | 18:32 |
| *** alanp has quit IRC | 18:42 | |
| CIA-23 | epyon tpserver-cpp-refactor * r60bb6fc79a2a /tpserver/ (adminconnection.cpp playerconnection.h): | 18:43 |
| CIA-23 | Connection massive refactoring part 7 | 18:43 |
| CIA-23 | * refactores adminconnection | 18:43 |
| *** llnz has joined #tp | 18:45 | |
| llnz | morning all | 18:46 |
| cherez | Morning. | 19:10 |
| llnz | hi cherez | 19:20 |
| epyon | late evening here | 19:20 |
| llnz | hi epyon | 19:20 |
| llnz | your connection refactoring looks good | 19:21 |
| epyon | 1~sorry I was away, hope nash conveyed the info :) | 19:21 |
| epyon | well, admin and player were almost the same... | 19:21 |
| llnz | it had we worried when i saw the inversion of part of the heirarchy, but all good now | 19:21 |
| llnz | s/we/me/ | 19:21 |
| epyon | it's a lot more clear | 19:21 |
| epyon | btw, I had a question, what is sequence in frames? | 19:22 |
| llnz | yeah, i knew they were similar | 19:22 |
| llnz | in the tp protocol, its possible for the server to send a set of frames in reply to a single client request | 19:23 |
| llnz | the first frame is the sequence frame that says how many more frames to expect | 19:23 |
| llnz | they all have the same sequence number | 19:23 |
| CIA-23 | epyon tpserver-cpp-refactor * r1d0025fa7b9a /tpserver/ (playerhttpconn.cpp tcpconnection.cpp tcpconnection.h): | 19:31 |
| CIA-23 | Connection massive refactoring part 8 | 19:31 |
| CIA-23 | * refactored the return value chaos in tcp methods | 19:31 |
| CIA-23 | * sendData and sendDataAndClose now replaced with sendString | 19:31 |
| epyon | llnz, could you explain the various buffers used in tcp connection? sbuff and rdatabuff? | 19:31 |
| llnz | sbuff is the send buffer | 19:32 |
| llnz | rdatabuff is the body data part of the received frame (rheadbuff is the header) | 19:32 |
| llnz | btw, have you read about filters? | 19:37 |
| epyon | hmm? | 19:40 |
| llnz | it't not too important, but will happen (more) in future | 19:41 |
| llnz | including merging the tlsconnection and tcpconnection, and having to turn off the pipelining | 19:42 |
| llnz | http://www.thousandparsec.net/tp/dev/documents/protocol4.php | 19:42 |
| tpb | <http://ln-s.net/JqO> (at www.thousandparsec.net) | 19:42 |
| epyon | btw, instead of buffers we will use std::string | 19:43 |
| llnz | ok | 19:43 |
| CIA-23 | epyon tpserver-cpp-refactor * rf42f6a60e778 /tpserver/ (tcpconnection.cpp tcpconnection.h): Warning : change to std::string for sbuff and sbuffsize/pos | 19:45 |
| llnz | btw, you could move the connection classes to a directory and namespace if you wanted | 19:45 |
| epyon | now frame will have to be responsible for cleanup. | 19:45 |
| epyon | I will ;) | 19:45 |
| * epyon doesn't get "sendandclose" | 19:49 | |
| llnz | sendandclose is meant to send a plain text error message to the socket, then close the connection | 19:51 |
| epyon | uh no, not SensDataAndClose | 19:52 |
| epyon | sendandclose boolean :P | 19:52 |
| llnz | humm... | 19:52 |
| epyon | btw, what's the general eval of my progress? I know I sidetracked from the original plan quite a bit, and missed some days :/ | 19:55 |
| llnz | something like, give the socket extra time to send the queued frames | 19:55 |
| llnz | not sure if sendandclose is needed | 19:56 |
| llnz | epyon: I feel that you are a bit behind where I think you should be, but you have done some useful work | 19:57 |
| epyon | things have been hectic around the end of the academic year, it should be far better now :) | 19:59 |
| llnz | cool | 19:59 |
| epyon | btw, seems as sendFail makes many lines of code obsolete... | 20:22 |
| llnz | umm... maybe | 20:27 |
| llnz | some might not fit | 20:27 |
| llnz | specifically those that have been upgraded to pass the list of references | 20:28 |
| *** peres has joined #tp | 20:29 | |
| epyon | is there a version to string func someweher? | 20:29 |
| llnz | epyon: no | 20:29 |
| llnz | version is just an integer | 20:32 |
| *** verhoevenv has quit IRC | 20:52 | |
| llnz | Landon: the move element in battlexml should be a 3d position | 21:13 |
| llnz | i have decided | 21:13 |
| llnz | hopefully mithro and everyone is ok with it | 21:14 |
| Landon | with a way to degrade gracefully I suppose? | 21:16 |
| Landon | for a 2d viewer | 21:16 |
| Landon | well, I guess it could just use the X,Y of it | 21:16 |
| Landon | sounds like a good deal | 21:16 |
| llnz | yeah, just drop z | 21:17 |
| llnz | most ruleset (at least for now) wont use it | 21:17 |
| epyon | llnz, can you check how long is your playeragent.cpp? | 21:20 |
| llnz | (the fact that none of the examples use 'move' at all is... odd) | 21:20 |
| epyon | file lines, including whitespace | 21:20 |
| llnz | 1855 according to wc -l | 21:21 |
| * epyon is down to 1550 and getting less :/ | 21:23 | |
| llnz | nice | 21:24 |
| Landon | llnz: wrt move, whos responsibility would it be to keep collisions from happening | 21:27 |
| Landon | do rulesets have enough information about size to move stuff carefully? | 21:28 |
| llnz | Landon: the ruleset should do | 21:28 |
| Landon | ok | 21:29 |
| llnz | i think you can safely assume that if it's in a (xml valid) battlexml file, it's correct | 21:29 |
| llnz | epyon: btw, I was looking at boost::program_options yesterday and it looks quite good | 21:31 |
| epyon | 1460 lines... | 21:39 |
| epyon | and I'm not removing blanks D: | 21:39 |
| llnz | hehe, i'm busy adding 300+ lines :-) | 21:47 |
| epyon | 1400... | 21:51 |
| * epyon likes removing obsolete ^_^ | 21:51 | |
| *** alanp has joined #tp | 21:55 | |
| *** Erroneous has quit IRC | 21:55 | |
| CIA-23 | epyon tpserver-cpp-refactor * rfd1ab6ed216d /tpserver/ (playerconnection.cpp playerconnection.h tcpconnection.h): TODO markers and PlayerConnection ping frame | 22:05 |
| CIA-23 | epyon tpserver-cpp-refactor * r8c48ee5c9644 /tpserver/ (4 files): Player agent TCP connection goodies -- 500 lines of code less! | 22:05 |
| CIA-23 | Greywhind tpclient-pywx-tp04 * r96b70c3510e0 / (34 files in 3 dirs): Re-made panelInfo to work with tp04 and to have a collapsible, extensible layout. | 22:07 |
| epyon | gnight | 22:21 |
| llnz | cya later epyon | 22:21 |
| *** jmtan has joined #tp | 23:04 | |
| *** jmtan has quit IRC | 23:17 | |
| CIA-23 | llnz tpserver-cpp-battlexml * rfb3afa0c64e6 /tpserver/ (7 files in 2 dirs): | 23:28 |
| CIA-23 | Adding initial BattleXml classes. | 23:28 |
| CIA-23 | Still needs a little work, mostly what to do with the xml once it is created. | 23:28 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!