| *** tpb has joined #timvideos | 00:00 | |
| *** froztbyt1 is now known as froztbyte | 02:41 | |
| *** rohitksingh_work has joined #timvideos | 04:23 | |
| paddatrapper | mithro: thanks! | 04:36 |
|---|---|---|
| *** tvCommitBot has joined #timvideos | 04:50 | |
| -tvCommitBot- [av-foss-stack] CarlFK pushed 1 new commit to master: https://git.io/vQc6U | 04:50 | |
| -tvCommitBot- av-foss-stack/master 1c1a172 Carl Karsten: testing veyepar | 04:50 | |
| *** tvCommitBot has left #timvideos | 04:50 | |
| *** sb0 has quit IRC | 06:50 | |
| *** tpb has joined #timvideos | 07:07 | |
| shenki | Ishan_Bansal: when you're learning how to respond to code reviews I recommend going through each of the comments one by one | 07:24 |
| shenki | Ishan_Bansal: if you have fixed the issue that the review comment points out, then just reply 'Done' | 07:25 |
| mithro | I'll be around for an hour if you have questions | 07:31 |
| Ishan_Bansal | shenki : After fixing any issue how can I make it to review again. Should I push my code again in the pull request or simply commit it in my own repository. | 08:19 |
| mithro | Ishan_Bansal: You push your commits to the branch you made the pull request from | 08:31 |
| mithro | Ishan_Bansal: and then reply to the comments on the pull request | 08:31 |
| Ishan_Bansal | mithro : got it. | 08:43 |
| *** techman83 has quit IRC | 08:47 | |
| *** techman83 has joined #timvideos | 08:48 | |
| *** ChanServ sets mode: +v techman83 | 08:48 | |
| *** techman83 has quit IRC | 08:50 | |
| *** techman83 has joined #timvideos | 08:54 | |
| *** ChanServ sets mode: +v techman83 | 08:54 | |
| *** techman83 has quit IRC | 09:17 | |
| *** techman83 has joined #timvideos | 09:23 | |
| *** ChanServ sets mode: +v techman83 | 09:23 | |
| mithro | Ishan_Bansal: normal comments will be placed near the place which needs fixing, but you should make sure you apply the same logic through out the rest of the code | 09:53 |
| mithro | Ishan_Bansal: IE I'll only probably mention fixing indenting in one or two places, but you should fix it everywhere. | 09:54 |
| mithro | Anyway, heading out for the night | 09:54 |
| paddatrapper | mithro: progress report up for you | 10:41 |
| *** sb0 has joined #timvideos | 11:43 | |
| *** sb0 has quit IRC | 12:22 | |
| *** rohitksingh_work has quit IRC | 12:51 | |
| paddatrapper | well turns out my exam is tomorrow... So will try get things done tonight | 13:09 |
| *** sb0 has joined #timvideos | 14:08 | |
| *** rohitksingh has joined #timvideos | 14:29 | |
| *** hyadez has quit IRC | 16:58 | |
| *** rohitksingh has quit IRC | 18:00 | |
| *** rohitksingh has joined #timvideos | 18:03 | |
| *** rohitksingh has quit IRC | 18:25 | |
| paddatrapper | mithro: those two PRs should be good now | 19:23 |
| *** hyadez has joined #timvideos | 19:43 | |
| *** CarlFK has quit IRC | 23:40 | |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!