| *** tpb has joined #timvideos | 00:00 | |
| xfxf | mithro: nah, getting working audio is totally more important than exams. who likes exams? :P | 00:59 |
|---|---|---|
| tumbleweed | exam time usually means lots of free time :) | 01:01 |
| paddatrapper | mithro: my first exam is early tomorrow, so may be able to get it done tomorrow afternoon | 04:11 |
| *** miselin has quit IRC | 05:14 | |
| *** miselin has joined #timvideos | 05:15 | |
| *** rohitksingh has joined #timvideos | 05:20 | |
| paddatrapper | mithro: ok never mind. My exam is tomorrow afternoon, so I doubt I'll be able to work on it before Thursday | 05:53 |
| mithro | paddatrapper: Okay, understand | 06:34 |
| mithro | paddatrapper: Are you going to make our meeting tomorrow? | 06:35 |
| *** bjoern_ has joined #timvideos | 06:38 | |
| paddatrapper | mithro: tomorrow's Wednesday, isn't our meeting Thursday? | 06:49 |
| mithro | Yes, I'm just confused :-P | 06:50 |
| paddatrapper | Cool :) as long as today is not Wednesday! | 06:51 |
| mithro | It is not | 06:54 |
| *** rohitksingh has quit IRC | 06:58 | |
| *** rohitksingh_work has joined #timvideos | 07:57 | |
| *** rohitksingh_work has quit IRC | 08:28 | |
| *** rohitksingh_work has joined #timvideos | 08:28 | |
| *** rohitksingh_work has quit IRC | 08:29 | |
| mithro | Ishan_Bansal: Hi! I added a bunch of comments on your pull request | 09:14 |
| mithro | Ishan_Bansal: I added a lot of comments, but that is normal on your first few! | 09:14 |
| mithro | Ishan_Bansal: If you have any questions, please do poke me and I'll try and respond | 09:15 |
| mithro | Ishan_Bansal: I've been coding for ~15 years and still get tonnes of comments when I send out my code at work too :-P | 09:16 |
| mithro | Ishan_Bansal: See an example at https://codereview.chromium.org/2054763004/ :-P | 09:18 |
| tpb | Title: Issue 2054763004: luci-go/common/dirwalk: Code for walking a directory tree efficiently - Code Review (at codereview.chromium.org) | 09:18 |
| mithro | shenki: FYI ^^ | 09:18 |
| shenki | mithro: thank you! | 09:20 |
| *** andi-m has joined #timvideos | 09:29 | |
| *** ivodd_ has joined #timvideos | 09:29 | |
| *** froztbyt1 has joined #timvideos | 09:30 | |
| mithro | paddatrapper: FYI - I also put comments on your pull request at https://github.com/mithro/fx2lib-linux-headers/pull/1/files | 09:30 |
| tpb | Title: Add string table generator by paddatrapper · Pull Request #1 · mithro/fx2lib-linux-headers · GitHub (at github.com) | 09:30 |
| paddatrapper | mithro: thanks | 09:30 |
| mithro | Oh wait | 09:31 |
| mithro | I forgot to publish them | 09:31 |
| paddatrapper | lol. That does help :) | 09:34 |
| paddatrapper | Hopefully I'll be able to work on them later tonight | 09:34 |
| *** Ishan_Bansal has quit IRC | 09:35 | |
| *** andi_m has quit IRC | 09:35 | |
| *** froztbyte has quit IRC | 09:35 | |
| *** ivodd has quit IRC | 09:35 | |
| *** Ishan_Bansal has joined #timvideos | 09:40 | |
| shenki | Ishan_Bansal: i reading through all of mithro's comments, and once you've read them all address each of his comments in turn | 09:50 |
| shenki | Ishan_Bansal: where you're not sure what the comment means, or you disagree with the suggestion, please use the tool to publish your comments | 09:51 |
| *** rohitksingh has joined #timvideos | 13:43 | |
| *** rohitksingh has quit IRC | 13:51 | |
| *** rohitksingh has joined #timvideos | 13:52 | |
| *** rohitksingh has quit IRC | 13:58 | |
| Ishan_Bansal | shenki : sure | 14:57 |
| Ishan_Bansal | mithro : should I go through each of the comment one by one and than show the edited version of the code after each step. | 14:59 |
| Ishan_Bansal | mithro : Or I go through all of them at once. | 15:00 |
| *** tsglove has quit IRC | 16:58 | |
| *** tsglove has joined #timvideos | 17:01 | |
| *** tsglove2 has joined #timvideos | 21:36 | |
| *** tsglove has quit IRC | 21:40 | |
| mithro | paddatrapper: Good luck with the exams! | 22:06 |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!