| *** tpb has joined #litex | 00:00 | |
| *** CarlFK has quit IRC | 00:44 | |
| *** peepsalot has quit IRC | 00:55 | |
| *** peepsalot has joined #litex | 01:00 | |
| *** Degi has quit IRC | 02:35 | |
| *** Degi has joined #litex | 02:36 | |
| *** _whitelogger has quit IRC | 04:45 | |
| *** _whitelogger has joined #litex | 04:47 | |
| *** kgugala_ has joined #litex | 04:59 | |
| *** kgugala has quit IRC | 05:01 | |
| *** st-gourichon-fid has quit IRC | 05:22 | |
| *** st-gourichon-fid has joined #litex | 05:22 | |
| *** keesj has quit IRC | 06:05 | |
| *** keesj has joined #litex | 06:10 | |
| *** kgugala has joined #litex | 07:10 | |
| *** kgugala_ has quit IRC | 07:14 | |
| st-gourichon-fid | pepijndevos, if my PR was useful to your "good news! vexrisc boots to console no" then I'm happy about it, any way that's okay. https://github.com/enjoy-digital/litex/pull/663 | 07:58 |
|---|---|---|
| tpb | Title: Fix SoC CPU crash on minimal variants on call to flush_cpu_dcache(). by fidergo-stephane-gourichon · Pull Request #663 · enjoy-digital/litex · GitHub (at github.com) | 07:58 |
| *** kgugala_ has joined #litex | 08:27 | |
| *** kgugala has quit IRC | 08:29 | |
| *** kgugala has joined #litex | 08:44 | |
| *** kgugala_ has quit IRC | 08:47 | |
| *** david-sawatzke[m has quit IRC | 10:33 | |
| *** CarlFK[m]1 has quit IRC | 10:33 | |
| *** david-sawatzke[m has joined #litex | 10:34 | |
| *** CarlFK[m]1 has joined #litex | 10:34 | |
| st-gourichon-fid | Hi! When building documentation for a design we get "AttributeError: 'CDCUsbPHY' object has no attribute 'duid'". Investigating the hypothesis that this means "document id" and something is missing in CSCUsbPHY. Any hint appreciated. | 11:12 |
| st-gourichon-fid | on calling generate_docs(soc, "build/"+target+"/documentation") | 11:16 |
| zyp | sounds to me like the CDCUsbPHY instance gets passed to some code that expects a CSR instance (the CSR instances have a duid attribute) | 11:17 |
| zyp | i.e. you're probably passing in the wrong object somewhere | 11:17 |
| st-gourichon-fid | Thanks zyp for the feedback. The design compiles and works fine, only generating doc fails like this. | 11:18 |
| zyp | can you pastebin the full traceback of the error? | 11:21 |
| st-gourichon-fid | yes | 11:31 |
| st-gourichon-fid | https://paste.ubuntu.com/p/SHngNPcQbw/ | 11:35 |
| tpb | Title: Ubuntu Pastebin (at paste.ubuntu.com) | 11:35 |
| zyp | ah, right, it's not the CSR duid, it's the ModuleDoc duid | 11:41 |
| zyp | where does the CDCUsbPHY come from? | 11:43 |
| st-gourichon-fid | Strangely, the code does test if object is of ModuleDoc class. | 11:43 |
| st-gourichon-fid | Let me check. | 11:43 |
| st-gourichon-fid | In ValentyUSB | 11:44 |
| st-gourichon-fid | We were instructed to follow https://gist.github.com/enjoy-digital/82ed88b77ef0b1e3e91b0592e44eaa14#file-gistfile1-txt-L83 which requires branch hw_cdc_eptri of valentyusb | 11:48 |
| tpb | Title: Fomu · GitHub (at gist.github.com) | 11:48 |
| zyp | ah, right | 11:50 |
| st-gourichon-fid | https://github.com/gregdavill/valentyusb/blob/hw_cdc_eptri/valentyusb/usbcore/cpu/cdc_eptri.py#L180 | 11:50 |
| tpb | Title: valentyusb/cdc_eptri.py at hw_cdc_eptri · gregdavill/valentyusb · GitHub (at github.com) | 11:50 |
| st-gourichon-fid | class CDCUsbPHY(Module, AutoDoc, ModuleDoc): | 11:50 |
| zyp | yeah, I found it | 11:51 |
| *** kgugala_ has joined #litex | 11:51 | |
| zyp | I have an idea of what the problem might be | 11:52 |
| st-gourichon-fid | I'm interested. | 11:53 |
| *** kgugala has quit IRC | 11:53 | |
| *** kgugala has joined #litex | 11:54 | |
| zyp | well, ref. https://github.com/enjoy-digital/litex/blob/master/litex/soc/integration/doc.py#L27 | 11:57 |
| tpb | Title: litex/doc.py at master · enjoy-digital/litex · GitHub (at github.com) | 11:57 |
| zyp | that claims there's no need to call __init__(), but __init__() is what calls DUID.__init__() which is what sets self.duid | 11:58 |
| *** kgugala_ has quit IRC | 11:58 | |
| zyp | so I don't really understand how it's supposed to work without calling __init__ | 11:58 |
| zyp | try adding ModuleDoc.__init__(self) to CDCUsbPHY | 12:00 |
| st-gourichon-fid | doing that | 12:02 |
| zyp | I guess it got overlooked because __init__() doesn't do anything else useful when called without arguments | 12:03 |
| st-gourichon-fid | Done. No more exception. | 12:05 |
| st-gourichon-fid | Considering PR to https://github.com/gregdavill/valentyusb/blob/hw_cdc_eptri/valentyusb/usbcore/cpu/cdc_eptri.py#L180 | 12:05 |
| tpb | Title: valentyusb/cdc_eptri.py at hw_cdc_eptri · gregdavill/valentyusb · GitHub (at github.com) | 12:05 |
| zyp | yeah, and probably a PR to litex as well to remove the line about __init__ not being required :) | 12:06 |
| zyp | unless there is a better way to solve it | 12:06 |
| st-gourichon-fid | Can do that. Will include your hints in the PR. | 12:06 |
| *** kgugala_ has joined #litex | 12:06 | |
| *** kgugala_ has quit IRC | 12:08 | |
| *** kgugala_ has joined #litex | 12:09 | |
| *** kgugala has quit IRC | 12:10 | |
| st-gourichon-fid | zyp, where is that mentioned in litex that __init__ is not required? | 12:12 |
| st-gourichon-fid | I grepped and did not find. | 12:12 |
| zyp | I linked it | 12:13 |
| zyp | 13:57:37 < zyp> well, ref. https://github.com/enjoy-digital/litex/blob/master/litex/soc/integration/doc.py#L27 | 12:13 |
| tpb | Title: litex/doc.py at master · enjoy-digital/litex · GitHub (at github.com) | 12:13 |
| *** kgugala_ has quit IRC | 12:14 | |
| *** kgugala has joined #litex | 12:14 | |
| st-gourichon-fid | Ah thanks. I grepped excluding *.py ... | 12:14 |
| st-gourichon-fid | Thanks zyp, things were not clear to me before, re-reading your lines above things are clear now. Doing PRs. | 12:22 |
| st-gourichon-fid | Done https://github.com/gregdavill/valentyusb/pull/1 | 12:29 |
| tpb | Title: Fix incompatibility with ModuleDoc(). by fidergo-stephane-gourichon · Pull Request #1 · gregdavill/valentyusb · GitHub (at github.com) | 12:29 |
| st-gourichon-fid | and https://github.com/enjoy-digital/litex/pull/668 | 12:29 |
| tpb | Title: Change misleading comment about ModuleDoc. by fidergo-stephane-gourichon · Pull Request #668 · enjoy-digital/litex · GitHub (at github.com) | 12:29 |
| *** kgugala_ has joined #litex | 12:35 | |
| *** kgugala_ has quit IRC | 12:38 | |
| *** kgugala has quit IRC | 12:38 | |
| *** kgugala has joined #litex | 12:38 | |
| *** kgugala_ has joined #litex | 12:48 | |
| *** kgugala has quit IRC | 12:52 | |
| *** FFY00 has quit IRC | 13:17 | |
| *** FFY00 has joined #litex | 13:18 | |
| *** FFY00 has quit IRC | 13:18 | |
| *** FFY00 has joined #litex | 13:19 | |
| *** [Matt] has quit IRC | 14:22 | |
| *** [Matt] has joined #litex | 14:40 | |
| *** vup has quit IRC | 14:43 | |
| *** vup has joined #litex | 14:44 | |
| *** CarlFK has joined #litex | 18:00 | |
| futarisIRCcloud | https://github.com/secworks/poly1305 | 22:44 |
| tpb | Title: GitHub - secworks/poly1305: Hardware implementation of the poly1305 message authentication function. (at github.com) | 22:44 |
| *** lf has quit IRC | 23:10 | |
| *** lf has joined #litex | 23:10 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!