| *** tpb has joined #tomu | 00:00 | |
| *** hEl[pm0mey[m] has joined #tomu | 00:11 | |
| *** rj has quit IRC | 00:14 | |
| *** kcnickerson_____ has quit IRC | 00:16 | |
| *** thepatr1ck has quit IRC | 00:16 | |
| *** _florent_ has quit IRC | 00:17 | |
| *** thepatr1ck has joined #tomu | 00:18 | |
| *** kcnickerson_____ has joined #tomu | 00:18 | |
| *** futarisIRCcloud has quit IRC | 00:19 | |
| *** futarisIRCcloud has joined #tomu | 00:19 | |
| *** _florent_ has joined #tomu | 00:20 | |
| *** deltab has quit IRC | 01:50 | |
| *** deltab has joined #tomu | 02:00 | |
| *** mmmattyx has quit IRC | 02:16 | |
| *** ewen has quit IRC | 05:32 | |
| *** ewen has joined #tomu | 07:01 | |
| *** kuldeep_ has quit IRC | 07:38 | |
| *** ewen has quit IRC | 08:06 | |
| *** coderobe7 has joined #tomu | 12:18 | |
| *** gio has quit IRC | 12:19 | |
| *** coderobe has quit IRC | 12:20 | |
| *** coderobe7 is now known as coderobe | 12:20 | |
| *** gio has joined #tomu | 12:20 | |
| *** rqou has quit IRC | 14:00 | |
| *** rqou has joined #tomu | 14:00 | |
| *** rj has joined #tomu | 15:35 | |
| *** thaytan has quit IRC | 15:42 | |
| *** thaytan has joined #tomu | 15:43 | |
| st-gourichon-f | Hi! I noticed a suspicious line on https://github.com/im-tomu/foboot/blob/master/sw/src/dfu.c#L184 (permalink https://github.com/im-tomu/foboot/blob/882ce04da8b97084ef95f5a967a0e2b7312b19c2/sw/src/dfu.c#L184 ). When i is an integer variable that is incremented (by 1), this sounds suspect: if (dfu_buffer[i/4] == RAM_BOOT_SENTINAL) { | 15:50 |
|---|---|---|
| st-gourichon-f | Probably not a big deal, the result is that code checks 4 times each address. It might not check the whole intended area, though. | 15:50 |
| st-gourichon-f | Doc says first 56 bytes are searched, actual search range might be 4 times too small. | 15:51 |
| ssb | search range looks okay as dfu_buffer is uint32[], but yes, "i" needs to be incremented by 4, as it seems. | 16:25 |
| *** AnimaInvicta has joined #tomu | 17:00 | |
| *** srk has quit IRC | 18:51 | |
| *** NoGodDamnIdea has joined #tomu | 18:59 | |
| *** rj has quit IRC | 19:20 | |
| *** srk has joined #tomu | 20:04 | |
| *** thepatr1ck has quit IRC | 21:35 | |
| *** englishm has quit IRC | 21:36 | |
| *** johnhmay has quit IRC | 21:36 | |
| *** thepatr1ck has joined #tomu | 21:37 | |
| *** englishm has joined #tomu | 21:38 | |
| *** johnhmay has joined #tomu | 21:39 | |
| *** AnimaInvicta has left #tomu | 23:32 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!