| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| *** StupidIncarnate has joined #tp | 00:15 | |
| alanp | sup | 01:23 |
|---|---|---|
| llnz | hi alanp | 01:36 |
| *** tansell-laptop has joined #tp | 01:49 | |
| alanp | hey llnz | 02:31 |
| alanp | big excitement in NZ today? | 02:31 |
| llnz | hehe, yeah | 02:31 |
| alanp | 2 points, not bad | 02:31 |
| llnz | :-) | 02:33 |
| *** StupidIncarnate has quit IRC | 02:34 | |
| llnz | how is it going alanp? | 02:50 |
| *** StupidIncarnate has joined #tp | 02:58 | |
| alanp | not bad | 03:07 |
| alanp | you? | 03:07 |
| *** StupidIncarnate has quit IRC | 03:08 | |
| llnz | not too bad | 03:09 |
| llnz | it was good to crush some tpserver-cpp bugs on the weekend | 03:09 |
| tansell | llnz, did you get the one with time going backwards? | 03:36 |
| llnz | yes, not a tpserver-cpp bug, but in libtpclient-py | 03:37 |
| alanp | was that 97? | 03:41 |
| CIA-31 | alanp tpserver-cpp * r39b81eb414e3 /modules/games/mtsec/tpserver-cpp-mtsec-gamedata.xml: - Scheme fixes for colonisation module | 03:42 |
| CIA-31 | alanp tpserver-cpp * r4364880ef74c /tpserver/ (11 files): Merge branch 'master' of git+ssh://git.thousandparsec.net/git/tpserver-cpp | 03:42 |
| alanp | wtf is that second commit | 03:43 |
| tansell | llnz, got a link to the fix? | 03:43 |
| llnz | http://git.thousandparsec.net/gitweb/gitweb.cgi?p=libtpclient-py.git;a=commit;h=b3ae9a0af1088f15e2d1d2be750e1353db246768 | 03:44 |
| tpb | <http://ln-s.net/79OI> (at git.thousandparsec.net) | 03:44 |
| llnz | four line addition | 03:44 |
| llnz | alanp: that for merging with master (probably a git pull after you have a local commit) | 03:45 |
| alanp | ahh | 03:45 |
| tansell | why is 0 == noaccess? | 03:45 |
| llnz | beacuse it's true | 03:46 |
| llnz | it occured to me this morning that it could have been len(allowed order types) == 0 | 03:46 |
| llnz | in fact len(allowed order types) == 0 and num_orders == 0 would work | 03:48 |
| tansell | Order QueueAn order queue. | 03:53 |
| tansell | 32 bit unsigned integer, the Maximum slots, The maximum number of slots that can be used in this queue. | 03:53 |
| tansell | 32 bit unsigned integer, the Queue ID, The ID number of the queue. | 03:53 |
| tansell | 32 bit unsigned integer, the Number of Orders, The number of orders in the queue. | 03:53 |
| tansell | It doesn't really say that the Queue ID == 0 is no-access | 03:54 |
| llnz | the guest user doesn't have access to any orderqueue - what should the orderqueueid be then? | 03:54 |
| matthewd | Should queue 0 be an empty queue that really exists, perhaps? | 03:56 |
| llnz | matthewd: why should it exist? | 03:56 |
| matthewd | (So the fact that 0 implies no-access is purely a server-side convention) | 03:56 |
| llnz | ah | 03:56 |
| tansell | yeah, that is what I was just thinking | 03:56 |
| tansell | the problem is actually this | 03:57 |
| tansell | 688 self.orders[queueid] = (self.objects[objectid].modify_time, subs) | 03:57 |
| tansell | order queue's don't have their own mod-time | 03:57 |
| llnz | fucked if i know what was causing the problem with that line, the modtime for the getIds list and the object itself both come from the same value | 03:58 |
| tansell | so if two objects reference the same order queue, things go pair shaped | 03:58 |
| llnz | ah | 03:58 |
| llnz | aaahhhhhh | 03:58 |
| * llnz grumbles about wasting all that time on the weekend trying to find the problem | 03:59 | |
| tansell | llnz, well - if you hadn't found that fix, I wouldn't have figured out the real cause | 03:59 |
| tansell | llnz, what do you think is the correct fix? | 04:06 |
| llnz | probably for orderqueues to exist as first class objects | 04:10 |
| llnz | maybe? | 04:10 |
| *** StupidIncarnate has joined #tp | 04:10 | |
| llnz | or the second don't fetch filter i suggested about with num_orders and order types | 04:11 |
| tansell | llnz, that was my thought | 04:17 |
| tansell | it would dramatically reduce the number of objects we need to get | 04:17 |
| llnz | maybe not "dramatically" | 04:33 |
| *** mithro has joined #tp | 04:35 | |
| llnz | bbl | 04:39 |
| *** llnz has quit IRC | 04:39 | |
| *** mithro has quit IRC | 04:40 | |
| *** mithro has joined #tp | 04:54 | |
| *** DTRemenak has quit IRC | 05:10 | |
| *** DTRemenak has joined #tp | 05:11 | |
| *** StupidIncarnate has quit IRC | 05:23 | |
| tansell | ezod, pong? | 05:24 |
| tansell | alanp, ping? | 05:24 |
| alanp | tansell: pong | 05:24 |
| tansell | alanp, do you use tripit? | 05:24 |
| alanp | no | 05:25 |
| alanp | do i need to? | 05:25 |
| tansell | when are you flying back home from the Thousand Parsec hackfest? | 05:25 |
| alanp | Departure (SJC): August 14, 8:45 AM PDT (morning) | 05:26 |
| alanp | any problem? | 05:27 |
| tansell | Looks like I've book the hotel till the 13th rather then the 14th | 05:30 |
| alanp | :( | 05:30 |
| alanp | when does hackfest end | 05:30 |
| tansell | well, the 13th is the last day of hacking | 05:31 |
| alanp | might be able to couchsurf | 05:35 |
| alanp | going to have to leave for the airport around 430-500 | 05:35 |
| tansell | I'm going to see if we can extend the reservation | 05:35 |
| alanp | wtf | 05:36 |
| alanp | they must have changed the flight time since i bought them | 05:36 |
| alanp | now it's showing 10am | 05:37 |
| alanp | yep, changed it | 05:38 |
| alanp | shorter plane change now though | 05:38 |
| tansell | alanp, if you put your trips in tripit, you can share them with me :) | 05:40 |
| alanp | hehe | 05:40 |
| alanp | 1min | 05:41 |
| *** StupidIncarnate has joined #tp | 05:42 | |
| alanp | i think i had the android client at one point but didn't want to send all the e-mails | 05:42 |
| alanp | what's your email on tripit? | 05:47 |
| alanp | tansell: ^ | 05:48 |
| *** llnz has joined #tp | 06:02 | |
| tansell | llnz, which day are you flying out on? | 06:11 |
| tansell | (out of SFO) | 06:11 |
| llnz | humm... | 06:39 |
| llnz | let me check | 06:39 |
| tansell | llnz, do you use tripit? | 06:43 |
| alanp | tripit privacy concerns worry me, but it seems pretty ok | 06:44 |
| llnz | no, i don't | 06:46 |
| llnz | not good.... | 06:53 |
| tansell | llnz, ? | 06:59 |
| llnz | found it | 07:02 |
| llnz | i fly home the evening of 14 August | 07:02 |
| *** DTRemenak has quit IRC | 07:13 | |
| *** DTRemenak has joined #tp | 07:17 | |
| tansell | llnz, do you want to write up a proposal for how to fix the orderqueue thing? | 07:34 |
| *** bisc has joined #tp | 08:01 | |
| llnz | tansell: i guess so | 08:04 |
| bisc | mithro, tansell: ping | 08:17 |
| tansell | bisc, pong | 08:20 |
| bisc | tansell: a question about creating the controls for sending messages. Wasn't it done earlier (saw winmessageboard.py, but didn't see usage of it)? And if it wasn't -- do we want it as a lightweigh frame or a dialog? | 08:23 |
| tansell | I think the idea was to create a proper message board type system | 08:24 |
| bisc | tansell: the board should be a separate window or a panel? | 08:25 |
| tansell | window | 08:26 |
| bisc | tansell: are these boards now supported by server? | 08:35 |
| tansell | not sure | 08:38 |
| bisc | tansell: hmm. So, I shouldn't work in the way of making message board work on client? | 08:42 |
| *** null_000 has joined #tp | 08:47 | |
| *** null_000 has quit IRC | 09:09 | |
| tansell | bisc, the message window in the client is to view "system" messages really, rather then viewing communication between players | 09:47 |
| bisc | tansell: you mean the messages panel? And the message board is intended for players communication? | 09:49 |
| tansell | yeah | 09:50 |
| llnz | player will (eventually) have access to many boards | 09:51 |
| llnz | one is the current system board, the others are shared with another player to allow them to communicate | 09:52 |
| bisc | llnz: is this already working or just plans? | 09:52 |
| bisc | llnz: or, maybe, partly working. | 09:53 |
| llnz | just plans, but all protocol support is there | 09:53 |
| llnz | if there were plans to use it I might improve it and get it working | 09:53 |
| bisc | llnz: In my opinion -- it would be great to have this functionality. Then I work on client part for this thing. | 09:56 |
| llnz | bisc: how do i test if it's working? i need to client to test it | 09:56 |
| bisc | llnz: yes, I understand. Will see what's currently done there and make it formally show all available boards and their messages. | 09:58 |
| llnz | cool | 09:58 |
| * llnz adds interplayer boards to his todo list | 09:59 | |
| *** tanoku has joined #tp | 10:01 | |
| bisc | tansell: can you please look at these patches (latest patch sets) when you have time http://codereview.mithis.com/68001 http://codereview.mithis.com/59001 http://codereview.mithis.com/54002 | 10:01 |
| tpb | Title: Issue 68001: Work on update window UI. - Code Review (at codereview.mithis.com) | 10:01 |
| * llnz wanders off | 10:14 | |
| llnz | later all | 10:14 |
| *** llnz has quit IRC | 10:14 | |
| tansell | bisc, comments added to the last two | 10:18 |
| bisc | tansell: replied to your comments. What about the first one? | 10:25 |
| tansell | bisc, if auto-connect is set to true, then the system will connect to the first server in the list | 10:34 |
| bisc | tansell: I'm not operating with autoconnect parameter. That's just sorting of server list, and consequently setting the default selected server. | 10:35 |
| *** Epyon has joined #tp | 10:36 | |
| bisc | tansell: it makes you have 127.0.0.1 selected by in the combobox if the previous time you've tried connecting to it. | 10:37 |
| tansell | bisc, if you have autoconnect on and then connect to a different server you'll change that server to be autoconnected too | 10:38 |
| bisc | tansell: it | 10:41 |
| bisc | tansell: yes, I know that. How does it affect my patch? I seem to be working independently with this logic. | 10:43 |
| tansell | if you are setting a new server as the default, shouldn't you ask? | 10:44 |
| bisc | tansell: oh, I understand what you're saying. | 10:45 |
| bisc | tansell: if the autoconnect is switched on, I should ask the user about changing the server, right? | 10:46 |
| bisc | tansell: changing the _default_ server | 10:46 |
| bisc | tansell: the code, governing the autoconnect selection, is strange. it checks all servers and finds the one with autoconnect. And if not found sets the autoconnect from the first server. So, I don't understand it again :) | 10:55 |
| tansell | maybe I'm wrong | 10:56 |
| bisc | tansell: lines 785-816 here http://git.thousandparsec.net/gitweb/gitweb.cgi?p=tpclient-pywx.git;a=blob;f=windows/winConnect.py;h=34f362e15834f90e0ca1d5d68560214d8a6bcae2;hb=refs/heads/tp04 | 10:57 |
| tpb | <http://ln-s.net/79V2> (at git.thousandparsec.net) | 10:57 |
| bisc | tansell: check all servers for autoconnect, then take the first server. So, in case of autoconnect, I don't spoil anything. | 10:59 |
| tansell | looks like you are correct | 11:00 |
| bisc | tansell: in case there's only one server with autoconnect = true. And this is ensured by other code. | 11:01 |
| bisc | tansell: * not more than one * | 11:02 |
| tansell-laptop | okay | 11:12 |
| *** welterde has quit IRC | 11:16 | |
| bisc | tansell-laptop: and what is your opinion on this patch? You think that my code is misplaced? | 11:21 |
| tansell-laptop | bisc, yes, I think it should be one level out with the if statements | 11:21 |
| *** welterde has joined #tp | 11:22 | |
| bisc | tansell-laptop: hmm, why? I don't want to do this to servers not in config, as they're handled separately. | 11:27 |
| tansell-laptop | because you want to do something like | 11:27 |
| tansell-laptop | if currentserver != oldserver: move the server to the front of the queue | 11:27 |
| bisc | tansell-laptop: I can add this condition ( currentserver!=oldserver), but still I see no reason to remove my code out of "if server in self.config['servers']:" | 11:30 |
| tansell-laptop | because that code is logically doing something different | 11:30 |
| bisc | tansell-laptop: ah, I see. Ok, will fix that. | 11:32 |
| bisc | mithro, tansell-laptop: there're a lot of commits in my repos at github. You possibly want to try or/and pull them. | 12:11 |
| *** Agon has joined #tp | 12:19 | |
| *** StupidIncarnate has quit IRC | 13:13 | |
| *** bisc has quit IRC | 13:29 | |
| *** peres has joined #tp | 13:45 | |
| *** matthewd has quit IRC | 13:59 | |
| *** peres has quit IRC | 14:01 | |
| *** Epyon has quit IRC | 14:14 | |
| *** ezod has quit IRC | 14:18 | |
| *** Epyon has joined #tp | 14:19 | |
| *** ezod has joined #tp | 14:30 | |
| *** matthewd has joined #tp | 14:35 | |
| *** Epyon has quit IRC | 14:53 | |
| *** glew has joined #tp | 15:27 | |
| *** Agon has quit IRC | 16:37 | |
| *** verhoevenv has joined #tp | 16:59 | |
| *** Epyon has joined #tp | 17:06 | |
| *** JLP has joined #tp | 17:24 | |
| *** JLP has joined #tp | 17:24 | |
| *** JLP_ has quit IRC | 17:25 | |
| *** null_000 has joined #tp | 17:44 | |
| *** Agon has joined #tp | 18:42 | |
| *** tanoku has quit IRC | 18:50 | |
| *** tanoku has joined #tp | 19:02 | |
| *** tanoku has quit IRC | 19:08 | |
| *** tanoku has joined #tp | 19:10 | |
| *** Agon has quit IRC | 20:25 | |
| null_000 | alanp: ping | 20:36 |
| *** llnz has joined #tp | 20:46 | |
| llnz | morning all | 20:48 |
| null_000 | llnz: evening | 21:15 |
| llnz | hi null_000 | 21:17 |
| llnz | afk | 22:04 |
| *** null_000 has quit IRC | 22:22 | |
| Epyon | llnz: ping? | 22:48 |
| *** verhoevenv has quit IRC | 22:52 | |
| *** verhoevenv has joined #tp | 23:04 | |
| alanp | w00p | 23:16 |
| *** Epyon_ has joined #tp | 23:28 | |
| *** Epyon has quit IRC | 23:29 | |
| *** glew has quit IRC | 23:29 | |
| * llnz is back | 23:35 | |
| llnz | hi Epyon_ | 23:35 |
| llnz | oh, net split | 23:35 |
| *** glew has joined #tp | 23:44 | |
| *** verhoevenv has quit IRC | 23:50 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!