*** tpb has joined #tp | 00:00 | |
*** ChanServ sets mode: +o tpb | 00:00 | |
*** shenki__ is now known as shenki | 00:44 | |
*** tansell-laptop has joined #tp | 01:05 | |
*** Epyon has quit IRC | 01:47 | |
*** Erroneous has quit IRC | 02:11 | |
*** glew has quit IRC | 02:20 | |
*** nash has joined #tp | 03:02 | |
llnz | bbl, maybe | 05:02 |
---|---|---|
*** llnz has quit IRC | 05:02 | |
*** mithro has joined #tp | 05:56 | |
*** bisc has joined #tp | 06:56 | |
bisc | mithro: hello, you're available? | 06:59 |
tansell | bisc, yes | 07:05 |
bisc | tansell: I've created a fork repo and commited code which you approved http://github.com/bisc/tpclient-pywx | 07:08 |
tpb | Title: bisc's tpclient-pywx at schemepy - GitHub (at github.com) | 07:08 |
tansell-laptop | bisc, okay found another problem | 07:13 |
tansell-laptop | bisc, you have not set your email address in ~/.gitconfig | 07:14 |
tansell-laptop | http://help.github.com/git-email-settings/ | 07:14 |
tpb | Title: Help.GitHub - Setting user name, email and GitHub token (at help.github.com) | 07:14 |
tansell-laptop | bisc <bisc@acer-timeline.(none)> | 07:15 |
tansell-laptop | bisc, if you fix that I'll pull it into my repository | 07:17 |
bisc | tansell-laptop: oops, sorry, I did that, but maybe locally in another repo. will fix it. as well, I added "before" picture here http://codereview.mithis.com/36001 | 07:21 |
tpb | Title: Issue 36001: Error messages. - Code Review (at codereview.mithis.com) | 07:21 |
tansell | #dlg = wx.MessageDialog(self.application.gui.current, unicode(evt), _("Network Error"), wx.OK|wx.ICON_ERROR) | 07:23 |
tansell | 398 dlg = wx.MessageDialog(self.application.gui.current, "Cannot connect to Thousand Parsec server.", _("Network Error"), wx.OK|wx.ICON_ERROR) | 07:23 |
tansell | I think the proper fix here is to make the unicode(evt) return "Cannot connect to Thousand Parsec server" | 07:23 |
bisc | tansell: yes, I agree, that's more correct. is that done by adding __str__ method to event class? | 07:27 |
tansell | bisc, I'm unsure why it's not working at the moment - in theory it should already | 07:27 |
tansell | bisc, need to figure out why unicode(evt) is not returning the string | 07:46 |
bisc | tansell: ok, will find out. | 07:46 |
tansell | the string should be something like | 07:47 |
tansell | "The client was unable to connect to the host. This could be because the server is down or there is a problem with the network." | 07:47 |
*** shenki has quit IRC | 07:55 | |
bisc | tansell: there's one more issue: for wrong password a NetworkFailureUserEvent is returned, not NetworkFailurePasswordEvent | 08:04 |
tansell | bisc, you can't tell the difference between wrong password and wrong username | 08:04 |
bisc | tansell: that's true on server side or on client side? | 08:05 |
tansell | bisc, on the client side | 08:05 |
*** cahirwpz has joined #tp | 08:10 | |
tansell | bisc, so what have you done this week? | 08:11 |
tansell | have you setup a blog yet? | 08:11 |
tansell | bisc, poke? | 08:12 |
tansell | hello cahirwpz | 08:12 |
bisc | tansell: yes, I have. http://ruchkin.wordpress.com/ also, I created those patches at codereview. as well, I was digging through message panel code. | 08:12 |
bisc | tansell: I'm going to work on message panel, the first thing is to add wxToggleButton instead of simple button. and debug this filter window | 08:13 |
cahirwpz | tansell, pong | 08:14 |
cahirwpz | tansell, but wait for a sec, I need to drink my first coffee ;-) | 08:15 |
tansell | bisc, you mean replace the filder button with a toggle? | 08:16 |
tansell | s/filder/filter/ | 08:16 |
bisc | tansell: yes, and make it work appropriately | 08:18 |
bisc | tansell: second, I'm going to set up a new OS on NVidia video, so that I can find out, if buggy behavior of popup frames occurs because of my intel gma 4500, or poorly written code | 08:19 |
tansell | buggy popup frames? | 08:20 |
cahirwpz | tansell, http://github.com/cahirwpz/tpserver-py | 08:21 |
tpb | Title: cahirwpz's tpserver-py at master - GitHub (at github.com) | 08:21 |
cahirwpz | tansell, http://github.com/cahirwpz/libtpproto2-py | 08:21 |
tpb | Title: cahirwpz's libtpproto2-py at master - GitHub (at github.com) | 08:21 |
bisc | tansell: I mean those issues which I posted on google bugtracker. and my filter frame is not placed correctly when shown first time. | 08:21 |
tansell | cahirwpz, http://github.com/cahirwpz/libtpproto2-py/commit/fc52bf28bb5fd15532055746747f7ee4bc4bdd89 <- that should have some tests associated with it | 08:25 |
tpb | <http://ln-s.net/6cvP> (at github.com) | 08:25 |
cahirwpz | tansell, ok - I'll write one | 08:27 |
tansell | cahirwpz, you should never be accessing the ._ variables | 08:32 |
cahirwpz | tansell, why's that? what's they purpose then ? | 08:33 |
tansell | cahirwpz, the ._ variables are private to a class, you should access them via their public name | 08:33 |
cahirwpz | tansell, ok - I'll check if in cases I use underscore variables there're other (cleaner) methods to access the data my code requires | 08:37 |
bisc | tansell: just to find out: when you click "Filter" button where is the filter window displayed? | 08:37 |
tansell | cahirwpz, if you access it directly, you by pass all the checking that the structures stuff does | 08:39 |
cahirwpz | tansell, that's a good reason not to use them my way ;-) | 08:40 |
*** Agon-laptop has joined #tp | 09:44 | |
*** mithro has quit IRC | 10:11 | |
*** Agon-laptop has quit IRC | 10:13 | |
*** nash has quit IRC | 10:37 | |
*** Agon-laptop has joined #tp | 10:56 | |
*** shenki has joined #tp | 11:21 | |
*** Agon-laptop has quit IRC | 12:06 | |
*** Agon-laptop has joined #tp | 13:23 | |
*** mithro has joined #tp | 13:45 | |
*** jmtan has joined #tp | 14:46 | |
*** verhoevenv has joined #tp | 14:48 | |
*** Noughmad has joined #tp | 15:36 | |
*** Noughmad has quit IRC | 16:47 | |
*** peres has joined #tp | 16:54 | |
*** bisc has quit IRC | 16:55 | |
*** peres has quit IRC | 17:20 | |
*** Noughmad has joined #tp | 17:28 | |
*** jmtan has quit IRC | 17:32 | |
*** Noughmad has quit IRC | 17:41 | |
*** Erroneous has joined #tp | 18:17 | |
*** null_000 has joined #tp | 18:26 | |
null_000 | can anyone help me with adding a new design using libtpclient-py? | 20:23 |
*** llnz has joined #tp | 21:00 | |
*** null_000 has quit IRC | 21:14 | |
*** cahirwpz has quit IRC | 21:48 | |
*** Agon-laptop has quit IRC | 22:47 | |
*** mithro has quit IRC | 23:51 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!