Tuesday, 2013-04-16

*** tpb has joined #melange00:00
*** DrJoel has quit IRC00:06
*** VirajSinha has joined #melange00:08
*** saurabhsood91_ has joined #melange00:09
*** saurabhsood91 has quit IRC00:10
*** VirajSinha_ has quit IRC00:10
*** guido__ has quit IRC00:31
*** VirajSinha has quit IRC01:13
*** r0bby_ has joined #melange01:20
*** desophos has quit IRC01:22
*** r0bby_ is now known as robbyoconnor01:25
*** robbyoconnor has quit IRC01:40
* nathanielmanista heads out for supper01:42
*** piyushbansal has quit IRC01:46
*** saurabhsood91_ has quit IRC02:07
*** desophos has joined #melange03:10
*** roonyH has joined #melange03:10
roonyHhi03:14
roonyHI am working on issue 164703:14
roonyHI am looking for some help for the following03:15
roonyHI d like to get a link to the page where organization list is displayed just before adding a new task03:16
roonyHcurrently i am doing it in this way03:16
roonyHself.data.redirect.urlOf('gci_dashboard')+"#create_tasks"03:17
roonyHbut "#create_tasks" is hardcoded03:17
roonyHany suggestions how to do this?03:18
*** roonyH has quit IRC03:38
*** robbyoconnor has joined #melange03:48
*** roonyH has joined #melange04:04
*** yupbank has joined #melange04:58
*** roonyH has quit IRC05:08
*** desophos has quit IRC06:01
*** kkthecoder has joined #melange06:09
*** VirajSinha has joined #melange06:31
*** asmeurer__ has quit IRC06:43
*** desophos has joined #melange06:50
*** desophos has quit IRC07:12
*** asmeurer__ has joined #melange07:22
*** desophos has joined #melange07:26
*** kkthecoder has quit IRC07:30
*** bumbu_ has joined #melange07:38
*** desophos has quit IRC07:42
*** asmeurer__ has quit IRC07:47
*** iulians has joined #melange07:49
*** voxsim has joined #melange08:18
*** VirajSinha_ has joined #melange08:29
*** VirajSinha has quit IRC08:32
*** iulians has quit IRC08:55
*** MatthewWilkes is now known as mwilkes|away09:03
*** sanket has joined #melange09:11
*** mwilkes|away is now known as MatthewWilkes09:20
*** kkthecoder has joined #melange09:25
*** VirajSinha has joined #melange09:26
*** VirajSinha_ has quit IRC09:28
*** bumbu_ has quit IRC09:28
*** Darrel has joined #melange09:40
*** rihnapstor has joined #melange09:53
*** kkthecoder has quit IRC09:58
*** rihnapstor has quit IRC10:03
*** rihnapstor has joined #melange10:16
*** rihnapstor has quit IRC10:17
*** rihnapstor has joined #melange10:18
*** sanket has quit IRC10:19
*** piyushbansal has joined #melange10:20
*** VirajSinha has quit IRC10:26
*** sanket has joined #melange10:31
*** VirajSinha has joined #melange10:32
*** sanket has quit IRC10:47
*** sanket has joined #melange10:48
*** piyushbansal has quit IRC10:48
*** sanket has quit IRC11:02
*** rihnapstor has quit IRC11:07
*** bumbu has joined #melange11:15
*** bumbu has quit IRC11:16
*** bumbu has joined #melange11:16
*** rihnapstor has joined #melange11:21
*** bumbu1 has joined #melange11:42
*** bumbu has quit IRC12:03
*** rihnapstor has quit IRC12:03
*** MatthewWilkes is now known as mwilkes|away12:32
*** Darrel has quit IRC12:49
*** meria has joined #melange13:12
meriahello sir..13:12
meriathis is abhinav here13:12
meriai need to talk to you regarding the gsoc project13:13
*** banas has joined #melange13:13
meriacan i seek your attention for a moment?13:13
*** banas has left #melange13:13
*** bumbu1 has quit IRC13:14
*** bumbu has joined #melange13:15
meriai m interested in doing the project named "javascript tests"..please guide me about how to start it.13:16
bumbuhave you ever done js testing before?13:17
meriano.....but i read about it recently ....and it fascinated me13:20
meriaso can be done13:20
*** madrazr has quit IRC13:23
bumbuas you can see in project description the project already has set up Testem, Jasmine, PhantomJS. So your first step woulb be reading and trying these things13:24
bumbu*would13:25
meriasince i m a first year undergraduate student...and have an above average knowledge of javascript...13:26
meriaso i will have to start from the very basic of these platform13:27
meriaso what exactly do i need to do to get to that level so that i can accomplish the project?13:28
bumbuNext step would be set up these things by yourself in order to understand how do they work.13:29
bumbuAlso try to do some simple tests. You can search for examples in other big projects.13:29
bumbuThen try to write and run some tests on this project.13:29
meriaif i m not wrong, the project deals with the improvement of existing testing platforms or writing developing a new one?13:32
*** piyushbansal has joined #melange13:33
bumbuAs I now (but I know a little) testing environment is allready set, and your job is to write tests. Also you have to refactor existing javascript13:34
bumbuIf you don't know JS (JavaScript) well enough then you have some time to read more about it. Maybe some good practicies how it should be.13:34
voxsimhi meria, if you want example, watch my patches in mailing list13:37
voxsimabout tests bla bla13:37
meriaactually, i know js quite well but i dont know that my knowledge is sufficient for handling this project13:38
voxsimthey are using jasmine, labjs, jquery and other js libraries13:38
meriai m comfortable with jquery...but i need to see the other libraries13:40
meriacool...so my first step should be reading and trying the existing environments ..ryt13:40
*** mwilkes|away is now known as MatthewWilkes13:41
voxsimyes, try to request something in the mailing list, or try just to checkout melange, build and run tests (read getting started in wiki)13:42
*** kkthecoder has joined #melange13:43
*** roonyH has joined #melange13:48
meriathnx a lot13:51
*** Merio has joined #melange13:57
*** ChanServ sets mode: +o Merio13:57
piyushbansalHi Merio14:05
piyushbansalCan you please have a look at https://code.google.com/p/soc/source/browse/tests/app/soc/modules/gci/logic/test_profile.py?spec=svn1e2054422de9c747b0d4689ed18f1056998a9555&r=1e2054422de9c747b0d4689ed18f1056998a9555#12814:07
tpb<http://ln-s.net/-1B3> (at code.google.com)14:07
Meriohi piyushbansal14:07
piyushbansalI could not understand lennie's comment very clearly14:08
Lenniepiyushbansal, which one?14:08
piyushbansalAt line 128.14:08
piyushbansal"Weird thing is I would swear that student.scope should give you a GCIProgram."14:09
Lennieprogram = student.scope14:09
Lenniesee if test passes :)14:09
MerioI think that means that you can get the GCIProgram by accessing student.scope without having to create a new one14:09
MerioOh Lennie there you are :)14:09
piyushbansalhi Lennie :)14:09
LennieMerio, could you take a look at the JS test patches we got?14:09
piyushbansalLennie: could you please have a look at https://code.google.com/r/piyushdevel-melange/source/detail?r=7c6f55b6512571707a35dded629c71bc7563563c14:10
tpb<http://ln-s.net/-1B8> (at code.google.com)14:10
piyushbansalI mean, there I have written a comment( comment no 3)14:10
Lennieyeah you are passing in the student14:11
Lennienot a program14:11
Lennietry student.scope14:11
piyushbansaltask = gci_task_utils.GCITaskHelper(student.scope).createTask(14:11
piyushbansal    'Open', self.foo_org, foo_mentor, student)14:11
MerioLennie: I'm already in contact with him14:12
piyushbansalI am passing student.scope , in place of the program that I created earlier14:12
Lenniehmm14:12
Lennieok14:12
Lenniesigh test cases14:12
Lennie program = tests.program_utils.GCIProgramHelper().createProgram()14:12
Lennieand then on 12014:12
Lenniehave a 'scope' : program entry14:12
Lennie(essentially move 128 up to the top)14:13
*** VirajSinha has quit IRC14:13
piyushbansalAre you talking about the method def testHasCreatedOrModifiedTask(self):14:13
Lennieyes14:13
piyushbansalSo if in place of 128 I write program = student.scope14:14
piyushbansalWhat more changes do I have to do14:14
LennieWell you wouldn't need to write that anymore14:15
Lennietake the way it was in your patch, remove line 12814:15
Lennieand start the method with14:15
Lennieprogram = tests.program_utils.GCIProgramHelper().createProgram()14:15
Lenniestudent_properties = {'is_student': True , 'scope': program}14:15
piyushbansalOh, but would it save some computation ?14:16
piyushbansalI mean, I can not see why is doing this better approach than I have followed ?14:16
LennieBecause it would fail if I were to write a simple assertino where task.program == student.scope14:18
Lenniewhich is true during normal operations but not in these tests14:18
piyushbansalOh okay, got it14:18
Lennie( you are not the one to blame, the rest of the tests in this module are also wrong)14:18
LennieIn simple terms, it would create a task for program X with a student in program Y14:19
piyushbansalGood point, tests should work exactly as the real world scenario14:19
Lenniewhich doesn't make sense14:19
piyushbansalYeah, got it :D14:19
Lennie(Don't fix the other tests though)14:19
Lennienot in this patch at least14:19
piyushbansalOkay, I would just modify the the line where you have commented, and make a new commit14:19
LennieThe smaller the change the earlier it can be submitted :)14:19
piyushbansalThanks for pointing out, I have also changed the status as you pointed out that it cannot be Open once it is assigned14:20
piyushbansalI could not realise it myself :D14:20
Lennieyeah, nathanielmanista would this fall under "we need assertion on data consistency?"14:20
LennieIt's easy to miss14:20
Lennieand the code should have given you an error14:20
piyushbansalCode actually should have, I mean logically speaking.14:22
piyushbansalBut I did not get any error, so it was easy to overlook14:22
piyushbansalThough it is a mistake, I agree14:22
Lennieyes but not yours :)14:23
piyushbansalAlso would you please have a look once at https://code.google.com/r/piyushdevel-melange/source/detail?r=76d2914cba319d5ca401bb4abcc011d5b865386714:26
tpb<http://ln-s.net/-1BK> (at code.google.com)14:26
piyushbansalI have made all the changes and you and nathaniel suggested, point out any if some are still left.14:26
piyushbansalOops a typo in the commit message :|14:27
*** voxsim has quit IRC14:27
Lenniepiyushbansal, i'd say ping the thread that you are ready? I'm confident Nathaniel will see it14:27
piyushbansalLennie : Also tell me if I need to change the commit message in ^14:28
piyushbansalThread ?14:28
piyushbansalwhich one ?14:28
LennieI have to get back to work now though14:28
Lenniepiyushbansal, the comments on the revision14:29
piyushbansalOh, okay, nevermind, nathaniel would have a look14:29
Lenniehttps://code.google.com/r/piyushdevel-melange/source/detail?r=7c6f55b6512571707a35dded629c71bc7563563c14:29
tpb<http://ln-s.net/-1B8> (at code.google.com)14:29
Lenniepiyushbansal, you can rewrite that last commit if you'd like14:29
Lennieit hasn't been merged yet14:29
piyushbansalOkay, got it thanks a lot for your time14:29
Lenniehttp://stackoverflow.com/questions/179123/how-do-i-edit-an-incorrect-commit-message-in-git14:29
tpb<http://ln-s.net/-1BR> (at stackoverflow.com)14:29
piyushbansalOh, so I would change the commit message14:29
Lenniemight help14:29
piyushbansalGreat , never did that before :D14:30
piyushbansalThanks a lot, done !14:31
*** rihnapstor has joined #melange15:01
*** saurabhsood91 has joined #melange15:06
rihnapstorHi Merio :) voxsim always working on same project as am I.can I continue my work or focus on Javascript List Enhancement project ?15:09
rihnapstor*always = also15:10
*** bumbu has quit IRC15:10
*** VirajSinha has joined #melange15:24
rihnapstorMerio: you there ?15:48
*** sanket has joined #melange15:48
* rihnapstor brb15:58
*** rihnapstor has quit IRC15:59
*** tpb has quit IRC15:59
*** tpb has joined #melange15:59
*** VirajSinha_ has joined #melange16:05
*** VirajSinha has quit IRC16:08
*** roonyH has quit IRC16:22
*** sanket has quit IRC16:28
*** BlankVerse has joined #melange16:30
*** carols has joined #melange16:31
*** yupbank has quit IRC16:33
*** sanket has joined #melange16:34
*** tpb has joined #melange16:45
*** VirajSinha_ has quit IRC16:46
*** VirajSinha has joined #melange16:48
*** roonyH has quit IRC16:51
*** VirajSinha_ has joined #melange16:51
*** VirajSinha has quit IRC16:54
*** VirajSinha_ has quit IRC16:55
*** VirajSinha has joined #melange16:57
*** meria has quit IRC16:57

Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!