| *** tpb has joined #melange | 00:00 | |
| *** mithro has quit IRC | 00:05 | |
| *** mithro has joined #melange | 00:45 | |
| *** ChanServ sets mode: +v mithro | 00:45 | |
| *** tansell_laptop has quit IRC | 02:04 | |
| *** tansell_laptop has joined #melange | 02:04 | |
| *** dhans has joined #melange | 02:06 | |
| *** ChanServ sets mode: +v dhans | 02:06 | |
| *** madrazr has joined #melange | 02:48 | |
| *** ChanServ sets mode: +v madrazr | 02:48 | |
| *** madrazr has quit IRC | 03:11 | |
| *** tansell_laptop has quit IRC | 04:40 | |
| *** tansell_laptop has joined #melange | 04:45 | |
| *** madrazr has joined #melange | 04:53 | |
| *** ChanServ sets mode: +v madrazr | 04:53 | |
| *** dr__house has joined #melange | 04:59 | |
| *** tansell_laptop has quit IRC | 05:16 | |
| *** Merio has joined #melange | 05:18 | |
| *** ChanServ sets mode: +v Merio | 05:18 | |
| *** tansell_laptop has joined #melange | 05:18 | |
| Merio | dhans: ping | 05:40 |
|---|---|---|
| dhans | Merio: pong | 05:51 |
| dhans | Merio: sorry, I was eating | 05:51 |
| Merio | dhans: no problems :) | 05:51 |
| Merio | dhans: I've seen you made the virtual statistic stuff, great :) I just wanna ask if it's a problem of mine that the table doesn't update and the update_chart triggers twice or it happens to you too | 05:53 |
| dhans | Merio: you mean that when you change virtual statistic, the visualization does not change? | 05:53 |
| Merio | dhans: yes, even if I see the correct data is coming from the backend | 05:54 |
| dhans | Merio: when you change visualization then, you will see the correct data | 05:55 |
| dhans | Merio: but I do not know why it is like this... | 05:55 |
| Merio | dhans: hmm it does weird things to be fair :( | 05:55 |
| Merio | dhans: but there's no problem, I can have a look at it | 05:56 |
| dhans | Merio: I mean I tried to debug the script yesterday for a couple of hours, but do not know how to fix it | 05:56 |
| Merio | dhans: just a question, otherwise we're constantly changing stuff :P | 05:56 |
| Merio | dhans: no probs, I'll do it then :) | 05:56 |
| Merio | I see that | 05:56 |
| Merio | you've deleted the JSON stringify around the ID for the "update_chart" code | 05:57 |
| Merio | did you do it because something was not working? | 05:57 |
| dhans | Merio: because it did not know for me when it was stringified :-) | 05:57 |
| Merio | dhans: what do you mean? | 05:58 |
| dhans | Merio: it was also strange... it took me some time to find this. everything looked right... | 05:58 |
| dhans | Merio: in updateChart in statistic_chart logic | 05:59 |
| dhans | Merio: link_id looked right, but getForFields returned [] | 06:00 |
| dhans | Merio: when I deleted stringify, it started to work | 06:01 |
| dhans | Merio: about the bug that the new data is not displayed: | 06:02 |
| Merio | dhans: ok problem is that in this way IIRC it doesn't work the update chart :D | 06:02 |
| dhans | Merio: I was talking about updateChart | 06:02 |
| Merio | dhans: because you're waiting for string pairs and I'm waiting for a "proper" JSON object | 06:03 |
| Merio | dhans: sorry I mixed up | 06:03 |
| Merio | dhans: hmm I can see it doesn't save now the selected visualization, is it happening to you also? | 06:04 |
| Merio | dhans: (however the same thing applies, we're doing slightly different things when communicating with the server) | 06:04 |
| dhans | Merio: I see that visualizations are saved (Safari, Firefox) | 06:06 |
| Merio | dhans: I mean as soon as you create the widget, change the visualization and reload the dashboard => the selected visualization is not saved. If then you change the visualization again and try to change the visualization and reload the dashboard => the selected visualization now is saved | 06:07 |
| dhans | Merio: right ;-/ | 06:08 |
| Merio | "If then you change the visualization again and try to change the visualization"=> change the visualization once ... ehehhe.. I was distracted while writing :P | 06:08 |
| dhans | Merio: I'll try to fix it | 06:10 |
| Merio | dhans: well... do you need to work on melange.graph.chart.js now? | 06:10 |
| Merio | dhans: I would like to spend some time refactoring it | 06:10 |
| dhans | Merio: sure | 06:10 |
| Merio | dhans: because we have some code duplication there | 06:10 |
| dhans | Merio: about the bug that the new data is not displayed when you change the statistic: | 06:11 |
| Merio | dhans: ok just telling you because the merge could be eventually painful :D | 06:11 |
| Merio | dhans: yep tell me | 06:12 |
| dhans | Merio: you'll probably find it out quickly, but what I discovered is that when a visualization for a new statistic should be drawn, in _drawChartInside | 06:13 |
| dhans | Merio: just before return new melange.graph.chart[visualization_type](... statistic_data[current_statistic],....) | 06:13 |
| dhans | statistic_data[current_statistic] was up to date | 06:14 |
| *** MatthewWilkes has joined #melange | 06:14 | |
| dhans | Merio: then it moved to $m[visualization_name] = function (div_container, vis_data, chart_options, callback) {...}, but this._drawIntoContainer = function (container) was not executed | 06:15 |
| dhans | it was executed later, but then with the old data | 06:15 |
| dhans | Merio: and I had no idea how to fix it :-) | 06:15 |
| Merio | dhans: ok no problem, I'll spend some hours today on that | 06:16 |
| Merio | dhans: thanks for the tip however | 06:16 |
| dhans | Merio: great :-) | 06:16 |
| dhans | Merio: just to let you know: generally, when a widget is loaded/created, it does not load any dataTable at the beginning. it just loads virtual_statistics which is in a form of dictionary {virtual_statistic_name: [list_of_possible_visualizations]}. Then: if it is a new widget, it chooses the first virtual statistic to be the default one and downloads data for it. Otherwise (if the widget it loaded from the server), it sets current_statistic and | 06:21 |
| *** mithro has quit IRC | 06:21 | |
| *** MatthewWilkes has quit IRC | 06:26 | |
| *** MatthewWilkes has joined #melange | 06:26 | |
| Merio | dhans: and...? | 06:38 |
| dhans | Merio: and basically that's it :-) | 06:39 |
| Merio | dhans: ok :D | 06:39 |
| dhans | Merio: I just wanted to point out that when a widget is created no dataTables are downloaded, because now you can download dataTables for virtual statistics only | 06:40 |
| Merio | dhans: ok, gotcha | 06:40 |
| *** mithro has joined #melange | 06:49 | |
| *** ChanServ sets mode: +v mithro | 06:49 | |
| Merio | dhans: just FTR, refactoring is including also dashboard.js :) | 06:59 |
| dhans | Merio: ok :-) | 06:59 |
| Merio | dhans: 1) can you make the getjsonresponse return only properly available statistics? It shows also statistics that still are not collected (probably it's enough to just look at the finaljsonstring of the statistic?) | 07:05 |
| dhans | Merio: sure | 07:06 |
| Merio | dhans: thx :) | 07:06 |
| *** dr__house has quit IRC | 07:48 | |
| *** Merio1 has joined #melange | 08:14 | |
| *** Merio1 has quit IRC | 08:15 | |
| *** Merio has quit IRC | 08:31 | |
| *** arun__ has joined #melange | 09:18 | |
| *** arun__ is now known as arun | 09:20 | |
| *** madrazr has quit IRC | 10:26 | |
| *** dhans has quit IRC | 10:35 | |
| *** madrazr has joined #melange | 10:37 | |
| *** ChanServ sets mode: +v madrazr | 10:37 | |
| *** madrazr has quit IRC | 11:09 | |
| *** mithro has quit IRC | 11:10 | |
| *** Merio has joined #melange | 12:46 | |
| *** ChanServ sets mode: +v Merio | 12:46 | |
| *** MatthewWilkes has quit IRC | 13:13 | |
| *** dr__house has joined #melange | 13:21 | |
| *** dr__house has quit IRC | 13:32 | |
| *** dr__house has joined #melange | 13:34 | |
| *** dhaun has joined #melange | 13:47 | |
| *** dhans has joined #melange | 14:04 | |
| *** ChanServ sets mode: +v dhans | 14:04 | |
| *** dhans has quit IRC | 14:51 | |
| *** dhaun has quit IRC | 17:30 | |
| *** dr__house has quit IRC | 17:32 | |
| *** dhans has joined #melange | 18:47 | |
| *** ChanServ sets mode: +v dhans | 18:47 | |
| *** Merio has quit IRC | 20:00 | |
| *** mithro has joined #melange | 20:34 | |
| *** ChanServ sets mode: +v mithro | 20:34 | |
| *** dhans has left #melange | 20:35 | |
| *** tansell_laptop has quit IRC | 22:12 | |
| *** tansell_laptop has joined #melange | 23:55 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!