*** tpb has joined #melange | 00:00 | |
*** jamtoday has joined #melange | 04:33 | |
ajaksu | jamtoday: ping | 04:51 |
---|---|---|
*** dhans has joined #melange | 05:12 | |
*** ChanServ sets mode: +v dhans | 05:12 | |
*** MatthewWilkes has joined #melange | 05:37 | |
*** Lennie has joined #melange | 05:46 | |
*** ChanServ sets mode: +o Lennie | 05:46 | |
*** Lennie sets mode: +v jamtoday | 05:47 | |
Lennie | morning | 05:47 |
*** Lennie has left #melange | 05:47 | |
*** Lennie has joined #melange | 05:47 | |
*** ChanServ sets mode: +o Lennie | 05:47 | |
*** Lennie has left #melange | 05:47 | |
*** Lennie has joined #melange | 05:48 | |
*** ChanServ sets mode: +o Lennie | 05:48 | |
ajaksu | Lennie: good morning :) | 05:51 |
jamtoday | ajaksu and Lennie: ping | 05:53 |
jamtoday | it only took me an hour | 05:53 |
Lennie | yes? | 05:53 |
jamtoday | Lennie: it only took me an hour to respond to ajaksu | 05:53 |
Lennie | hehe large ping | 05:53 |
Lennie | wassup? | 05:53 |
ajaksu | jamtoday: pong :) | 05:53 |
ajaksu | jamtoday, k0p: I've fixed everything UI that annoyed me, except for the JS version of the widgets (should be done in 15 min), can you take a look at http://melange-ajaksu.appspot.com/survey/take/program/melange_team/surveys_demo/midterm_demo2 to see if there's anything amiss? :) | 05:56 |
tpb | <http://ln-s.net/3T9j> (at melange-ajaksu.appspot.com) | 05:56 |
ajaksu | http://melange-ajaksu.appspot.com/survey/edit/program/melange_team/surveys_demo/midterm_demo2 too :) | 05:56 |
Lennie | ajaksu: I can't apply your first JS patch | 05:56 |
Lennie | the file was renamed before you sent it in | 05:56 |
tpb | Title: Error (at melange-ajaksu.appspot.com) | 05:56 |
ajaksu | Lennie: oops, fixing it | 05:56 |
Lennie | ajaksu: nm | 05:57 |
Lennie | ajaksu: I hacked it :P | 05:57 |
jamtoday | ajaksu: looks good at every width I've tried, from 1024 up | 05:57 |
ajaksu | Lennie: thanks :) | 05:57 |
jamtoday | ajaksu: is it supposed to ask for both the question type and rendering type? | 05:58 |
ajaksu | jamtoday: the known weakness we have is that if a select is wider than #survey_widget, the color background gets visibly narrower than the form table | 05:59 |
jamtoday | ajaksu: yes, this should fix that problem | 06:00 |
jamtoday | ajaksu: I'd suggest that the required field be next to the question title, because before it was below, and now it's to the side of the question field | 06:01 |
jamtoday | but that's just a personal preference | 06:01 |
ajaksu | jamtoday: Python code still expects both, is there JS setting one when the other is selected? if so, I can get rid of one select in the template version, otherwise I'll add JS and keep both selects in sync | 06:01 |
ajaksu | jamtoday: in take or edit view? | 06:01 |
jamtoday | ajaksu: ummm a week or so ago I had made a fix that didn't require both | 06:01 |
jamtoday | ajaksu: i'm looking at the take view now | 06:02 |
jamtoday | ajaksu: in the take view, I'd also keep the margin-bottom on comment fields, so that its very clear which item it's paired with | 06:02 |
ajaksu | jamtoday: I just checked, ISTM I never touched margin-bottom for comments... maybe it was a side effect from a float or display:block? | 06:06 |
jamtoday | the commit I'm referring to is here -- http://bit.ly/mSVjJ and the code is still intact in getSchemaOptions (ln 383) in views/models/survey.py | 06:07 |
tpb | Title: Commit 9dbf85788e9d4738d285a414ed7b3d8b7c8442e5 to jamslevy's Melange - GitHub (at bit.ly) | 06:07 |
jamtoday | ajaksu: earlier today, your instance had these css changes I had made. Question names were bigger, some of the field sizes were smaller. This was from a patch I submitted a couple days ago | 06:08 |
jamtoday | so at some point in the last 24 hours it was jettisoned | 06:08 |
Lennie | james touched the margin bottom from comments | 06:08 |
Lennie | I commited that patch from him | 06:09 |
Lennie | that's all I know :P | 06:09 |
Lennie | It didn't had more changes | 06:09 |
jamtoday | ajaksu: sorry, it actually is there. my bad....but it's not working as intended..... | 06:10 |
jamtoday | it looks like the margin-bottom needs to be directly applied to the textarea now, which is great because that doesn't require any jQuery | 06:12 |
jamtoday | I'll submit a patch for this in 2mins | 06:12 |
ajaksu | jamtoday: here's most of my changes, the tooltip patch has a couple more: http://paste.pocoo.org/show/126864/ :) | 06:12 |
tpb | Title: Paste #126864 | LodgeIt! (at paste.pocoo.org) | 06:12 |
ajaksu | jamtoday, Lennie: what were all those floats and clears for? removing them gave me consistently good layout in 8 browsers in windows and linux... | 06:13 |
Lennie | Don't ask me, I'm just the messenger | 06:13 |
Lennie | ^_^ | 06:14 |
Lennie | this is interesting | 06:15 |
Lennie | if I create a new survey of the same type and I make the form fail so that the survey is not created I get to see survey records | 06:15 |
Lennie | from other surveys | 06:16 |
ajaksu | jamtoday: great, I missed the getSchemaOptions change, I'm removing the superfluous select from our template then :) | 06:16 |
jamtoday | IIRC that was the cause of some weird behavior when you selected the wrong combo | 06:17 |
ajaksu | Lennie: uhoh... I thought I had squashed that in createGet, but a validation error means you're going through... createPost? | 06:17 |
Lennie | yosh | 06:17 |
Lennie | hmm | 06:17 |
ajaksu | Lennie: a proper fix would be a bit better than the hack I tried :) | 06:17 |
k0p | ajaksu, I'll | 06:27 |
jamtoday | Lennie: odd. I'm not getting that. Is your view modified from the repository? | 06:32 |
Lennie | yes | 06:32 |
Lennie | Ajaksu's patch :) | 06:32 |
k0p | ajaksu, 1) and 2) is the same? | 06:35 |
ajaksu | k0p: 1) and 2) as in the links I pasted above or the demo and demo2 surveys? :) | 06:37 |
jamtoday | ajaksu: I'm going to update the survey wiki with import/export instructions. I'll also import your sample midterm to my instance to make sure it works. | 06:38 |
jamtoday | I may need a little help getting started | 06:39 |
*** mithro has quit IRC | 06:39 | |
k0p | ajaksu, first one | 06:39 |
k0p | http://melange-ajaksu.appspot.com/survey/take/program/melange_team/surveys_demo/midterm_demo2 | 06:39 |
tpb | <http://ln-s.net/3T9j> (at melange-ajaksu.appspot.com) | 06:39 |
k0p | brb | 06:40 |
ajaksu | jamtoday: repo is missing recent version of import view, did you get the patch I sent to the ML? | 06:41 |
ajaksu | k0p: the links are for the take and the edit pages, for the same survey but showing different parts of our UI (edit view will be restricted to admins on production server) | 06:42 |
jamtoday | I'm working off the head of the soc repo, but I can reapply it | 06:43 |
ajaksu | jamtoday: I can regenerate the patch if it'd help | 06:44 |
jamtoday | I was just thinking it would probably conflict....but I'm about to try | 06:44 |
jamtoday | "patch does not apply" :( | 06:45 |
jamtoday | and hg says "abort: local changes found, refresh first" | 06:47 |
ajaksu | jamtoday: kinda expected that :) | 06:47 |
jamtoday | I can cherry pick this in, dont worry about it | 06:47 |
ajaksu | jamtoday: what are you telling hg to do when it says that? | 06:49 |
jamtoday | I'm just going into the diff and manually applying it | 06:49 |
jamtoday | best way i know of :) | 06:49 |
jamtoday | and it gives me a chance to look at the code | 06:50 |
*** florinciu has joined #melange | 07:06 | |
Lennie | jamtoday: ping | 07:10 |
Lennie | your js to css patch | 07:11 |
Lennie | there was a margin-top in there as well | 07:11 |
Lennie | but now it is not in the CSS | 07:11 |
jamtoday | Lennie: the margin-top is unrelated, but I probably should have taken that out as well, since it won't have any effect | 07:16 |
Lennie | you took it out of JS | 07:16 |
Lennie | but you didn't put it in the CSS | 07:16 |
Lennie | what do you want :P? | 07:16 |
jamtoday | i didn't add it to the css? div #survey_widget textarea.comment{ | 07:17 |
Lennie | nope | 07:17 |
Lennie | diff says only margin-bottom | 07:17 |
jamtoday | oh yes, i see what you mean. the margin-top doesn't need to be there | 07:18 |
Lennie | ok | 07:18 |
Lennie | fine | 07:18 |
jamtoday | the negative margin top makes the comment go closer to the prev field, and the margin bottom pushes away the next one | 07:18 |
Lennie | then I leave it be :) | 07:18 |
jamtoday | as long as the margin-bottom of 30px is there, the pairing should be obvious | 07:18 |
jamtoday | .prev().css({'margin-top': '-10px'}) could be changed to .prev() in the JS, I thought at first that's what you meant | 07:19 |
Lennie | hehe nope | 07:19 |
Lennie | anyhow I pushed your patch | 07:19 |
jamtoday | Lennie: do you think I should be doing import/export now, or is there something more urgent? | 07:20 |
Lennie | jamtoday: import/export off? | 07:21 |
Lennie | of | 07:21 |
jamtoday | if you change the url_name to /json/ you export the survey as JSON, and /import_json/ is a page allowing JSON uploads | 07:21 |
Lennie | oh | 07:21 |
Lennie | don't worry abou tthat | 07:21 |
Lennie | csv export is working right? | 07:22 |
Lennie | for survey records | 07:22 |
jamtoday | Lennie: yes, it works | 07:22 |
Lennie | does it translate the user property to their public name? | 07:22 |
ajaksu | (except it's missing comments! k0p made me see it) | 07:22 |
Lennie | you might also want to add additional columns for projectsurvey | 07:23 |
ajaksu | Lennie: nope, but should be easy as I'm explicitly asking for user.link_id | 07:23 |
Lennie | in which some information about the project is added as well | 07:23 |
Lennie | like name and org | 07:23 |
Lennie | I think that would be a good thing to work on | 07:23 |
Lennie | Cat and Ellen would be very happy :) | 07:24 |
k0p | ajaksu, sorry but not time to see yet. :( | 07:25 |
Lennie | however | 07:26 |
Lennie | I'm sure there is work for newsfeeds as well | 07:27 |
ajaksu | k0p: you really have no reason to be sorry: you've helped me with UI, exports and access checks, thank you very much and don't worry a bit :) | 07:27 |
jamtoday | Lennie: so IIUC you mean denormalizing so that project properties are stored in project survey? | 07:27 |
Lennie | certainly on code style :D | 07:27 |
Lennie | jamtoday: no just that the export shows them | 07:27 |
Lennie | (shows them denormalized that is) | 07:27 |
jamtoday | Lennie: Okay, so subclass the export view | 07:27 |
Lennie | not all properties but the important ones | 07:27 |
Lennie | mentor name | 07:27 |
Lennie | student name | 07:27 |
Lennie | org name | 07:27 |
Lennie | project name | 07:27 |
jamtoday | Sure, I can do this. Then I will get a little bit of sleep. Rinse and repat | 07:28 |
jamtoday | *repeat | 07:28 |
Lennie | yeah sure | 07:28 |
Lennie | no hurry | 07:28 |
jamtoday | *rebase | 07:28 |
Lennie | this is something that can be added afterwards :) | 07:28 |
Lennie | sleep is good | 07:28 |
Lennie | I had too much today :P | 07:28 |
Lennie | I really should go and have brunch now | 07:29 |
Lennie | bbialb | 07:29 |
*** dhans_ has joined #melange | 08:15 | |
*** dhans has quit IRC | 08:15 | |
*** dhans_ has left #melange | 08:16 | |
*** dhans_ has joined #melange | 08:16 | |
*** dhans_ has left #melange | 08:16 | |
*** dhans has joined #melange | 08:18 | |
*** ChanServ sets mode: +v dhans | 08:18 | |
*** MatthewWilkes is now known as mwilkes|lunch | 08:23 | |
Lennie | back :) | 08:46 |
k0p | ajaksu, are you there? | 09:05 |
Lennie | hi k0p, wassup :)? | 09:06 |
Lennie | ajaksu is probably very busy with the latest fixes ^^ | 09:07 |
k0p | Lennie, fine | 09:07 |
k0p | but the last questions | 09:07 |
ajaksu | k0p: yep, but running for a release... do you have more feedback? :) | 09:07 |
k0p | in the link refered by him doesn't have questions. | 09:07 |
k0p | Well you decrease the number of rows in comments probably you decrease too much :). Columns is fine. | 09:08 |
k0p | But no more remarks :) | 09:09 |
*** mwilkes|lunch is now known as MatthewWilkes | 09:26 | |
*** madrazr has joined #melange | 10:20 | |
*** ChanServ sets mode: +v madrazr | 10:20 | |
*** gangil has joined #melange | 10:49 | |
*** gangil has left #melange | 10:50 | |
*** dhans has quit IRC | 10:56 | |
*** dhans has joined #melange | 11:25 | |
*** ChanServ sets mode: +v dhans | 11:25 | |
*** dr__house has joined #melange | 12:43 | |
*** SRabbelier has joined #melange | 13:34 | |
*** ChanServ sets mode: +o SRabbelier | 13:34 | |
*** MatthewWilkes has quit IRC | 13:43 | |
*** MatthewWilkes has joined #melange | 13:44 | |
*** MatthewWilkes has quit IRC | 13:45 | |
*** florinciu has quit IRC | 13:58 | |
*** florinciu has joined #melange | 14:45 | |
*** lh has joined #melange | 14:52 | |
*** ChanServ sets mode: +o lh | 14:52 | |
*** dhaun has joined #melange | 15:06 | |
* lh ^5s ajaksu and jamtoday | 15:09 | |
*** dhans has quit IRC | 15:12 | |
*** solydzajs has joined #melange | 15:23 | |
*** ChanServ sets mode: +o solydzajs | 15:23 | |
*** k0p has quit IRC | 15:24 | |
*** borja has joined #melange | 15:29 | |
* borja waves | 15:29 | |
borja | quick q: will there be a way for admins to check what students/mentors have submitted their evaluations? I seem to remember this was possible last year, but can't find anything equivalent in Melange. | 15:30 |
Lennie | nope not now sorry :( | 15:32 |
Lennie | However we might send a mail nearing the end of the week to people who haven't done it | 15:32 |
Lennie | might be nice to drop a copy to org admins | 15:32 |
Lennie | borja: http://code.google.com/p/soc/issues might be nice to keep it on the radar | 15:33 |
tpb | Title: Issues - soc - Google Code (at code.google.com) | 15:33 |
Lennie | (the system itself is quite new so we didn't have time to do it all :() | 15:33 |
solydzajs | Lennie: we might add some new functionality at the end of the week, I will try to find some more time to work on it | 15:33 |
borja | Lennie: No worries :-) If you do send out e-mails a few days before the deadline, sending a copy to the admin would be enough for me. | 15:34 |
solydzajs | Lennie: Org admins cannot take a survey on behalf of their mentors right now right ? | 15:34 |
Lennie | as said might do something like that at the end of the week L:) | 15:34 |
Lennie | nope solydzajs the mentor is responsible for it | 15:34 |
Lennie | if the org admin wants to replace him with another mentor he can | 15:34 |
solydzajs | Lennie: true | 15:35 |
solydzajs | ok bbilb | 15:35 |
Lennie | solydzajs: LH was fine with this so :) | 15:35 |
solydzajs | Lennie: ok :-) | 15:38 |
borja | Lennie: http://code.google.com/p/soc/issues/detail?id=651 | 15:39 |
tpb | <http://ln-s.net/3ThW> (at code.google.com) | 15:39 |
Lennie | thanks! | 15:39 |
borja | Lennie: However, I realize there isn't time to do everything this year. The e-mail-based solution sounds perfectly reasonable, as long as it results in the admin being made aware of what mentors/students haven't filled out their surveys. | 15:41 |
Lennie | yes | 15:41 |
Lennie | I'll see what can get done | 15:41 |
borja | cool | 15:41 |
*** solydzajs has quit IRC | 15:51 | |
jamtoday | Lennie: The midterm looks good. I'll be submitting the csv patch soon. Fell asleep on the job. | 15:52 |
Lennie | ty | 15:53 |
Lennie | access should be set to checkIsSurveyReadable ;) | 15:53 |
jamtoday | Lennie: Also, we could support additional_mentors very easily, re: solydzajs request for org_admins to take the midterm | 15:53 |
Lennie | mwah | 15:53 |
Lennie | additional mentors perhaps | 15:54 |
Lennie | but | 15:54 |
Lennie | org admins is harder | 15:54 |
Lennie | breaks the meaning of the taking access :) | 15:54 |
Lennie | anyhow | 15:54 |
Lennie | things seem to work | 15:54 |
Lennie | I'lm off | 15:54 |
jamtoday | yes, you've done great work. | 15:54 |
Lennie | gonna post agenda for tomorrow's meeting perhaps before I go to bed else tomorrow morning | 15:55 |
Lennie | and fix a plan for the record group | 15:55 |
Lennie | thanks for your work jamtoday ajaksu :) | 15:55 |
Lennie | bye | 15:55 |
*** Lennie has quit IRC | 15:55 | |
*** dhans has joined #melange | 16:14 | |
*** ChanServ sets mode: +v dhans | 16:14 | |
*** k0p has joined #melange | 16:27 | |
*** madrazr1 has joined #melange | 16:34 | |
*** madrazr has quit IRC | 16:35 | |
*** dr__house has quit IRC | 16:37 | |
*** dr__house has joined #melange | 16:37 | |
*** madrazr1 is now known as madrazr | 16:40 | |
*** ChanServ sets mode: +v madrazr | 16:40 | |
*** borja has left #melange | 16:52 | |
*** dr__house has quit IRC | 17:17 | |
*** dhaun has quit IRC | 17:26 | |
*** ThomasWaldmann has joined #melange | 17:54 | |
ThomasWaldmann | moin :) | 17:54 |
ThomasWaldmann | The last option for question 14 of the midterm eval (done by mentor) is strange. | 17:55 |
ThomasWaldmann | likely should read "... with my student" | 17:56 |
ThomasWaldmann | http://socghop.appspot.com/grading_project_survey/document/show/program/google/gsoc2009/faqs#evaluations | 17:57 |
ThomasWaldmann | 404 | 17:57 |
ThomasWaldmann | linked from " Google Summer of Code 2009 Mentor Midterm Evaluation Form ", 2nd paragraph | 17:58 |
ThomasWaldmann | other link in 1st paragraph is also 404 | 17:58 |
*** florinciu has quit IRC | 18:08 | |
k0p | ajaksu, there? | 18:33 |
*** madrazr has quit IRC | 18:42 | |
*** Merio has joined #melange | 19:16 | |
*** Merio has left #melange | 19:25 | |
*** lh has quit IRC | 19:41 | |
*** lh has joined #melange | 19:42 | |
*** tansell_laptop has joined #melange | 20:21 | |
jamtoday | ThomasWaldmann: We're working on getting the broken link fixed. Thanks for bringing it to our attention | 20:27 |
*** SRabbelier1 has joined #melange | 20:30 | |
*** SRabbelier has quit IRC | 20:32 | |
*** SRabbelier1 is now known as srabbelier | 20:32 | |
*** ChanServ sets mode: +o srabbelier | 20:32 | |
*** SRabbelie1 has joined #melange | 20:33 | |
*** tansell--laptop has joined #melange | 20:34 | |
*** tansell_laptop has quit IRC | 20:52 | |
*** mithro has joined #melange | 21:40 | |
*** ChanServ sets mode: +v mithro | 21:40 | |
*** dhans has left #melange | 21:40 | |
*** tansell--laptop has quit IRC | 21:44 | |
*** tansell-laptop has joined #melange | 23:11 | |
*** lh has quit IRC | 23:34 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!