*** tpb has joined #melange | 00:00 | |
*** dmitrig01|afk has joined #melange | 00:03 | |
*** ChanServ sets mode: +v dmitrig01|afk | 00:03 | |
*** dmitrig01|afk is now known as dmitrig01 | 00:04 | |
*** mithro has joined #melange | 00:06 | |
*** ChanServ sets mode: +v mithro | 00:06 | |
*** madrazr has joined #melange | 01:28 | |
*** penyaskito has quit IRC | 02:38 | |
*** SRabbelier has joined #melange | 02:40 | |
*** ChanServ sets mode: +v SRabbelier | 02:40 | |
*** dmitrig01 has quit IRC | 02:41 | |
*** mithro has quit IRC | 03:31 | |
*** solydzajs has joined #melange | 03:35 | |
*** ChanServ sets mode: +o solydzajs | 03:35 | |
*** mithro has joined #melange | 03:45 | |
*** ChanServ sets mode: +v mithro | 03:45 | |
*** mithro has quit IRC | 05:27 | |
*** madrazr has left #melange | 05:37 | |
*** mithro has joined #melange | 05:39 | |
*** ChanServ sets mode: +v mithro | 05:39 | |
*** mithro has quit IRC | 06:37 | |
*** solydzajs has quit IRC | 06:49 | |
*** mithro has joined #melange | 06:50 | |
*** ChanServ sets mode: +v mithro | 06:50 | |
*** solydzajs has joined #melange | 06:51 | |
*** ChanServ sets mode: +o solydzajs | 06:51 | |
*** madrazr has joined #melange | 08:03 | |
*** Merio has joined #melange | 10:11 | |
*** dmitrig01|afk has joined #melange | 11:19 | |
*** ChanServ sets mode: +v dmitrig01|afk | 11:20 | |
*** Lennie has joined #melange | 11:42 | |
*** ChanServ sets mode: +v Lennie | 11:42 | |
*** Lennie is now known as Lennie|Gone | 11:50 | |
*** Merio has quit IRC | 12:08 | |
*** Merio has joined #melange | 12:08 | |
*** lyaunzbe has quit IRC | 12:28 | |
*** lyaunzbe has joined #melange | 12:33 | |
solydzajs | Merio: ping | 12:58 |
---|---|---|
Merio | solydzajs: pong | 13:12 |
solydzajs | Merio: hi :-) just wanted to check with you if there was any progress | 13:12 |
Merio | solydzajs: yes, hope great progresses ;) Just testing during if all behaves correctly if errors happen. Then I need someone to test it in IE ;) | 13:13 |
solydzajs | Merio: ok great, let me know when it's ready | 13:14 |
Merio | solydzajs: ok :) | 13:15 |
Merio | solydzajs: I think it's kinda complete. | 13:23 |
solydzajs | kinda ?;-) | 13:23 |
solydzajs | is there something missing ?;-) | 13:24 |
Merio | Well, it depends on Redmond ;) | 13:26 |
solydzajs | hehe :-) | 13:27 |
solydzajs | send the patch whenever you're ready and I will have a look | 13:27 |
Merio | ok, I'll let you know when I'll send it to the list (matter of minutes) | 13:28 |
solydzajs | ok | 13:29 |
solydzajs | thx | 13:29 |
Merio | solydzajs: patch sent | 13:58 |
*** Lennie|Gone is now known as Lennie | 13:59 | |
Lennie | Merio cool | 13:59 |
solydzajs | Merio: ok awesome | 13:59 |
Lennie | will take a look aswell :) | 13:59 |
solydzajs | ok great :-) | 13:59 |
Merio | Lennie: great .. hope IE7 will love me a bit even if I don't love it so much ;) | 13:59 |
Lennie | hehe | 14:00 |
Lennie | we'll see :D | 14:00 |
Merio | Actually I was doing something stupid inside the code, so I wonder why my Firefox was happy, perhaps is because it loves me more than any other Firefox installation :D | 14:01 |
*** dmitrig01|afk is now known as dmitrig01 | 14:02 | |
Lennie | stuff happens | 14:02 |
Lennie | ^_^ | 14:02 |
Merio | ^__^ | 14:03 |
Merio | I shouldn't reformat my hard disk anymore, I could kill a living Firefox installation with its own feelings :P | 14:04 |
*** penyaskito has joined #melange | 14:13 | |
*** madrazr has left #melange | 14:15 | |
Lennie | ooo | 14:25 |
Lennie | Merio | 14:25 |
Lennie | it works :P | 14:25 |
Lennie | Merio, one problem though. When I hit the accept for the second time because I put all the orgs back to pre-accepted in another window it shows the bar going backwards at first | 14:30 |
Lennie | after which it goes forward exactly at 50% | 14:31 |
Merio | Lennie: sorry I was away, reading backlog | 15:03 |
Lennie | k | 15:03 |
solydzajs | Merio: well probably there is no reseting of the progress value at the end of the function, it should be set to 0 | 15:04 |
solydzajs | Merio: can you confirm ? | 15:04 |
Merio | solydzajs: yes, I'm looking at the code to tell you where to reset the value | 15:05 |
Merio | Lennie: so, the line to reset the progress bar is $("#applications_progress_bar").progressBar(0); | 15:06 |
Lennie | k | 15:06 |
Lennie | where should I put it? | 15:06 |
Merio | Try to add it before line 82 | 15:06 |
Merio | (should be: $("#button_accept").fadeIn("slow"); | 15:06 |
Merio | so before that command | 15:06 |
Lennie | k | 15:07 |
Lennie | testing :) | 15:07 |
solydzajs | Merio: can we set progress bar to 100 without animation ? | 15:07 |
Merio | Perhaps it should be inserted before line 14 too $("#button_accept").val("Bulk accept"); | 15:07 |
Lennie | before line 82 works | 15:08 |
Lennie | but on 14 might be better | 15:08 |
Merio | Lennie: great :) | 15:08 |
Lennie | since you want to reset it beforehand | 15:09 |
Lennie | not afterwards :D | 15:09 |
Merio | Lennie: perhaps it's better both, so it resets even when eventual errors occur | 15:09 |
Merio | solyzdajs: you mean every time the progress bar updates? | 15:09 |
solydzajs | Merio: nope I mean for example you hit the button, but there is no orgs to accept, so you should set progress bar to 100 without animation and show Done! | 15:10 |
Merio | solydzajs: let me see a bit how the source code works | 15:11 |
Lennie | solydzajs: The bar automatically returns to a button when it is done | 15:11 |
Lennie | but it doesnt show Done thats true | 15:12 |
Merio | Lennie, solydzajs: if there are no orgs I just do nothing ATM | 15:15 |
Merio | I think in that case we should just display an info message to say "no orgs to accept" or something like that | 15:15 |
solydzajs | yep good idea | 15:16 |
solydzajs | let's display that | 15:16 |
solydzajs | :-) | 15:16 |
Lennie | shouldnt be too hard | 15:16 |
Lennie | you already have a if statement that checks if there even is an org to accept :D | 15:16 |
solydzajs | "No organizations to accept" | 15:16 |
Merio | Lennie: yes, it's at line 15 | 15:17 |
Merio | Just put | 15:17 |
Merio | else { | 15:17 |
Merio | $("#description_done").html("No organization to accept"); | 15:17 |
Merio | } | 15:17 |
Merio | after that if should do | 15:18 |
Lennie | do we want to show that <strong> too? | 15:18 |
Merio | Think so, I don't know if there's a class for infos | 15:18 |
Lennie | hmm | 15:19 |
Merio | Probably the same as "document saved" or "program saved" (the orange rounded box)? | 15:19 |
Lennie | hmm | 15:19 |
Lennie | btw Merio | 15:19 |
Lennie | next time try to not capitalize the first letter in your comments :) | 15:19 |
Merio | Lennie: if it's an established code style... well... will do, ok :) | 15:21 |
Lennie | yeah it's what we do in python for this project : | 15:21 |
Lennie | so it might as well apply to JS :P | 15:21 |
Merio | Lennie: ok... actually I see I mix the two options inside the JS code :P | 15:21 |
solydzajs | once Lennie commits your patch with fixes, I will let you know Merio what else can be done. | 15:22 |
Merio | eheh :) | 15:22 |
Lennie | yeah that's because I fixed it before :P | 15:22 |
Merio | solydzajs: ok :) | 15:24 |
Merio | I like the way the scripts are externalised from the templates and called selectively in the base.html now... it's cleaner | 15:24 |
Merio | Don't know who did it, but I like it, just wanna say :) | 15:25 |
Merio | Lennie: is IE7 happy too? | 15:25 |
Lennie | yosh | 15:25 |
Lennie | still have caching problems | 15:26 |
Lennie | but that's redmond :p | 15:26 |
Merio | sic | 15:26 |
Merio | In which case you have those caching issues? | 15:26 |
Lennie | just always :P | 15:26 |
Lennie | it just caches the JSON object | 15:26 |
Lennie | because it can :P | 15:26 |
Lennie | It caches the page that supplies it | 15:26 |
Merio | So for example if there's an error it recovers badly trying to accept all the orgs (even those who were accepted before)? | 15:27 |
Lennie | :) | 15:29 |
Lennie | yosh | 15:29 |
Lennie | or I can keep accepting them over and over again :p | 15:29 |
Lennie | but it wont do any harm | 15:29 |
Lennie | since the backend will only send them one message | 15:29 |
*** lyaunzbe has quit IRC | 15:29 | |
Lennie | that reminds me that the email still needs to be written :p | 15:29 |
Merio | Lennie: just for fun, try to change line 8 ==> $.getJSON(bulk_accept_link, | 15:30 |
Lennie | to? | 15:31 |
Merio | to ==> $.getJSON(bulk_accept_link+"&_="+(new Date().getTime()), | 15:31 |
Lennie | it's line 7 here btw :P | 15:31 |
Merio | eheh sorry you're right :) | 15:31 |
Merio | Don't know if it should be "?" or "&" (can't remember the link) | 15:32 |
Merio | But it should simulate different pages called from time to time (should at least :)) | 15:32 |
solydzajs | the date cannot be given in accept url link | 15:32 |
Merio | And as long as the "_" variable is meaningless to the page serving the JSON object it wouldn't hurt | 15:32 |
Lennie | wont work :( | 15:33 |
Lennie | stupid IE7 :p | 15:33 |
solydzajs | it should be done in python | 15:33 |
Merio | solydzajs: sorry, I can't understand | 15:34 |
solydzajs | ah ok I got it | 15:34 |
solydzajs | :-) | 15:34 |
solydzajs | nevermind | 15:34 |
solydzajs | you guys tried to fix caching | 15:34 |
solydzajs | but IE7 is IE7 ;-) | 15:35 |
Merio | solydzajs: :) | 15:35 |
Merio | Lennie: it doesn't work? | 15:35 |
Lennie | nope | 15:35 |
Lennie | it doesn call new URL's | 15:35 |
Lennie | as seen in devserver log | 15:35 |
Merio | hmm | 15:35 |
Lennie | but no new response is registered by IE7 | 15:35 |
Merio | When you click the button again it doesn't request a new page? | 15:36 |
Lennie | it does | 15:36 |
Merio | With a different "_" parameter I mean | 15:36 |
Lennie | but IE7 doesnt euse it :p | 15:36 |
Merio | Fantastic | 15:37 |
Lennie | :D | 15:37 |
Lennie | Redmond ftw :P? | 15:37 |
Merio | eheheh | 15:37 |
Merio | Lennie: have you tried the "?" too? | 15:39 |
Lennie | http://code.google.com/p/soc/source/detail?r=1990 | 15:39 |
tpb | <http://ln-s.net/2rpV> (at code.google.com) | 15:39 |
solydzajs | Lennie: checking and testing now | 15:39 |
Lennie | oh crap | 15:41 |
Lennie | I failed | 15:41 |
Lennie | Merio, ? works ^_^ | 15:42 |
Lennie | solydzajs want me to use it :P? | 15:42 |
Merio | Lennie: try to have a look at this (even if it's for php) http://www.tildemark.com/browsers/ie7-always-keep-a-cache-of-the-visited-pages.html | 15:42 |
tpb | <http://ln-s.net/2rpb> (at www.tildemark.com) | 15:42 |
Lennie | funny thing is it also adds it to the other calls :S | 15:42 |
Lennie | ./org_app/review/google/gsoc2009/org_7?status=accepted&_=1234816804875 | 15:43 |
Merio | Lennie: the other calls are done that way because jquery's ajax does | 15:43 |
solydzajs | Merio: we already set no-cache, no-store, pre-check and post-check | 15:43 |
solydzajs | and pragma too | 15:43 |
solydzajs | I will add Expires to -1 | 15:43 |
Lennie | K | 15:43 |
Lennie | the ?_=time hax works :p | 15:43 |
Merio | Lennie: using cache:false on line 54 | 15:43 |
Lennie | yeah it sucks | 15:44 |
Merio | solydzajs: nevermind, seems to work with ? | 15:44 |
Lennie | doesnt listen :p | 15:44 |
Merio | Lennie: that's good :) | 15:44 |
Lennie | ? is kinda hacky | 15:44 |
Lennie | hopefully the other method will work | 15:44 |
solydzajs | I will add expires -1 and maybe that will help | 15:44 |
Merio | Lennie: is quite common hack in ajax development AFAIK | 15:44 |
Lennie | lol really :D | 15:45 |
Lennie | Merio, I have so much to learn :P | 15:45 |
Merio | Lennie: everyone has :) | 15:47 |
solydzajs | ok testing now | 15:48 |
solydzajs | I get " Error encountered, try again" all the time | 15:49 |
solydzajs | any ideas ? | 15:50 |
*** MatthewWilkes has joined #melange | 15:50 | |
Merio | solydzajs: it happens when the ajax call is not successful | 15:51 |
Merio | solydzajs: is the server ... uhm... serving the pages even if the error is printed? | 15:51 |
solydzajs | server works fine | 15:51 |
Merio | solydzajs: can you see the progressbar? | 15:52 |
solydzajs | $.getJSON("{{ bulk_accept_link|safe }}", | 15:52 |
solydzajs | is now | 15:52 |
solydzajs | $.getJSON(bulk_accept_link, | 15:52 |
solydzajs | why ? | 15:53 |
solydzajs | Lennie: ping | 15:53 |
Merio | solydzajs: because the JS is now out of the main page | 15:53 |
solydzajs | ah true | 15:53 |
solydzajs | ok anyway | 15:53 |
solydzajs | it doesn't work for me | 15:53 |
Merio | solydzajs: so it's out of the python scope, the bulk_accept_link|safe it's in the review.html and passed as a parameter to the orgInit function | 15:54 |
solydzajs | I see the progress bar | 15:54 |
Lennie | it doesnt? | 15:54 |
solydzajs | and get error all the time | 15:54 |
Merio | solydzajs: you see also the retry button? | 15:54 |
Lennie | works here :S | 15:55 |
solydzajs | I get 404 on org_app/bulk_accept/google/gsoc2009 | 15:55 |
Merio | which is the page form which you're making the requests, is it right? | 15:57 |
Merio | solydzajs: ^^^ | 15:57 |
solydzajs | ok it's not 404 | 15:57 |
solydzajs | hmmm | 15:57 |
Lennie | you get a404? | 15:57 |
solydzajs | ok when I go to http://localhost:8080/org_app/bulk_accept/google/gsoc2009 | 15:57 |
solydzajs | I get JSON | 15:57 |
solydzajs | so life is good | 15:57 |
Lennie | k | 15:57 |
solydzajs | but I still get an error | 15:57 |
Lennie | hmm | 15:57 |
Lennie | strange :S | 15:57 |
Merio | Seems strange to me too, the error is shown when error happens during the continuous ajax requests | 15:59 |
Merio | You can try to change line 70 (I think) ==> $("#description_done").html("<strong class='error'> Error encountered, try again</strong>"); | 15:59 |
Lennie | MatthewWilkes, sorry I didnt had time to really go through your patch :p | 15:59 |
MatthewWilkes | Lennie: :) | 16:00 |
Merio | solydzajs: with this ==> $("#description_done").html("<strong class='error'> Error encountered, try again</strong>textStatus: "+textStatus+" error: "+errorThrown); | 16:00 |
Lennie | the email was still in my inbox though :D | 16:00 |
Merio | solydzajs: and see if there is something printed | 16:01 |
MatthewWilkes | Lennie: Yeah, I've got 13k unread ones in mine, I know how it is | 16:01 |
Lennie | actually I dont have that many unread ones | 16:01 |
Lennie | it's just marked as TODO :p | 16:01 |
MatthewWilkes | Ooooh, a tentative sign up for my sprint in August from the USA | 16:02 |
solydzajs | Merio: Error encountered, try againtextStatus: error error: undefined | 16:02 |
Merio | solydzajs: ahahah how useful :P | 16:03 |
Lennie | bbs | 16:03 |
*** Lennie is now known as Lennie|Gone | 16:03 | |
solydzajs | hmmm | 16:04 |
Merio | solydzajs: do you have firebug extension installed in your firefox browser? | 16:04 |
solydzajs | yep I have | 16:04 |
solydzajs | I will have a look in a sec | 16:04 |
Merio | solydzajs: great, it should show you the httprequests that are made | 16:05 |
solydzajs | http://localhost:8080/org_app/review/google/gsoc2009/wannabe_0?status=accepted&_=1234818142287 | 16:06 |
solydzajs | 500 INTERNAL SERVER ERROR | 16:07 |
solydzajs | 886ms | 16:07 |
solydzajs | something is broken :-) | 16:07 |
solydzajs | global name 'context' is not defined | 16:07 |
Merio | solydzajs: seems more than something is broken :P | 16:08 |
Lennie|Gone | wtf? | 16:08 |
Lennie|Gone | why do you have that strange link? | 16:08 |
Merio | Lennie|Gone: the link is fine to me | 16:09 |
Lennie|Gone | did you add that yourself | 16:09 |
Lennie|Gone | since I'm sure I didnt commit it :S | 16:09 |
Lennie|Gone | atleast I hope lol | 16:09 |
solydzajs | Add what ? | 16:09 |
Lennie|Gone | oh crap fail then :S? | 16:09 |
Merio | if wannabe_0 is a valid link_id... than I don't know why the server returns that | 16:09 |
solydzajs | Lennie|Gone: line 247in group_app.py | 16:10 |
solydzajs | error, request, template=params['error_public'], context=context) | 16:10 |
Lennie|Gone | I'll take a look at it in a few min | 16:10 |
solydzajs | global name 'context' is not defined | 16:10 |
Lennie|Gone | doing dishes | 16:10 |
Merio | ah ok... so context is for the python end | 16:10 |
Merio | I thought it was a JS error :) | 16:10 |
Merio | taken from firebug | 16:11 |
Merio | solydzajs, Lennie: However, remember that the &_=12348 etc is normal, and created automatically by JQuery to avoid caching, so don't mind that :) | 16:11 |
Merio | Lennie|Gone: ^^^^ ;) | 16:12 |
Lennie|Gone | hmm | 16:12 |
Lennie|Gone | it doesnt get added at my end :P | 16:12 |
Merio | Lennie|Gone: seems strange to me, it's added in my box too, for every single call for acceptance | 16:13 |
Lennie|Gone | IE7 ftl :p? | 16:13 |
Merio | Lennie|Gone: probably! :P however it's not a problem, since every request it's different by its own nature (link_id are all different)... so nevermind :) | 16:15 |
Merio | However... now watching a film, be back afterwards (perhaps checking sometime ;)) | 16:15 |
Lennie|Gone | solydzajs I fixed that bug | 16:15 |
Lennie|Gone | but that still indicates that the application didn't exist :S | 16:15 |
Lennie|Gone | brb | 16:15 |
solydzajs | Lennie|Gone: "This Application can not be reviewed anymore (it has been completed or rejected). " | 16:16 |
*** Merio is now known as MerioAway | 16:18 | |
* SRabbelier wakes up | 16:20 | |
SRabbelier | O hi? | 16:20 |
solydzajs | hi | 16:20 |
SRabbelier | too much backlog | 16:20 |
SRabbelier | some one tell me what I missed please? | 16:20 |
solydzajs | basically I'm testing bulk accept now | 16:21 |
solydzajs | and I have an issue | 16:21 |
solydzajs | when I run reseed_db | 16:21 |
SRabbelier | ok | 16:21 |
solydzajs | I see all the wannabe org apps | 16:21 |
solydzajs | in | 16:21 |
solydzajs | Overview of Organization Applications which status is pre-accepted | 16:21 |
SRabbelier | solydzajs: what's wrong with that? | 16:22 |
solydzajs | but when I click on any of them | 16:22 |
solydzajs | I get | 16:22 |
solydzajs | This Application can not be reviewed anymore (it has been completed or rejected). | 16:22 |
SRabbelier | ok | 16:22 |
solydzajs | which also causes bulk accept not to work | 16:23 |
solydzajs | I found one error | 16:23 |
solydzajs | in group_app.py | 16:23 |
solydzajs | line 247 | 16:23 |
SRabbelier | solydzajs: ok, please have Lennie fix that since he knows more about that part :) | 16:23 |
solydzajs | I removed context from parameters there | 16:23 |
solydzajs | because it was not defined | 16:23 |
SRabbelier | solydzajs: yes, that's correct | 16:23 |
solydzajs | SRabbelier: 1983 | 16:26 |
solydzajs | revision | 16:26 |
solydzajs | you broke it :-) | 16:26 |
solydzajs | the context thingy | 16:26 |
SRabbelier | solydzajs: yeah | 16:26 |
SRabbelier | please commit the fix :) | 16:26 |
solydzajs | ok :-) | 16:26 |
solydzajs | will do | 16:26 |
solydzajs | but it's not all | 16:27 |
solydzajs | I still get this error :-) | 16:27 |
Lennie|Gone | yeah | 16:27 |
*** Lennie|Gone is now known as Lennie | 16:27 | |
Lennie | are you going to commit that ifx? | 16:27 |
solydzajs | yep one sec | 16:27 |
Lennie | k | 16:27 |
Lennie | it only happens when no application is found | 16:28 |
Lennie | so something strange is going on with your build :S | 16:28 |
solydzajs | Lennie: done | 16:28 |
Lennie | since that shouldnt happen :S | 16:28 |
solydzajs | Lennie: committed | 16:28 |
Lennie | still does not account for the errors you are having | 16:30 |
solydzajs | Lennie: I see all the org apps in the datastore | 16:31 |
solydzajs | with preaccepted state | 16:31 |
solydzajs | status | 16:31 |
solydzajs | and I get "This Application can not be reviewed anymore (it has been completed or rejected). " all the time | 16:31 |
Lennie | what does bulk link say? | 16:32 |
Lennie | The JSON object that is | 16:32 |
solydzajs | the JSON objects gives proper JSON with the list of all the org apps | 16:33 |
Lennie | k | 16:33 |
solydzajs | but I cannot view the org application | 16:33 |
solydzajs | all of them give me the same error when I click on any of them | 16:34 |
Lennie | :S | 16:34 |
solydzajs | Lennie: any ideas ? | 16:34 |
Lennie | put a diaf @ acces.py:827 | 16:35 |
Lennie | it shouldnt happen lol | 16:35 |
solydzajs | try to reseed_db | 16:36 |
solydzajs | it works for you ? | 16:36 |
Lennie | maybe the seeding somehow screws up something | 16:37 |
SRabbelier | Lennie, solydzajs: are you two running the same revision? | 16:37 |
Lennie | I'm running latest :p | 16:37 |
SRabbelier | Lennie: well, then try reseed_db... duh | 16:37 |
solydzajs | SRabbelier: yep me too, but I can double check | 16:37 |
Lennie | solydzajs, make a org_app manually | 16:38 |
Lennie | via the button on the webpage | 16:38 |
Lennie | and see if it works | 16:38 |
solydzajs | ok one sec | 16:40 |
solydzajs | SRabbelier: the org_app form doesn't show field under the field label but next it | 16:40 |
SRabbelier | solydzajs: huh? | 16:41 |
Lennie | because they use as row? | 16:41 |
solydzajs | They didn't use as row before right ? | 16:41 |
Lennie | or as table | 16:41 |
Lennie | or whatever :P | 16:41 |
Lennie | o yeah | 16:42 |
Lennie | hmm | 16:42 |
Lennie | that's wrong :D | 16:42 |
solydzajs | Lennie: it works fine with manual | 16:44 |
Lennie | blame your datatstore :) | 16:44 |
solydzajs | SRabbelier: your reseed_db is broken ? | 16:44 |
SRabbelier | solydzajs: it is? | 16:44 |
solydzajs | SRabbelier: did you try bulk accept ? | 16:45 |
SRabbelier | solydzajs: no man, I'm working on that stupid ToS of yours | 16:45 |
solydzajs | SRabbelier: what ToS of mine ? | 16:45 |
SRabbelier | solydzajs: the tos that doesn't show up at the bottom of the form :P | 16:45 |
SRabbelier | it's proving quite a PITA | 16:46 |
Lennie | group = Z. Agreement :P? | 16:46 |
solydzajs | SRabbelier: ok, also when no agreement is set for org admin/mentor the checkbox shows up anyway and it required | 16:46 |
SRabbelier | Lennie: we want sort orders | 16:46 |
solydzajs | s/it/is/ | 16:47 |
SRabbelier | solydzajs: then set one | 16:47 |
Lennie | it should just work the same way as the ToS does since not every program might have an agreement | 16:52 |
solydzajs | yes exactly | 16:52 |
SRabbelier | Lennie: we can do that later | 16:52 |
Lennie | hmm | 16:53 |
solydzajs | SRabbelier: have you left any TODO there ? | 16:53 |
Lennie | I'm off | 16:53 |
SRabbelier | solydzajs: no, because it isn't a TODO for me | 16:53 |
SRabbelier | solydzajs: if someone needs it they can submit a feature request | 16:53 |
solydzajs | eh | 16:53 |
SRabbelier | who's Daniel? | 16:53 |
SRabbelier | is he the guy we met at FOSDEM? | 16:53 |
Lennie | he should sign the CLA btw | 16:53 |
solydzajs | Daniel is some polish GSoC dude | 16:54 |
solydzajs | SRabbelier: nope , not from FOSDEM | 16:54 |
SRabbelier | oh, ok :) | 16:54 |
SRabbelier | solydzajs: wonder whatever happened to him | 16:54 |
solydzajs | SRabbelier: the one that wanted G1 ? | 16:54 |
SRabbelier | solydzajs: hehe, yes :P | 16:55 |
solydzajs | SRabbelier: I have him on skype but I didn't hear from him | 16:55 |
Lennie | ^_^ | 16:55 |
Lennie | anyhow | 16:55 |
SRabbelier | solydzajs: ok | 16:55 |
solydzajs | Lennie: I will let him know about CLA | 16:55 |
Lennie | I've told you before that the ToS shouldnt been shown | 16:55 |
* SRabbelier could care less | 16:55 | |
Lennie | and just because you dont want to do it doesnt mean you shouldnt leave a todo ;) | 16:55 |
SRabbelier | we have more important things to worry about | 16:55 |
solydzajs | I agree with Lennie here | 16:55 |
solydzajs | WE DON'T WRITE CRAPPY SOFTWARE! | 16:55 |
SRabbelier | I'm fine with you guys putting in a TODO :) | 16:55 |
SRabbelier | solydzajs: caps fail | 16:56 |
solydzajs | it was on purpose | 16:56 |
SRabbelier | solydzajs: still fail :P | 16:56 |
SRabbelier | solydzajs: it's not crappy software if it assumes there's a ToS though | 16:56 |
SRabbelier | solydzajs: it's a requirement of our employee ;) | 16:57 |
SRabbelier | although, the reason I didn't put in a TODO is because I didn't think of it | 16:57 |
SRabbelier | not because I decided against it | 16:57 |
solydzajs | but if the sitewide ToS doesn't show up when it's not set , other ToS should do the same | 16:57 |
SRabbelier | solydzajs: that's just overengineered imho :) | 16:57 |
solydzajs | overenginnering ? are you kidding me ? | 16:58 |
* SRabbelier sigh | 16:58 | |
SRabbelier | nvm :) | 16:58 |
solydzajs | right now when there is no ToS you still have the checkbox that you need to tick | 16:58 |
solydzajs | which means you agree to ToS that doesn | 16:59 |
SRabbelier | yes yes, you are right | 16:59 |
solydzajs | t | 16:59 |
solydzajs | exist | 16:59 |
solydzajs | which is stupid | 16:59 |
SRabbelier | let's spend our time on something useful | 16:59 |
SRabbelier | I've got some code to write | 16:59 |
* SRabbelier away | 16:59 | |
solydzajs | eh | 16:59 |
SRabbelier | even better | 17:01 |
SRabbelier | I'm going to bed early | 17:01 |
Lennie | nn | 17:02 |
solydzajs | Lennie: | 17:14 |
solydzajs | Lennie: it fails in def checkCanReviewGroupApp(self, django_args, group_app_logic): | 17:14 |
solydzajs | raise out_of_band.AccessViolation(message_fmt=DEF_REVIEW_COMPLETED_MSG) | 17:14 |
Lennie | yeah on the seeded stuff right? | 17:15 |
Lennie | but not on the ones you create yourself | 17:15 |
Lennie | which to me says it works | 17:15 |
Lennie | and the error is because of some inconsistency in your datastore :S | 17:15 |
Lennie | is the scope path set? | 17:17 |
Lennie | on the other entities | 17:17 |
Lennie | since the query doesnt retrieve an application | 17:17 |
solydzajs | {'link_id': u'wannabee_0', 'scope_path': u'google/gsoc2009', 'status': ['needs review', 'accepted', 'rejected', 'ignored', 'pre-accepted']} | 17:17 |
solydzajs | this is what we have in fields | 17:18 |
Lennie | yes and in your datatstore? | 17:18 |
solydzajs | google/gsoc2009 pre-accepted | 17:19 |
Lennie | ? | 17:19 |
Lennie | which fields did you copy lol :P | 17:20 |
solydzajs | scope_path then status | 17:20 |
solydzajs | and link_id is wannabe_0 | 17:20 |
Lennie | did you type that> | 17:20 |
Lennie | since it has two ee's :P | 17:20 |
solydzajs | oh nice finding | 17:21 |
solydzajs | :-) | 17:21 |
Lennie | k something failed :S | 17:21 |
Lennie | how did that get added with a wrong keyname then :P? | 17:21 |
solydzajs | I have no idea | 17:23 |
solydzajs | asking Sverre now | 17:23 |
Lennie | oh | 17:24 |
Lennie | haha | 17:24 |
Lennie | typo in seed | 17:24 |
Lennie | 194 | 17:24 |
solydzajs | yep | 17:24 |
Lennie | 195 | 17:24 |
Lennie | 196 | 17:24 |
Lennie | anyhow | 17:24 |
Lennie | see | 17:24 |
Lennie | It works :P | 17:24 |
Lennie | nothing wrong with bulk accept :D | 17:25 |
Lennie | so I'm off | 17:25 |
Lennie | cya tomorrow | 17:25 |
solydzajs | ;-) | 17:25 |
Lennie | with student ptach :) | 17:25 |
Lennie | later | 17:25 |
solydzajs | cya | 17:25 |
solydzajs | :-) | 17:25 |
*** Lennie has quit IRC | 17:25 | |
*** solydzajs has quit IRC | 17:27 | |
*** SRabbelier has quit IRC | 18:11 | |
*** MerioAway has quit IRC | 18:31 | |
*** mithro has quit IRC | 19:01 | |
*** dmitrig01 has quit IRC | 19:11 | |
*** dmitrig01|afk has joined #melange | 19:11 | |
*** ChanServ sets mode: +v dmitrig01|afk | 19:11 | |
*** dmitrig01|afk is now known as dmitrig01 | 19:30 | |
*** madrazr has joined #melange | 22:37 | |
*** madrazr has quit IRC | 23:02 | |
*** mithro has joined #melange | 23:07 | |
*** ChanServ sets mode: +v mithro | 23:07 | |
*** kr4sh has joined #melange | 23:49 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!