*** tpb has joined #freeorion | 00:00 | |
*** VargaD has quit IRC | 00:32 | |
*** lethu has quit IRC | 03:48 | |
*** lethu has joined #freeorion | 04:00 | |
*** lethu has joined #freeorion | 04:00 | |
*** STalKer-Y has quit IRC | 04:46 | |
*** STalKer-X has joined #freeorion | 04:46 | |
*** _Maru_ has quit IRC | 06:06 | |
*** gvdm has joined #freeorion | 06:21 | |
*** VargaD has joined #freeorion | 06:45 | |
*** _Maru_ has joined #freeorion | 06:58 | |
gvdm | when adding descriptions to effects the standard currently is to prefix the description key by the effects file it originates from, right? | 07:22 |
---|---|---|
gvdm | so, for a description of a species foci, SP_FARMING in eng_stringtables.txt? | 07:23 |
GeofftheMedio | descriptions for content usually have some related prefix before the stringtable entry | 07:34 |
GeofftheMedio | these aren't "effects" though | 07:34 |
gvdm | instead of Species: +15, i'd like Focused Farming: +15 | 07:36 |
gvdm | etc | 07:36 |
gvdm | its an effect in species.txt | 07:36 |
gvdm | well, as far as I understand | 07:36 |
GeofftheMedio | I don't know what you're asking about then | 07:36 |
GeofftheMedio | I thought you meant what to call the stringtable entries | 07:37 |
gvdm | EffectsGroup | 07:37 |
gvdm | scope = Source | 07:37 |
gvdm | activation = Planet environment = Good | 07:37 |
gvdm | effects = SetTargetFarming Value + Target.Population * 1 | 07:37 |
gvdm | right, so this is in species.txt | 07:37 |
gvdm | would I call it SP_FARMING? | 07:38 |
gvdm | if i added a description clause | 07:38 |
gvdm | would I call it SP_FARMING_DESC? | 07:38 |
GeofftheMedio | I still don't knwo what you're talking about | 07:38 |
GeofftheMedio | what are "calling" anything? | 07:38 |
gvdm | the string key | 07:38 |
GeofftheMedio | for what? | 07:38 |
gvdm | for a production/farming effect, species.txt lines ~10320 | 07:39 |
gvdm | well, for the humans | 07:39 |
gvdm | i'm first testing/implementing with humans, then i'll do the rest of the species | 07:40 |
GeofftheMedio | that's in the middle of a species definition... | 07:40 |
GeofftheMedio | where is there a stringtable entry reference? | 07:40 |
gvdm | when farming is focused, instead of just having the description of additions being "Species:" it'll be "Focused farming:" | 07:42 |
GeofftheMedio | there's no string for that | 07:42 |
gvdm | i'm making one | 07:42 |
gvdm | so i'm asking | 07:42 |
gvdm | what is the string key format? | 07:42 |
gvdm | SP_ (as its in the species file?) FARMING_ (what it describes?) DESC (as its a description?) | 07:43 |
gvdm | SP_FARMING_DESC? | 07:43 |
gvdm | whats the convention? | 07:43 |
gvdm | i'm trying to follow project conventions | 07:43 |
gvdm | or should I make my own up? | 07:44 |
GeofftheMedio | the prefixes are for names of things of various types, not what file they're in | 07:45 |
GeofftheMedio | eg. species names have strings starting with SP | 07:45 |
GeofftheMedio | colony ship parts have string names starting with CO | 07:45 |
GeofftheMedio | depending how you're setting things up, this might be an effects group name? | 07:46 |
gvdm | ok, so, for a more decriptive resource breakdown (which works well right now for tech additions and specials etc) which is due to species benefits, what kind of string key would I use? | 07:46 |
gvdm | let me test with just a single string, then I'll come back and ask what I should call the string key | 07:47 |
GeofftheMedio | are you effectively naming an effects group? | 07:47 |
gvdm | well, don't know if its an effects group, because its a different effects group depending on planet size, but yeah | 07:48 |
gvdm | so, the same string regardless of planet size, but for research and industry, yes, its one effects group | 07:48 |
GeofftheMedio | doesn't sound like this needs a prefix | 07:49 |
gvdm | ok | 07:52 |
gvdm | , thans | 07:52 |
gvdm | thanks | 07:52 |
gvdm | is there a particular place in eng_stringtable to put them? | 07:52 |
GeofftheMedio | no | 07:52 |
gvdm | ## Resources Panel ########## ? | 07:53 |
gvdm | looks like a good place | 07:53 |
gvdm | hmm, seems to be in a strictly UI area though | 07:54 |
GeofftheMedio | isn't your addition a UI thing? | 07:55 |
gvdm | well, yes | 07:56 |
gvdm | ok, its going there | 07:56 |
gvdm | this is going to have to be reviewed anyway | 07:56 |
*** gvdm has quit IRC | 07:59 | |
*** gvdm has joined #freeorion | 08:05 | |
gvdm | anyway to find out why a file is not being read? ie, error messages? | 08:06 |
gvdm | ok, yeah, putting a description on an effects group | 08:07 |
gvdm | doesn't work | 08:08 |
gvdm | apart from that, my changes are good | 08:08 |
gvdm | they just result in crappy text appear on focus hover, the resources breakdown descriptions | 08:08 |
gvdm | Species Human appears twice | 08:09 |
gvdm | as the effects are both applied in the species definition | 08:09 |
GeofftheMedio | what version are you running / modifying? | 08:13 |
gvdm | 4471 | 08:14 |
GeofftheMedio | update to the latest svn. the changes in part are intended to make scripting errors clearer. | 08:14 |
GeofftheMedio | it should give some indication of the problem on the command-line, though | 08:15 |
GeofftheMedio | even in 4471 | 08:15 |
GeofftheMedio | usually only localized to the top level thing in the file | 08:15 |
GeofftheMedio | eg. the offending species definition | 08:15 |
GeofftheMedio | but not the offending effectsgroup or condition | 08:16 |
gvdm | well, i figured out the issue, a description in an effectsgroup | 08:16 |
gvdm | how would we achieve configurable text there? | 08:18 |
gvdm | with the new parser changes is it slightly easier? | 08:19 |
GeofftheMedio | I don't think the new parser makes making changes any easier, but yes, a parser change would likely be needed | 08:20 |
gvdm | so effectsgroups can't have descriptions at the moment? | 08:34 |
GeofftheMedio | nope | 08:46 |
*** Farmer_ has joined #freeorion | 09:55 | |
*** gvdm has quit IRC | 10:51 | |
*** gvdm has joined #freeorion | 12:07 | |
*** StrangerDanger has quit IRC | 12:19 | |
gvdm | http://www.freeorion.org/forum/viewtopic.php?f=6&t=6210 | 13:31 |
tpb | <http://ln-s.net/9LmP> (at www.freeorion.org) | 13:31 |
gvdm | to play with test species? | 13:36 |
gvdm | you enable them in species.txt? | 13:36 |
gvdm | I want to test dansans ship shield patch | 13:38 |
gvdm | so i need a suitably weak enemy i can send a ship at, which will then live | 13:38 |
gvdm | also, uncommenting the "powerful testing fleet" (dragon tooth designs) creates an empty fleet which disappears after one turn | 13:58 |
gvdm | I needed to add it to starting_designs.txt | 14:01 |
gvdm | I needed to add it to starting_ship_designs.txt | 14:01 |
gvdm | dansan, patch doesn't work | 14:04 |
gvdm | or at least, the dragon tooth did not recover its shields | 14:04 |
gvdm | but the patch /looks/ fine | 14:04 |
gvdm | i tried in supply range | 14:04 |
gvdm | but only at a drydock did they recover shield, which is irrelevant to this i think | 14:05 |
gvdm | is a xentrium hull meant to recover shield? | 14:06 |
gvdm | oh, hah | 14:11 |
gvdm | its not for structure, just shield, my silly | 14:11 |
gvdm | well, after a battle the shields are up again | 14:15 |
gvdm | so... it works? | 14:15 |
gvdm | anybody awake? | 14:26 |
*** Farmer_ has quit IRC | 14:56 | |
*** gvdm has quit IRC | 19:15 | |
*** Xenux has joined #freeorion | 20:19 | |
*** Farmer_ has joined #freeorion | 20:23 | |
*** Xenux has quit IRC | 23:54 |
Generated by irclog2html.py 2.5 by Marius Gedminas - find it at mg.pov.lt!