| *** tpb has joined #melange | 00:00 | |
| *** mithro has joined #melange | 01:16 | |
| *** ChanServ sets mode: +v mithro | 01:16 | |
| *** dmitrig01|afk is now known as dmitrig01 | 01:25 | |
| *** madrazr has left #melange | 01:33 | |
| *** mithro has quit IRC | 01:39 | |
| *** mithro has joined #melange | 01:42 | |
| *** ChanServ sets mode: +v mithro | 01:42 | |
| *** dmitrig01 has quit IRC | 02:37 | |
| *** madrazr has joined #melange | 02:54 | |
| *** mithro has quit IRC | 03:25 | |
| *** mithro has joined #melange | 03:26 | |
| *** ChanServ sets mode: +v mithro | 03:26 | |
| *** MatthewWilkes has joined #melange | 04:30 | |
| *** madrazr1 has joined #melange | 04:40 | |
| *** madrazr has quit IRC | 04:41 | |
| *** madrazr1 has quit IRC | 05:05 | |
| *** SRabbelier has joined #melange | 05:24 | |
| *** ChanServ sets mode: +v SRabbelier | 05:24 | |
| *** bcarlyon|laptop has joined #melange | 06:31 | |
| *** bcarlyon|laptop is now known as BCarlyon|Laptop | 06:35 | |
| *** mithro has quit IRC | 06:52 | |
| *** MatthewWilkes has quit IRC | 08:14 | |
| *** madrazr has joined #melange | 08:26 | |
| *** MatthewWilkes has joined #melange | 09:05 | |
| *** [1]bcarlyon|lapt has joined #melange | 09:08 | |
| *** BCarlyon|Laptop has quit IRC | 09:23 | |
| *** [1]bcarlyon|lapt is now known as bcarlyon|laptop | 09:23 | |
| *** madrazr has quit IRC | 09:26 | |
| *** [1]bcarlyon|lapt has joined #melange | 09:58 | |
| *** bcarlyon|laptop has quit IRC | 10:14 | |
| *** [1]bcarlyon|lapt is now known as bcarlyon|laptop | 10:14 | |
| *** lyaunzbe has joined #melange | 10:30 | |
| *** madrazr has joined #melange | 10:35 | |
| *** MatthewWilkes has quit IRC | 10:47 | |
| *** MatthewWilkes has joined #melange | 10:50 | |
| *** tlarsen has joined #melange | 11:09 | |
| *** ChanServ sets mode: +o tlarsen | 11:09 | |
| tlarsen | SRabbelier: Yes, the "user_self" view was old and crufty, but it was customized to make it easy to use. I hope that customization has not been undone by the recent refactoring. | 11:29 |
|---|---|---|
| *** Lennie has joined #melange | 11:34 | |
| *** ChanServ sets mode: +v Lennie | 11:34 | |
| Lennie | tlarsen, please try something before marking patches as -1 | 11:34 |
| Lennie | ty | 11:34 |
| tlarsen | Lennie: Which one? | 11:35 |
| tlarsen | Lennie: The TODO was definitely a -1. | 11:35 |
| Lennie | default value for ToS :p | 11:35 |
| Lennie | yeah the TODO was something I ran into | 11:35 |
| Lennie | and apparently we thought about it ^_^ | 11:36 |
| tlarsen | Lennie: Adding a default to agrees_to_tos and eliminating the None state is also a -1. | 11:36 |
| tlarsen | Those are the only two I gave -1. | 11:36 |
| Lennie | it's the 2nd one | 11:36 |
| Lennie | the system still stands | 11:36 |
| tlarsen | You cannot make someones answer False for them. | 11:36 |
| tlarsen | It is an answer to a legal document. You need "Yes", "No", and "no answer yet". | 11:37 |
| Lennie | There is no "no answer yet" since it's clear that if there is no ToS you have not agreed to one | 11:37 |
| tlarsen | That is the way I originally implemented it, and I tested that it worked that way. | 11:37 |
| Lennie | Go try out the latest rev and see that it still stands | 11:38 |
| Lennie | and it finally works as it should | 11:39 |
| Lennie | you can't overwrite any accounts | 11:39 |
| Lennie | and you can't resuse the emailadress | 11:39 |
| tlarsen | Lennie: Yes, the improvements are nice. | 11:40 |
| Lennie | Does legal care about wheter or not you looked at it and disagreed or that you didn't look at it at all? | 11:41 |
| tlarsen | Lennie: In the U.S. at least, you should not assume that someones answer is "no". | 11:41 |
| tlarsen | Lennie: If there were not terms of service, and now there are, you have to assume their answer is "I haven't seen them yet". | 11:41 |
| tlarsen | None == "I haven't seen them yet" | 11:42 |
| solydzajs | Lennie: I agree with tlarsen here. | 11:42 |
| tlarsen | This should be easy to fix: | 11:42 |
| solydzajs | Lennie: None state is needed. | 11:42 |
| tlarsen | 1) remove the default=False from agrees_to_tos | 11:42 |
| tlarsen | 2) in the clean_agrees_to_tos method, return None, if the ToS do not exist and there is not already a value for that property | 11:42 |
| tlarsen | If they already answered True or False, and then the admin (temporarily?) removes the ToS, don't change their answer to None. | 11:43 |
| tlarsen | If they never *had* an answer, because there never was a ToS (at least since they've been using the site), and there still isn't a ToS, keep the answer None. | 11:44 |
| tlarsen | The old checkAgreesToSiteToS() (that got folded into checkIsUser(), another change I disagree with, but that's a different story...) would already allow them access to the site if there was no active ToS, regardless of the True/False/None state of agrees_to_tos. | 11:45 |
| solydzajs | ok solved | 11:47 |
| solydzajs | let's move to something more interesting ;-) | 11:47 |
| tlarsen | solydzajs: I guess I will spend my day working on Melange next week fixing this. | 11:51 |
| Lennie | fixing what? | 11:51 |
| tlarsen | Lennie: Fixing the tri-state-ness of agrees_to_tos | 11:51 |
| Lennie | lol | 11:51 |
| Lennie | you need a day for that? | 11:51 |
| Lennie | I already fixed it :S | 11:51 |
| tlarsen | When? | 11:51 |
| Lennie | 2 min ago | 11:52 |
| Lennie | ? | 11:52 |
| tlarsen | Did you commit it? | 11:52 |
| solydzajs | Lennie: you didn't fix everything | 11:52 |
| Lennie | what's still broken then? | 11:52 |
| solydzajs | Lennie: you just did 1) | 11:52 |
| Lennie | if not site_logic.getToS(site_logic.getSingleton()): | 11:53 |
| Lennie | # no site-wide ToS in effect, so let the User slide for now | 11:53 |
| Lennie | return True | 11:53 |
| Lennie | read access check | 11:53 |
| Lennie | auto true when no ToS | 11:53 |
| Lennie | so I dont know what's wrong with 2) | 11:53 |
| tlarsen | Lennie: That is on the access control side. We still need to be sure we don't store a False in the datastore when there was no checkbox for the user to select anything (because there was no ToS). | 11:53 |
| Lennie | but you'd probably be spending your day on something else then :) | 11:53 |
| tlarsen | Lennie: It is a more interesting problem than you realize. | 11:53 |
| tlarsen | Lennie: Google Legal can be *very* picky. | 11:54 |
| Lennie | k | 11:54 |
| Lennie | so that's just it | 11:54 |
| Lennie | if there has never been a tos | 11:54 |
| Lennie | on moment of signup | 11:54 |
| Lennie | there should be None | 11:54 |
| tlarsen | Lennie: Interestingly, though, once there is a ToS in place, there is no way to actually answer False. :) | 11:54 |
| Lennie | yes lawyers | 11:55 |
| Lennie | they should shoot them into the moon :P | 11:55 |
| Lennie | anyhow | 11:55 |
| tlarsen | Let's just make SRabbelier's change. | 11:55 |
| tlarsen | True == "I have read and agree to the Terms of Service" | 11:55 |
| tlarsen | False == "I have not read or agreed to the Terms of Service" | 11:55 |
| tlarsen | There is no way to answer False once the Terms of Service are present, since you cannot submit your profile without the checkbox being checked. | 11:56 |
| Lennie | just a matter of interpatation | 11:57 |
| Lennie | but I'll have it fixed in 5 min | 11:57 |
| Lennie | :) | 11:57 |
| Lennie | just hang on :P | 11:57 |
| solydzajs | :-) | 11:57 |
| Lennie | then you can go and do more useful stuff on your day for Melange | 11:57 |
| Lennie | :D | 11:57 |
| solydzajs | good ;-) | 11:57 |
| Lennie | or you can test it then :) | 11:57 |
| Lennie | so that you dont have to fix it :D | 11:57 |
| tlarsen | OK, I've said all I am going to say. My replies are attached to the changeset threads. | 12:00 |
| solydzajs | tlarsen: Todd regarding when organization can see how many slots they will get, should we implement that as on/off switch or timeline field ? | 12:02 |
| tlarsen | solydzajs: You should ask Leslie that. | 12:02 |
| tlarsen | solydzajs: I don't have a preference one way or the other, so my choice would be "which ever is easiest to implement". :) | 12:03 |
| solydzajs | tlarsen: yep I will, just wondering what's you opinion | 12:03 |
| tlarsen | solydzajs: But then, Leslie wouldn't like that choice, perhaps. | 12:03 |
| solydzajs | heh :-) | 12:03 |
| solydzajs | ok | 12:03 |
| tlarsen | solydzajs: So, to avoid the possibility of implementing it twice, check with Leslie. | 12:03 |
| tlarsen | You could create a User Story and send her the link, asking her to comment. :) | 12:04 |
| solydzajs | tlarsen: will do | 12:04 |
| tlarsen | "When all you have is an issue tracker, everything looks like an issue..." :) | 12:04 |
| tlarsen | s/issue tracker/hammer/ s/issue/nail/ for those of you not familiar with the common English expression. | 12:05 |
| Lennie | hm | 12:08 |
| *** tlarsen is now known as tlarsen|busy | 12:08 | |
| *** tlarsen|busy is now known as tlarsen | 12:14 | |
| *** Lennie is now known as Lennie|Food | 12:44 | |
| tlarsen | OK, I have flipped the agrees_to_tos stuff to Leslie. | 12:50 |
| solydzajs | tlarsen: Lennie committed some fixes, did you see them ? | 12:50 |
| tlarsen | solydzajs: Yes, but he and I had an off-line discussion. | 12:51 |
| solydzajs | tlarsen: ah ok | 12:51 |
| solydzajs | tlarsen: and what's the summary of the discussion ? | 12:51 |
| tlarsen | solydzajs: The problem is more complex than I originally thought, so I am taking the channel's advice to let legal folks comment (through Leslie). | 12:52 |
| solydzajs | tlarsen: ok sounds good | 12:52 |
| tlarsen | solydzajs: Check your inbox. :) | 12:52 |
| solydzajs | tlarsen: yep my inbox is full ;-) | 12:52 |
| tlarsen | http://code.google.com/p/soc/issues/detail?id=174 | 12:52 |
| tpb | <http://ln-s.net/2m+l> (at code.google.com) | 12:52 |
| solydzajs | tlarsen: ok thx | 13:02 |
| Lennie|Food | tlarsen: discussion was good, atleast we have a possible working system :P | 13:04 |
| Lennie|Food | in which you can never disagree after agreeing anymore | 13:04 |
| Lennie|Food | but we'll see what legal says ^_ ^ | 13:04 |
| SRabbelier | tlarsen: I fixed the site having a delete button issue | 13:18 |
| *** Lennie|Food is now known as Lennie | 13:57 | |
| *** Merio has joined #melange | 14:10 | |
| *** madrazr has quit IRC | 14:13 | |
| *** madrazr has joined #melange | 14:13 | |
| *** MatthewWilkes has quit IRC | 14:20 | |
| *** Merio has quit IRC | 14:23 | |
| tlarsen | SRabbelier: OK, assign it to me with a comment asking it to be verified. | 14:32 |
| solydzajs | tlarsen: ping | 14:53 |
| tlarsen | Just a head's up: Monday is going to become my "Melange day", and I won't be on the IRC channel except on Mondays from next week onward. | 14:56 |
| solydzajs | tlarsen: ok | 14:57 |
| solydzajs | tlarsen: thx for update | 14:57 |
| tlarsen | Also, I will not necessarily be responding to Melange emails the same day, and definitely not in minutes. :) | 14:58 |
| tlarsen | So, with that, chat with you all on Monday! | 14:58 |
| *** tlarsen is now known as tlarsen|busy | 14:58 | |
| tlarsen|busy | (bug Leslie if you need something urgent, and she can decide to escalate it to me, thanks) | 15:00 |
| *** Lennie has quit IRC | 15:27 | |
| *** madrazr1 has joined #melange | 15:34 | |
| *** madrazr has quit IRC | 15:35 | |
| *** madrazr1 is now known as madrazr | 15:35 | |
| *** MatthewWilkes has joined #melange | 15:53 | |
| *** MatthewWilkes has quit IRC | 15:58 | |
| *** MatthewWilkes has joined #melange | 16:07 | |
| *** madrazr has quit IRC | 16:29 | |
| *** johndbritton has joined #melange | 16:46 | |
| *** johndbritton has joined #melange | 16:48 | |
| *** johndbritton has quit IRC | 16:53 | |
| *** tlarsen|busy has quit IRC | 18:21 | |
| *** solydzajs has quit IRC | 19:27 | |
| *** MatthewWilkes has quit IRC | 19:30 | |
| *** dmitrig01|afk has joined #melange | 19:32 | |
| *** ChanServ sets mode: +v dmitrig01|afk | 19:32 | |
| *** MatthewWilkes has joined #melange | 19:33 | |
| *** mithro has joined #melange | 19:46 | |
| *** ChanServ sets mode: +v mithro | 19:46 | |
| *** penyaskito has quit IRC | 20:23 | |
| *** penyaskito has joined #melange | 20:25 | |
| *** SRabbelier has quit IRC | 20:44 | |
| *** mithro has quit IRC | 21:11 | |
| *** mithro has joined #melange | 21:12 | |
| *** ChanServ sets mode: +v mithro | 21:12 | |
| *** MatthewWilkes has quit IRC | 21:24 | |
| *** dmitrig01|afk is now known as dmitrig01 | 22:04 | |
| *** tlarsen has joined #melange | 22:52 | |
| *** ChanServ sets mode: +o tlarsen | 22:52 | |
| *** madrazr has joined #melange | 23:43 | |
| *** tlarsen has quit IRC | 23:53 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!