| *** tpb has joined #vtr-dev | 00:00 | |
| elms | kem_: I ran into the blif parsing being more restrictive than I think required. I'm curious about why the ID needs the two cases. I'd like to write a test case if I'm missing why starting with a digit needs to be treated differently. https://github.com/elmsfu/vtr-verilog-to-routing/commit/e2bfc126a7503a20eb52f82306510441aac66497 | 19:31 |
|---|---|---|
| tpb | Title: libblifparse: broaden allowed character set for Ids · elmsfu/vtr-verilog-to-routing@e2bfc12 · GitHub (at github.com) | 19:31 |
| kem_ | elms: I can't recall the reason it was written that way... | 19:38 |
| kem_ | elms: Provided it doesn't cause any problems the change you linked definitely looks cleaner | 19:38 |
| kem_ | elms: What I'd recommend is to try running the blifparse_test executable on all of the .blif files checked in the VTR repo to make sure we can still parse everything | 19:39 |
| elms | kem_: ok will do | 20:03 |
| *** litghost_ has quit IRC | 22:03 | |
| *** litghost has joined #vtr-dev | 22:03 | |
| litghost | I believe https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/473 is ready for review | 22:03 |
| tpb | Title: Add metadata support to architecture and rr_graph XML. by litghost · Pull Request #473 · verilog-to-routing/vtr-verilog-to-routing · GitHub (at github.com) | 22:03 |
| elms | kem_: all files except one passes, but I think it failed before. https://github.com/verilog-to-routing/vtr-verilog-to-routing/blob/master/abc_with_bb_support/JAMIESON_TESTS/sample4.blif#L18 looks like a .blackbox directive that isn't properly formed, but I'm not that familiar with blif | 22:14 |
| tpb | Title: vtr-verilog-to-routing/sample4.blif at master · verilog-to-routing/vtr-verilog-to-routing · GitHub (at github.com) | 22:14 |
| kem_ | elms: Yeah that one looks malformed so not passing on it is OK | 22:20 |
| kem_ | elms: If you want to submit a PR for that, it should go to: https://github.com/kmurray/libblifparse | 22:22 |
| tpb | Title: GitHub - kmurray/libblifparse: Parsing library for BLIF netlists (at github.com) | 22:22 |
| kem_ | elms: Once it's in there the subtree used to include the library in VTR can be updated | 22:22 |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!