| *** tpb has joined #vtr-dev | 00:00 | |
| mithro | digshadow: Are they allocated in the order defined in the pinlocation section? | 00:25 |
|---|---|---|
| mithro | jhol: FYI - my version of your branch now has an initial version of top level routing | 00:41 |
| digshadow | mithro: I found it in the source | 00:42 |
| digshadow | they are put into a map | 00:42 |
| digshadow | therefore, the order is not preserved | 00:42 |
| digshadow | sec let me get the line | 00:42 |
| mithro | digshadow: Well then I think my patch which adds the port names into the rr_graph output is required? | 00:43 |
| digshadow | libs/libarchfpga/src/read_xml_arch_file.cpp | 00:43 |
| digshadow | yes | 00:43 |
| digshadow | map<string, int> pb_port_names; | 00:43 |
| mithro | digshadow: There is an ordered map thingy.... | 00:44 |
| mithro | digshadow: How is the int allocated? | 00:44 |
| mithro | digshadow: That is a map between string<->int right? | 00:44 |
| digshadow | yes | 00:46 |
| digshadow | I'm not sure, it looks to me like they might template it as all 0's and then fill them in? | 00:46 |
| digshadow | ret_pb_ports = pb_port_names.insert( | 00:46 |
| digshadow | pair<string, int>(pb_type->ports[j].name, 0)); | 00:46 |
| digshadow | anyway it doesn't really matter | 00:47 |
| digshadow | if you have that patch ready | 00:47 |
| mithro | digshadow: The other option is to sort them in someway when outputting to the rr_graph | 00:49 |
| mithro | digshadow: The patch works but needs to be cleaned up and sent upstream | 00:49 |
| mithro | digshadow: I haven't run it past kem_ yet either | 00:49 |
| mithro | digshadow: Do you want to cherry-pick the patch, clean it up and send it upstream? | 00:51 |
| digshadow | mithro: what needs to be cleaned up | 00:52 |
| mithro | digshadow: Remove all my debugging prints, fixing C++ formatting, etc | 00:53 |
| digshadow | sure I can do that | 00:54 |
| digshadow | on the aforementioned branch? | 00:54 |
| digshadow | well | 00:54 |
| digshadow | its on vpr branch | 00:54 |
| digshadow | which one? | 00:54 |
| digshadow | ptc-check? | 01:01 |
| mithro | digshadow: Its just that commit I linked earlier | 01:04 |
| mithro | digshadow: Mobile internet is not being reliable, so can't really get you it.... | 01:04 |
| mithro | I said "<mithro> digshadow: https://github.com/mithro/vtr-verilog-to-routing/commit/2f63c539d297d5dd3c4b523bce39adb600534d1f" early -- I think that is it? | 01:04 |
| digshadow | got it | 01:05 |
| digshadow | mithro: in the contributing guide I see it says "match code around it" | 02:09 |
| digshadow | is there something more official? | 02:09 |
| digshadow | a checker tool? | 02:09 |
| mithro | digshadow: Nope! | 02:09 |
| digshadow | I'll review your code, but was there something specifically that you thought was out of style | 02:09 |
| mithro | digshadow: Adding that is on my todo list too | 02:10 |
| mithro | digshadow: I thought I might be using tabs instead of spaces or something | 02:10 |
| mithro | digshadow: If it matches the code around it, then it should be all good? | 02:12 |
| digshadow | I'm not seeing anything sticking out | 02:13 |
| digshadow | I stripped out those files that you said didn't matter and improved the commit message | 02:13 |
| digshadow | recompiled vpr and I'll take a look at the rr_graph and make sure its still works | 02:14 |
| mithro | digshadow: Then if whitespace is all good, just need to fix the commit message and possible tests? | 02:14 |
| mithro | digshadow: I just assume all my code is terrible by default :-) | 02:17 |
| digshadow | mithro: if I run vpr from symbiflow, is it going to use the condra version? how do I use my version? | 02:32 |
| mithro | export VPR=<vpr binary> | 02:32 |
| *** digshadow has quit IRC | 03:23 | |
| *** digshadow has joined #vtr-dev | 03:42 | |
| mithro | jhol: Did you come across this? https://github.com/verilog-to-routing/vtr-verilog-to-routing/issues/318 | 20:52 |
| tpb | Title: Assert failure when writing atom_netlist.cleaned.echo.blif · Issue #318 · verilog-to-routing/vtr-verilog-to-routing · GitHub (at github.com) | 20:52 |
| mithro | jhol: Do you have your counter example somewhere too? | 20:52 |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!