| *** tpb has joined #vtr-dev | 00:00 | |
| *** digshadow has quit IRC | 02:18 | |
| *** digshadow has joined #vtr-dev | 02:54 | |
| mithro | kem_: How did you end up using git-subtree in vtr? I only discovered git-subtrees a couple of weeks ago and they seem pretty cool and should be used more widely.... | 16:56 |
|---|---|---|
| kem_ | mithro: When I started writing more general purpose libraries (e.g. libblifparse) for VTR that I wanted to re-use on other projects I looked at what the best approach was | 16:58 |
| kem_ | mithro: I considered submodules, but tried to see what the issues/limitations were | 16:58 |
| kem_ | mithro: subtree came up as a good alternative | 16:59 |
| mithro | kem_: git submodules *suck* -- but there didn't seem to be any other alternative | 16:59 |
| kem_ | mithro: subtree also follows the single-repo style that VTR has used, while still allowing the tracking of remote dependencies, but in a more de-coupled way than submodules | 17:00 |
| kem_ | mithro: so it seemed a good compromise | 17:01 |
| mithro | Yeah - it seems to have quite a few strong positives compared to submodules | 17:01 |
| awygle | the disadvantage of subtree is that it's less explicit and pushing to a subtree dependency from the combined repo is more complicated, also people are unfamiliar with it. other than that it's quite nice. | 17:01 |
| mithro | I'm guessing that the when I last looked at the option of submodules git-subtree wasn't really used all that much and I never really looked again... | 17:01 |
| awygle | the big danger is new contributors making changes to the combined repo without realizing it's composed of subrepos | 17:02 |
| kem_ | awygle: Agreed, it does put a bit more responsibility on the developers | 17:02 |
| kem_ | However for VTR's purposes most of the things we keep as sub-trees don't change that often | 17:02 |
| mithro | I've don't think I've meet someone who has been able to get contributing to git-submodule based stuff correct on first go | 17:02 |
| mithro | I struggle with it all the time and I use submodules all the time... | 17:03 |
| awygle | mithro: assuming i can get the stuff checked out in the first place (a big assumption), i've never found contributing to be that difficult | 17:03 |
| awygle | i can just never remember how to _get all the code i need_ when cloning for the first time | 17:04 |
| awygle | anyway, back to lurking :) | 17:04 |
| mithro | awygle: I find people always forget to push the submodule | 17:04 |
| kem_ | That was also a motivator for using sub-trees in VTR; it just works | 17:04 |
| mithro | kem_: That is a *huge* plus | 17:04 |
| *** digshadow has quit IRC | 18:12 | |
| *** digshadow has joined #vtr-dev | 19:02 | |
| *** digshadow has quit IRC | 19:17 | |
| *** digshadow has joined #vtr-dev | 19:35 | |
| *** digshadow has quit IRC | 22:37 | |
| *** digshadow has joined #vtr-dev | 22:53 | |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!