| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| *** epyon-sa1ura has quit IRC | 00:19 | |
| *** epyon-sa1ura has joined #tp | 00:20 | |
| *** epyon-sa1ura has quit IRC | 00:26 | |
| *** StupidIncarnate has joined #tp | 01:44 | |
| llnz | brb | 02:15 |
|---|---|---|
| *** llnz has quit IRC | 02:15 | |
| *** llnz has joined #tp | 02:17 | |
| *** StupidIncarnate has quit IRC | 03:51 | |
| llnz | bbl, maybe | 04:47 |
| *** llnz has quit IRC | 04:47 | |
| *** StupidIncarnate has joined #tp | 05:15 | |
| *** epyon-sa1ura has joined #tp | 05:16 | |
| *** cahirwpz has joined #tp | 06:41 | |
| cahirwpz | tansell, ping? | 07:01 |
| *** bisc has joined #tp | 07:30 | |
| tansell | cahirwpz, pong | 07:31 |
| cahirwpz | tansell, I managed to port tests to unittest, could you review the commit ? | 07:34 |
| tansell | cahirwpz, did you see my comments about using the stack frame to find the information you are after rather then a logctx decorator? | 07:36 |
| cahirwpz | yep, I'm going to investigate it after the breakfast | 07:37 |
| tansell | cahirwpz, I don't understand the reason behind the context stuff used in the test code | 07:38 |
| tansell | cahirwpz, the tests should really start up a tpserver-py in the setUp/tearDown so they get fresh state each time | 07:40 |
| cahirwpz | Test Context is (mostly) a storage for data generated in setUp methods | 07:41 |
| tansell | cahirwpz, why not just use attributes on the test class? | 07:42 |
| cahirwpz | before any test is run, a game must be set up, then the game with two players is stored in a context | 07:42 |
| cahirwpz | then the context is saved (against changes) and forwarded to tests suites | 07:43 |
| *** bisc has quit IRC | 07:43 | |
| cahirwpz | tansell, I'd need to remember which class stores a required attribute, so effectively browse parents of a test case | 07:44 |
| tansell | cahirwpz, so you pass around a dictionary instead? | 07:45 |
| cahirwpz | dictionary does not have a save / restore methods and I cannot control what's inside if I need to | 07:45 |
| tansell | cahirwpz, I still don't understand why are you saving/restoring stuff - why don't you setup a clean context each time? | 07:47 |
| cahirwpz | I don't want to set up the game and tables each time I run a single test case | 07:48 |
| cahirwpz | If I know I'll play only with Categories why should I fill up whole database, only categories will change after all | 07:50 |
| cahirwpz | take a path from root test suite (MainTestSuite) to AddCategoryWithSameNameAsPublic test | 07:51 |
| tansell | cahirwpz, I should be able to look at AddCategoryWithSameNameAsPublic and see the test add a category with same name as public and then test for the expected result - instead I get something which looks nothing like a test | 07:53 |
| *** epyon-sa1ura has quit IRC | 08:02 | |
| *** knotwork has quit IRC | 08:02 | |
| *** cahirwpz has quit IRC | 08:02 | |
| *** Greywhind has quit IRC | 08:02 | |
| *** DTRemenak has quit IRC | 08:02 | |
| *** ezod has quit IRC | 08:02 | |
| *** tote has quit IRC | 08:02 | |
| *** verhoevenv_ has quit IRC | 08:02 | |
| *** StupidIncarnate has quit IRC | 08:02 | |
| *** welterde has quit IRC | 08:02 | |
| *** Vadtec has quit IRC | 08:02 | |
| *** cahirwpz has joined #tp | 08:06 | |
| cahirwpz | tansell, Do you think that I should create CategoryTestCase and move setUp / tearDown methods from CategoryTestSuite to CategoryTestCase, and after that derive all Category related tests from CategoryTestCase ? | 08:07 |
| cahirwpz | tansell, If I changed tests in this way we could probably also remove TestContext class | 08:08 |
| tansell | yes - TestSuites shouldn't be doing any setUp/tearDown | 08:08 |
| cahirwpz | well, they could do some fixtures | 08:09 |
| cahirwpz | but that's not relevant at the moment | 08:09 |
| cahirwpz | I think I can remove setUp / tearDown methods from TestSuites and move them to helper classes | 08:10 |
| cahirwpz | this way each TestCase would be independent from each other | 08:11 |
| cahirwpz | probably TestContext could be removed then, and TestSuite class greatly simplified | 08:12 |
| cahirwpz | what do you think about that ? | 08:12 |
| *** cahirwpz has quit IRC | 08:14 | |
| *** cahirwpz has joined #tp | 08:15 | |
| cahirwpz | tansell, poke? | 08:21 |
| tansell | sounds good in principle | 08:22 |
| cahirwpz | ok, it seems to work as expected | 08:31 |
| cahirwpz | a test run is much slower but works | 08:31 |
| tansell | okay | 08:32 |
| cahirwpz | I added CategoryTestMixin class, moved there setUp / tearDown methods, and added CategoryTestMixin to the inheritance list of classes that need such initialisation | 08:34 |
| *** epyon-sakura has joined #tp | 08:34 | |
| *** verhoevenv_ has joined #tp | 08:48 | |
| *** StupidIncarnate has joined #tp | 08:51 | |
| *** welterde has joined #tp | 08:51 | |
| *** Vadtec has joined #tp | 08:51 | |
| *** epyon-sakura has quit IRC | 09:03 | |
| *** tansell has quit IRC | 09:03 | |
| *** CIA-31 has quit IRC | 09:03 | |
| *** StupidIncarnate has quit IRC | 09:03 | |
| *** welterde has quit IRC | 09:03 | |
| *** Vadtec has quit IRC | 09:03 | |
| *** verhoevenv_ has quit IRC | 09:03 | |
| *** cahirwpz has quit IRC | 09:03 | |
| *** StupidIncarnate has joined #tp | 09:10 | |
| *** cahirwpz has joined #tp | 09:11 | |
| *** verhoevenv_ has joined #tp | 09:14 | |
| *** tansell has joined #tp | 09:14 | |
| *** welterde has joined #tp | 09:14 | |
| *** Vadtec has joined #tp | 09:14 | |
| *** cahirwpz has quit IRC | 09:14 | |
| *** tansell has quit IRC | 09:14 | |
| *** welterde has quit IRC | 09:14 | |
| *** Vadtec has quit IRC | 09:14 | |
| *** verhoevenv_ has quit IRC | 09:14 | |
| *** cahirwpz_ has joined #tp | 09:15 | |
| *** Vadtec has joined #tp | 09:17 | |
| *** welterde has joined #tp | 09:17 | |
| *** tansell has joined #tp | 09:17 | |
| *** verhoevenv_ has joined #tp | 09:17 | |
| *** cahirwpz_ has quit IRC | 09:18 | |
| *** Greywhind has joined #tp | 09:20 | |
| *** DTRemenak has joined #tp | 09:20 | |
| *** knotwork has joined #tp | 09:20 | |
| *** 77CAA3L5J has joined #tp | 09:21 | |
| *** epyon-sakura has joined #tp | 09:21 | |
| *** ezod has joined #tp | 09:21 | |
| *** tote has joined #tp | 09:21 | |
| *** 77CAA3L5J has quit IRC | 09:21 | |
| *** epyon-sakura has quit IRC | 09:21 | |
| *** ezod has quit IRC | 09:21 | |
| *** tote has quit IRC | 09:21 | |
| *** knotwork has quit IRC | 09:22 | |
| *** Greywhind has quit IRC | 09:22 | |
| *** DTRemenak has quit IRC | 09:22 | |
| *** tansell has quit IRC | 09:22 | |
| *** welterde has quit IRC | 09:22 | |
| *** Vadtec has quit IRC | 09:22 | |
| *** verhoevenv_ has quit IRC | 09:22 | |
| *** shenki has quit IRC | 09:25 | |
| *** Vadtec has joined #tp | 09:35 | |
| *** shenki_ has joined #tp | 09:35 | |
| *** tote has joined #tp | 09:35 | |
| *** ezod has joined #tp | 09:35 | |
| *** epyon-sakura has joined #tp | 09:35 | |
| *** CIA-27 has joined #tp | 09:35 | |
| *** knotwork has joined #tp | 09:35 | |
| *** DTRemenak has joined #tp | 09:35 | |
| *** Greywhind has joined #tp | 09:35 | |
| *** welterde has joined #tp | 09:35 | |
| *** tansell has joined #tp | 09:35 | |
| *** verhoevenv_ has joined #tp | 09:35 | |
| *** Vadtec has quit IRC | 09:36 | |
| *** Vadtec has joined #tp | 09:36 | |
| *** mithro has quit IRC | 09:42 | |
| *** cahirwpz has joined #tp | 09:44 | |
| CIA-27 | Krystian Bacławski gsoc2010 * r614d3b6 / (23 files in 3 dirs): [mithro's request] Full TestCase isolation. - http://bit.ly/cUAErS | 09:44 |
| tpb | Title: Commit 614d3b64bb3689a6ba91f3134a716f685b8c562d to cahirwpz's tpserver-py - GitHub (at bit.ly) | 09:44 |
| cahirwpz | tansell, okay - now tests are much closer to the philosophy of unittest module, some bugs in test cases emerged, but I'll fix them today | 09:47 |
| *** tansell-laptop has quit IRC | 09:47 | |
| *** tansell-laptop has joined #tp | 10:01 | |
| CIA-27 | Krystian Bacławski gsoc2010 * r1401581 / (16 files): Minor tests clean up. - http://bit.ly/b7pE4t | 10:12 |
| tpb | Title: Commit 1401581c60e52fa320035656c34fcad5412fb74f to cahirwpz's tpserver-py - GitHub (at bit.ly) | 10:12 |
| epyon-sakura | @seen llnz | 10:13 |
| epyon-sakura | dammit | 10:13 |
| epyon-sakura | this hotel has a weird firewall... can't push anything :/ | 10:13 |
| CIA-27 | Krystian Bacławski gsoc2010 * r709d0aa / tests/testcases/testenv.py : Fixed tearDown method in GameTestEnvMixin. - http://bit.ly/9Kitvq | 10:35 |
| tpb | Title: Commit 709d0aab2038976a528ab87003cbd6d837fa7611 to cahirwpz's tpserver-py - GitHub (at bit.ly) | 10:35 |
| cahirwpz | tansell, poke? | 10:36 |
| *** StupidIncarnate has quit IRC | 10:45 | |
| CIA-27 | Krystian Bacławski gsoc2010 * reeefdd7 / (12 files in 2 dirs): Minor tests refactoring. - http://bit.ly/cuUXOp | 11:38 |
| tpb | Title: Commit eeefdd7e82e97f4a097509817337cf8996068d2a to cahirwpz's tpserver-py - GitHub (at bit.ly) | 11:38 |
| CIA-27 | Krystian Bacławski gsoc2010 * r2a1cc43 / tp/server/commands/Common.py : Removed a really nasty workaround. - http://bit.ly/aOhaG0 | 12:08 |
| tpb | Title: Commit 2a1cc43db6dd0fc1e3a427b318f071de693602fa to cahirwpz's tpserver-py - GitHub (at bit.ly) | 12:08 |
| CIA-27 | Krystian Bacławski gsoc2010 * rceaf590 / (10 files in 4 dirs): [mithro's request] Removed logctx and logPrefix. - http://bit.ly/aGZj34 | 12:56 |
| tpb | Title: Commit ceaf590cafff1fef891026ed0097ba36bebf075f to cahirwpz's tpserver-py - GitHub (at bit.ly) | 12:56 |
| *** Greywhind has quit IRC | 12:57 | |
| *** Greywhind has joined #tp | 13:29 | |
| *** StupidIncarnate has joined #tp | 13:41 | |
| *** shenki_ is now known as shenki | 14:14 | |
| *** StupidIncarnate has quit IRC | 15:47 | |
| *** glew has joined #tp | 15:56 | |
| *** epyon-sakura has quit IRC | 17:23 | |
| *** epyon-sakura has joined #tp | 17:27 | |
| *** epyon-sakura has quit IRC | 17:31 | |
| *** StrangerDanger has quit IRC | 18:12 | |
| *** StrangerDanger has joined #tp | 18:17 | |
| *** UltraDMA has joined #tp | 18:42 | |
| *** Agon-laptop has joined #tp | 18:47 | |
| *** UltraDMA has left #tp | 18:58 | |
| *** Agon-laptop has quit IRC | 19:24 | |
| *** StupidIncarnate has joined #tp | 19:53 | |
| *** StupidIncarnate has quit IRC | 20:03 | |
| glew | ezod: hey, just wanted to let you know I did a write up on my blog, and I did the final evaluation survey | 20:05 |
| glew | ezod: if there's anything else you need/want me to do, let me know | 20:05 |
| *** StupidIncarnate has joined #tp | 20:08 | |
| *** llnz has joined #tp | 20:38 | |
| llnz | morning all | 20:38 |
| llnz | GSoC students and mentors: don't forget to do your evaluations in the next 24 hours (or so) | 20:39 |
| llnz | actually, it's slightly less than 23 hours | 20:39 |
| *** cahirwpz has quit IRC | 20:57 | |
| *** Greywhind has quit IRC | 21:07 | |
| *** Greywhind has joined #tp | 21:32 | |
| *** epyon-sa1ura has joined #tp | 21:33 | |
| *** cahirwpz has joined #tp | 21:43 | |
| epyon-sa1ura | llnz: ping? | 22:08 |
| llnz | epyon-sa1ura: pong | 22:12 |
| epyon-sa1ura | llnz: prv msg | 22:16 |
| *** cahirwpz has quit IRC | 22:25 | |
| *** epyon-sa1ura has quit IRC | 22:46 | |
| llnz | afk | 23:01 |
| *** jnengland77 has joined #tp | 23:30 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!