*** tpb has joined #tp | 00:00 | |
*** ChanServ sets mode: +o tpb | 00:00 | |
ezod | ~seen glew | 00:57 |
---|---|---|
tpb | ezod: glew was last seen in #tp 3 days, 0 hours, 42 minutes, and 48 seconds ago: <glew> ezod: hey | 00:57 |
*** nash has joined #tp | 01:22 | |
*** mithro has joined #tp | 01:24 | |
*** mithro has quit IRC | 01:44 | |
*** mithro has joined #tp | 01:57 | |
*** Erroneous has quit IRC | 02:41 | |
*** Epyon_ has quit IRC | 02:59 | |
*** nash has quit IRC | 04:41 | |
llnz | bbl, maybe | 04:59 |
*** llnz has quit IRC | 04:59 | |
*** StupidIncarnate has joined #tp | 05:13 | |
StupidIncarnate | mithro ping | 05:13 |
*** bisc has joined #tp | 05:31 | |
*** nash has joined #tp | 05:43 | |
bisc | mithro: can you please see my resubmitted patches at codereview.mithis.com | 06:04 |
tansell | StupidIncarnate, pong | 06:05 |
StupidIncarnate | hey, question for you. On libtpproto Cache class, either in the update or save function, the pickle.dump command was commented out in the tp04 version. Was this accidental or intentional, do you know? | 06:06 |
tansell | no idea | 06:08 |
StupidIncarnate | opps I mean libtpclient cache.py, in the save function | 06:11 |
StupidIncarnate | mithro, have you heard of any issues with pickling the DynamicBaseObject class? | 06:13 |
tansell | nope | 06:13 |
StupidIncarnate | hmmmm | 06:14 |
StupidIncarnate | Why does it store things in a cache instead of grabbing all the data and loading it directly into the program? | 06:18 |
tansell | StupidIncarnate, I have no idea what you mean? | 06:24 |
StupidIncarnate | i'll have to look at the code more | 06:24 |
bisc | tansell: ping | 06:30 |
tansell | bisc, pong | 06:30 |
bisc | tansell: I requested code review half an hour ago, have you read the message? | 06:33 |
tansell | nope, can you please link me the ones you want me to look at | 06:33 |
bisc | http://codereview.mithis.com/36001 http://codereview.mithis.com/37001 http://codereview.mithis.com/38001 http://codereview.mithis.com/39001 http://codereview.mithis.com/40001 | 06:34 |
tpb | Title: Issue 36001: Error messages. - Code Review (at codereview.mithis.com) | 06:34 |
*** StupidIncarnate has quit IRC | 06:38 | |
tansell | bisc, descriptions should start with a capital | 06:38 |
tansell | can you please link to only the relevant screenshot too | 06:39 |
bisc | tansell: updated issues | 06:42 |
tansell | bisc, you really need a "before" and "after" screenshots | 06:44 |
bisc | tansell: ok, will add them in future. | 06:46 |
tansell-laptop | bisc, hiding a bug doesn't solve a bug | 06:55 |
bisc | tansell: it's not actually hiding. this dialog doesn't have good sizers to be resized. I'm not even sure that such dialogs should be resized. It ruins their appearance anyway. | 07:05 |
*** cahirwpz has joined #tp | 07:36 | |
*** cahirwpz has quit IRC | 08:17 | |
bisc | tansell-laptop: what about 2 patches you haven't commented? | 08:28 |
tansell-laptop | I'm not happy with them yet | 08:32 |
tansell-laptop | will comment later | 08:32 |
bisc | tansell-laptop: and other ones -- they should be pushed to origin/tp04 ? | 08:32 |
tansell-laptop | bisc, they should be pushed to a github repository I can then pull from | 08:33 |
bisc | tansell-laptop: so I should create a new github-hosted project, give you a link and push into github repo? | 08:45 |
tansell-laptop | yes, create it by forking from the ones under github.com/thousandparsec | 08:45 |
*** cahirwpz has joined #tp | 08:52 | |
*** cahirwpz has joined #tp | 08:52 | |
*** null_000 has joined #tp | 08:58 | |
*** Agon has joined #tp | 09:35 | |
*** Agon has quit IRC | 10:03 | |
*** Agon has joined #tp | 10:03 | |
*** Agon has quit IRC | 10:05 | |
*** nash has quit IRC | 10:25 | |
*** Epyon has joined #tp | 10:46 | |
*** tansell-laptop has quit IRC | 10:48 | |
*** mithro has quit IRC | 10:49 | |
*** Landon has quit IRC | 11:01 | |
*** Epyon has quit IRC | 11:25 | |
*** null_000 has quit IRC | 11:32 | |
*** mithro has joined #tp | 12:00 | |
*** Epyon has joined #tp | 12:08 | |
*** peres has joined #tp | 13:09 | |
*** bisc has quit IRC | 13:21 | |
ezod | ~seen glew | 13:23 |
tpb | ezod: glew was last seen in #tp 3 days, 13 hours, 8 minutes, and 36 seconds ago: <glew> ezod: hey | 13:23 |
*** cahirwpz has quit IRC | 14:10 | |
*** null_000 has joined #tp | 14:57 | |
*** null_000 has quit IRC | 15:05 | |
*** null_000 has joined #tp | 15:11 | |
*** Agon-laptop has joined #tp | 15:24 | |
*** shenki__ has joined #tp | 15:33 | |
*** shenki has quit IRC | 15:37 | |
*** jmtan has joined #tp | 15:40 | |
*** Greywhind has quit IRC | 16:11 | |
*** null_000 has quit IRC | 16:22 | |
*** Greywhind has joined #tp | 16:42 | |
*** peres has quit IRC | 16:48 | |
*** jmtan has quit IRC | 18:28 | |
*** cahirwpz has joined #tp | 19:33 | |
*** Erroneous has joined #tp | 19:36 | |
*** Agon-laptop has quit IRC | 19:52 | |
*** Agon-laptop has joined #tp | 19:57 | |
*** llnz has joined #tp | 20:09 | |
*** glew has joined #tp | 21:20 | |
*** Agon-laptop has quit IRC | 21:40 | |
*** Agon-laptop has joined #tp | 21:45 | |
*** Agon-laptop has quit IRC | 22:25 | |
*** cahirwpz has quit IRC | 22:40 | |
*** Landon has joined #tp | 22:42 | |
*** mithro has quit IRC | 23:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!