| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| tansell | Greywhind, 10002 reviewed | 00:05 |
|---|---|---|
| Greywhind | tansell: thanks | 00:06 |
| tansell | cherez, comments added to that CL | 00:14 |
| cherez | Thanks. | 00:14 |
| tansell | cherez, I'm still waiting on a CL for your latest changes to libtpproto-py | 00:14 |
| cherez | libtpproto2-py? | 00:14 |
| tansell | yeah | 00:19 |
| llnz | bbl | 00:27 |
| *** llnz has quit IRC | 00:28 | |
| Greywhind | tansell: http://codereview.mithis.com/10002 | 01:19 |
| tpb | Title: Issue 10002: Added threaded downloading, fixed up code in media.py - Code Review (at codereview.mithis.com) | 01:19 |
| tansell | Greywhind, you missed a comment | 01:54 |
| Greywhind | tansell: fixed | 03:10 |
| tansell | Greywhind, you didn't upload the new version? | 03:14 |
| Greywhind | tansell: it's just a comment | 03:49 |
| Greywhind | tansell: it says: # FIXME: Creating and destroying threads is expensive. This should use a thread pool. | 03:49 |
| tansell | okay that looks good | 03:54 |
| tansell | Greywhind, can you do a report like the one I asked cherez to do? | 03:54 |
| tansell | Greywhind, yours should be a lot more screenshot heavy | 03:54 |
| Greywhind | tansell: i didn't see the request - what would you like in it? | 03:54 |
| tansell | Greywhind, look at the logs | 03:55 |
| Greywhind | tansell: ok. i'll do it tomorrow, if that's alright? | 03:55 |
| *** tansell-laptop has joined #tp | 04:01 | |
| Greywhind | tansell: it's rather late here, is it alright if i do the report tomorrow? | 04:02 |
| tansell-laptop | sure | 04:03 |
| tansell-laptop | it should take you a bit | 04:04 |
| Greywhind | tansell: ok. i'd really like to get these last two code reviews fully pushed before i do the final survey - do you think they're going to be ready? | 04:04 |
| tansell-laptop | have they LGTM | 04:09 |
| tansell-laptop | ? | 04:09 |
| Greywhind | tansell: you haven't put an LGTM on 10002 yet | 04:10 |
| tansell-laptop | well did now | 04:10 |
| Greywhind | tansell: sneaky :P | 04:10 |
| Greywhind | tansell: well, i'm going to sleep then. tomorrow i'll push those and write the report. | 04:11 |
| tansell-laptop | okay | 04:12 |
| *** Greywhind has quit IRC | 04:14 | |
| *** llnz has joined #tp | 04:33 | |
| *** nash has quit IRC | 05:14 | |
| *** mithro has quit IRC | 05:32 | |
| *** tansell-laptop has quit IRC | 05:39 | |
| *** jmtan has quit IRC | 07:00 | |
| *** mithro has joined #tp | 07:06 | |
| * llnz wanders off | 09:44 | |
| llnz | later all | 09:44 |
| *** llnz has quit IRC | 09:44 | |
| *** bddebian has joined #tp | 10:05 | |
| *** jmtan has joined #tp | 11:27 | |
| *** Greywhind has joined #tp | 11:55 | |
| *** DTRemenak has quit IRC | 12:07 | |
| *** DTRemenak has joined #tp | 12:09 | |
| *** mithro has quit IRC | 12:44 | |
| *** mithro has joined #tp | 12:47 | |
| *** Erroneous has joined #tp | 13:30 | |
| *** DTRemenak has quit IRC | 14:10 | |
| *** llnz has joined #tp | 15:56 | |
| llnz | morning all | 16:10 |
| *** bddebian has quit IRC | 17:00 | |
| CIA-26 | Greywhind libtpclient-py-tp04 * r94a860b75102 /tp/client/ (media.py threads.py): Added threaded downloading, fixed up code in media.py, improved threads.py code, added mixin for tracking downloading files. | 17:23 |
| CIA-26 | Greywhind tpclient-pywx-tp04 * r6ab51f763cf9 / (11 files in 5 dirs): Improved media download support by centralizing downloads and adding a download manager to track and cancel downloads. | 17:30 |
| *** mhilmi has quit IRC | 18:19 | |
| *** nash has joined #tp | 18:51 | |
| *** jmtan has quit IRC | 19:28 | |
| *** Erroneous has quit IRC | 21:32 | |
| *** jmtan has joined #tp | 22:48 | |
| *** jmtan has quit IRC | 23:02 | |
| *** jmtan has joined #tp | 23:09 | |
| shenki | mithro: tansell: ping ping ping | 23:42 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!