| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| *** gau_veldt1 has joined #tp | 00:17 | |
| *** gau_veldt1 has left #tp | 00:20 | |
| *** Linkadmin has joined #tp | 01:13 | |
| *** llnz has joined #tp | 01:45 | |
| *** llnz has quit IRC | 03:07 | |
| *** llnz has joined #tp | 03:08 | |
| *** Greywhind has quit IRC | 03:52 | |
| *** greenlion has joined #tp | 04:30 | |
| *** greenlion has quit IRC | 04:37 | |
| mithro | cherez: comments added | 06:21 |
|---|---|---|
| epyon | mithro: are you responsible for the result class in tpserver-cpp? | 08:01 |
| epyon | llnz: what's the exact functionality of setValid and isValid in TimerCallback? i.e. I know what it does, but how is it used? | 08:02 |
| llnz | it's used to cancel the timer before it expires | 08:03 |
| epyon | sooo, it could be just set up to null when I change it to a function | 08:04 |
| epyon | or no, I'll just pack it into a class | 08:04 |
| llnz | a class would be a good idea | 08:04 |
| mithro | epyon: yes | 08:05 |
| epyon | yeah, but using boost::function instead of that messy callback implementation :> | 08:05 |
| llnz | epyon: yeah, i knew that was coming :-) | 08:05 |
| epyon | mithro: why did you do it, if it's basically a error-prone substitute for exception handling? | 08:05 |
| mithro | because previously it was returning 0/1 | 08:06 |
| mithro | I need a way to return true/(false+error message) | 08:06 |
| epyon | wouldn't it be better to throw exceptions instead? | 08:06 |
| llnz | yes it would be | 08:07 |
| mithro | epyon: agreed | 08:07 |
| mithro | but that would have required much bigger changes | 08:07 |
| epyon | I'll do it, ok? | 08:08 |
| mithro | no problem to me, ask llnz | 08:08 |
| epyon | llnz? | 08:08 |
| llnz | no problem, i never liked the Result class | 08:08 |
| mithro | when I make a change to tpserver-cpp I do the smallest one possible | 08:20 |
| epyon | what's the point of invalidate if it's always called before delete? | 09:47 |
| llnz | ? | 09:47 |
| llnz | the timercallback? | 09:47 |
| epyon | OMFG, the timercallback queue was a awfull and dirty hack D: | 10:00 |
| epyon | Not to mention that it wasn't guaranteed to work | 10:00 |
| llnz | oh? | 10:01 |
| llnz | why is that? | 10:01 |
| epyon | You can't hold structures allocated with new and then do a copy... arrrghhh | 10:02 |
| epyon | It works, but may not... | 10:02 |
| * epyon rewrites to shared pointers | 10:02 | |
| epyon | Big one completed... | 10:11 |
| CIA-27 | epyon tpserver-cpp-refactor * r801d18742608 /tpserver/ (18 files): (log message trimmed) | 10:12 |
| CIA-27 | Major TimerCallback rewrite | 10:12 |
| CIA-27 | * TimerCallback now uses boost::function | 10:12 |
| CIA-27 | * TimerCallback shared pointer introduced | 10:12 |
| CIA-27 | * Network holds shared pointers to TimerCallbacks | 10:12 |
| CIA-27 | * Timer Callbacks are always accessed via shared pointers | 10:12 |
| CIA-27 | * Comparison operator for TimerCallback::Ptr for priority_queue | 10:12 |
| *** peres has joined #tp | 10:12 | |
| CIA-27 | epyon tpserver-cpp-refactor * r3e6218d57d9a /tpserver/net.cpp: STL fun ^_^ | 10:23 |
| llnz | epyon: doesn't the AvahiTimer destructor need to invalidate the TimeCallback, as the callback function is no longer valid? | 11:29 |
| epyon | point | 11:30 |
| llnz | and BasicTurnTimer | 11:30 |
| llnz | maybe not BasicTurnTimer... | 11:31 |
| epyon | all TurnTimer destructors invalidate their timers | 11:32 |
| llnz | yeah, see that now, the actual timer in the TurnTimer, and is destructed correctly | 11:37 |
| llnz | btw, getTurnLength is wrong | 11:37 |
| llnz | each timer could give a different result | 11:37 |
| llnz | thresholdturntimer in particular | 11:37 |
| epyon | ? | 11:38 |
| epyon | the code was exact | 11:38 |
| epyon | only in one case we have virtual override -- in the threshold case | 11:38 |
| mithro | epyon: how are you checking that your refactoring is not breaking tpserver-cpp? | 11:40 |
| epyon | not every commit, but from time to time I run a minisec game | 11:41 |
| epyon | but yeah, full stress tests are still to be done | 11:41 |
| ezod | alanp: ping | 11:43 |
| CIA-27 | epyon tpserver-cpp-refactor * r345526e6b3f3 /tpserver/ (orderqueue.cpp orderqueue.h): OrderQueue::removeOrder result was not used | 11:50 |
| CIA-27 | epyon tpserver-cpp-refactor * rbf820e4c5725 /tpserver/ (Makefile.am frameexception.h): FrameException added for substitution for Result | 11:50 |
| CIA-27 | epyon tpserver-cpp-refactor * r9bd25718250a /tpserver/avahi.cpp: Fix for timer invalidation | 11:50 |
| CIA-27 | epyon tpserver-cpp-refactor * r5c3aeb894fdf / (36 files in 5 dirs): | 11:50 |
| CIA-27 | Removal of Result class | 11:50 |
| CIA-27 | * Instead FrameExceptions were used | 11:50 |
| CIA-27 | * unfortunately that needed updates in the rulesets | 11:50 |
| mithro | epyon: how do you run a minisec game? | 12:12 |
| mithro | do you run it all the way to the end? | 12:12 |
| * llnz wanders off | 12:16 | |
| llnz | later all | 12:16 |
| *** llnz has quit IRC | 12:16 | |
| *** peres has quit IRC | 13:13 | |
| *** Greywhind has joined #tp | 13:31 | |
| *** tuna-fish has joined #tp | 13:43 | |
| *** Greywhind has quit IRC | 13:59 | |
| *** Greywhind has joined #tp | 14:07 | |
| *** jnengland77 has joined #tp | 14:58 | |
| *** llnz has joined #tp | 19:19 | |
| *** mithro has quit IRC | 19:25 | |
| *** mithro has joined #tp | 19:26 | |
| *** Greywhind has quit IRC | 19:31 | |
| llnz | morning all | 19:46 |
| CIA-27 | llnz libtpproto-cpp * r286264215fee /tpproto/gamestatuslistener.h: Better documentation in GameStatusListener. | 19:48 |
| *** jnengland77 has quit IRC | 19:53 | |
| llnz | cia didn't see it :-( | 20:48 |
| CIA-27 | llnz libtpproto-cpp * r505032baf082 / (test/nettest.cpp tpproto/gamelayer.cpp tpproto/gamelayer.h): | 20:49 |
| CIA-27 | Added access to GameInfo, both for all the games on the server and the active game. | 20:49 |
| CIA-27 | This breaks the API though. GameLayer::login and GameLayer::createAccount now | 20:49 |
| CIA-27 | take the game name, which can retreived from the GameInfo. | 20:49 |
| CIA-27 | Nettest updated to reflect, uses game "tp". | 20:49 |
| llnz | ah, there it is | 20:49 |
| llnz | :-) | 20:49 |
| llnz | mhilmi: there you go :-) | 20:50 |
| *** CIA-27 has quit IRC | 20:59 | |
| *** CIA-26 has joined #tp | 21:07 | |
| llnz | epyon: it appears you haven't updated all the rulesets | 21:07 |
| llnz | i'm finding includes for tpserver/result.h in mtsec and minisec, and includes for the different orderparameter class headers in tae | 21:09 |
| mhilmi | llnz: just read your email, thanks ! | 21:37 |
| llnz | no problem | 21:38 |
| *** Greywhind has joined #tp | 22:08 | |
| *** jnengland77 has joined #tp | 22:47 | |
| * llnz wonders what to work on for a bit | 23:27 | |
| *** jnengland77 has quit IRC | 23:33 | |
| cherez | tansell: Ping? | 23:44 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!