| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| *** Greywhind has quit IRC | 00:09 | |
| *** mithro_ has joined #tp | 00:29 | |
| *** mithro_ has quit IRC | 00:29 | |
| llnz | it's quiet | 01:44 |
|---|---|---|
| *** llnz has quit IRC | 02:27 | |
| *** llnz has joined #tp | 02:27 | |
| *** JL has joined #tp | 03:24 | |
| *** JLafont_ has quit IRC | 03:41 | |
| *** verhoevenv has joined #tp | 05:40 | |
| *** verhoevenv_ has joined #tp | 06:10 | |
| *** verhoevenv has quit IRC | 06:10 | |
| * llnz wanders off | 08:01 | |
| llnz | later all | 08:01 |
| *** llnz has quit IRC | 08:01 | |
| *** jmtan has joined #tp | 08:32 | |
| *** jmtan1 has joined #tp | 08:37 | |
| *** jmtan has quit IRC | 08:37 | |
| *** jmtan1 is now known as jmtan | 08:37 | |
| *** verhoevenv has joined #tp | 09:09 | |
| *** verhoevenv_ has quit IRC | 09:26 | |
| *** gau_veldt has joined #tp | 09:33 | |
| *** gau_veldt has left #tp | 09:33 | |
| *** bdefreese2 has quit IRC | 10:33 | |
| *** peres has joined #tp | 10:40 | |
| *** verhoevenv_ has joined #tp | 10:51 | |
| *** verhoevenv has quit IRC | 10:53 | |
| *** tansell-laptop has joined #tp | 11:04 | |
| *** jmtan1 has joined #tp | 11:31 | |
| *** jmtan has quit IRC | 11:31 | |
| *** verhoevenv_ has quit IRC | 11:33 | |
| *** jmtan1 is now known as jmtan | 11:34 | |
| *** mithro has quit IRC | 11:46 | |
| *** peres has quit IRC | 11:46 | |
| *** tansell-laptop has quit IRC | 11:58 | |
| *** zzorn has joined #tp | 12:04 | |
| *** Greywhind has joined #tp | 12:25 | |
| *** llnz has joined #tp | 16:05 | |
| *** greenlion has joined #tp | 17:25 | |
| *** Vadtec has quit IRC | 17:33 | |
| *** Vadtec has joined #tp | 17:53 | |
| *** greenlion has quit IRC | 18:20 | |
| *** nash has joined #tp | 18:54 | |
| tansell | morning | 19:27 |
| Greywhind | morning, tansell | 19:28 |
| tansell | how goes things? | 19:29 |
| Greywhind | tansell: pretty well | 19:29 |
| tansell | great | 19:29 |
| Greywhind | tansell: i'm currently working on the download viewer/canceler | 19:29 |
| tansell | yes I saw from your blog | 19:34 |
| Greywhind | tansell: i think i've got it pretty much done for an initial version, at least | 19:34 |
| tansell | okay | 19:34 |
| *** mithro has joined #tp | 19:44 | |
| Greywhind | tansell: http://codereview.mithis.com/9001 | 20:11 |
| tpb | Title: Issue 9001: Improved media support by centralizing media calls and adding a download manager. - Code Review (at codereview.mithis.com) | 20:11 |
| Greywhind | tansell: i'll be back in about 45 minutes | 20:12 |
| tansell | Greywhind, are there any changes to libtpclient-py? | 20:13 |
| Greywhind | tansell: no | 20:14 |
| Greywhind | tansell: i don't think so, at least | 20:14 |
| tansell | okay | 20:14 |
| Greywhind | tansell: i'll be back | 20:15 |
| *** Greywhind has quit IRC | 20:15 | |
| *** Greywhind has joined #tp | 21:37 | |
| tansell | Greywhind, poke me when you get back | 21:45 |
| *** mhilmi has joined #tp | 21:56 | |
| Greywhind | tansell: i'm back | 22:01 |
| tansell | heading to lunch... | 22:01 |
| Greywhind | tansell: ok. let me know. | 22:01 |
| tansell | back now | 23:07 |
| tansell | Greywhind, ping? | 23:07 |
| Greywhind | tansell: pong | 23:07 |
| tansell | Greywhind, so - while this looks good - I think there are a few problems with this approach | 23:08 |
| Greywhind | tansell: ok... what problems do you see? | 23:09 |
| tansell | Greywhind, I really think you need to probably integrate the MediaLibrary and the Media stuff in libtpclient-py | 23:09 |
| Greywhind | tansell: why's that? | 23:09 |
| tansell | Greywhind, as without doing so, you can't do things like priorities | 23:10 |
| Greywhind | i didn't know priorities were planne | 23:10 |
| Greywhind | *planned | 23:10 |
| tansell | Greywhind, well this same code is likely to be needed to download things like battle data | 23:11 |
| tansell | Landon, ping? | 23:11 |
| Greywhind | tansell: well, where would you think this kind of thing would fit in libtpclient-py? | 23:13 |
| tansell | Greywhind, and obviously battle data is probably going to be needed before the pictures | 23:13 |
| tansell | Greywhind, well I think it's probably a case where the Media stuff should implement the basics and then your system should inherit from it for the pywx specific stuff | 23:14 |
| Greywhind | tansell: i think the stuff in MediaLibrary.py is generic, not pywx specific? | 23:15 |
| Landon | tansell: pong | 23:18 |
| tansell | Greywhind, yes a lot of it seems that way | 23:18 |
| tansell | the whole GetFile stuff in the Media.py is pretty horrible | 23:19 |
| Greywhind | tansell: it seems to work - what would you like to see done to it? | 23:19 |
| tansell | you can't have multiple files being downloaded at once | 23:25 |
| Greywhind | tansell: oh, that's true. i noticed that. | 23:26 |
| tansell | it just seems horrible fragile | 23:28 |
| tansell | it's not really safe if there are multiple clients running at once | 23:28 |
| tansell | It doesn't actually check the downloaded files | 23:28 |
| tansell | it doesn't actually do what the comments say :) | 23:28 |
| tansell | Greywhind, so - lots of stuff | 23:29 |
| tansell | it's probably worth just throwing it away and rewriting most of it | 23:29 |
| Greywhind | tansell: so i see | 23:29 |
| Greywhind | tansell: i'll see if i can do it | 23:29 |
| Greywhind | tansell: i don't know if i know enough about libtpclient-py to do it right | 23:30 |
| Greywhind | tansell: but i'll try | 23:30 |
| Greywhind | tansell: what file is the code mostly in? | 23:30 |
| tansell | media.py | 23:31 |
| Greywhind | k | 23:31 |
| tansell | well now it a good time to learn as any | 23:31 |
| Greywhind | true | 23:31 |
| tansell | it's probably a good time to also think about porting some of your functions back into this library | 23:32 |
| Greywhind | the objectutils ones? | 23:32 |
| tansell | yeah | 23:36 |
| *** jnengland77 has joined #tp | 23:37 | |
| *** jmtan has quit IRC | 23:45 | |
| *** jnengland77 has quit IRC | 23:51 | |
| llnz | mhilmi: have you got somewhere to upload the code so that we can see it? | 23:56 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!