| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| tansell | Greywhind, back now | 00:18 |
|---|---|---|
| tansell | sorry I was of doing work | 00:18 |
| Greywhind | tansell: no problem | 00:18 |
| Greywhind | see my changes to 2002 | 00:18 |
| tansell | Greywhind, I can see your comments | 00:18 |
| tansell | Greywhind, looking at it now | 00:19 |
| tansell | Greywhind, you seem to have missed the following comment | 00:21 |
| tansell | http://codereview.mithis.com/2002/diff/6/1004#newcode137 | 00:21 |
| tansell | Line 137: | 00:21 |
| tansell | Would it be better to have a generic method which does the for loop part of | 00:21 |
| tansell | these functions? | 00:21 |
| tpb | <http://ln-s.net/3Fy$> (at codereview.mithis.com) | 00:21 |
| Greywhind | tansell: i'm not sure i can make it generic... i could look into it | 00:21 |
| tansell | those functions look very similar | 00:22 |
| tansell | I'm still unsure why you need the second loop | 00:23 |
| Greywhind | well, it's there in case the media list has an extra layer of wrapper | 00:23 |
| Greywhind | i can remove it if all the rulesets will follow Minisec's example for how media will be contained | 00:24 |
| tansell | Greywhind, can you show me in a diagram? | 00:24 |
| Greywhind | tansell: i can try | 00:24 |
| tansell | that would be great | 00:24 |
| tansell | Greywhind, we probably want to support username/password | 00:28 |
| tansell | as it's likely that some 'media' might be behind protection | 00:29 |
| Greywhind | tansell: ok... i'll see if i can look into that | 00:30 |
| tansell | urllib supports username/password | 00:30 |
| Greywhind | tansell: http://pastebin.com/d104d405e | 00:30 |
| tpb | Title: pastebin - collaborative debugging tool (at pastebin.com) | 00:30 |
| *** Vadtec has quit IRC | 00:31 | |
| *** alanp has quit IRC | 00:31 | |
| *** edison has quit IRC | 00:31 | |
| *** jnengland77 has joined #tp | 00:31 | |
| tansell | Greywhind, what are the Icon: - are they group structures themselves? | 00:32 |
| Greywhind | tansell: yes, they're the root GroupStructures | 00:32 |
| tansell | I'm pretty sure we don't support nested group structures | 00:32 |
| tansell | brb | 00:32 |
| *** alanp has joined #tp | 00:33 | |
| Greywhind | tansell: oh, i think i made a mistake in the drawing actually | 00:36 |
| *** edison has joined #tp | 00:37 | |
| *** Vadtec has joined #tp | 00:37 | |
| Greywhind | tansell: but if we don't support nested GroupStructures, i guess this might be irrelevant | 00:38 |
| Greywhind | tansell: here's the corrected version: http://pastebin.com/d44a92567 | 00:38 |
| tpb | Title: pastebin - collaborative debugging tool (at pastebin.com) | 00:38 |
| *** edison has quit IRC | 00:39 | |
| *** edison has joined #tp | 00:39 | |
| *** tansell--laptop has quit IRC | 00:48 | |
| *** tansell--laptop has joined #tp | 00:48 | |
| tansell--laptop | back | 00:48 |
| *** jmtan has joined #tp | 00:51 | |
| tansell--laptop | Greywhind, so I don't think we support nested GroupStructures | 00:53 |
| tansell--laptop | check the protocol documents | 00:54 |
| Greywhind | tansell--laptop: ok | 00:54 |
| Greywhind | tansell--laptop: ping? | 01:42 |
| tansell | Greywhind, pong | 01:44 |
| Greywhind | tansell: so... it looks like urllib supports username and password through http://username:[email protected] | 01:44 |
| Greywhind | is that right? | 01:44 |
| tansell | Greywhind, yeah | 01:45 |
| Greywhind | tansell: should i manually construct that URL format from the base media URL then? | 01:46 |
| tansell | yes | 01:46 |
| tansell | you can use the urllib to do the split/combind | 01:46 |
| Greywhind | urllib.parse.urlsplit(urlstring)? | 01:48 |
| tansell | yeah that should help | 01:50 |
| shenki | tansell: (offtopic) is it possible to install to my home directory using setuptools? | 01:50 |
| tansell | shenki, not easily in my knowledge | 01:52 |
| tansell | easy-install might be able too | 01:56 |
| *** jnengland77 has quit IRC | 01:57 | |
| Greywhind | tansell: http://codereview.mithis.com/2002 | 02:45 |
| tpb | Title: Issue 2002: Added functions to get media lists to objectutils, used these lists in panelPicture.py. - Code Review (at codereview.mithis.com) | 02:45 |
| tansell | Greywhind, where does self.waitingimages initialised? | 02:48 |
| Greywhind | tansell: in __init__ | 02:48 |
| tansell | oh I see | 02:48 |
| tansell | sorry was diffing the patches | 02:48 |
| Greywhind | no problem | 02:48 |
| tansell | looks okay | 02:49 |
| Greywhind | i tested it without any images cached, and it works | 02:49 |
| *** zzorn-afk has quit IRC | 02:50 | |
| Greywhind | tansell: i'm going to --squash and push then, k? | 02:50 |
| tansell | Greywhind, yeah go ahead | 02:50 |
| tansell | Greywhind, you should also check it works okay if you don't have an internet connection | 02:51 |
| CIA-46 | Greywhind libtpclient-py-tp04 * r5e6e2a5cee04 /tp/client/threads.py: Fixed error when files list is empty in MediaThread. | 02:51 |
| CIA-46 | Greywhind libtpclient-py-tp04 * r6b73b0cc035f /tp/client/ (media.py threads.py): Fixed login with username and password to media server. | 02:51 |
| Greywhind | tansell: hmm... i'll check at some point | 02:51 |
| Greywhind | i'll try it now, i guess | 02:51 |
| Greywhind | brb | 02:51 |
| Greywhind | tansell: well, it looks like it doesn't crash | 02:53 |
| Greywhind | acts about as well as you could expect without any internet | 02:53 |
| tansell | great | 02:53 |
| tansell | what icon are you using if the object is unknown verse downloading? | 02:53 |
| Greywhind | no icon | 02:53 |
| Greywhind | in either case | 02:54 |
| Greywhind | tansell: is that a problem? i wouldn't see it as one. | 02:54 |
| tansell | maybe there needs to be a way to tell if the icons are downloading or if they don't exist | 02:55 |
| Greywhind | tansell: i don't see an icon that could be used for that in the media directory | 02:58 |
| Greywhind | tansell: i could scale one of the other images down and add a new one | 02:58 |
| tansell | Greywhind, no - might need to figure out one | 02:58 |
| tansell | I would make a little question mark for unknown | 02:59 |
| Greywhind | tansell: maybe scale down downloading.gif? | 02:59 |
| Greywhind | tansell: or unknown.png | 02:59 |
| tansell | whats downloading.gif? | 03:00 |
| Greywhind | it's a loading circle | 03:00 |
| tansell | possibly, but I don't think the icons can be animated | 03:00 |
| Greywhind | tansell: i could take just one frame | 03:01 |
| Greywhind | but we could scale down unknown.png instead | 03:01 |
| Greywhind | and use that for unknown objects | 03:01 |
| tansell | see what looks good | 03:03 |
| tansell | I think you'll find it will be unreconisable at that size | 03:03 |
| Greywhind | i can clearly see the question mark | 03:04 |
| CIA-46 | Greywhind tpclient-pywx-tp04 * r0f879fa3d75e /libtpclient-py: Updated libtpclient-py to newest version, with media changes. | 03:11 |
| CIA-46 | Greywhind tpclient-pywx-tp04 * rd869bd8361cd /libtpclient-py: Updated libtpclient-py to make use of newest threads.py changes for media. | 03:11 |
| CIA-46 | Greywhind tpclient-pywx-tp04 * r6a73562e6a0d /libtpclient-py: Updated libtpclient-py to make use of MediaThread files fix. | 03:11 |
| CIA-46 | Greywhind tpclient-pywx-tp04 * rbb1e60aaf81a /libtpclient-py: Updated libtpclient-py to use media login change. | 03:11 |
| CIA-46 | Greywhind tpclient-pywx-tp04 * r0dacf031e16e / (5 files in 4 dirs): Added media support to panelPicture and panelSystem. | 03:11 |
| *** greenlion has joined #tp | 03:23 | |
| tansell | Greywhind, you could have also squashed the libtpclient-py updates | 03:25 |
| *** nash has quit IRC | 03:30 | |
| Greywhind | tansell: well, i committed them individually to tp04 itself because otherwise the git cl upload wouldn't have worked | 03:30 |
| tansell | Greywhind, not a huge problem | 03:31 |
| Greywhind | sorry 'bout that. | 03:31 |
| Greywhind | anyway, my blog post is up, and i'm going to stop for tonight | 03:31 |
| tansell | have a good night | 03:32 |
| Greywhind | see you late | 03:32 |
| Greywhind | you too | 03:32 |
| *** Greywhind has quit IRC | 03:49 | |
| *** Greywhind has joined #tp | 03:51 | |
| *** Greywhind has quit IRC | 04:32 | |
| *** Vadtec has quit IRC | 04:53 | |
| *** edison has quit IRC | 04:53 | |
| *** edison has joined #tp | 04:54 | |
| *** Vadtec has joined #tp | 04:54 | |
| *** llnz has joined #tp | 05:30 | |
| *** tuna-fish has quit IRC | 06:06 | |
| *** jmtan has quit IRC | 06:13 | |
| *** JLP has joined #tp | 06:50 | |
| *** JLP_ has quit IRC | 07:03 | |
| *** JLP_ has joined #tp | 07:14 | |
| *** JLP has quit IRC | 07:25 | |
| *** alanp has quit IRC | 07:47 | |
| *** jmtan has joined #tp | 07:53 | |
| *** jmtan1 has joined #tp | 08:21 | |
| *** sladegen has joined #tp | 08:23 | |
| *** jmtan has quit IRC | 08:39 | |
| * llnz wanders off | 08:39 | |
| llnz | later all | 08:39 |
| *** llnz has quit IRC | 08:39 | |
| *** peres has joined #tp | 09:12 | |
| *** bddebian has joined #tp | 10:10 | |
| *** tuna-fish has joined #tp | 11:44 | |
| *** peres has left #tp | 12:02 | |
| *** jmtan1 has left #tp | 12:57 | |
| *** verhoevenv has joined #tp | 13:10 | |
| *** Greywhind has joined #tp | 13:13 | |
| tote | i've cloned libtpproto-py a couple of weeks ago, and today i did a git fetch, after that i did a git status and got this message: | 13:32 |
| tote | Your branch is behind 'origin/master' by 3 commits, and can be fast-forwarded. | 13:32 |
| tote | what does it mean and how do fast-forward and should i do it? | 13:32 |
| tote | ah i should use git pull instead of fetch? | 13:39 |
| ezod | tote: i think so, yes | 13:46 |
| ezod | that will fetch and update | 13:46 |
| *** verhoevenv has quit IRC | 14:36 | |
| *** Erroneous has joined #tp | 15:40 | |
| *** llnz has joined #tp | 16:07 | |
| *** cherez1 has joined #tp | 16:32 | |
| *** cherez has quit IRC | 16:33 | |
| *** cherez1 is now known as cherez | 16:38 | |
| cherez | mithro: Ping? | 16:41 |
| *** bddebian has quit IRC | 16:42 | |
| llnz | cherez: it's a bit early for him yet | 16:53 |
| *** cherez1 has joined #tp | 16:54 | |
| *** cherez has quit IRC | 16:59 | |
| *** cherez1 is now known as cherez | 17:17 | |
| *** alanp has joined #tp | 17:19 | |
| *** jnengland77 has joined #tp | 17:38 | |
| CIA-46 | joelboh tpclient-pyweb * ra1ac97f52c13 /app/ (__init__.py application.py middleman.py tpclient-pyweb.wsgi): Created a simple base for the backend to be built upon. | 18:06 |
| *** jnengland77 has quit IRC | 18:24 | |
| alanp | ./configure: line 18270: syntax error near unexpected token `avahiclient,' | 18:25 |
| alanp | ./configure: line 18270: `PKG_CHECK_MODULES(avahiclient, avahi-client > 0.6.0,' | 18:25 |
| alanp | ? | 18:25 |
| *** JLafont has quit IRC | 18:34 | |
| *** JLafont has joined #tp | 18:37 | |
| llnz | alanp: do you have package-config installed? | 18:45 |
| llnz | pkg-config, or whatever it's called | 18:46 |
| alanp | llnz: yes | 19:02 |
| llnz | odd, try running ./autogen.sh again | 19:03 |
| *** greenlion has quit IRC | 19:10 | |
| *** bddebian has joined #tp | 20:18 | |
| mithro | morning people | 20:24 |
| llnz | hi mithro | 20:26 |
| cherez | Morning. | 20:26 |
| cherez | mithro: If you have no more suggestions for http://codereview.mithis.com/2001, I'll push it. | 20:27 |
| tansell | cherez, where is your blog located these days? | 20:29 |
| tansell | cherez, did you fix the stuff in my comments? | 20:30 |
| cherez | Yeah. | 20:30 |
| cherez | tansell: The blog is at http://tpproto2.blogspot.com/, I was just writing my report for this week. | 20:30 |
| tansell | Greywhind, ping? | 20:32 |
| cherez | I also ported the tests to unittest, I'll make a branch and put it up for code review after the report. | 20:32 |
| Greywhind | tansell: pong | 20:37 |
| tansell | Greywhind, just looking at the system graphics | 20:38 |
| Greywhind | tansell: ok | 20:38 |
| Greywhind | i'm working on Starmap graphics, to see if it works reasonably well | 20:38 |
| tansell | Greywhind, I'm sure I cleared out the white backgrounds | 20:39 |
| Greywhind | tansell: hmm... maybe it's not recognizing transparency? | 20:40 |
| Greywhind | it did that even before i started changing things | 20:40 |
| tansell | Greywhind, it might be that versions in the media repository are old? | 20:40 |
| Greywhind | tansell: could be | 20:40 |
| tansell | Greywhind, the tp icon seems to be working properly | 20:41 |
| Greywhind | tansell: yeah, the ones in my graphics directory are transparent | 20:41 |
| tansell | if you look in ./graphics/*-icon.png | 20:41 |
| tansell | you will see that they are transparent | 20:41 |
| tansell | Greywhind, I'll set you up an account on the media svn repository | 20:42 |
| *** Vadtec has quit IRC | 20:43 | |
| *** Vadtec has joined #tp | 20:51 | |
| *** alanp_ has joined #tp | 20:56 | |
| *** alanp has quit IRC | 20:56 | |
| tansell | cherez, ping? | 21:00 |
| cherez | tansell: Pong. | 21:00 |
| tansell | cherez, all done? | 21:01 |
| cherez | Finishing the writing. | 21:01 |
| cherez | Alright, I have a summary of what I did for the xstruct module. | 21:05 |
| tansell | link me? | 21:06 |
| cherez | http://tpproto2.blogspot.com/2009/06/update-for-june-2nd.html | 21:07 |
| tpb | <http://ln-s.net/3GFr> (at tpproto2.blogspot.com) | 21:07 |
| cherez | It looks a lot less impressive than my fingers felt it should have been after I typed out the raw strings for every test. :( | 21:09 |
| tansell | cherez, so what is the plan for next week? | 21:14 |
| cherez | tansell: http://tpproto2.blogspot.com/2009/06/plans-for-june-9th.html | 21:16 |
| tpb | <http://ln-s.net/3GFv> (at tpproto2.blogspot.com) | 21:16 |
| cherez | Basically, I'll be doing with structures what I did with xstruct. | 21:16 |
| tansell | so I think that should only take you a day or two | 21:18 |
| tansell | do you have coverage information about xstruct? | 21:18 |
| cherez | Not yet, I'm going to look for tools to generate that. | 21:19 |
| cherez | I guess that would also be part of my plans for next week. | 21:20 |
| CIA-46 | cherez libtpproto2-py * r27ec9372dc65 / (testxstruct.py tp/netlib/xstruct.py): Failure tests. | 21:27 |
| *** Erroneous has quit IRC | 21:28 | |
| Greywhind | tansell: any news on the transparency? | 21:29 |
| tansell | cherez, so coverage is an important measure of how successful you are at testing | 21:30 |
| tansell | Greywhind, yeah the media in svn is out of date | 21:30 |
| Greywhind | tansell: any way to fix it? | 21:30 |
| tansell | cherez, how do you know if you need more testing? | 21:31 |
| tansell | Greywhind, yes - I'll give you a username/password and you can updated it | 21:31 |
| Greywhind | tansell: ok | 21:31 |
| cherez | tansell: By looking at the code coverage? | 21:32 |
| Greywhind | tansell: http://codereview.mithis.com/2006 | 21:32 |
| tpb | Title: Issue 2006: Fixed old method of finding homeworld, added new getResources() method to objectutils. - Code Review (at codereview.mithis.com) | 21:33 |
| tansell | cherez, yeah | 21:33 |
| Greywhind | tansell: http://codereview.mithis.com/2007 | 21:33 |
| tpb | Title: Issue 2007: Added media support to the Systems-level overlay on the Starmap. - Code Review (at codereview.mithis.com) | 21:33 |
| tansell | cherez, IE how do you know that the xstruct stuff is done | 21:34 |
| tansell | cherez, I think you should look into coverage ASAP | 21:34 |
| cherez | I'm reading over it now. | 21:35 |
| tansell | so for next week I would like to see the following | 21:35 |
| tansell | * coverage reports before and after | 21:35 |
| tansell | * all the stuff in structures working | 21:36 |
| tansell | * and a start of testing the parser | 21:37 |
| tansell | does that seem okay? | 21:37 |
| cherez | Yeah. | 21:37 |
| cherez | tansell: By the way, http://codereview.mithis.com/2008 | 21:37 |
| tpb | Title: Issue 2008: Switched unit tests to use the unittest module. - Code Review (at codereview.mithis.com) | 21:37 |
| tansell | cherez, do they still work with py.test? | 21:38 |
| tansell | cherez, you probably want to split that into two separate function calls | 21:39 |
| tansell | cherez, easier to debug when something goes wrong | 21:40 |
| cherez | Not at present. I'll have to figure out how to make the frameworks work together. | 21:40 |
| tansell | cherez, have you looked at nose? | 21:42 |
| Greywhind | this repository is rather large :P | 21:42 |
| cherez | tansell: Not in much depth, but I have. | 21:43 |
| tansell | Greywhind, yeah it's about 300mb | 21:44 |
| tansell | opps | 21:45 |
| tansell | around 1.5G | 21:45 |
| cherez | tansell: is there anything in particular about Nose that is important here? | 21:45 |
| tansell | cherez, it's just a nicer test runner then the default unittest one | 21:46 |
| cherez | tansell: I got a coverage report on xstruct. | 22:03 |
| cherez | There are a few things it pointed out I need to add tests for, and a few bits of code that I'm not sure will ever be run. | 22:04 |
| tansell | like? | 22:04 |
| cherez | The hexbytes function doesn't look to be used anywhere. | 22:04 |
| tansell | can you upload the report? | 22:05 |
| tansell | cherez, the hexbyte function is helpful for debugging xstruct strings :) | 22:05 |
| cherez | And there are some tests in the internal functions for input which are redundant to tests in pack and unpack. | 22:06 |
| Greywhind | tansell: i don't seem to have the defense, mine, or scanner icons | 22:06 |
| cherez | How do you want the report uploaded? | 22:06 |
| cherez | A pastebin? Or should be in a repository? | 22:06 |
| tansell | cherez, just upload it somewhere you have access too | 22:07 |
| tansell | the output is html right? | 22:08 |
| tansell | Greywhind, probably never used | 22:08 |
| tansell | feel free to fix them up | 22:08 |
| cherez | This one is plain text, I know the tool supports html, but I haven't tried it yet. | 22:08 |
| Greywhind | tansell: ok, i'll remove the backgrounds from them | 22:09 |
| cherez | I just have an annotated version of xstruct. | 22:09 |
| tansell | cherez, well I can give you ability to upload to http://www.thousandparsec.net/~cherez if you have nowhere else to upload too | 22:10 |
| cherez | Well, I could fiddle with my router and use my box to host. | 22:11 |
| cherez | My internet tends to be a little shaky, though. | 22:11 |
| tansell | cherez, okay - i'll do it after lunch | 22:13 |
| tansell | bblr | 22:13 |
| cherez | Alright, thanks. | 22:14 |
| *** jmtan has joined #tp | 22:43 | |
| *** alanp_ is now known as alanp | 22:44 | |
| Greywhind | tansell: ping? | 23:11 |
| Landon | hey jmtan | 23:12 |
| Landon | just letting you know, progress this week will be very slow, I hit some snags moving into the house and haven't had time to get stuff like internet set up yet | 23:13 |
| jmtan | sure, you're moving house after all, get your stuff in order first :) | 23:16 |
| Landon | turned out they weren't ready for me to move up on the first :P | 23:20 |
| Landon | still doing house repair all over | 23:20 |
| jmtan | are you staying at the house now? | 23:21 |
| Landon | yeah, they had at least one of the rooms completely finished heh | 23:22 |
| Landon | leeching from a neighbors wireless >.> | 23:22 |
| jmtan | thank goodness for default router settings eh | 23:24 |
| tansell | back now | 23:30 |
| tansell | Greywhind, pong | 23:34 |
| Greywhind | tansell: what was that you said about removing the media from the tpclient package? | 23:34 |
| tansell | Greywhind, well the icons are downloaded now | 23:34 |
| tansell | so they shouldn't be shipped with the client | 23:35 |
| Greywhind | tansell: ah. | 23:35 |
| *** sladegen has quit IRC | 23:35 | |
| CIA-46 | greywhind * r71 media/client/common/object-icons/ (9 files): Updated icons to make backgrounds transparent. | 23:36 |
| tansell | Landon, of course you should be able to develop without internet access | 23:36 |
| Greywhind | tansell: ok, transparent icons are in | 23:37 |
| tansell | great! - do they work? | 23:38 |
| Greywhind | yep | 23:38 |
| Greywhind | tansell: i'm going to go write my summary now | 23:39 |
| *** sladegen has joined #tp | 23:41 | |
| tansell | Greywhind, great - they are good to read | 23:41 |
| Landon | tansell: yeah, need to get the desktop set up after the carpets dry from steam cleaning | 23:53 |
| Landon | hopefully I have the ogre docs on there somewhere :P | 23:54 |
| Landon | although hmm, I don't think I'll need those for a while | 23:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!