| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| *** Erroneous has quit IRC | 00:06 | |
| CIA-46 | llnz tpserver-cpp * r438e8c4b425b /.gitignore: Added the docs directory to gitignore | 00:17 |
|---|---|---|
| CIA-46 | llnz tpserver-cpp * rb5b35fda15cf /modules/games/minisec/ (10 files): | 00:17 |
| CIA-46 | Pull out the ParameterGroupID and ParameterID values as constants in Minisec. | 00:17 |
| CIA-46 | Should make adding media parameters easier. | 00:17 |
| *** jnengland77 has joined #tp | 00:20 | |
| CIA-46 | llnz tpserver-cpp * rf9844cb0a6e2 /modules/games/minisec/ (6 files): | 00:33 |
| CIA-46 | Added media parameters to SpaceObject in Minisec. | 00:33 |
| CIA-46 | Had to update all the ParameterGroupIDs. Needs to still be set. | 00:33 |
| CIA-46 | This adds two parameters, called "Icon" and "Media", that are for the icon and main media | 00:33 |
| CIA-46 | respectively, as they are not currently together in the media repo. | 00:33 |
| *** jmtan has joined #tp | 00:49 | |
| *** mhilmi has quit IRC | 01:18 | |
| *** jnengland77 has quit IRC | 01:33 | |
| *** mithro has joined #tp | 01:41 | |
| mithro | morning people | 01:42 |
| llnz | hi mithro | 01:42 |
| Greywhind | mithro: hope you don't mind waking up to a bunch of patches waiting for review ;P | 01:44 |
| mithro | Greywhind: nope | 01:44 |
| mithro | It makes me feel like there has been progress | 01:44 |
| Greywhind | mithro: at least a bit, hopefully | 01:44 |
| mithro | urls? | 01:45 |
| *** jnengland77 has joined #tp | 01:45 | |
| Greywhind | http://codereview.mithis.com/2002 | 01:45 |
| tpb | Title: Issue 2002: Added functions to get media lists to objectutils, used these lists in panelPicture.py. - Code Review (at codereview.mithis.com) | 01:45 |
| Greywhind | http://codereview.mithis.com/2003 | 01:45 |
| tpb | Title: Issue 2003: Temporary fix for drawing icons in the system list - need to improve once media support is better. - Code Review (at codereview.mithis.com) | 01:45 |
| Greywhind | http://codereview.mithis.com/2004 | 01:45 |
| tpb | Title: Issue 2004: Added getOwner method in objectutils, used it in Systems.py to colorize icons. - Code Review (at codereview.mithis.com) | 01:45 |
| mithro | 2002 done | 01:55 |
| mithro | Greywhind: all reviewed | 01:58 |
| Greywhind | mithro: thanks | 01:58 |
| Greywhind | mithro: so you think i shouldn't make an attempt to auto-detect object type if there's no media? | 02:00 |
| mithro | Greywhind: yeah | 02:01 |
| Greywhind | ok. it does make the code a bit simpler. it'll force all rulesets to include media if they want the client to be at its best, though. | 02:02 |
| Greywhind | i'll work on really fixing the media support starting tomorrow, since llnz updated minisec to have media | 02:03 |
| CIA-46 | Greywhind tpclient-pywx-tp04 * r63bde7c3fac8 / (extra/objectutils.py windows/main/overlays/Systems.py): Added getOwner method in objectutils, used it in Systems.py to colorize icons. | 02:05 |
| mithro | Greywhind: he did? Cool! | 02:06 |
| Greywhind | [21:17] CIA-46 : llnz tpserver-cpp * rb5b35fda15cf /modules/games/minisec/ (10 files): | 02:06 |
| Greywhind | [21:17] CIA-46 : Pull out the ParameterGroupID and ParameterID values as constants in Minisec. | 02:06 |
| Greywhind | [21:17] CIA-46 : Should make adding media parameters easier. | 02:06 |
| Greywhind | [21:20] + jnengland77 [[email protected]] has joined #tp | 02:06 |
| Greywhind | [21:33] CIA-46 : llnz tpserver-cpp * rf9844cb0a6e2 /modules/games/minisec/ (6 files): | 02:06 |
| Greywhind | [21:33] CIA-46 : Added media parameters to SpaceObject in Minisec. | 02:06 |
| Greywhind | [21:33] CIA-46 : Had to update all the ParameterGroupIDs. Needs to still be set. | 02:06 |
| Greywhind | [21:33] CIA-46 : This adds two parameters, called "Icon" and "Media", that are for the icon and main media | 02:06 |
| Greywhind | [21:33] CIA-46 : respectively, as they are not currently together in the media repo. | 02:06 |
| mithro | great | 02:11 |
| mithro | well, I'm about to head out for a bit | 02:18 |
| mithro | Greywhind: I assume you'll probably be asleep by the time I get back | 02:18 |
| Greywhind | mithro: probably. see you tomorrow. | 02:21 |
| *** jnengland77 has quit IRC | 02:35 | |
| cherez | mithro: Ping? | 02:45 |
| Landon | jmtan: I was looking at my timeline today and I ntoiced that your work already covers the next week or two (setting up a battle scene) | 02:47 |
| Landon | so I think I'll fastforward next week to processing battle events | 02:47 |
| *** greenlion has joined #tp | 03:07 | |
| *** jmtan has quit IRC | 03:51 | |
| * llnz waits for the media repository to crawl down | 05:50 | |
| *** llnz2 has joined #tp | 06:23 | |
| *** llnz has quit IRC | 06:23 | |
| *** llnz2 is now known as llnz | 06:23 | |
| *** mithro has quit IRC | 06:57 | |
| *** peres has joined #tp | 07:12 | |
| * llnz wanders off | 08:38 | |
| llnz | later all | 08:38 |
| *** llnz has quit IRC | 08:38 | |
| *** mithro has joined #tp | 08:51 | |
| *** peres has quit IRC | 11:59 | |
| *** tuna-fish has joined #tp | 12:23 | |
| *** Greywhind has quit IRC | 13:22 | |
| *** epyon_ has joined #tp | 13:53 | |
| *** Greywhind has joined #tp | 14:28 | |
| cherez | mithro: Ping? | 17:31 |
| CIA-46 | Greywhind tpclient-pywx-tp04 * raeb243bcb90b /extra/objectutils.py: If an object has only positional and media parameters, it can still be a galaxy. | 18:21 |
| *** llnz has joined #tp | 18:24 | |
| *** greenlion has quit IRC | 18:45 | |
| *** reac has joined #tp | 18:59 | |
| *** reac has quit IRC | 19:04 | |
| *** reac has joined #tp | 19:23 | |
| *** llnz2 has joined #tp | 19:40 | |
| *** llnz has quit IRC | 20:02 | |
| *** llnz2 is now known as llnz | 20:32 | |
| llnz | hail and sleat | 21:13 |
| cherez | That bad outside? | 21:15 |
| Greywhind | llnz: ping? | 21:18 |
| *** llnz2 has joined #tp | 21:23 | |
| *** llnz has quit IRC | 21:23 | |
| *** llnz2 is now known as llnz | 21:23 | |
| llnz | yeah | 21:26 |
| llnz | better now though | 21:26 |
| llnz | Greywhind: pong | 21:26 |
| Greywhind | llnz: would you be able to add an icon and an image to at least one object in minisec, so i can test? | 21:28 |
| Greywhind | right now, they're all empty strings | 21:28 |
| llnz | Greywhind: should be in with all media in 10-15 minutes | 21:28 |
| Greywhind | llnz: thanks! | 21:30 |
| CIA-46 | llnz tpserver-cpp * r92426643ea79 /modules/games/minisec/ (build.cpp minisec.cpp minisec.h splitfleet.cpp): | 21:36 |
| CIA-46 | Add media to minisec objects. | 21:36 |
| CIA-46 | Looks like the Names and subclasses should be moved to core. | 21:36 |
| llnz | :-) | 21:36 |
| llnz | let me know if the urls don't work | 21:36 |
| *** llnz2 has joined #tp | 22:05 | |
| *** llnz has quit IRC | 22:05 | |
| *** llnz2 is now known as llnz | 22:05 | |
| mithro | morning people | 22:50 |
| Greywhind | mithro: hello | 22:50 |
| mithro | Greywhind: need any code reviews today? | 22:52 |
| mithro | as I'm hoping to head out soonish | 22:52 |
| Greywhind | mithro: 2002 | 22:54 |
| Greywhind | err, 1002 | 22:54 |
| Greywhind | http://codereview.mithis.com/1002 | 22:54 |
| tpb | Title: Issue 1002: Added support for getting object-specified media to panelPicture, with support in objectutils. - Code Review (at codereview.mithis.com) | 22:54 |
| mithro | Greywhind: I thought I commented on this already? | 22:55 |
| Greywhind | mithro: it's revised | 22:55 |
| mithro | Greywhind: why didn't you upload it over the old one? | 22:55 |
| Greywhind | but i had to bring it back into the mainline first to get other hcnages | 22:55 |
| Greywhind | *changes | 22:55 |
| Greywhind | the original one is here: http://codereview.mithis.com/2002 | 22:56 |
| tpb | Title: Issue 2002: Added functions to get media lists to objectutils, used these lists in panelPicture.py. - Code Review (at codereview.mithis.com) | 22:56 |
| mithro | Greywhind: you are missing changes for some of my comments there | 22:56 |
| mithro | btw you know you can reply to my comments by clicking on the command and hitting the reply button | 22:56 |
| mithro | Greywhind: you know you can just merge tp04 into your topic branch | 22:57 |
| mithro | (or rebase your branch on tp04) | 22:58 |
| Greywhind | mithro: i suppose... i'll do that next time | 22:58 |
| Greywhind | mithro: hmm... it looks like the urls llnz put in don't have filetype endings on them. i was assuming they would. | 22:59 |
| mithro | Greywhind: yes | 23:00 |
| mithro | did you read the media page I sent you? | 23:00 |
| Greywhind | mithro: i'll look over it again | 23:00 |
| Greywhind | can you remind me of the address? | 23:00 |
| mithro | http://www.thousandparsec.net/wiki/Media.gz | 23:01 |
| tpb | Title: Media.gz - Thousand Parsec Wiki (at www.thousandparsec.net) | 23:01 |
| Greywhind | thanks | 23:01 |
| mithro | that make sense? | 23:11 |
| *** jnengland77 has joined #tp | 23:16 | |
| Greywhind | mithro: do we already have code for getting/parsing the Media.gz? | 23:17 |
| mithro | es | 23:22 |
| mithro | s/es/yes | 23:22 |
| mithro | it's in libtpclient-py | 23:22 |
| Greywhind | mithro: ok. i'll look into it. thanks. | 23:23 |
| mithro | see media.py | 23:23 |
| Greywhind | mithro: i'm having trouble figuring out how to get the list of file extensions for a given object... it seems like panelPicture keeps its own list by tying into the MediaDownloadEvent? | 23:50 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!