| *** tpb has joined #timvideos | 00:00 | |
| mithro | https://www.irccloud.com/pastebin/JTjYb4Wv/ | 01:11 |
|---|---|---|
| tpb | Title: Snippet | IRCCloud (at www.irccloud.com) | 01:11 |
| *** Kamilion has quit IRC | 03:07 | |
| *** Kamilion has joined #timvideos | 03:17 | |
| *** rohitksingh_work has joined #timvideos | 04:01 | |
| *** sb0 has quit IRC | 04:18 | |
| mithro | shenki: https://github.com/timvideos/flterm/blob/master/flterm.c#L1058-L1076 | 05:32 |
| tpb | Title: flterm/flterm.c at master · timvideos/flterm · GitHub (at github.com) | 05:32 |
| shenki | mithro: https://github.com/timvideos/flterm/pull/4 | 05:43 |
| tpb | Title: Fix parsing of line-ending option by shenki · Pull Request #4 · timvideos/flterm · GitHub (at github.com) | 05:43 |
| *** Kamilion has quit IRC | 06:07 | |
| mithro | cr1901_modern: ping? | 06:12 |
| *** sb0 has joined #timvideos | 06:12 | |
| *** Kamilion has joined #timvideos | 06:18 | |
| mithro | shenki: https://github.com/enjoy-digital/litex/blob/master/litex/soc/cores/cpu/mor1kx/core.py#L18-L41 | 07:10 |
| tpb | Title: litex/core.py at master · enjoy-digital/litex · GitHub (at github.com) | 07:10 |
| *** CarlFK has quit IRC | 07:49 | |
| cr1901_modern | mithro: Pong. Sorry, I saw your message almost immediately, but didn't want to respond till I had some good news. First the bad news: | 08:49 |
| cr1901_modern | I didn't get much done the past week. libmodem still miscompiles and crashes at the tip of my HDMI2USB-litex-firmware tree. | 08:49 |
| cr1901_modern | Good news: I know for a fact that I introduced a compile option somewhere by accident that's causing the crash- idk what. In the interim, I forced using a known-to-work version of libmodem on the Opsis, otherwise compiling using the tip of my HDMI2USB-litex-firmware tree | 08:51 |
| cr1901_modern | Opsis firmware upload works!! Dual/Quad SPI bitbang works | 08:51 |
| cr1901_modern | So all I have to do is fix the miscompilation error (and add working timer to qemu) and we're good to go! | 08:51 |
| *** sb0 has quit IRC | 12:12 | |
| *** rohitksingh_work has quit IRC | 12:29 | |
| *** valessio has joined #timvideos | 13:06 | |
| *** sb0 has joined #timvideos | 14:11 | |
| *** rohitksingh has joined #timvideos | 14:45 | |
| *** CarlFK has joined #timvideos | 15:17 | |
| *** ChanServ sets mode: +v CarlFK | 15:17 | |
| *** rohitksingh has quit IRC | 15:30 | |
| mithro | tumbleweed: ping? | 20:17 |
| tumbleweed | mithro: pong | 20:23 |
| mithro | tumbleweed: So regarding, your new line pull request | 20:24 |
| tumbleweed | yeah? | 20:24 |
| mithro | tumbleweed: I'm pretty sure the change to firmware/stdio_wrap.c is wrong? | 20:25 |
| mithro | tumbleweed: Either we should change firmware/stdio_wrap to do "\n" to "\r\n" replacement and remove "\r\n" from all the strings - or firmware/stdio_wrap shouldn't touch the strings and we should use "\r\n" everywhere? | 20:26 |
| tumbleweed | oh, LF,CR? | 20:26 |
| mithro | tumbleweed: Hrm? | 20:27 |
| mithro | tumbleweed: I'm talking about this pull request -> https://github.com/timvideos/HDMI2USB-litex-firmware/pull/341 | 20:27 |
| tpb | Title: Use CRLF line-endings by stefanor · Pull Request #341 · timvideos/HDMI2USB-litex-firmware · GitHub (at github.com) | 20:27 |
| tumbleweed | I'm asking what you think about that change is wrong | 20:28 |
| tumbleweed | and I'm guessing it does LFCR | 20:28 |
| tumbleweed | to answer your more general questino: yeah, there's no reason to use CRLF internally, if there's some kind of io driver for network or serial termianls that translates to CRLF | 20:28 |
| mithro | tumbleweed: Either we should change firmware/stdio_wrap to do "\n" to "\r\n" replacement always (and remove "\r\n" from all the strings) -- **or** we should use "\r\n" everywhere and firmware/stdio_wrap shouldn't touch the strings. | 20:29 |
| tumbleweed | yes, I agree about that | 20:29 |
| tumbleweed | but that does need coordination with the submodules | 20:29 |
| tumbleweed | because there are prints all over the place | 20:29 |
| *** Ravenheart has quit IRC | 20:32 | |
| mithro | tumbleweed: I like the idea of firmware/stdio_wrap doing the translation because of the prints all over the place | 20:32 |
| tumbleweed | yeah | 20:33 |
| mithro | tumbleweed: So, do you want to change that pull request to do that? | 20:34 |
| tumbleweed | that is pretty much what it's doing | 20:35 |
| tumbleweed | just not very elegantly | 20:35 |
| tumbleweed | it changes all the (non-wrapped) printfs | 20:35 |
| tumbleweed | if it did a little more inspection and translated '\r?\n' -> '\n' in the wrapper, then I could drop the changes to mdio.c | 20:36 |
| mithro | tumbleweed: Hrm? If you are doing the translation in stdio_wrap, we should remove all the other \r\n right? | 20:57 |
| tumbleweed | no, because not everything uses the wrappers | 21:00 |
| tumbleweed | the wrappers provide wprintf, but there are some printfs scattered around | 21:00 |
| mithro | tumbleweed: Where wprintf isn't used there is normally a special reason? | 21:01 |
| tumbleweed | dunno? | 21:02 |
| mithro | tumbleweed: But the wprintf related should be fixed then? | 21:04 |
| tumbleweed | not sure what you're asking | 21:05 |
| mithro | tumbleweed: If the wrapping functions are doing '\r\n', then we should remove all '\r\n' from the strings which are being sent to the functions? | 21:07 |
| tumbleweed | sure | 21:07 |
| mithro | tumbleweed: Happy to merge it then | 21:14 |
| tumbleweed | OK, I'll have a shot at it | 21:14 |
| tumbleweed | string manipulation in C. So much fun | 21:15 |
| tumbleweed | esp without dynamic memory allocation | 21:15 |
| tumbleweed | the other way around (have everyone do CRLF everywhere, and translate to LF if needed) would be far simpler memory-wise :) | 21:16 |
| mithro | tumbleweed: Use static buffers? | 21:20 |
| tumbleweed | yeah, I have to | 21:20 |
| tumbleweed | (or call the wrapped prints multiple times) | 21:20 |
| tumbleweed | I guess I'll crib the buffer size from the telnet bit | 21:21 |
| mithro | tumbleweed: Yeah - you can't call a function with va_list multiple times | 21:21 |
| tumbleweed | that's true | 21:21 |
| mithro | tumbleweed: It appears to work at first until it doesn't | 21:21 |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!