| *** tpb has joined #timvideos | 00:00 | |
| *** futarisIRCcloud has joined #timvideos | 00:45 | |
| *** SamSagaZ has quit IRC | 01:05 | |
| *** SamSagaZ has joined #timvideos | 01:14 | |
| *** rohitksingh_work has joined #timvideos | 03:50 | |
| Ishan_Bansal | mithro : ping | 04:11 |
|---|---|---|
| mithro | Ishan_Bansal: Pong | 04:11 |
| mithro | I didn't get a chance to look at anything yesterday | 04:11 |
| mithro | I will look at things shortly | 04:11 |
| Ishan_Bansal | mithro : I just want to confirm that is there a need to look after all the issue which are coming in duplication in new_dct6.py ? | 04:12 |
| mithro | Ishan_Bansal: Possibly, I haven't look again - I don't obviously expect you to read my mind and do things I haven't yet mentioned :-P | 04:13 |
| Ishan_Bansal | mithro : I am talking about these issues : https://codeclimate.com/github/timvideos/litejpeg/pull/1 | 04:16 |
| tpb | Title: Adding additional files - timvideos/litejpeg - Code Climate (at codeclimate.com) | 04:16 |
| mithro | Ishan_Bansal: have you addressed all the comments I have put on there? | 04:16 |
| Ishan_Bansal | mithro : yes | 04:16 |
| mithro | Ishan_Bansal: The issues on codeclimate may be relevant, they might not be | 04:17 |
| mithro | Ishan_Bansal: Use your judgement | 04:17 |
| Ishan_Bansal | mithro : ya I am working on them and try to reduce them to as small number as possible. | 04:18 |
| mithro | Ishan_Bansal: I do notice that it seems to be concerned with the complexity of new_dct6.py which I did mention in my code review too | 04:18 |
| mithro | Ishan_Bansal: code climate is suppose to be an automated code reviewer -- it does an okay job sometimes but being a computer it can get things hilariously wrong sometimes :-P | 04:20 |
| Ishan_Bansal | mithro : OK . :-P | 04:23 |
| *** SamSagaZ has quit IRC | 04:30 | |
| mithro | Ishan_Bansal: Any other questions? | 04:36 |
| Ishan_Bansal | : No. | 04:47 |
| *** SamSagaZ has joined #timvideos | 04:48 | |
| mithro | Ishan_Bansal: Great! Hopefully you'll have more soon :-) | 04:55 |
| CarlFK | mithro: should this work for flashing: https://github.com/CarlFK/HDMI2USB-mode-switch/wiki | 05:26 |
| tpb | Title: Home · CarlFK/HDMI2USB-mode-switch Wiki · GitHub (at github.com) | 05:26 |
| mithro | CarlFK: yeap - I think that was the state I last had | 05:26 |
| CarlFK | can you cut/paste that indo the docs, or do you want a PR? | 05:27 |
| mithro | With the "If you see: DNA = 110000001100000011000000110000001100000011000000110000001 (0x181818181818181) try 2 or 3 times, then power cycle it." -- you probably want to try switching the device into serial mode and then back out on the Opsis | 05:27 |
| mithro | CarlFK: PR | 05:28 |
| *** SamSagaZ has quit IRC | 05:45 | |
| CarlFK | mithro: https://editor.timvideos.us/#timvideos/hdmi2usb.tv/edit/master/Firmware.md I hit "Save" and it has been "Saving..." for over 5 min | 06:08 |
| mithro | I'm not sure that works... | 06:08 |
| mithro | It should work - but nobody has tested it in a very long time | 06:09 |
| CarlFK | awesome. | 06:10 |
| CarlFK | what should I be editing? | 06:10 |
| mithro | Go to https://github.com/timvideos/hdmi2usb.tv/blob/master/Firmware.md | 06:13 |
| tpb | Title: hdmi2usb.tv/Firmware.md at master · timvideos/hdmi2usb.tv · GitHub (at github.com) | 06:13 |
| mithro | Click the little edit button - and then make sure the " Create a new branch for this commit and start a pull request." is selected | 06:14 |
| CarlFK | mithro: what is "status"? TODO: Can someone update the status info here. | 06:18 |
| mithro | What works, what doesn't on which boards | 06:18 |
| CarlFK | mithro: I think I committed to the main repo, so I cant do a PR .. | 06:24 |
| mithro | CarlFK: there were two options at the bottom of that page - "Commit directly and commit and send a pull reqest" | 06:25 |
| mithro | CarlFK: I'm fixing now | 06:26 |
| CarlFK | I thought I was on my fork and needed to commit to my master then PR to get it to yours | 06:26 |
| mithro | CarlFK: that would have worked if you were already on your fork | 06:28 |
| mithro | CarlFK: Fixed your stuff to make it into a pull request here -> https://github.com/timvideos/hdmi2usb.tv/pull/21 | 06:30 |
| tpb | Title: flash-gateware instructions by mithro · Pull Request #21 · timvideos/hdmi2usb.tv · GitHub (at github.com) | 06:30 |
| mithro | CarlFK: I also enable protection on the master branch to hopefully prevent that accidently happening again but unsure if it works... | 06:32 |
| mithro | CarlFK: Thank you so much for taking the time to send a pull request! | 06:37 |
| CarlFK | mithro: sure - any idea how to add a page? other than forking and cloning and whatever | 07:00 |
| mithro | CarlFK: As a separate thing to your current pull request? | 07:01 |
| CarlFK | mithro: sure - whatever I need to do to add: With the "If you see: DNA = 110000001100000011000000110000001100000011000000110000001 (0x181818181818181) try 2 or 3 times, then power cycle it." -- you probably want to try switching the device into serial mode and then back out on the Opsis | 07:01 |
| mithro | CarlFK: I thought you were editing existing stuff? | 07:02 |
| CarlFK | that page is a little cluttered as it is - and "diagnostic and debugging" stuff will likely grow and grow so it should have its own page | 07:03 |
| mithro | Did you look at the pull request I sent you? | 07:03 |
| mithro | CarlFK: okay | 07:03 |
| mithro | Go to https://github.com/timvideos/hdmi2usb.tv/tree/carlfk-pull-1 | 07:04 |
| tpb | Title: GitHub - timvideos/hdmi2usb.tv at carlfk-pull-1 (at github.com) | 07:04 |
| mithro | There is a "Create new file" button on that page | 07:04 |
| mithro | That will add a new page to your carlfk-pull-1 branch I beleive | 07:04 |
| mithro | CarlFK: did that work? | 07:07 |
| CarlFK | mithro: maybe. I have a new file. not sure if the link to it should work on githug | 07:09 |
| CarlFK | https://github.com/timvideos/hdmi2usb.tv/blob/carlfk-pull-1/flash-gateware | 07:09 |
| tpb | Title: hdmi2usb.tv/flash-gateware at carlfk-pull-1 · timvideos/hdmi2usb.tv · GitHub (at github.com) | 07:09 |
| mithro | CarlFK: needs to have a .md on the end to be rendered properly | 07:09 |
| mithro | Also needs a header bit to work as a page see the other .md files for an example -> https://raw.githubusercontent.com/timvideos/hdmi2usb.tv/carlfk-pull-1/Numato-Opsis.md | 07:10 |
| CarlFK | mithro: https://github.com/timvideos/hdmi2usb.tv/blob/carlfk-pull-1/flash-gateware.md | 07:18 |
| tpb | Title: hdmi2usb.tv/flash-gateware.md at carlfk-pull-1 · timvideos/hdmi2usb.tv · GitHub (at github.com) | 07:18 |
| mithro | CarlFK: starting to get there... | 07:18 |
| mithro | CarlFK: It won't appear on the website until it is merged into the master branch | 07:18 |
| mithro | CarlFK: See https://github.com/timvideos/HDMI2USB-mode-switch/issues/33 and https://github.com/timvideos/HDMI2USB-litex-firmware/blob/master/getting-started.md#common-errors too.... | 07:19 |
| tpb | Title: Check for common issues when flashing · Issue #33 · timvideos/HDMI2USB-mode-switch · GitHub (at github.com) | 07:19 |
| CarlFK | mithro: do I need to approve the PR? | 07:24 |
| mithro | CarlFK: Hrm? | 07:25 |
| mithro | CarlFK: You send pull request, I review it, you make any changes needed then I approve & merge it | 07:25 |
| CarlFK | what is in my email asked me to review it | 07:29 |
| mithro | CarlFK: What is in your email? | 07:30 |
| CarlFK | You can view, comment on, or merge this pull request online at: https://github.com/timvideos/hdmi2usb.tv/pull/21 | 07:30 |
| tpb | Title: flash-gateware instructions by mithro · Pull Request #21 · timvideos/hdmi2usb.tv · GitHub (at github.com) | 07:30 |
| mithro | Oh, it might be a bit confused because I created the pull request for you... | 07:31 |
| mithro | CarlFK: I left a bunch of comments on your changes at https://github.com/timvideos/hdmi2usb.tv/pull/21#pullrequestreview-47592141 | 07:31 |
| tpb | Title: flash-gateware instructions by mithro · Pull Request #21 · timvideos/hdmi2usb.tv · GitHub (at github.com) | 07:31 |
| CarlFK | mithro: you are making this too hard | 07:32 |
| mithro | CarlFK: In what way? Sending pull requests is the way that github works for collaboration, getting someone to look at your changes before merging them is also common practice | 07:35 |
| CarlFK | a wiki is also common | 07:35 |
| CarlFK | we should be spending time trying to figure out why my opsis won't flash | 07:37 |
| CarlFK | not on editing docs | 07:37 |
| CarlFK | mithro: all I care about are the 5 commands https://github.com/CarlFK/HDMI2USB-mode-switch/wiki | 07:49 |
| tpb | Title: Home · CarlFK/HDMI2USB-mode-switch Wiki · GitHub (at github.com) | 07:49 |
| CarlFK | I did that, it errored. I power flipped ti to serial and back and power cycled. no help | 07:50 |
| *** futarisIRCcloud has quit IRC | 09:05 | |
| *** diadara_ has joined #timvideos | 09:51 | |
| shenki | Ishan_Bansal: we should squash your patches down to one commit in your review | 10:51 |
| shenki | Ishan_Bansal: to do this, type git rebase -i a973349bc976f3e36005cd91115d1228f6e2dd8c | 10:51 |
| shenki | that will open your editor with a list of commits | 10:51 |
| shenki | then you can edit the rebase operation to squash the patches. I will send you a link about how this works | 10:52 |
| shenki | before you start, type 'git branch backup/before-rebase-1' to create a backup | 10:52 |
| *** CarlFK has quit IRC | 11:20 | |
| *** sb0 has joined #timvideos | 11:33 | |
| *** diadara_ has quit IRC | 11:58 | |
| *** SamSagaZ has joined #timvideos | 12:15 | |
| *** rohitksingh_work has quit IRC | 12:44 | |
| *** sb0 has quit IRC | 13:28 | |
| *** SamSagaZ has quit IRC | 13:29 | |
| *** CarlFK has joined #timvideos | 14:11 | |
| *** ChanServ sets mode: +v CarlFK | 14:11 | |
| *** shenki has quit IRC | 15:08 | |
| *** SamSagaZ has joined #timvideos | 15:27 | |
| *** CarlFK has quit IRC | 16:07 | |
| *** CarlFK has joined #timvideos | 16:16 | |
| *** ChanServ sets mode: +v CarlFK | 16:16 | |
| *** jea[m] has quit IRC | 16:20 | |
| *** MatrixTraveler[m has joined #timvideos | 16:26 | |
| *** jea[m] has joined #timvideos | 16:43 | |
| *** SamSagaZ has quit IRC | 17:06 | |
| *** shenki has joined #timvideos | 17:20 | |
| *** ChanServ sets mode: +v shenki | 17:20 | |
| *** rohitksingh has joined #timvideos | 17:36 | |
| *** SamSagaZ has joined #timvideos | 18:58 | |
| *** rohitksingh has quit IRC | 19:31 | |
| *** SamSagaZ has quit IRC | 20:37 | |
| *** SamSagaZ has joined #timvideos | 22:09 | |
| *** SamSagaZ has quit IRC | 22:45 | |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!