| *** tpb has joined #timvideos | 00:00 | |
| *** sb0 has joined #timvideos | 01:18 | |
| *** nueces has joined #timvideos | 02:03 | |
| *** sab_123 has joined #timvideos | 03:58 | |
| *** nueces has quit IRC | 04:09 | |
| *** rohitksingh_work has joined #timvideos | 04:15 | |
| mithro | sab_123: Formatting requirements are not the only thing you should be checking on the pull request | 05:22 |
|---|---|---|
| mithro | sab_123: But they are required | 05:23 |
| *** ssk1328 has joined #timvideos | 05:27 | |
| ssk1328 | mithro: The pull request looks okay | 05:28 |
| sab_123 | mithro, ok | 05:28 |
| ssk1328 | mithro: I merged my float16 conversion branch csc-update with this branch | 05:28 |
| mithro | sab_123: What do you think of splitting the fx2lib examples into their own repositories? IE Maybe like each having fx2lib-firmware-ftdi fx2lib-firmware-cdc fx2lib-firmware-audio .... | 06:35 |
| mithro | ssk1328: would that make things easier / harder for you? | 06:36 |
| sab_123 | mithro, Sure. Sounds good. | 06:36 |
| ssk1328 | mithro: No problem | 06:37 |
| mithro | sab_123: I'd like you to think about it and have some reasoning why you think it is good / bad | 06:37 |
| mithro | ssk1328: opps that was suppose to be "sab_123: would that make things easier / harder for you?" | 06:37 |
| mithro | sab_123: I didn't mean via email - chatting via IRC would be fine | 06:48 |
| sab_123 | mithro, ah okay | 06:49 |
| sab_123 | mithro, do you want to discuss it now? | 06:55 |
| mithro | sab_123: The indent tool is making the code formatted a certain way, right? | 08:16 |
| mithro | sab_123: so if there is a diff, then the code has not been formatted properly | 08:16 |
| sab_123 | mithro, We are not sure of that. Many times I ran it through indent but you still found some issues | 08:17 |
| sab_123 | like wrapping, new lines etc | 08:17 |
| mithro | sab_123: s/indent/an indent tool/ | 08:17 |
| mithro | sab_123: that is what I meant by "evaluate and figure out which tools are the right choice" | 08:18 |
| sab_123 | mithro, okay | 08:18 |
| mithro | sab_123: if the tool is letting through code which isn't formatted correctly, then that is bad | 08:18 |
| mithro | sab_123: Checking formatting is a hard thing to do, so some tools might miss things | 08:19 |
| sab_123 | Well its not letting code without formatting. Its just what we expect is different | 08:19 |
| mithro | sab_123: Its why generally in python world we use *both* pep8 and pylint | 08:19 |
| mithro | sab_123: they catch different set of problems | 08:20 |
| sab_123 | mithro, okay | 08:20 |
| sab_123 | mithro, I just have 1 question | 08:21 |
| sab_123 | https://github.com/mithro/fx2lib/pull/18#issuecomment-231641835 | 08:21 |
| tpb | Title: Implemented UART in accordance with the API definition in softuart.h to allow the example code to access printf() functionality by RacingTornado · Pull Request #18 · mithro/fx2lib · GitHub (at github.com) | 08:21 |
| sab_123 | mithro, why do you say that? | 08:21 |
| mithro | sab_123: because just from inspecting the code I can see a whole bunch of bugs / issues | 08:22 |
| sab_123 | mithro, uart_api.h needs to merged still. So I havent edited the header file | 08:23 |
| sab_123 | mithro, only soft_uart.h and uart_main.c are the 2 main files | 08:23 |
| mithro | sab_123: I don't understand what you mean | 08:24 |
| sab_123 | mithro, That pull request ideally is only 2 files | 08:24 |
| sab_123 | I dont see anything in uart_main.c apart from a printf and configuration of UART | 08:25 |
| sab_123 | mithro, so the only file left where there could possibly be bugs is the soft_uart.h | 08:25 |
| mithro | sab_123: You can create a branch which only has the files, then create a separate branch where you do a merge of that plus the dependencies | 08:27 |
| sab_123 | mithro, okay | 08:27 |
| mithro | sab_123: Do you want me to review #17 again? | 08:30 |
| sab_123 | mithro, not right now | 08:30 |
| sab_123 | I really havent changed much | 08:30 |
| mithro | There is a comment on that "I have changed things to the best of my knowledge." | 08:30 |
| mithro | https://github.com/mithro/fx2lib/pull/17 | 08:31 |
| tpb | Title: Created a UART API definition by RacingTornado · Pull Request #17 · mithro/fx2lib · GitHub (at github.com) | 08:31 |
| sab_123 | Ah thats 17 | 08:31 |
| sab_123 | Well yes, thats just the API | 08:31 |
| mithro | sab_123: and you have performed all the checks in your list | 08:32 |
| sab_123 | well I was working on the linting tools, but from what I understand https://github.com/mithro/fx2lib/pull/17#issuecomment-230139382 this was already okay | 08:33 |
| tpb | Title: Created a UART API definition by RacingTornado · Pull Request #17 · mithro/fx2lib · GitHub (at github.com) | 08:33 |
| mithro | sab_123: As mentioned multiple times, you should check every pull request for all the things in your check list | 08:35 |
| sab_123 | I am in the process of doing that line by line | 08:35 |
| sab_123 | using the python scripts | 08:35 |
| sab_123 | and write to an excel file and upload it | 08:35 |
| mithro | ? | 08:35 |
| mithro | sab_123: You should also be manually checking | 08:36 |
| mithro | sab_123: until you are 100% confident that automation is working, even then you should do a manual check | 08:36 |
| sab_123 | mithro, ok | 08:36 |
| mithro | sab_123: It is like 100 lines, it should be pretty easy to check manually too | 08:37 |
| mithro | I'm going to dinner | 08:37 |
| mithro | be back in an hour | 08:37 |
| sab_123 | mithro, okay | 08:37 |
| *** Bertl_zZ is now known as Bertl | 09:23 | |
| mithro | xfxf: ping? | 10:30 |
| *** ssk1328 has quit IRC | 10:45 | |
| *** sab_123 has quit IRC | 11:31 | |
| *** sab_123 has joined #timvideos | 11:31 | |
| *** danielki has joined #timvideos | 12:01 | |
| *** panther_ has joined #timvideos | 12:07 | |
| *** sab_123 has quit IRC | 12:07 | |
| *** panther_ is now known as sab_123 | 12:07 | |
| *** rohitksingh_work has quit IRC | 13:18 | |
| *** ssk1328 has joined #timvideos | 13:22 | |
| ssk1328 | mithro: I am building gateware by inserting my modules in video pipeline, after make load-gateware the USB device automatically disconnects and disappears from lsusb. ANy reason why this is happening? | 13:25 |
| mithro | ssk1328: The FPGA resets the FX2 chip after it boots so it can load the FX2 firmware | 13:26 |
| ssk1328 | mithro | 13:27 |
| ssk1328 | mithro: So shoudl I wait? | 13:27 |
| mithro | It should come up as the UVC camera+serial port after a couple of seconds | 13:27 |
| mithro | As you don't care about the USB functionality at the moment, it might be worth just using the mixer target and not resetting the FX2 | 13:28 |
| ssk1328 | mithro: You mean change something in opsis_hdmi2usb file | 13:29 |
| ssk1328 | mithro: In the target folder | 13:29 |
| mithro | ssk1328: No, "export TARGET=videomixer" | 13:30 |
| ssk1328 | mithro: Ok | 13:30 |
| mithro | ssk1328: The videomixer target also builds gateware much faster then the hdmi2usb target | 13:30 |
| mithro | ssk1328: we don't regularly test/use the mixer target, so test that it works without your changes first | 13:31 |
| ssk1328 | mithro: Okay | 13:32 |
| mithro | ssk1328: As the FX2 will no longer get firmware from the FPGA you'll have to use modeswitch to get it into serial/jtag modes | 13:32 |
| ssk1328 | mithro: From my understanding, there is no videomixer target in make file and also no such file in target folder, so I guess you are reffering to using 'video' instead of 'videomixer' | 13:34 |
| mithro | ssk1328: oh, yeah it's called VideoMixerSoC in the file | 13:35 |
| ssk1328 | But I set TARGET=video? | 13:35 |
| *** danielki has quit IRC | 13:36 | |
| ssk1328 | mithro: But anyways I need to rebuilt the bit file, so I am running make gateware again. Lets see how soon it ends | 13:36 |
| mithro | ssk1328: yes | 13:36 |
| ssk1328 | mithro: I have inserted both float16 conversions and floatmult in the video pipeline and it seemed to be working correctly | 13:37 |
| mithro | ssk1328: What is it doing? | 13:39 |
| ssk1328 | right now connected hdmi_in0 to hdmi_out0, which looked good | 13:40 |
| mithro | ssk1328: But what is it multiplying? | 13:40 |
| ssk1328 | mithro: So I hardcoded one of the input of multiplier to 0.5, to see if this works | 13:41 |
| ssk1328 | mithro: So the piprline at the input is like this RBG->RGB16f->RGB16fMult->RGB->YCbCr->YCbCr4:2:2 | 13:42 |
| ssk1328 | *RBG->RGB16f->RGB16fMult->RGB16f->RGB->YCbCr->YCbCr4:2:2 | 13:42 |
| mithro | ssk1328: so it's making things darker or lighter? | 13:44 |
| ssk1328 | mithro: It looked darker | 13:44 |
| ssk1328 | mithro: But it didn't look perfect, so I thought I should try with hardcoded 1 as input, and since then I am stuck | 13:45 |
| mithro | ssk1328: Well, if I understand correctly you are multiplying by 0.5 ? | 13:45 |
| ssk1328 | mithro: Yeah, i understand logically it should be darker | 13:45 |
| mithro | ssk1328: If you use an value of 1 it should be perfect, right? | 13:46 |
| ssk1328 | mithro: Yeah, that was what I was hoping to test, but I was stuck in error which I mentioned earlier | 13:47 |
| ssk1328 | mithro: Hence couldn't test it | 13:47 |
| mithro | What error? | 13:47 |
| ssk1328 | mithro: The USB device disappearing when I do make load-gateware with my generated gateware | 13:48 |
| ssk1328 | mithro: And then I can't do anything without power cycling the board | 13:49 |
| ssk1328 | mithro: Which then erases the uploaded gateware | 13:49 |
| ssk1328 | mithro: And this loop goes on! | 13:49 |
| mithro | ssk1328: It worked with 0.5 and not with 1.0? | 13:49 |
| ssk1328 | mithro: Yeah, but I encountered the same problem the first time I tried to upload the "0.5" gateware file, then I rebuilt the gateware again (read waiting for 20 mins) and then when I uploaded it worked | 13:51 |
| ssk1328 | mithro: I know the error is not related to hardcoded constant | 13:51 |
| *** rohitksingh has joined #timvideos | 13:54 | |
| *** danielki has joined #timvideos | 13:54 | |
| mithro | ssk1328: Does the device disappear from the USB forever? | 13:55 |
| ssk1328 | mithro: Yeah, I waited for like 5-10 seconds | 13:56 |
| ssk1328 | mithro: But anyways the videomixer thing you suggested seemed to work | 13:56 |
| mithro | ssk1328: You can debug it by looking at the FX2 reset and I2C lines | 13:58 |
| ssk1328 | mithro: What exactly do I look at? | 13:58 |
| ssk1328 | mithro: Some pins on the board? | 13:58 |
| *** rohitksingh1 has joined #timvideos | 14:00 | |
| mithro | ssk1328: yes | 14:01 |
| *** rohitksingh has quit IRC | 14:01 | |
| mithro | https://opsis.hdmi2usb.tv/features/usb-peripheral.html | 14:02 |
| ssk1328 | mithro: So I need to check for voltages at those pins, I don't have access to an multimeter right now though! | 14:04 |
| mithro | ssk1328: no, you'll need a logic analyzer | 14:04 |
| ssk1328 | mithro: Ohh, I might take time for me to get hold of that, so maybe later | 14:05 |
| *** rohitksingh has joined #timvideos | 14:33 | |
| *** rohitksingh1 has quit IRC | 14:35 | |
| *** rohitksingh1 has joined #timvideos | 14:39 | |
| *** rohitksingh has quit IRC | 14:39 | |
| *** rohitksingh1 has quit IRC | 14:50 | |
| *** rohitksingh has joined #timvideos | 15:11 | |
| *** Bertl is now known as Bertl_oO | 15:18 | |
| *** sab_123 has quit IRC | 16:32 | |
| *** rohitksingh has quit IRC | 17:19 | |
| *** ssk1328 has quit IRC | 17:35 | |
| *** [d__d] has quit IRC | 18:33 | |
| *** [d__d] has joined #timvideos | 18:36 | |
| *** [d__d] has quit IRC | 18:47 | |
| *** [d__d] has joined #timvideos | 18:52 | |
| *** danielki has quit IRC | 19:32 | |
| *** danielki has joined #timvideos | 20:40 | |
| *** danielki has quit IRC | 21:31 | |
| *** danielki has joined #timvideos | 21:50 | |
| *** CarlFK has quit IRC | 22:36 | |
| *** Bertl_oO is now known as Bertl_zZ | 23:26 | |
| *** paradisaeidae has joined #timvideos | 23:42 | |
| *** paradisaeidae has quit IRC | 23:45 | |
| *** paradisaeidae_ has joined #timvideos | 23:46 | |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!