| *** tpb has joined #timvideos | 00:00 | |
| *** Joelw has quit IRC | 00:03 | |
| *** Joelw has joined #timvideos | 00:04 | |
| *** hyades has quit IRC | 00:09 | |
| *** Joelw has quit IRC | 00:34 | |
| *** Joelw has joined #timvideos | 00:36 | |
| mithro | MaZderMind: yes I have a fix for that | 00:46 |
|---|---|---|
| mithro | MaZderMind: will try and look at your pull request today | 00:48 |
| mithro | MaZderMind: I also have a fix for your Ethernet problem. I don't want it to always be enabled because it increases the CPU load significantly | 00:58 |
| mithro | MaZderMind: I guess you are probably asleep now - but is there any area you'd like me to concentrate on reviewing - IE somewhere you are not confident is correct? | 01:29 |
| mithro | CarlFK: how are those debian packages going? | 02:45 |
| CarlFK | mithro: technically I made progress. might be 1/2 way there. let me wrap up a little PSF/PS1 evote install bug report and Ill give a better answer | 04:06 |
| *** tvCommitBot has joined #timvideos | 04:52 | |
| tvCommitBot | [streaming-system] mithro pushed 1 new commit to master: http://git.io/vJVUo | 04:52 |
| tvCommitBot | streaming-system/master 9b66b53 Tim 'mithro' Ansell: Adding license information.... | 04:52 |
| *** tvCommitBot has left #timvideos | 04:52 | |
| *** Niharika has joined #timvideos | 05:03 | |
| *** hyades has joined #timvideos | 05:21 | |
| CarlFK | evote PR created. | 05:26 |
| CarlFK | im helping :p | 05:26 |
| CarlFK | mithro: on packing. I was told to follow this guide, and I am to here so far: https://www.debian.org/doc/manuals/maint-guide/modify.en.html | 05:30 |
| tpb | Title: Chapter 3. Modifying the source (at www.debian.org) | 05:30 |
| CarlFK | I am not suck, just keep getting distacted. | 05:31 |
| CarlFK | if I do get stuck, I can go back to the local guy that told me to follow the guide. | 05:31 |
| *** Niharika has quit IRC | 05:50 | |
| MaZderMind | mithro: I think it would be best to review the actual tests so I did bot miss snything | 06:12 |
| MaZderMind | CarlFK: might want to chat with florolf in #voc on hackint, he does the packaging/jenkins | 06:12 |
| CarlFK | MaZderMind: it seems like it's grunt work that someone has to sit down and do | 06:25 |
| mithro | MaZderMind: morning! | 06:26 |
| mithro | MaZderMind: just about to take a look at that pull request now that I've finished the HDMI2USB production board review work | 06:27 |
| MaZderMind | cool :) have some questions regarding hdmi2usb, too, but first things first | 06:33 |
| mithro | MaZderMind: some of the tests in your int-tests-rewrite2 branch fail on my machine | 07:08 |
| mithro | MaZderMind: https://gist.github.com/mithro/e7d554f0efd772bda9a5 | 07:08 |
| tpb | Title: gist:e7d554f0efd772bda9a5 (at gist.github.com) | 07:08 |
| mithro | MaZderMind: it looks like the scipy version installed on ubuntu trusty doesn't have the scipy.misc.imread function... -- 0.13.3-1build1 | 07:09 |
| mithro | Which is a bit weird, because it is in the documentation at http://docs.scipy.org/doc/scipy-0.13.0/reference/generated/scipy.misc.imread.html | 07:10 |
| tpb | Title: scipy.misc.imread SciPy v0.13.0 Reference Guide (at docs.scipy.org) | 07:10 |
| mithro | Oh, it's because I'm missing the python3-pil package | 07:10 |
| mithro | MaZderMind: yay, they now pass - but I'm getting lint errors | 07:12 |
| CarlFK | MaZderMind: buttons: Cut and whatever it takes to switch streams. | 07:12 |
| mithro | https://www.irccloud.com/pastebin/9636oj3X | 07:13 |
| tpb | Title: Pastebin | IRCCloud (at www.irccloud.com) | 07:13 |
| CarlFK | I think this is progresss: dpkg-source: error: aborting due to unexpected upstream changes, | 07:21 |
| CarlFK | 2.19, time for bed. | 07:21 |
| *** CarlFK has quit IRC | 07:56 | |
| *** MaZderMind has quit IRC | 08:38 | |
| *** MaZderMind has joined #timvideos | 08:40 | |
| *** Niharika has joined #timvideos | 09:01 | |
| *** Niharika has quit IRC | 09:26 | |
| MaZderMind | mithro: thank you for the review but all your comments are multiple days worth of work on the int-tests. As I stated I'll work on something more useful to our project. I'll see if I can change some mor small things but I won't add new tests atm. because I'll need to get a working GUI and server running -- and tests won't help there | 11:44 |
| mithro | MaZderMind: what is multiple days worth of work? | 11:44 |
| mithro | MaZderMind: I thought I had just requested a bunch of extra comments / minor docstring fixes? | 11:47 |
| MaZderMind | mithro: for example this: https://github.com/timvideos/gst-switch/pull/198/files#r29578330 | 11:47 |
| tpb | Title: Rewriting the integration tests to make them reliable and easier to understand by MaZderMind · Pull Request #198 · timvideos/gst-switch · GitHub (at github.com) | 11:47 |
| MaZderMind | Do you have tests which handle the case where a controller is connected after everything it set up? | 11:47 |
| MaZderMind | What about the case where multiple controllers are connected? | 11:47 |
| MaZderMind | no we don't and writing them - so they even pass travis - is not that easy | 11:48 |
| mithro | MaZderMind: I was expecting you to reply "No, shall I add a TODO for that?" | 11:48 |
| mithro | MaZderMind: or "Yes you silly person, see section ABC below." | 11:49 |
| mithro | MaZderMind: code review is a discussion, if something is going to a lot of effort or I might have missed something - please do point it out | 11:50 |
| MaZderMind | well, you're right that we should have such tests but I worked for about 4 hours today now on those tests which is more then I usually have on a normal workday | 11:50 |
| mithro | MaZderMind: this pull request is very close to being mergable | 11:50 |
| mithro | MaZderMind: putting in "TODO: We should add tests for XXXX, see issue #452" is fine | 11:51 |
| mithro | MaZderMind: btw adding a TODO doesn't mean your responsible for finishing the TODO either | 11:52 |
| MaZderMind | I just wanted you to know how many days working on this can consume | 11:53 |
| MaZderMind | well… I'll see how far i get | 11:53 |
| mithro | MaZderMind: I'm super excited about this code | 11:54 |
| mithro | MaZderMind: it's *so* much more readable and understandable then the previous version | 11:54 |
| MaZderMind | mithro: how about https://github.com/MaZderMind/gst-switch/commit/c7c6277baa47a2c4ada7a477f25043d789a66756 <- whould i add this to the int-test PR? | 12:01 |
| tpb | Title: Change Control-Port to be IPv6 Compatible · MaZderMind/gst-switch@c7c6277 · GitHub (at github.com) | 12:02 |
| mithro | MaZderMind: Does it merge without it? That LGTM, so I'm happy to just merge it. | 12:03 |
| mithro | MaZderMind: sorry I missed that stuff in https://github.com/timvideos/gst-switch/pull/206 - Really should have gotten someone to review it :P | 12:04 |
| tpb | Title: Bind to all IP address (IPv4 and IPv6) by default. by mithro · Pull Request #206 · timvideos/gst-switch · GitHub (at github.com) | 12:04 |
| mithro | MaZderMind: otherwise I'm happy for you to send it as part of the other one | 12:04 |
| mithro | MaZderMind: which ever you think is easier | 12:04 |
| mithro | MaZderMind: Wish github let you suggest modifications to someone's pull request. Then I could just do the modification and ask you to accept it. | 12:13 |
| lukas2511 | mithro: well, i guess you could actually do a pullrequest on the branch that is requested to merge | 12:23 |
| mithro | lukas2511: yeah, but it a bit of a mess | 12:23 |
| MaZderMind | mithro: I did not know that there are docs automatically generated. makes sense to have the doc-comments structured then but I think this is a good thing for another PR | 12:49 |
| mithro | MaZderMind: Yeah, lets leave it for another PR | 12:49 |
| *** tvCommitBot has joined #timvideos | 13:05 | |
| tvCommitBot | [gst-switch] MaZderMind opened pull request #211: [WIP] Control port ipv6 (master...control-port-ipv6) http://git.io/vJwN5 | 13:05 |
| *** tvCommitBot has left #timvideos | 13:05 | |
| *** CarlFK has joined #timvideos | 13:32 | |
| *** ChanServ sets mode: +v CarlFK | 13:32 | |
| mithro | MaZderMind: is that everything? | 13:53 |
| MaZderMind | mithro: I'm done with your comments on #198 | 14:01 |
| MaZderMind | mithro: I'm currently trying to figure out why #211 os failing: https://github.com/timvideos/gst-switch/pull/211 | 14:01 |
| tpb | Title: [WIP] Control port ipv6 by MaZderMind · Pull Request #211 · timvideos/gst-switch · GitHub (at github.com) | 14:01 |
| *** tvCommitBot has joined #timvideos | 14:06 | |
| tvCommitBot | [gst-switch] mithro closed pull request #198: Rewriting the integration tests to make them reliable and easier to understand (master...int-tests-rewrite2) http://git.io/At5u | 14:06 |
| *** tvCommitBot has left #timvideos | 14:06 | |
| mithro | \o/ | 14:06 |
| mithro | MaZderMind: I'm working on https://github.com/timvideos/gst-switch/issues/200 | 14:08 |
| tpb | Title: Composite-Output is 30fps, independent of configured format · Issue #200 · timvideos/gst-switch · GitHub (at github.com) | 14:08 |
| MaZderMind | build on master passing, coverage 100% :) | 14:18 |
| mithro | \o/ | 14:22 |
| mithro | MaZderMind: thank you so much for all your effort on this | 14:22 |
| MaZderMind | you can't imagine how happy I'm to have this of my todo-list | 14:23 |
| MaZderMind | interesting how always one of the two int-tests fail https://travis-ci.org/timvideos/gst-switch/builds/61142866 - https://travis-ci.org/timvideos/gst-switch/builds/61147810 - https://travis-ci.org/timvideos/gst-switch/builds/61151303 | 14:30 |
| tpb | Title: Travis CI - Test and Deploy Your Code with Confidence (at travis-ci.org) | 14:30 |
| MaZderMind | they fail because the gst-launch command did not capture any frames from the server | 14:31 |
| mithro | MaZderMind: looks like you have a scope issue there too, should probably set img=None at the begining | 14:31 |
| mithro | MaZderMind: I need to go to bed | 15:08 |
| *** tvCommitBot has joined #timvideos | 15:08 | |
| tvCommitBot | [gst-switch] mithro opened pull request #214: [WIP] Fix recording output format (master...recording-fix) http://git.io/vJrHG | 15:08 |
| *** tvCommitBot has left #timvideos | 15:08 | |
| mithro | MaZderMind: but I think I have a working change for the recording problem at https://github.com/timvideos/gst-switch/issues/200 | 15:08 |
| tpb | Title: Composite-Output is 30fps, independent of configured format · Issue #200 · timvideos/gst-switch · GitHub (at github.com) | 15:08 |
| mithro | MaZderMind: atleast it makes your test pass :) | 15:08 |
| mithro | MaZderMind: take a look and see what you think, I'll try and work on it again tomorrow depending on how busy work gets | 15:09 |
| MaZderMind | mithro: thank you for coding along with me :) | 15:16 |
| mithro | I think I have a handle on what is causing the multiple audio failure issue too | 15:31 |
| mithro | MaZderMind: if you want to concentrate on getting the new Python UI working, I'll try and get the server side working? | 15:32 |
| MaZderMind | mithro: I think I fixed the Control-Port-IPv6-Thing | 15:33 |
| MaZderMind | mithro: I think you wanted to head to bed? :) | 15:33 |
| MaZderMind | mithro: I have some requirements to the server that need to be finished before, although they are small | 15:33 |
| MaZderMind | there are three signals missing on the controller-api: A/B selection, Audio-Selection and the New-Recordig-Filename Signal | 15:34 |
| mithro | I only just got home from work so still getting ready for bed. | 15:44 |
| mithro | Adding those signals seems reasonable thing to do. | 15:45 |
| mithro | Anyway, really going to bed now | 15:46 |
| mithro | Thanks once again MaZderMind ! | 15:46 |
| MaZderMind | n8 | 15:47 |
| *** Niharika has joined #timvideos | 16:02 | |
| *** Niharika has quit IRC | 16:12 | |
| *** Niharika has joined #timvideos | 16:12 | |
| *** hyades has quit IRC | 16:19 | |
| *** hyades has joined #timvideos | 17:41 | |
| *** CarlFK has quit IRC | 18:24 | |
| MaZderMind | fyi: #211, #208 and #190 should be ready for review / merge. | 18:59 |
| MaZderMind | oh dear how i love those green checkmarks | 18:59 |
| *** CarlFK has joined #timvideos | 19:30 | |
| *** ChanServ sets mode: +v CarlFK | 19:30 | |
| *** Niharika has quit IRC | 19:43 | |
| *** CARAM__ has quit IRC | 20:25 | |
| *** CARAM__ has joined #timvideos | 20:27 | |
| *** CARAM__ has quit IRC | 20:32 | |
| *** Sewar has quit IRC | 20:32 | |
| *** micolous has quit IRC | 20:34 | |
| *** micolous has joined #timvideos | 20:34 | |
| *** CARAM__ has joined #timvideos | 20:35 | |
| *** Sewar has joined #timvideos | 20:35 | |
| *** hyades has quit IRC | 23:09 | |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!