*** tpb has joined #timvideos | 00:00 | |
*** CarlFK has joined #timvideos | 00:53 | |
*** ChanServ sets mode: +v CarlFK | 00:53 | |
*** Sewar has quit IRC | 02:30 | |
*** Sewar has joined #timvideos | 02:32 | |
*** Sewar has quit IRC | 03:06 | |
*** Sewar has joined #timvideos | 03:11 | |
*** Sewar has quit IRC | 03:16 | |
*** Sewar has joined #timvideos | 03:25 | |
*** Sewar has quit IRC | 03:32 | |
*** Sewar has joined #timvideos | 03:38 | |
*** Sewar has quit IRC | 03:50 | |
*** Sewar has joined #timvideos | 03:55 | |
*** Sewar has quit IRC | 04:12 | |
*** Sewar has joined #timvideos | 04:19 | |
*** Sewar has quit IRC | 04:23 | |
*** Niharika has joined #timvideos | 04:28 | |
*** Sewar has joined #timvideos | 04:44 | |
*** Sewar has quit IRC | 05:04 | |
*** Sewar has joined #timvideos | 05:09 | |
*** sb0_ has joined #timvideos | 05:43 | |
*** Sewar has quit IRC | 05:52 | |
*** Sewar has joined #timvideos | 05:56 | |
*** Sewar has quit IRC | 06:01 | |
*** Sewar has joined #timvideos | 06:15 | |
*** Sewar has quit IRC | 06:20 | |
*** Sewar has joined #timvideos | 06:22 | |
*** Niharika is now known as Niharika|away | 06:22 | |
*** Sewar has quit IRC | 06:30 | |
*** Sewar has joined #timvideos | 06:36 | |
*** Niharika|away has quit IRC | 06:36 | |
*** Sewar has quit IRC | 06:58 | |
*** Sewar has joined #timvideos | 07:01 | |
*** sb0_ has quit IRC | 09:00 | |
*** hyades has joined #timvideos | 09:40 | |
*** hyades has quit IRC | 11:59 | |
mithro | MaZderMind: is the latest version of your code at https://github.com/timvideos/gst-switch/pull/198 ? | 12:29 |
---|---|---|
tpb | Title: [WIP] Rewrite of the Integration-Tests, Take 2 by MaZderMind · Pull Request #198 · timvideos/gst-switch · GitHub (at github.com) | 12:29 |
MaZderMind | mithro: kinda. I'm having issues comparing the Audio-Streams on Travis. My method rendering a spectrum and comparingthe image works locally but stalls on Travis. I'm experimenting with comparing the naked spectral values in https://github.com/MaZderMind/gst-switch/compare/int-tests-rewrite2...int-tests-rewrite2-audio-spectrum | 12:33 |
tpb | Title: Comparing int-tests-rewrite2...int-tests-rewrite2-audio-spectrum · MaZderMind/gst-switch · GitHub (at github.com) | 12:33 |
mithro | MaZderMind: any idea why it stalls? | 12:33 |
mithro | MaZderMind: do you have a link of the travis output that I can look at? | 12:34 |
MaZderMind | I guess it has something to do with the numpy comparison of the frames | 12:34 |
MaZderMind | first I had this, what I think was a memory leak in the frame-comparison-pipelin: https://travis-ci.org/timvideos/gst-switch/jobs/59625783 | 12:36 |
tpb | Title: Travis CI - Test and Deploy Your Code with Confidence (at travis-ci.org) | 12:36 |
MaZderMind | after reducinc the memory footprint it started to stall: https://travis-ci.org/timvideos/gst-switch/jobs/59671944 | 12:36 |
tpb | Title: Travis CI - Test and Deploy Your Code with Confidence (at travis-ci.org) | 12:36 |
MaZderMind | I then turned up logging which gave me this: https://travis-ci.org/timvideos/gst-switch/jobs/59695334 | 12:37 |
tpb | Title: Travis CI - Test and Deploy Your Code with Confidence (at travis-ci.org) | 12:37 |
mithro | MaZderMind: I assume they run fine locally? | 12:38 |
MaZderMind | that tells me two things: a) on localhost the spectral images match after ~10 samples, they do not match after 100+ samples on travis, so there must be an issue with the audio coming through | 12:38 |
MaZderMind | b) after 100+ frames the gst-pipeline stalls instead of throwing a RuntimeException when the 5s delay are over | 12:38 |
MaZderMind | My guess for a) is that gst-switch and the audio-source can't run in realtime on travis. while video-frames can be repearted, audio-dsamples usually get dropped, resulting in clicks in the audio which disturbes the spectral comparison | 12:39 |
MaZderMind | i don't have a guess for b) | 12:40 |
MaZderMind | mithro: they do run locally on multiple machines/servers | 12:40 |
mithro | MaZderMind: have you tried saving the audio file and uploading it? | 12:40 |
MaZderMind | mithro: not yet. it would have uploaded the spectral-images after a timeout exception | 12:41 |
MaZderMind | but as it stalls… | 12:41 |
mithro | okay | 12:41 |
mithro | how is the "timeout" implemented? | 12:41 |
mithro | MaZderMind: btw - I pushed a couple of small patches to gst-switch to deal with a problem around IPv6 | 12:42 |
MaZderMind | too simple, I guess: https://github.com/MaZderMind/gst-switch/blob/int-tests-rewrite2/python-api/tests/integrationtests2/baseclass.py#L217 | 12:42 |
tpb | Title: gst-switch/baseclass.py at int-tests-rewrite2 · MaZderMind/gst-switch · GitHub (at github.com) | 12:42 |
MaZderMind | as sample = appsink.emit('pull_sample') deadlocks, it never reaches the comparison | 12:43 |
MaZderMind | I guess i should better use GLib.timeout_add_seconds(timeout, self.quit_mainloop) | 12:43 |
MaZderMind | or sth. in this direction | 12:43 |
MaZderMind | fwiw: all tests are rewritten and pass locally, after I sorted this out somehow it's just a question of cleaning up doc-comments and renaming intergration2 to integration in all places. | 12:48 |
mithro | The only foolproof method would be to run it inside a separate process using multiprocessing and then actually use kill() | 12:48 |
MaZderMind | mithro: I thought about launching gst-launch as a separate process and write images using multifilesink | 12:49 |
mithro | MaZderMind: that process seem like too much work? | 12:50 |
MaZderMind | hm, guess not. it's a question of getting it as solid as possible | 12:51 |
MaZderMind | so the basecode must never be touched again ^^ | 12:51 |
MaZderMind | I'll enable travis for my own clone and do some experiments there, I'll also squash the last testing-this/trying-that commits in the PR | 12:52 |
MaZderMind | to keep the PR clean while experimenting | 12:52 |
mithro | MaZderMind: okay | 12:53 |
mithro | MaZderMind: if you force push to the branch the PR comes from, then it'll drop all the old commits and just show the new ones | 12:53 |
MaZderMind | that's what I planned to do | 12:53 |
mithro | MaZderMind: great, thanks for all your work on this | 12:56 |
MaZderMind | *grml*, i'm really happy when that PR is merged ^^ I was not expecting that to take so long | 12:57 |
mithro | Testing things is hard :( | 13:00 |
MaZderMind | yep | 13:02 |
MaZderMind | but merging this will close ~10 issues at once | 13:06 |
mithro | MaZderMind: I have a solution for the recording issue you pointed out | 14:49 |
MaZderMind | mithro: which recording issue? | 14:52 |
mithro | https://github.com/timvideos/gst-switch/issues/200 | 14:52 |
tpb | Title: Composite-Output is 30fps, independent of configured format · Issue #200 · timvideos/gst-switch · GitHub (at github.com) | 14:52 |
MaZderMind | ahh ok. du you have an idea where this comes from? | 14:53 |
CarlFK | "foolproof method would be to run it inside a separate process" is that for production or because tests are failing ? | 14:53 |
MaZderMind | CarlFK: it's because a gstreamer-pipeline in the tests is stalling and thus the test is stalling until killed by travis | 14:55 |
CarlFK | that sounds like "because tests are failing" | 14:56 |
CarlFK | if it isn't for production, I think it is a little too much work. tests are nice, but so is using it in production | 14:57 |
MaZderMind | and we're talking about running parts of the test in a separate process | 14:57 |
CarlFK | and I am trying to discourage that :p | 14:57 |
MaZderMind | kk | 14:57 |
CarlFK | I keep trying to use it "for real" and run into blockers | 14:58 |
MaZderMind | to use 'what' for real? | 14:58 |
CarlFK | "quotes" cuz it would be like 1 talk user group meetings where complete fail is acceptable | 14:58 |
CarlFK | mixy (my short name for gst-switch) | 14:59 |
CarlFK | MaZderMind: have you used https://github.com/CarlFK/dvsmon | 15:02 |
tpb | Title: CarlFK/dvsmon · GitHub (at github.com) | 15:02 |
MaZderMind | I'm not sure if I get your point correct: you'd rather not test the audio pipeline? or test it in a less exact way then to have too complex tests? | 15:03 |
MaZderMind | CarlFK: no have not seen this tool. Our sources and sinks usually run in runsv and are configured via ansible | 15:04 |
CarlFK | above point: currently mixy is too broken to use in production. (unless things have changed and no one told me) | 15:06 |
CarlFK | I would rather not have a bunch of time spent making a test run when that time could be spent getting it working better | 15:06 |
CarlFK | dvsmon is handy for dev/testing. it's really just a little terminal manager. | 15:08 |
mithro | CarlFK: patches welcome | 15:10 |
CarlFK | im patching behavior :p | 15:10 |
mithro | CarlFK: Best way to do that is lead by example. | 15:20 |
CarlFK | notice I am not working on tests. | 15:20 |
CarlFK | I am working on packaging ... hopefully that will get some of the debian-video group spending time on it | 15:21 |
mithro | CarlFK: I don't see any open issues from you about gst-switch being unusable in production? | 15:27 |
CarlFK | mithro: would you try to use it in production? | 15:30 |
CarlFK | MaZderMind: if you needed to record something next week, would you use dvswitch? | 15:41 |
*** Niharika has joined #timvideos | 18:05 | |
*** CarlFK has quit IRC | 18:34 | |
*** Niharika has quit IRC | 19:32 |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!