| *** tpb has joined #timvideos | 00:00 | |
| *** shenki_ is now known as shenki | 01:15 | |
| *** mithro-laptop has quit IRC | 01:44 | |
| *** iiie0 has quit IRC | 02:28 | |
| Sewar | iiie: meeting? | 02:56 |
|---|---|---|
| iiie | yes | 02:58 |
| *** mithro-laptop has joined #timvideos | 02:59 | |
| iiie | hm, my button to get into chat in gmail seems to be hiding | 02:59 |
| iiie | could help if I were in the right account... | 03:00 |
| *** mithro-laptop has quit IRC | 03:15 | |
| Sewar | Thanks for the meeting iiie | 03:30 |
| iiie | And thank you! | 03:30 |
| Sewar | 'transaction.commit_on_success()' fixed Selenium issues :D | 04:03 |
| iiie | awesome! | 04:04 |
| Sewar | thanks iiie | 04:05 |
| *** hyades has joined #timvideos | 05:13 | |
| mithro | Hey Sewar, have you been running any type of linter over your code? | 06:37 |
| Sewar | mithro: rarely, because it has a lot of false positives | 06:40 |
| mithro | Sewar, oh? | 06:40 |
| mithro | Sewar, if your code has lots of false positives - generally there is something wrong with your style? | 06:40 |
| mithro | which linter are you using? | 06:41 |
| mithro | pylint? | 06:41 |
| Sewar | I need to find Django tailored lintrc | 06:41 |
| Sewar | yeah | 06:41 |
| Sewar | E1101:605,8:DetailedTimingForm.__init__: Instance of 'DetailedTimingForm' has no 'fields' member | 06:42 |
| mithro | https://chris-lamb.co.uk/projects/django-lint | 06:43 |
| tpb | Title: django-lint: Static analysis tool for Django projects lamby (at chris-lamb.co.uk) | 06:43 |
| mithro | Sewar, i'm sure #django might be able to point you in the right direction | 06:45 |
| Sewar | that looks nice, should give it a try | 06:45 |
| mithro | Sewar, also - what about pep8? | 06:45 |
| Sewar | mithro, I have pep8 in my editor and try to comply to it | 06:46 |
| mithro | https://github.com/kmmbvnr/django-jenkins/blob/master/django_jenkins/tasks/pylint.rc | 06:46 |
| tpb | <http://ln-s.net/-p4o> (at github.com) | 06:46 |
| mithro | Sewar, it would be good to add it as part of the travis-ci build | 06:47 |
| Sewar | mithro, and where can I pipe the output to? or just have it there in the build log? | 06:48 |
| mithro | just have it in the build log | 06:48 |
| Sewar | sounds good | 06:48 |
| mithro | your code should be pep8 clean | 06:48 |
| Sewar | it's, just checked | 06:49 |
| mithro | you can use # noqa is you need a violation for some reason | 06:49 |
| mithro | Sewar, great! so make the build fail if pep8 reports any issues :) | 06:49 |
| Sewar | ok :) | 06:50 |
| mithro | Oh | 06:51 |
| mithro | you probably want to not use self.browser.find_element_by_xpath | 06:51 |
| mithro | Sewar, either use the id or css class | 06:52 |
| mithro | that way when the page structure changes you won't have test failures | 06:52 |
| Sewar | well, if the code changes, tests need to be updated too? | 06:54 |
| mithro | css classes are useful because they are also what is used to display things | 06:54 |
| mithro | Sewar, tests shouldn't need updating 99% of the time | 06:54 |
| mithro | unless you actually change functionality | 06:54 |
| Sewar | ok | 06:55 |
| mithro | IE your test is trying to make sure you don't break functionality right | 06:57 |
| mithro | see ya! | 06:57 |
| *** mithro-laptop has joined #timvideos | 12:08 | |
| *** hyades has quit IRC | 12:41 | |
| *** hyades has joined #timvideos | 13:25 | |
| *** hyades has quit IRC | 15:14 | |
| *** hyades has joined #timvideos | 15:17 | |
| *** hyades has quit IRC | 15:47 | |
| *** hyades has joined #timvideos | 16:13 | |
| *** hyades has quit IRC | 16:20 | |
| *** hyades has joined #timvideos | 16:22 | |
| *** hyades has quit IRC | 16:49 | |
| *** hyades has joined #timvideos | 16:49 | |
| *** hyades has quit IRC | 17:03 | |
| *** hyades has joined #timvideos | 17:11 | |
| *** hyades has quit IRC | 17:17 | |
| *** hyades has joined #timvideos | 17:38 | |
| *** mithro-laptop has quit IRC | 17:42 | |
| *** hyades has quit IRC | 17:49 | |
| *** hyades has joined #timvideos | 18:03 | |
| *** hyades has quit IRC | 18:34 | |
| *** hyades has joined #timvideos | 18:47 | |
| *** hyades has quit IRC | 19:09 | |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!