| *** tpb has joined #timvideos | 00:00 | |
| *** Jahanzeb has joined #timvideos | 00:27 | |
| *** mithro has quit IRC | 00:46 | |
| *** iiie0 has quit IRC | 01:45 | |
| *** hyades has quit IRC | 02:07 | |
| *** Jahanzeb has quit IRC | 02:40 | |
| *** hyades has joined #timvideos | 02:46 | |
| *** hyades has quit IRC | 03:08 | |
| *** hyades has joined #timvideos | 03:09 | |
| *** hyades has quit IRC | 03:37 | |
| *** hyades has joined #timvideos | 03:38 | |
| *** hyades has quit IRC | 03:54 | |
| mithro-work | ~seen parx | 04:45 |
|---|---|---|
| tpb | mithro-work: parx was last seen in #timvideos 2 days, 3 hours, 32 minutes, and 38 seconds ago: <parx> Sewar, we should make up for the meeting that was skipped for PyOhio. Set a time with iiie when he returns. | 04:45 |
| *** hyades has joined #timvideos | 05:01 | |
| *** shenki has quit IRC | 08:53 | |
| *** hyades has quit IRC | 08:56 | |
| *** hyades has joined #timvideos | 09:00 | |
| *** shenki has joined #timvideos | 09:43 | |
| *** Jahanzeb has joined #timvideos | 10:57 | |
| *** bananadine has joined #timvideos | 11:12 | |
| *** mithro has joined #timvideos | 11:28 | |
| mithro | hello bananadine | 11:36 |
| bananadine | hi mithro | 11:36 |
| bananadine | i was looking for you yesterday | 11:36 |
| mithro | You make any progress? | 11:37 |
| bananadine | no | 11:38 |
| bananadine | i'm still stuck with the internal data flow problem | 11:38 |
| bananadine | http://pastebin.com/bFsiYqgN | 11:38 |
| tpb | Title: INFO [ 7817] jelly Jul 31 15:45:07 - Pastebin.com (at pastebin.com) | 11:38 |
| mithro | so what have you tried? | 11:39 |
| bananadine | printing out probe id's | 11:40 |
| bananadine | i could only do it on one probe | 11:40 |
| bananadine | i mean, one probe id | 11:40 |
| mithro | bananadine, why? | 11:40 |
| bananadine | i don't know | 11:40 |
| mithro | bananadine, why not? | 11:41 |
| bananadine | https://github.com/bananadine/flumotion/blob/master/flumotion/component/feedcomponent.py#L987 | 11:42 |
| tpb | <http://ln-s.net/-cne> (at github.com) | 11:42 |
| bananadine | it could only print out the id on this one | 11:42 |
| bananadine | i guess the code with the others doesn't run | 11:42 |
| bananadine | tried with an exception | 11:42 |
| bananadine | so if the exception didn't raise, the code does not run, right? | 11:44 |
| mithro | highly likely | 11:44 |
| bananadine | i tired printing bp_id (buffer probe id) right after this line (with correct indent) https://github.com/bananadine/flumotion/blob/master/flumotion/component/feedcomponent.py#L1065 | 11:45 |
| tpb | <http://ln-s.net/-cnj> (at github.com) | 11:45 |
| bananadine | tired then with raising an exception and still nothing | 11:45 |
| mithro | ummm | 11:45 |
| mithro | there is a bug in that code | 11:45 |
| bananadine | i know | 11:46 |
| bananadine | i made it all messy | 11:46 |
| bananadine | :/ | 11:46 |
| mithro | bananadine, so I think you should go back to looking at what the difference between this code and the original code is | 11:47 |
| bananadine | i'm doing this all the time | 11:47 |
| bananadine | like | 11:47 |
| bananadine | i have both opened in my editor | 11:47 |
| bananadine | there are a lot of differences | 11:47 |
| bananadine | mainly because everything probe related | 11:47 |
| bananadine | is done with add probe and remove probe now | 11:47 |
| mithro | you know about side-by-side diff programs right? | 11:48 |
| bananadine | haven't used one | 11:49 |
| *** Jahanzeb has quit IRC | 11:49 | |
| mithro | looking at diffs by hand is very error prone | 11:49 |
| bananadine | mithro, which program should i install? | 11:50 |
| mithro | meld, vimdiff, tkdiff | 11:50 |
| mithro | and reduce the changes as much as possible | 11:57 |
| *** shenki_ has joined #timvideos | 12:00 | |
| bananadine | yes this is much nicer | 12:00 |
| bananadine | the probe changes start from here | 12:01 |
| bananadine | unblock_eater | 12:01 |
| bananadine | https://github.com/bananadine/flumotion/blob/master/flumotion/component/feedcomponent.py#L664 | 12:02 |
| tpb | <http://ln-s.net/-coA> (at github.com) | 12:02 |
| bananadine | the probe callbacks should all be in this format: | 12:03 |
| bananadine | (GstPad *pad, | 12:04 |
| bananadine | GstPadProbeInfo *info, | 12:04 |
| bananadine | gpointer user_data); | 12:04 |
| *** shenki has quit IRC | 12:04 | |
| bananadine | is this right what i'm doing https://github.com/bananadine/flumotion/blob/master/flumotion/component/feedcomponent.py#L674 | 12:06 |
| tpb | <http://ln-s.net/-coM> (at github.com) | 12:06 |
| bananadine | and then | 12:06 |
| bananadine | https://github.com/bananadine/flumotion/blob/master/flumotion/component/feedcomponent.py#L675 | 12:06 |
| tpb | <http://ln-s.net/-coN> (at github.com) | 12:06 |
| mithro | 674 and 675 are the same? | 12:08 |
| bananadine | yes with one difference | 12:09 |
| bananadine | on 674 i assign the value to a variable | 12:09 |
| bananadine | return value* | 12:09 |
| mithro | yes | 12:09 |
| mithro | you can't do both though? | 12:09 |
| bananadine | what i wanted to ask is | 12:10 |
| bananadine | do i need line 675 | 12:10 |
| mithro | umm, what do you think? | 12:13 |
| bananadine | that i don't need it | 12:13 |
| bananadine | i'm doing the same as the line above just not assigning to a variable | 12:13 |
| mithro | correct | 12:14 |
| *** hyades has quit IRC | 12:21 | |
| bananadine | ugh | 12:21 |
| bananadine | there's stuff that needs more porting | 12:22 |
| bananadine | which i can't find in the porting guide | 12:22 |
| bananadine | going to fire up ipython and find out the correct names | 12:23 |
| bananadine | might need help from #gstreamer | 12:29 |
| bananadine | i can't find a replacement for gst.BUFFER_FLAG_IN_CAPS | 12:29 |
| *** shenki_ has quit IRC | 12:45 | |
| *** shenki has joined #timvideos | 12:47 | |
| bananadine | mithro, this uses as a callback function the same function it's in https://github.com/bananadine/flumotion/blob/master/flumotion/component/feedcomponent.py#L801 | 12:56 |
| bananadine | and | 12:56 |
| tpb | <http://ln-s.net/-cpv> (at github.com) | 12:56 |
| bananadine | buffer in def got_new_buffer(pad, buff, element): | 12:56 |
| bananadine | is in place of the PadProbeInfo argument | 12:57 |
| bananadine | which is wrong | 12:57 |
| mithro | bananadine, ? | 12:57 |
| bananadine | buff* | 12:58 |
| bananadine | buff shouldn't be a PadProbeInfo type | 12:58 |
| mithro | I have no idea, what does the documentation say? | 13:00 |
| bananadine | http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstPad.html#GstPadProbeCallback | 13:01 |
| tpb | <http://ln-s.net/-Vgh> (at gstreamer.freedesktop.org) | 13:01 |
| *** shenki has quit IRC | 13:02 | |
| bananadine | buff uses functions like: set_caps , caps and there's buff.flag_is_set | 13:02 |
| bananadine | none of which are characteristic to Gst.PadProbeInfo | 13:03 |
| *** hyades has joined #timvideos | 13:03 | |
| *** shenki has joined #timvideos | 13:04 | |
| mithro | bananadine, so what did the original code do? | 13:04 |
| bananadine | i tried to find out | 13:05 |
| bananadine | but it won't get run | 13:05 |
| *** CarlFK has quit IRC | 13:06 | |
| bananadine | i guess it's not needed in the configuration i'm using | 13:06 |
| bananadine | or it swallows up the exception | 13:06 |
| mithro | so if it's not used by the configuration you are using - then what has changed, why is it getting executed now? | 13:07 |
| bananadine | i'm not talking about the whole component here | 13:08 |
| bananadine | i'm talking about this function | 13:08 |
| bananadine | https://github.com/bananadine/flumotion/blob/master/flumotion/component/feedcomponent.py#L780 | 13:08 |
| tpb | <http://ln-s.net/-cqH> (at github.com) | 13:08 |
| mithro | if this function is never called, then? | 13:10 |
| mithro | and I think you probably want to look at | 13:11 |
| mithro | gst_pad_probe_info_get_buffer () | 13:11 |
| mithro | but there is no point at the moment trying to port code which is never called? | 13:11 |
| bananadine | oh yes | 13:12 |
| bananadine | it would be padprobeinfo in the argument and then change it to buffer in the function | 13:13 |
| bananadine | good | 13:13 |
| bananadine | mithro, but look at this | 13:16 |
| bananadine | https://developer.gnome.org/gstreamer/0.10/gstreamer-GstBuffer.html | 13:16 |
| tpb | <http://ln-s.net/-cqd> (at developer.gnome.org) | 13:16 |
| bananadine | in 0.10 GstBuffer had those functions used in got_new_buffer() | 13:17 |
| bananadine | but now | 13:17 |
| bananadine | http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstBuffer.html | 13:17 |
| tpb | <http://ln-s.net/-cqe> (at gstreamer.freedesktop.org) | 13:17 |
| bananadine | i can't find set_caps | 13:17 |
| bananadine | i can see that flag_is_set is there | 13:18 |
| mithro | Looks like caps is no longer a member | 13:19 |
| bananadine | GST_BUFFER_CAPS() is gone, caps are not set on buffers anymore but are set | 13:19 |
| bananadine | on the pads where the buffer is pushed on. Likewise GST_BUFFER_COPY_CAPS is | 13:19 |
| bananadine | not needed anymore. gst_buffer_get/set_caps() are gone too. | 13:19 |
| bananadine | yep | 13:19 |
| *** hyades has quit IRC | 13:19 | |
| mithro | bananadine, I can't make heads or tails of what the original function was trying to actually do | 13:29 |
| bananadine | all i can say is | 13:30 |
| bananadine | what i can read | 13:30 |
| bananadine | and i can read that the function is supposed to get a new buffer somehow? | 13:30 |
| mithro | bananadine, gst_pad_probe_info_get_buffer should convert the pad into a buff | 13:32 |
| mithro | https://github.com/timvideos/flumotion/commit/92370b0ab899d8853745ec4049a938036fee581a <-- that is the CL which adds the confusing code | 13:32 |
| tpb | <http://ln-s.net/-cr3> (at github.com) | 13:32 |
| *** hyades has joined #timvideos | 13:33 | |
| bananadine | right, but there wasn't a PadProbeInfo in gst 01.0 | 13:33 |
| bananadine | 0.10* | 13:33 |
| mithro | bananadine, and? | 13:34 |
| bananadine | and there wasn't any gst_pad_probe_info_get_buffer, so there's this function | 13:36 |
| bananadine | got_new_buffer() | 13:36 |
| mithro | bananadine, so I think we can just change this function to a logging message and "return True" | 13:36 |
| *** hyades has quit IRC | 13:37 | |
| bananadine | you mean just comment out everything | 13:37 |
| bananadine | and return True | 13:38 |
| mithro | And put a "self.warning('Some message to go here')" | 13:38 |
| bananadine | ok | 13:39 |
| bananadine | right, did that | 13:43 |
| bananadine | and as expected nothing changed in the outcome | 13:43 |
| bananadine | so i can cross this function off the suspect list | 13:44 |
| bananadine | and move down the code | 13:44 |
| bananadine | but first i gotta go do something | 13:44 |
| bananadine | bbl | 13:44 |
| mithro | bananadine, moving down the code is not a good approach | 13:49 |
| *** hyades has joined #timvideos | 13:55 | |
| bananadine | mithro, what do you mean? | 14:19 |
| *** hyades has quit IRC | 14:29 | |
| mithro | bananadine, I mean going from the top of the file slowly down it is probably going to take a long time | 14:29 |
| bananadine | mithro, i'm only looking at the changes | 14:32 |
| *** hyades has joined #timvideos | 14:33 | |
| bananadine | and from where i'm looking now there are only 200 lines till the end | 14:33 |
| mithro | well, I have to go to bed | 14:37 |
| *** Jahanzeb has joined #timvideos | 14:37 | |
| *** hyades has quit IRC | 14:46 | |
| *** hyades has joined #timvideos | 14:48 | |
| bananadine | well | 14:51 |
| bananadine | good night mithro | 14:51 |
| *** hyades has quit IRC | 14:57 | |
| *** hyades has joined #timvideos | 15:16 | |
| *** hyades has quit IRC | 15:18 | |
| *** hyades has joined #timvideos | 15:18 | |
| *** hyades has quit IRC | 15:23 | |
| *** hyades has joined #timvideos | 15:25 | |
| *** bananadine has quit IRC | 15:28 | |
| *** hyades has quit IRC | 15:29 | |
| *** hyades has joined #timvideos | 15:30 | |
| *** hyades has quit IRC | 15:30 | |
| *** Jahanzeb has quit IRC | 15:39 | |
| *** hyades has joined #timvideos | 16:03 | |
| *** mithro has quit IRC | 16:08 | |
| *** parx has joined #timvideos | 17:43 | |
| *** Jahanzeb has joined #timvideos | 17:45 | |
| *** CarlFK has joined #timvideos | 18:01 | |
| *** iiie0 has joined #timvideos | 18:04 | |
| *** hyades_ has joined #timvideos | 18:10 | |
| *** hyades_ has quit IRC | 18:12 | |
| *** hyades_ has joined #timvideos | 18:13 | |
| *** hyades_ has quit IRC | 18:13 | |
| *** hyades_ has joined #timvideos | 18:14 | |
| *** CarlFK has quit IRC | 18:15 | |
| *** hyades_ has quit IRC | 18:18 | |
| *** Jahanzeb has quit IRC | 18:24 | |
| *** CarlFK has joined #timvideos | 18:40 | |
| *** hyades has quit IRC | 19:30 | |
| *** hyades has joined #timvideos | 19:32 | |
| *** hyades has quit IRC | 19:38 | |
| *** CarlFK has quit IRC | 19:53 | |
| *** hyades has joined #timvideos | 19:59 | |
| *** parx1 has joined #timvideos | 20:09 | |
| *** parx has quit IRC | 20:11 | |
| *** parx1 is now known as parx | 20:27 | |
| *** hyades has quit IRC | 20:40 | |
| *** hyades has joined #timvideos | 20:57 | |
| *** hyades has quit IRC | 21:33 | |
| *** parx has left #timvideos | 22:27 | |
| *** CarlFK has joined #timvideos | 23:05 | |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!