| *** tpb has joined #symbiflow | 00:00 | |
| litghost | mithro: Bouncing between 050/056 is probably okay, as 050 is semi-random | 00:03 |
|---|---|---|
| litghost | mithro: 044/046 should probably be more stable | 00:03 |
| *** Vonter has quit IRC | 01:08 | |
| *** proteusguy has quit IRC | 01:15 | |
| hackerfoo | Has anyone considered using types in the SymbiFlow Python scripts? e.g. https://github.com/python-attrs/attrs | 01:17 |
| tpb | Title: GitHub - python-attrs/attrs: Python Classes Without Boilerplate (at github.com) | 01:17 |
| hackerfoo | A lot of the documentation seems to be listing the expected types. | 01:18 |
| *** proteusguy has joined #symbiflow | 01:20 | |
| *** Vonter has joined #symbiflow | 01:34 | |
| *** tweakoz has joined #symbiflow | 01:59 | |
| *** space_zealot has joined #symbiflow | 01:59 | |
| *** shenki has quit IRC | 03:14 | |
| *** space_zealot has quit IRC | 04:02 | |
| *** kraiskil has joined #symbiflow | 04:44 | |
| *** Vonter has quit IRC | 06:14 | |
| *** Miyu has joined #symbiflow | 06:21 | |
| *** adjtm has quit IRC | 06:22 | |
| *** adjtm has joined #symbiflow | 06:22 | |
| *** Vonter has joined #symbiflow | 06:42 | |
| *** xobs has quit IRC | 07:01 | |
| *** mrhat2010[m] has quit IRC | 07:01 | |
| *** alexhw[m] has quit IRC | 07:01 | |
| *** nrossi has quit IRC | 07:01 | |
| *** zeigren has quit IRC | 07:01 | |
| *** vitamin-q[m] has quit IRC | 07:01 | |
| *** nrossi has joined #symbiflow | 07:11 | |
| *** xobs has joined #symbiflow | 07:45 | |
| *** zeigren has joined #symbiflow | 07:45 | |
| *** alexhw[m] has joined #symbiflow | 07:45 | |
| *** vitamin-q[m] has joined #symbiflow | 07:45 | |
| *** Vonter has quit IRC | 07:45 | |
| *** mrhat2010[m] has joined #symbiflow | 07:45 | |
| *** Vonter has joined #symbiflow | 07:48 | |
| *** OmniMancer has joined #symbiflow | 08:09 | |
| *** kraiskil has quit IRC | 08:20 | |
| sf-slack2 | <acomodi> mithro: I think I don't understood correctly: you mean including the VtR CI test suite to the SymbiFlow-arch-defs repo? Or run VtR tests with Kokoro in the SymbiFlow/VtR fork? | 08:42 |
| *** adjtm has quit IRC | 09:30 | |
| *** citypw has joined #symbiflow | 09:37 | |
| *** _whitelogger has quit IRC | 09:44 | |
| *** _whitelogger has joined #symbiflow | 09:47 | |
| *** tweakoz has quit IRC | 10:17 | |
| *** adjtm has joined #symbiflow | 11:05 | |
| *** kraiskil has joined #symbiflow | 12:13 | |
| *** kraiskil has quit IRC | 12:18 | |
| *** Bertl_zZ is now known as Bertl | 12:27 | |
| *** kraiskil has joined #symbiflow | 12:31 | |
| *** somlo has quit IRC | 13:22 | |
| *** adjtm has quit IRC | 13:22 | |
| *** somlo has joined #symbiflow | 13:23 | |
| *** adjtm has joined #symbiflow | 13:40 | |
| *** space_zealot has joined #symbiflow | 13:49 | |
| *** lopsided98_ has quit IRC | 13:58 | |
| *** lopsided98 has joined #symbiflow | 14:00 | |
| *** space_zealot has quit IRC | 14:38 | |
| *** adjtm has quit IRC | 14:55 | |
| mithro | acomodi: I mean run VtR tests with Kokoro on the SymbiFlow/VtR fork | 15:09 |
| sf-slack2 | <acomodi> mithro: all right, instead of using Travis CI or alongside them? Because right now a standard CI run of VtR takes ~1h | 15:15 |
| sf-slack2 | <acomodi> mithro: which is acceptable I suppose | 15:16 |
| mithro | acomodi: I was thinking from the idea of getting you the QoR values automatically for every branch without you having to run things manually | 15:20 |
| sf-slack2 | <acomodi> mithro: Ah all right, I thought you meant to move to kokoro the standard Travis CI | 15:22 |
| mithro | acomodi: No | 15:23 |
| sf-slack2 | <acomodi> mithro: I think that it makes sense, but it would be better to kick off the builds manually | 15:23 |
| sf-slack2 | <acomodi> mithro: not everytime a commit is pushed | 15:23 |
| mithro | acomodi: Why? | 15:23 |
| sf-slack2 | <acomodi> mithro: Titan benchmarks take actually more than one day to finish on the cloud machine. If we have many branches that need to be checked simultaneously it could require a longer time (plus the fact that if running all the different benchmarks all at once RAM usage goes beyond 250G) | 15:26 |
| sf-slack2 | <acomodi> mithro: IMO it would be better to kick off a QoR measurements only when the branch is ready to be compared against master (with something like `force kokoro-run` label) | 15:27 |
| mithro | acomodi: Issue is there is no way to add a label just to a branch.... | 15:27 |
| litghost | mithro: Is there a cron equiv for kokoro? | 15:28 |
| mithro | litghost: Kinda... | 15:29 |
| *** kraiskil has quit IRC | 15:51 | |
| *** space_zealot has joined #symbiflow | 16:16 | |
| *** _whitelogger has quit IRC | 16:29 | |
| *** _whitelogger has joined #symbiflow | 16:32 | |
| *** somlo has quit IRC | 16:37 | |
| *** somlo has joined #symbiflow | 16:38 | |
| hackerfoo | litghost: I'm having trouble understanding how to handle multiple site instances of the same type, specifically {I,O]LOGICE3. | 17:32 |
| hackerfoo | https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/xc7/utils/prjxray_tile_import.py#L84-L108 | 17:32 |
| tpb | Title: symbiflow-arch-defs/prjxray_tile_import.py at master · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com) | 17:32 |
| litghost | I thought we were splitting the tile? | 17:33 |
| litghost | so each tile would end up having only one ILOGICE3? | 17:33 |
| hackerfoo | Should there be something like IOLOGICE3/IOLOGICE3H,IOLOGICE3/IOLOGICE3H in the --site_types argument? | 17:33 |
| hackerfoo | I was trying to implement the joining part first. | 17:34 |
| litghost | Ah, so simply joining the IOB and IOI? | 17:34 |
| hackerfoo | Yeah | 17:34 |
| litghost | Well if you ask the script to output the IOI3, it should just work | 17:34 |
| hackerfoo | Alternatively, how do I get the script to split on Y0/Y1? | 17:34 |
| litghost | What its doing is mapping multiples of the same site to num_pb, and then indexing them | 17:34 |
| hackerfoo | It works for RIOI3, but I don't want to manually implement the rest. | 17:35 |
| litghost | You'll need to write code to do anything other than just output either a tile as is, or a tile per site (which is not what we want in this case) | 17:35 |
| litghost | You'll need to implement something to handle 2 prjxray tiles -> 1 VPR tile | 17:35 |
| litghost | That has never been required prior to now | 17:35 |
| litghost | The script supports 1 prjxray tile -> 1 VPR tile and 1 prjxray tile -> 1 VPR tile per site | 17:36 |
| litghost | neither of which is what you want | 17:36 |
| hackerfoo | Okay. So I do need to implement splitting on some criteria. | 17:36 |
| hackerfoo | Maybe just hardcode splitting on Y for now. | 17:36 |
| litghost | I thought you just said that you were starting with joining and no split? | 17:37 |
| hackerfoo | I was, but the script doesn't seem to work at all when there are multiple sites of the same type. | 17:37 |
| hackerfoo | If I pass in one of each type to --site_types, the first line fails, if I pass in two, the second fails: https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/xc7/utils/prjxray_tile_import.py#L394-L416 | 17:39 |
| tpb | Title: symbiflow-arch-defs/prjxray_tile_import.py at master · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com) | 17:39 |
| hackerfoo | And it's not clear how to fix it, since it seems odd to pass in multiple of each type, but the script seems to expect it. | 17:40 |
| litghost | CLBLL_L import used to work, I expect you are just using it wrong | 17:40 |
| hackerfoo | Probably. But I still don't understand it. | 17:40 |
| litghost | https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/xc7/archs/artix7/tiles/clbll_l/CMakeLists.txt | 17:40 |
| tpb | Title: symbiflow-arch-defs/CMakeLists.txt at master · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com) | 17:40 |
| litghost | The old CLBLL_L tile CMake definition is still present | 17:41 |
| litghost | Does it work as expected? | 17:41 |
| litghost | It is worth noting that the 1 type per SITE_TYPES is not required, but was added later | 17:41 |
| litghost | Last time 1 tile, multiple sites was used is https://github.com/SymbiFlow/symbiflow-arch-defs/tree/393e85351aa3924df097547daddd77e29f3a3b79 | 17:43 |
| tpb | Title: GitHub - SymbiFlow/symbiflow-arch-defs at 393e85351aa3924df097547daddd77e29f3a3b79 (at github.com) | 17:43 |
| hackerfoo | Okay, so I need a file per instance: https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/xc7/primitives/slicel/CMakeLists.txt | 17:43 |
| tpb | Title: symbiflow-arch-defs/CMakeLists.txt at master · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com) | 17:43 |
| litghost | https://github.com/SymbiFlow/symbiflow-arch-defs/blob/393e85351aa3924df097547daddd77e29f3a3b79/artix7/tiles/clbll_l/CMakeLists.txt | 17:43 |
| tpb | Title: symbiflow-arch-defs/CMakeLists.txt at 393e85351aa3924df097547daddd77e29f3a3b79 · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com) | 17:43 |
| litghost | File per instance is not required | 17:43 |
| litghost | Or was not required in the past | 17:43 |
| litghost | File per instance was used for a bit for SLICEL because of a carry chain issue | 17:44 |
| litghost | Which is no longer relevant | 17:44 |
| hackerfoo | cmake seems to expect a target for each TYPE/INSTANCE in SITE_TYPES | 17:45 |
| litghost | Sort of | 17:47 |
| litghost | It wants a path-like thing | 17:47 |
| litghost | so ilogic3/ilogic3 is okay | 17:47 |
| litghost | So for example | 17:48 |
| litghost | SITE_TYPES ILOGIC3/ILOGIC3 ILOGIC3/ILOGIC3 | 17:48 |
| litghost | is probably fine | 17:48 |
| hackerfoo | No, it'll fail the assertion. | 17:49 |
| hackerfoo | They need different instance names. | 17:49 |
| litghost | Which assertion? | 17:50 |
| hackerfoo | https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/xc7/utils/prjxray_tile_import.py#L413-L415 | 17:50 |
| tpb | Title: symbiflow-arch-defs/prjxray_tile_import.py at master · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com) | 17:50 |
| hackerfoo | `site_instance` is the name | 17:51 |
| litghost | Agreed that assertion will fire, but I think in this case the code is overly restrictive, it just needs a proper key. The assertion should read: | 17:52 |
| litghost | "is the key to site_type_ports unique" | 17:53 |
| litghost | Which the current code fails if you repeat a site instance type | 17:53 |
| litghost | object_ref (https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/xc7/utils/prjxray_tile_import.py#L76) supports site instance indicies | 17:53 |
| tpb | Title: symbiflow-arch-defs/prjxray_tile_import.py at master · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com) | 17:53 |
| litghost | In the short term, making N copies of the IOI sites will resolve the relevant issue | 17:54 |
| litghost | But prjxray_tile_import can/did support multiple instances of a single site | 17:54 |
| litghost | And the cells_idx list is still being built https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/xc7/utils/prjxray_tile_import.py#L390 | 17:56 |
| tpb | Title: symbiflow-arch-defs/prjxray_tile_import.py at master · SymbiFlow/symbiflow-arch-defs · GitHub (at github.com) | 17:56 |
| *** tweakoz has joined #symbiflow | 17:57 | |
| *** kraiskil has joined #symbiflow | 18:04 | |
| *** OmniMancer has quit IRC | 18:08 | |
| *** kraiskil has quit IRC | 19:17 | |
| *** Bertl is now known as Bertl_oO | 19:27 | |
| *** Miyu has quit IRC | 19:39 | |
| mithro | FYI - I have pushed the latest database as of a couple of hours ago | 22:02 |
| *** Bertl_oO is now known as Bertl_zZ | 22:53 | |
| hackerfoo | It looks like I have to make the same modifications to prjxray_physical_tile_import.py to merge tiles. | 23:20 |
| *** adjtm has joined #symbiflow | 23:59 | |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!