| *** tpb has joined #symbiflow | 00:00 | |
| *** OmniMancer has joined #symbiflow | 01:19 | |
| *** Bertl_oO is now known as Bertl_zZ | 03:55 | |
| *** _whitelogger has quit IRC | 04:29 | |
| *** proteusguy has quit IRC | 04:31 | |
| *** _whitelogger has joined #symbiflow | 04:31 | |
| *** proteusguy has joined #symbiflow | 04:43 | |
| *** proteusguy has quit IRC | 07:03 | |
| *** proteusguy has joined #symbiflow | 07:04 | |
| sf-slack2 | <arora.prayas> Hi @channel, I changed the vtr source code to fix two build warnings. I want to create a pull request for the same. While adding description for it, I saw that there should be an issue against the changes I propose. Do I file an issue first that can be reproduced to verify my changes ? | 07:38 |
|---|---|---|
| sf-slack2 | <kgugala> Hi @arora.prayas please open an issue where you describe the problem and then create PR where you link to the issue | 08:02 |
| sf-slack2 | <arora.prayas> Okay, thanks :) | 08:24 |
| *** futarisIRCcloud has quit IRC | 08:27 | |
| *** futarisIRCcloud has joined #symbiflow | 10:23 | |
| *** Bertl_zZ is now known as Bertl | 12:03 | |
| *** OmniMancer has quit IRC | 12:21 | |
| *** _whitelogger has quit IRC | 12:26 | |
| *** _whitelogger has joined #symbiflow | 12:28 | |
| *** futarisIRCcloud has quit IRC | 12:37 | |
| *** Bertl is now known as Bertl_oO | 13:01 | |
| sf-slack2 | <arora.prayas> I filed an issue for warnings while building vtr. Here: https://github.com/SymbiFlow/vtr-verilog-to-routing/issues/43 | 13:22 |
| tpb | Title: Warnings while bulding VTR · Issue #43 · SymbiFlow/vtr-verilog-to-routing · GitHub (at github.com) | 13:22 |
| sf-slack2 | <arora.prayas> I fixed the first two warnings(haven't created a pull request yet). The last warning for possibly dereferencing a null pointer is giving me a hard time. I tried various ways but haven't been able to get around it. One interesting thing to note is that there is no warning message for: _if (child_pbs != nullptr && has_modes())_ but, return child_pbs == nullptr; //or if(child_pbs != nullptr) give a warning: | 13:33 |
| sf-slack2 | *warning: potential null pointer dereference [-Wnull-dereference] if (child_pbs != nullptr) ^* | 13:33 |
| sf-slack2 | <arora.prayas> I am not trying to fixate on warning issues, neither do I want to waste anybody's time. But generally, any tool should build without any warnings in favour of the user. Often at building time, all warnings are treated as errors. | 13:37 |
| sf-slack2 | <arora.prayas> Any help would be appreciated :slightly_smiling_face: | 13:43 |
| *** adjtm has joined #symbiflow | 17:55 | |
| *** adjtm_ has quit IRC | 17:57 | |
| *** Bertl_oO is now known as Bertl_zZ | 18:10 | |
| *** _whitelogger has quit IRC | 21:11 | |
| *** _whitelogger has joined #symbiflow | 21:13 | |
Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!