| *** tpb has joined #melange | 00:00 | |
| *** DrJoel has quit IRC | 00:06 | |
| *** VirajSinha has joined #melange | 00:08 | |
| *** saurabhsood91_ has joined #melange | 00:09 | |
| *** saurabhsood91 has quit IRC | 00:10 | |
| *** VirajSinha_ has quit IRC | 00:10 | |
| *** guido__ has quit IRC | 00:31 | |
| *** VirajSinha has quit IRC | 01:13 | |
| *** r0bby_ has joined #melange | 01:20 | |
| *** desophos has quit IRC | 01:22 | |
| *** r0bby_ is now known as robbyoconnor | 01:25 | |
| *** robbyoconnor has quit IRC | 01:40 | |
| * nathanielmanista heads out for supper | 01:42 | |
| *** piyushbansal has quit IRC | 01:46 | |
| *** saurabhsood91_ has quit IRC | 02:07 | |
| *** desophos has joined #melange | 03:10 | |
| *** roonyH has joined #melange | 03:10 | |
| roonyH | hi | 03:14 |
|---|---|---|
| roonyH | I am working on issue 1647 | 03:14 |
| roonyH | I am looking for some help for the following | 03:15 |
| roonyH | I d like to get a link to the page where organization list is displayed just before adding a new task | 03:16 |
| roonyH | currently i am doing it in this way | 03:16 |
| roonyH | self.data.redirect.urlOf('gci_dashboard')+"#create_tasks" | 03:17 |
| roonyH | but "#create_tasks" is hardcoded | 03:17 |
| roonyH | any suggestions how to do this? | 03:18 |
| *** roonyH has quit IRC | 03:38 | |
| *** robbyoconnor has joined #melange | 03:48 | |
| *** roonyH has joined #melange | 04:04 | |
| *** yupbank has joined #melange | 04:58 | |
| *** roonyH has quit IRC | 05:08 | |
| *** desophos has quit IRC | 06:01 | |
| *** kkthecoder has joined #melange | 06:09 | |
| *** VirajSinha has joined #melange | 06:31 | |
| *** asmeurer__ has quit IRC | 06:43 | |
| *** desophos has joined #melange | 06:50 | |
| *** desophos has quit IRC | 07:12 | |
| *** asmeurer__ has joined #melange | 07:22 | |
| *** desophos has joined #melange | 07:26 | |
| *** kkthecoder has quit IRC | 07:30 | |
| *** bumbu_ has joined #melange | 07:38 | |
| *** desophos has quit IRC | 07:42 | |
| *** asmeurer__ has quit IRC | 07:47 | |
| *** iulians has joined #melange | 07:49 | |
| *** voxsim has joined #melange | 08:18 | |
| *** VirajSinha_ has joined #melange | 08:29 | |
| *** VirajSinha has quit IRC | 08:32 | |
| *** iulians has quit IRC | 08:55 | |
| *** MatthewWilkes is now known as mwilkes|away | 09:03 | |
| *** sanket has joined #melange | 09:11 | |
| *** mwilkes|away is now known as MatthewWilkes | 09:20 | |
| *** kkthecoder has joined #melange | 09:25 | |
| *** VirajSinha has joined #melange | 09:26 | |
| *** VirajSinha_ has quit IRC | 09:28 | |
| *** bumbu_ has quit IRC | 09:28 | |
| *** Darrel has joined #melange | 09:40 | |
| *** rihnapstor has joined #melange | 09:53 | |
| *** kkthecoder has quit IRC | 09:58 | |
| *** rihnapstor has quit IRC | 10:03 | |
| *** rihnapstor has joined #melange | 10:16 | |
| *** rihnapstor has quit IRC | 10:17 | |
| *** rihnapstor has joined #melange | 10:18 | |
| *** sanket has quit IRC | 10:19 | |
| *** piyushbansal has joined #melange | 10:20 | |
| *** VirajSinha has quit IRC | 10:26 | |
| *** sanket has joined #melange | 10:31 | |
| *** VirajSinha has joined #melange | 10:32 | |
| *** sanket has quit IRC | 10:47 | |
| *** sanket has joined #melange | 10:48 | |
| *** piyushbansal has quit IRC | 10:48 | |
| *** sanket has quit IRC | 11:02 | |
| *** rihnapstor has quit IRC | 11:07 | |
| *** bumbu has joined #melange | 11:15 | |
| *** bumbu has quit IRC | 11:16 | |
| *** bumbu has joined #melange | 11:16 | |
| *** rihnapstor has joined #melange | 11:21 | |
| *** bumbu1 has joined #melange | 11:42 | |
| *** bumbu has quit IRC | 12:03 | |
| *** rihnapstor has quit IRC | 12:03 | |
| *** MatthewWilkes is now known as mwilkes|away | 12:32 | |
| *** Darrel has quit IRC | 12:49 | |
| *** meria has joined #melange | 13:12 | |
| meria | hello sir.. | 13:12 |
| meria | this is abhinav here | 13:12 |
| meria | i need to talk to you regarding the gsoc project | 13:13 |
| *** banas has joined #melange | 13:13 | |
| meria | can i seek your attention for a moment? | 13:13 |
| *** banas has left #melange | 13:13 | |
| *** bumbu1 has quit IRC | 13:14 | |
| *** bumbu has joined #melange | 13:15 | |
| meria | i m interested in doing the project named "javascript tests"..please guide me about how to start it. | 13:16 |
| bumbu | have you ever done js testing before? | 13:17 |
| meria | no.....but i read about it recently ....and it fascinated me | 13:20 |
| meria | so can be done | 13:20 |
| *** madrazr has quit IRC | 13:23 | |
| bumbu | as you can see in project description the project already has set up Testem, Jasmine, PhantomJS. So your first step woulb be reading and trying these things | 13:24 |
| bumbu | *would | 13:25 |
| meria | since i m a first year undergraduate student...and have an above average knowledge of javascript... | 13:26 |
| meria | so i will have to start from the very basic of these platform | 13:27 |
| meria | so what exactly do i need to do to get to that level so that i can accomplish the project? | 13:28 |
| bumbu | Next step would be set up these things by yourself in order to understand how do they work. | 13:29 |
| bumbu | Also try to do some simple tests. You can search for examples in other big projects. | 13:29 |
| bumbu | Then try to write and run some tests on this project. | 13:29 |
| meria | if i m not wrong, the project deals with the improvement of existing testing platforms or writing developing a new one? | 13:32 |
| *** piyushbansal has joined #melange | 13:33 | |
| bumbu | As I now (but I know a little) testing environment is allready set, and your job is to write tests. Also you have to refactor existing javascript | 13:34 |
| bumbu | If you don't know JS (JavaScript) well enough then you have some time to read more about it. Maybe some good practicies how it should be. | 13:34 |
| voxsim | hi meria, if you want example, watch my patches in mailing list | 13:37 |
| voxsim | about tests bla bla | 13:37 |
| meria | actually, i know js quite well but i dont know that my knowledge is sufficient for handling this project | 13:38 |
| voxsim | they are using jasmine, labjs, jquery and other js libraries | 13:38 |
| meria | i m comfortable with jquery...but i need to see the other libraries | 13:40 |
| meria | cool...so my first step should be reading and trying the existing environments ..ryt | 13:40 |
| *** mwilkes|away is now known as MatthewWilkes | 13:41 | |
| voxsim | yes, try to request something in the mailing list, or try just to checkout melange, build and run tests (read getting started in wiki) | 13:42 |
| *** kkthecoder has joined #melange | 13:43 | |
| *** roonyH has joined #melange | 13:48 | |
| meria | thnx a lot | 13:51 |
| *** Merio has joined #melange | 13:57 | |
| *** ChanServ sets mode: +o Merio | 13:57 | |
| piyushbansal | Hi Merio | 14:05 |
| piyushbansal | Can you please have a look at https://code.google.com/p/soc/source/browse/tests/app/soc/modules/gci/logic/test_profile.py?spec=svn1e2054422de9c747b0d4689ed18f1056998a9555&r=1e2054422de9c747b0d4689ed18f1056998a9555#128 | 14:07 |
| tpb | <http://ln-s.net/-1B3> (at code.google.com) | 14:07 |
| Merio | hi piyushbansal | 14:07 |
| piyushbansal | I could not understand lennie's comment very clearly | 14:08 |
| Lennie | piyushbansal, which one? | 14:08 |
| piyushbansal | At line 128. | 14:08 |
| piyushbansal | "Weird thing is I would swear that student.scope should give you a GCIProgram." | 14:09 |
| Lennie | program = student.scope | 14:09 |
| Lennie | see if test passes :) | 14:09 |
| Merio | I think that means that you can get the GCIProgram by accessing student.scope without having to create a new one | 14:09 |
| Merio | Oh Lennie there you are :) | 14:09 |
| piyushbansal | hi Lennie :) | 14:09 |
| Lennie | Merio, could you take a look at the JS test patches we got? | 14:09 |
| piyushbansal | Lennie: could you please have a look at https://code.google.com/r/piyushdevel-melange/source/detail?r=7c6f55b6512571707a35dded629c71bc7563563c | 14:10 |
| tpb | <http://ln-s.net/-1B8> (at code.google.com) | 14:10 |
| piyushbansal | I mean, there I have written a comment( comment no 3) | 14:10 |
| Lennie | yeah you are passing in the student | 14:11 |
| Lennie | not a program | 14:11 |
| Lennie | try student.scope | 14:11 |
| piyushbansal | task = gci_task_utils.GCITaskHelper(student.scope).createTask( | 14:11 |
| piyushbansal | 'Open', self.foo_org, foo_mentor, student) | 14:11 |
| Merio | Lennie: I'm already in contact with him | 14:12 |
| piyushbansal | I am passing student.scope , in place of the program that I created earlier | 14:12 |
| Lennie | hmm | 14:12 |
| Lennie | ok | 14:12 |
| Lennie | sigh test cases | 14:12 |
| Lennie | program = tests.program_utils.GCIProgramHelper().createProgram() | 14:12 |
| Lennie | and then on 120 | 14:12 |
| Lennie | have a 'scope' : program entry | 14:12 |
| Lennie | (essentially move 128 up to the top) | 14:13 |
| *** VirajSinha has quit IRC | 14:13 | |
| piyushbansal | Are you talking about the method def testHasCreatedOrModifiedTask(self): | 14:13 |
| Lennie | yes | 14:13 |
| piyushbansal | So if in place of 128 I write program = student.scope | 14:14 |
| piyushbansal | What more changes do I have to do | 14:14 |
| Lennie | Well you wouldn't need to write that anymore | 14:15 |
| Lennie | take the way it was in your patch, remove line 128 | 14:15 |
| Lennie | and start the method with | 14:15 |
| Lennie | program = tests.program_utils.GCIProgramHelper().createProgram() | 14:15 |
| Lennie | student_properties = {'is_student': True , 'scope': program} | 14:15 |
| piyushbansal | Oh, but would it save some computation ? | 14:16 |
| piyushbansal | I mean, I can not see why is doing this better approach than I have followed ? | 14:16 |
| Lennie | Because it would fail if I were to write a simple assertino where task.program == student.scope | 14:18 |
| Lennie | which is true during normal operations but not in these tests | 14:18 |
| piyushbansal | Oh okay, got it | 14:18 |
| Lennie | ( you are not the one to blame, the rest of the tests in this module are also wrong) | 14:18 |
| Lennie | In simple terms, it would create a task for program X with a student in program Y | 14:19 |
| piyushbansal | Good point, tests should work exactly as the real world scenario | 14:19 |
| Lennie | which doesn't make sense | 14:19 |
| piyushbansal | Yeah, got it :D | 14:19 |
| Lennie | (Don't fix the other tests though) | 14:19 |
| Lennie | not in this patch at least | 14:19 |
| piyushbansal | Okay, I would just modify the the line where you have commented, and make a new commit | 14:19 |
| Lennie | The smaller the change the earlier it can be submitted :) | 14:19 |
| piyushbansal | Thanks for pointing out, I have also changed the status as you pointed out that it cannot be Open once it is assigned | 14:20 |
| piyushbansal | I could not realise it myself :D | 14:20 |
| Lennie | yeah, nathanielmanista would this fall under "we need assertion on data consistency?" | 14:20 |
| Lennie | It's easy to miss | 14:20 |
| Lennie | and the code should have given you an error | 14:20 |
| piyushbansal | Code actually should have, I mean logically speaking. | 14:22 |
| piyushbansal | But I did not get any error, so it was easy to overlook | 14:22 |
| piyushbansal | Though it is a mistake, I agree | 14:22 |
| Lennie | yes but not yours :) | 14:23 |
| piyushbansal | Also would you please have a look once at https://code.google.com/r/piyushdevel-melange/source/detail?r=76d2914cba319d5ca401bb4abcc011d5b8653867 | 14:26 |
| tpb | <http://ln-s.net/-1BK> (at code.google.com) | 14:26 |
| piyushbansal | I have made all the changes and you and nathaniel suggested, point out any if some are still left. | 14:26 |
| piyushbansal | Oops a typo in the commit message :| | 14:27 |
| *** voxsim has quit IRC | 14:27 | |
| Lennie | piyushbansal, i'd say ping the thread that you are ready? I'm confident Nathaniel will see it | 14:27 |
| piyushbansal | Lennie : Also tell me if I need to change the commit message in ^ | 14:28 |
| piyushbansal | Thread ? | 14:28 |
| piyushbansal | which one ? | 14:28 |
| Lennie | I have to get back to work now though | 14:28 |
| Lennie | piyushbansal, the comments on the revision | 14:29 |
| piyushbansal | Oh, okay, nevermind, nathaniel would have a look | 14:29 |
| Lennie | https://code.google.com/r/piyushdevel-melange/source/detail?r=7c6f55b6512571707a35dded629c71bc7563563c | 14:29 |
| tpb | <http://ln-s.net/-1B8> (at code.google.com) | 14:29 |
| Lennie | piyushbansal, you can rewrite that last commit if you'd like | 14:29 |
| Lennie | it hasn't been merged yet | 14:29 |
| piyushbansal | Okay, got it thanks a lot for your time | 14:29 |
| Lennie | http://stackoverflow.com/questions/179123/how-do-i-edit-an-incorrect-commit-message-in-git | 14:29 |
| tpb | <http://ln-s.net/-1BR> (at stackoverflow.com) | 14:29 |
| piyushbansal | Oh, so I would change the commit message | 14:29 |
| Lennie | might help | 14:29 |
| piyushbansal | Great , never did that before :D | 14:30 |
| piyushbansal | Thanks a lot, done ! | 14:31 |
| *** rihnapstor has joined #melange | 15:01 | |
| *** saurabhsood91 has joined #melange | 15:06 | |
| rihnapstor | Hi Merio :) voxsim always working on same project as am I.can I continue my work or focus on Javascript List Enhancement project ? | 15:09 |
| rihnapstor | *always = also | 15:10 |
| *** bumbu has quit IRC | 15:10 | |
| *** VirajSinha has joined #melange | 15:24 | |
| rihnapstor | Merio: you there ? | 15:48 |
| *** sanket has joined #melange | 15:48 | |
| * rihnapstor brb | 15:58 | |
| *** rihnapstor has quit IRC | 15:59 | |
| *** tpb has quit IRC | 15:59 | |
| *** tpb has joined #melange | 15:59 | |
| *** VirajSinha_ has joined #melange | 16:05 | |
| *** VirajSinha has quit IRC | 16:08 | |
| *** roonyH has quit IRC | 16:22 | |
| *** sanket has quit IRC | 16:28 | |
| *** BlankVerse has joined #melange | 16:30 | |
| *** carols has joined #melange | 16:31 | |
| *** yupbank has quit IRC | 16:33 | |
| *** sanket has joined #melange | 16:34 | |
| *** tpb has joined #melange | 16:45 | |
| *** VirajSinha_ has quit IRC | 16:46 | |
| *** VirajSinha has joined #melange | 16:48 | |
| *** roonyH has quit IRC | 16:51 | |
| *** VirajSinha_ has joined #melange | 16:51 | |
| *** VirajSinha has quit IRC | 16:54 | |
| *** VirajSinha_ has quit IRC | 16:55 | |
| *** VirajSinha has joined #melange | 16:57 | |
| *** meria has quit IRC | 16:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!