| *** tpb has joined #melange | 00:00 | |
| *** mang0 has quit IRC | 00:23 | |
| *** SinnerShanky has quit IRC | 00:26 | |
| *** banas has quit IRC | 00:43 | |
| *** r0bby has joined #melange | 00:50 | |
| *** r0bby has quit IRC | 01:06 | |
| *** r0bby has joined #melange | 01:12 | |
| *** madrazr has joined #melange | 01:23 | |
| *** ChanServ sets mode: +o madrazr | 01:23 | |
| *** r0bby has quit IRC | 02:08 | |
| *** r0bby has joined #melange | 02:09 | |
| *** r0bby has quit IRC | 02:22 | |
| *** r0bby has joined #melange | 02:23 | |
| *** r0bby has quit IRC | 02:30 | |
| *** roonyH has joined #melange | 02:31 | |
| *** madrazr has quit IRC | 02:38 | |
| *** roonyH has quit IRC | 03:01 | |
| *** manugupt1 has quit IRC | 03:08 | |
| *** manugupt1 has joined #melange | 03:11 | |
| *** r0bby has joined #melange | 03:14 | |
| *** madrazr has joined #melange | 03:27 | |
| *** ChanServ sets mode: +o madrazr | 03:27 | |
| *** r0bby has quit IRC | 04:04 | |
| *** Strik3r has quit IRC | 04:15 | |
| *** banas has joined #melange | 04:15 | |
| *** r0bby has joined #melange | 04:16 | |
| *** Strik3r has joined #melange | 04:41 | |
| *** Strik3r has left #melange | 04:42 | |
| *** r0bby_ has joined #melange | 04:52 | |
| *** rihnapstor has joined #melange | 04:55 | |
| *** r0bby has quit IRC | 04:56 | |
| *** banas has quit IRC | 04:58 | |
| *** rihnapstor has quit IRC | 05:14 | |
| *** rihnapstor has joined #melange | 05:26 | |
| *** shachaf_ has joined #melange | 06:08 | |
| *** shachaf_ has joined #melange | 06:08 | |
| *** shachaf has quit IRC | 06:08 | |
| *** shachaf_ is now known as shachaf | 06:08 | |
| *** SinnerShanky has joined #melange | 06:24 | |
| *** Merio has joined #melange | 06:31 | |
| *** ChanServ sets mode: +o Merio | 06:31 | |
| *** asmeurer has quit IRC | 06:37 | |
| *** rodney757 has joined #melange | 06:38 | |
| *** banas has joined #melange | 06:39 | |
| *** desophos has joined #melange | 07:14 | |
| rihnapstor | me brb | 07:27 |
|---|---|---|
| *** rihnapstor has quit IRC | 07:28 | |
| *** r0bby_ has quit IRC | 08:01 | |
| *** rihnapstor has joined #melange | 08:02 | |
| *** Merio has quit IRC | 08:46 | |
| *** Merio has joined #melange | 08:46 | |
| *** ChanServ sets mode: +o Merio | 08:46 | |
| rihnapstor | Hello Merio :) | 08:47 |
| Merio | Hello rihnapstor, how are you? | 08:48 |
| rihnapstor | i am good :) Merio | 08:50 |
| Merio | rihnapstor: how is it going with Jasmine? If you need any further assistance (also if you want to go ahead and try to put some actual tests on melange) just let me know. Unfortunately I'm gonna be busy from now until... I don't know, probably 1 or 2 hours, but just write the questions here if you have any and I will get back to you asap | 08:50 |
| *** rihnapstor has quit IRC | 08:57 | |
| *** rihnapstor has joined #melange | 09:09 | |
| *** Merio has quit IRC | 09:10 | |
| *** rihnapstor has quit IRC | 09:30 | |
| *** manugupt1 has quit IRC | 09:45 | |
| *** manugupt1 has joined #melange | 09:49 | |
| *** manugupt1 has joined #melange | 09:49 | |
| *** voxsim has joined #melange | 09:55 | |
| voxsim | Hi, I'm interested in Javascript Tests and Javascript List Enhancements, could I ask something about these two ideas? They are still free? And I try to see if there is any issues or bug in the software, but all issues have been assigned | 10:09 |
| *** piyushbansal has joined #melange | 10:18 | |
| *** snizzo has joined #melange | 10:22 | |
| *** voxsim has quit IRC | 10:23 | |
| *** snizzo has quit IRC | 10:43 | |
| *** banas has quit IRC | 12:03 | |
| *** Strangerke has left #melange | 12:05 | |
| *** madrazr has quit IRC | 12:35 | |
| *** Merio has joined #melange | 12:39 | |
| *** ChanServ sets mode: +o Merio | 12:39 | |
| *** snizzo has joined #melange | 13:18 | |
| *** DrJoel has joined #melange | 13:44 | |
| DrJoel | Any Melange devels awake or should I just preemptively move to the mailing list? | 13:45 |
| *** banas has joined #melange | 13:50 | |
| Merio | Hi Dr Joel, how are you? | 13:54 |
| Merio | Welcome :) | 13:54 |
| piyushbansal | Hi Lennie | 13:55 |
| DrJoel | Merio just battling Melange :) | 13:58 |
| DrJoel | We seem to get some folks signed up and others Melange doesn't like | 13:58 |
| DrJoel | And I stupidly invited myself to be a mentor before I realized admin implies mentor so that can't be deleted | 13:58 |
| Merio | Dr Joel, let me try to ping the right guys :) | 14:03 |
| DrJoel | Thanks. I think I made a mistake by using connect by email. It seems buggy. | 14:03 |
| DrJoel | Connections initiated by others seem to be more reliable | 14:04 |
| piyushbansal | Merio : Hi | 14:13 |
| DrJoel | brb .. printer at home broken.. meeting son at university with his homework.. printers suck | 14:16 |
| *** antrik_ has quit IRC | 14:17 | |
| *** scorche has quit IRC | 14:17 | |
| *** arun has quit IRC | 14:17 | |
| *** antrik_ has joined #melange | 14:19 | |
| *** scorche has joined #melange | 14:19 | |
| *** arun has joined #melange | 14:19 | |
| piyushbansal | Merio : I am not able to run functional tests , this error shows up "WebDriverException: Message: "Can't load the profile. Profile Dir: /tmp/tmpZqsLBC Firefox output: *** LOG addons.xpi: startup\n*** LOG addons.xpi: checkForChanges\n*** LOG addons.xpi: No changes found\n"" | 14:25 |
| piyushbansal | Any ideas , why ? | 14:25 |
| Merio | Dr Joel: Can you send a mail to the mailing list? I think it's the optimal solution right now | 14:27 |
| Merio | piyushbansal: I don't have anything on top of my head unfortunately... can you send a mail to the mailing list, so probably Syed could jump in the conversation? | 14:28 |
| piyushbansal | Merio : Okay sure, thanks a lot for the information. | 14:29 |
| piyushbansal | Merio: btw, just one thing, is it possible to configure to use chrome for selenium testing ? | 14:30 |
| piyushbansal | Where do I make changes for functional tests to use chrome webtdriver ? | 14:30 |
| Merio | piyushbansal: I think firefox is hard coded now, but I'm not 100% sure | 14:31 |
| piyushbansal | Oh okay , I'll just check , if it can be done on chrome | 14:32 |
| *** rihnapstor has joined #melange | 14:39 | |
| DrJoel | Merio I wil .. thanks. | 14:40 |
| rihnapstor | Merio: hey ! where can i access the IRC chat logs ? | 14:41 |
| *** nopper has quit IRC | 14:57 | |
| dreimark | hi, is there another issue that a potential mentor can't apply for a project ? | 14:57 |
| dreimark | tpb: ^ | 14:57 |
| dreimark | sorry | 14:57 |
| dreimark | ThomasWaldmann: ^^ | 14:57 |
| DrJoel | Each year you select student or mentor.. you can't switch | 14:57 |
| DrJoel | A mentor can see all proposals so during the early part it would be unfair to submit a proposal and be a mentor | 14:58 |
| DrJoel | I suppose a rejected student could want to switch to mentor.. but I don't recall that coming up | 14:59 |
| dreimark | is start a connection working currently ? | 15:07 |
| DrJoel | It appears to be... my experience is that it is mostly working to invite mentors | 15:08 |
| DrJoel | But an org admin is implicitly a mentor so if you want more co-admins, ask them to do that first | 15:08 |
| DrJoel | and they will implicitly be mentors | 15:08 |
| dreimark | Merio: we have problems to get one of our "wanted mentors" getting into the project | 15:09 |
| dreimark | he don't see" | 15:10 |
| *** nopper has joined #melange | 15:10 | |
| dreimark | "Start a Connection" | 15:10 |
| DrJoel | You could invite them... http://www.google-melange.com/gsoc/connect/google/gsoc2013/MYORG (replace MYORG) | 15:11 |
| *** jenmylo has joined #melange | 15:11 | |
| dreimark | cool, i try | 15:13 |
| *** manugupt1 has quit IRC | 15:16 | |
| *** manugupt1 has joined #melange | 15:20 | |
| *** manugupt1 has joined #melange | 15:20 | |
| *** Lennie has quit IRC | 15:23 | |
| *** DrJoel has left #melange | 15:23 | |
| *** Lennie has joined #melange | 15:26 | |
| *** ChanServ sets mode: +o Lennie | 15:26 | |
| *** saurabhsood91 has joined #melange | 15:45 | |
| dreimark | that solved it | 15:46 |
| Merio | dreimark: sorry I couldn't reply earlier. is everything fine now? | 15:56 |
| Merio | rihnapstor: it's in the channel topic: --> http://www.thousandparsec.net/~irc/logm/ | 15:56 |
| tpb | Title: IRC logs (at www.thousandparsec.net) | 15:56 |
| *** carols has joined #melange | 15:58 | |
| *** snizzo has quit IRC | 16:02 | |
| rihnapstor | thanks Merio :) | 16:12 |
| Merio | rihnapstor: yw :) | 16:13 |
| *** saurabhsood91 has quit IRC | 16:21 | |
| dreimark | Merio: i was able to invite the mentor, but i can't verify if want to be mentors can "start a connection" | 16:26 |
| * rihnapstor brb | 16:30 | |
| *** rihnapstor has quit IRC | 16:32 | |
| *** carols has quit IRC | 16:35 | |
| *** carols has joined #melange | 16:37 | |
| *** mang0 has joined #melange | 16:52 | |
| *** mang0 has joined #melange | 16:52 | |
| *** banas_ has joined #melange | 17:02 | |
| *** banas has quit IRC | 17:03 | |
| *** banas_ is now known as banas | 17:04 | |
| *** rihnapstor has joined #melange | 17:04 | |
| piyushbansal | hi rihnapstor :) | 17:17 |
| rihnapstor | hey piyushbansal :) | 17:19 |
| nathanielmanista | Hello to both of you. :-) | 17:22 |
| piyushbansal | hello nathanielmanista :) | 17:23 |
| rihnapstor | hie nathanielmanista | 17:29 |
| rihnapstor | :) | 17:29 |
| rihnapstor | Merio: studying Melange codebase. As you mentioned earlier that BDD test with for jasmine js is a learning curve,can you point me to bugs or any tests code that i can start writing and experimenting with Melange js . | 17:38 |
| piyushbansal | nathanielmanista : Do you have any idea about selenium as used by melange | 17:50 |
| piyushbansal | I mean, have we hard coded it to use firefix webdriver, or can we configure it to chrome as well ? | 17:51 |
| piyushbansal | I have firefox 20 and I guess selenium doesn't work well with ff>=16 | 17:51 |
| piyushbansal | Also I posted somewhere in the chat above with Merio, that I was having an error, while using firefox, that is probably due to version incompatibility bw ff and selenium | 17:52 |
| piyushbansal | What do you think ? | 17:52 |
| rodney757 | Hi | 17:55 |
| rodney757 | I am interested in participating in GSOC | 17:55 |
| rodney757 | One project that looked interesting to me was the Messaging System | 17:56 |
| Merio | rihnapstor: let me think about it | 17:56 |
| rodney757 | What skill level do you think is need to accomplish that project? | 17:56 |
| Merio | rodney757: hi and welcome to Melange :) Can you send a mail in the mailing list about it? Not everyone is here on chat so it would be easier for the others to answer you | 17:57 |
| rodney757 | sure | 17:57 |
| *** nikunj_ has joined #melange | 18:00 | |
| nikunj_ | Is it necessary to use python for listed projects? | 18:03 |
| nathanielmanista | piyushbansal: I don't have any strong opinion about how selenium is used and configured for our tests - probably Merio can give the best guidance. | 18:05 |
| Merio | nikunj_: as you can see in our ideas page -> https://code.google.com/p/soc/wiki/GSoC2013Ideas there is one of them which only needs javascript skills | 18:05 |
| tpb | <http://ln-s.net/+z_O> (at code.google.com) | 18:05 |
| Merio | nathanielmanista, piyushbansal: not really, Syed or Leo would be the best people to talk with. I can just have a look at the code | 18:05 |
| *** carols has quit IRC | 18:06 | |
| nikunj_ | yes but I am interseted in javascript List Enhancement.And i think it requires python | 18:07 |
| *** carols has joined #melange | 18:08 | |
| *** rodney757 has left #melange | 18:09 | |
| Merio | nikunj_: yes, I've just fixed the relevant skills there. They were listed in the text but not in the relevant skills part | 18:09 |
| *** rodney757 has joined #melange | 18:09 | |
| rihnapstor | Merio: ok i wrote a multiply function and tested it with jasmine as an excercise :D | 18:10 |
| Merio | rihnapstor: cool. If you want to try and get your feet wet with melange testing, you could try and see if you can test the unpack function here https://code.google.com/p/soc/source/browse/app/soc/content/js/melange.dependency.js#410 | 18:13 |
| tpb | <http://ln-s.net/+z_Z> (at code.google.com) | 18:13 |
| nikunj_ | and ya in javascript tests project are we required to implement test cases or we need to implement some framework for written javascript code? | 18:14 |
| * rihnapstor looks | 18:15 | |
| Merio | rihnapstor: this is however in a private variable inside a self invoking function, so I'm not 100% sure you can access it using Jasmine. You can try and see if that's possible somehow and that would be very interesting if we're allowed to do so. If that's not possible you can make it a public function temporarily changing it from "var unpack" to "$m.unpack" and test the tweaked javascript code. | 18:15 |
| Merio | nikunj_: the javascript testing framework is in place but we have no tests yet. Since we didn't have test for those things yet, we are not 100% sure the architecture that is in place is sufficient for our goals, so there is much room for driving the whole JS testing thing | 18:16 |
| Merio | nikunj_, rihnapstor: also there's the possibility that the current code is not 100% testable, so we might need to change it to requirejs (see https://code.google.com/p/soc/issues/detail?id=1748) in order to be more easily testable. I will write these details as soon as possible. | 18:18 |
| tpb | <http://ln-s.net/+z_d> (at code.google.com) | 18:18 |
| Merio | nikunj_, rihnapstor: but probably changing everything to requirejs is a whole gsoc project in itself | 18:19 |
| nikunj_ | i think if inplace framework is not sufficient then we should go for it as gsoc project | 18:20 |
| Merio | nikunj_: well, actually, I don't think tweaking the current framework is a whole gsoc project in itself, unless we have proof of what has to be changed, why and what the actual effort would be | 18:21 |
| desophos | hi everyone, i'm interested in GSoC and the 'Integration of Summer of Code's "Connections" subsystem with Code-in' project looks interesting and doable with my skills. | 18:22 |
| desophos | so i'd just like to start to get acquainted with melange :) | 18:22 |
| Merio | rihnapstor: another possible attempt is to check the loadScripts function (same file, line 426). This is possibly a more difficult one to do, since it implies the understanding on how we load the additional javascript and css from arrays in the django templates, through the use of the rest of melange.dependency.js and LABJs and the unpack function itself (more info here: https://code.google.com/p/soc/wiki/JavascriptAndCSS) | 18:24 |
| tpb | <http://ln-s.net/+z_o> (at code.google.com) | 18:24 |
| Merio | desophos: Hi, you can have a look at our mailing lists, there are some questions about this already asked. If you don't find enough information you can send another email there | 18:24 |
| Merio | desophos: and welcome to Melange, of course :) | 18:25 |
| nikunj_ | Merio : it will be very helpful if you give me some idea about backend part of it. | 18:26 |
| nikunj_ | i forgot to mention i am talking about that list enhancement project | 18:26 |
| rihnapstor | Merio: are we also concern about IE ? ^^ | 18:32 |
| Merio | nikunj_: about the backend I'm not the best person to talk with, you should send a mail to the mailing list. What I can say is that currently the lists are always created in javascript by the scripts in app/soc/content/js/melange.list*, which use jqgrid (http://www.trirand.com/blog/) The way lists are behaving is dictated by the backend by the use of https://code.google.com/p/soc/source/browse/app/soc/views/helper/lists.py, which creates something compatible wit | 18:33 |
| tpb | Title: jQuery Grid Plugin jqGrid (at www.trirand.com) | 18:33 |
| Merio | rihnapstor: as far as I know IE is not officially supported | 18:34 |
| rihnapstor | ok | 18:34 |
| *** asmeurer has joined #melange | 18:35 | |
| Merio | nikunj_: the idea is not to do this everytime at least for some lists which don't need the advanced functions that JS lists have | 18:37 |
| Merio | nikunj_: or show an HTML list by default and make it an option to activate the JS ones in order for the user to have the advanced options on that list | 18:37 |
| Merio | advanced options meaning advanced features | 18:38 |
| Merio | like sorting, searching, adding/removing columns and stuff | 18:38 |
| nikunj_ | k i am just looking at the code and i'll try my best to find out someway to get rid of this problem. | 18:38 |
| Merio | Some features that are available on the lists are documented here in the manual -> http://en.flossmanuals.net/melange/lists-how-to/ | 18:39 |
| tpb | <http://ln-s.net/+zaK> (at en.flossmanuals.net) | 18:39 |
| Merio | nikunj_: sure, if you have any questions feel free to send a mail in the mailing list (have a look at least at the last week archive to make sure no other student has already asked the same question though ;)) | 18:40 |
| Merio | everybody: I need to head home now, it's starting to get very late here | 18:42 |
| nikunj_ | Merio : thank you for your guidance.good night | 18:42 |
| Merio | I will be available tomorrow as well, starting from about 8 UTC+1... depending on how busy I am at work I will try to do my best to be responsive enough :) | 18:43 |
| Merio | 8 UTC+1 being 8 AM UTC+1 of course | 18:43 |
| rihnapstor | Merio: how much code coverage will requirejs do ? and how do we use it with melange ? | 18:44 |
| Merio | nikunj_: you're welcome and thanks.. same to you :) | 18:44 |
| Merio | rihnapstor: requirejs is a different way of loading and modularize javascript, it's not something that is strictly related to testing | 18:45 |
| Merio | rihnapstor: we're currently using LABjs but they gave up since they're stable and basically requirejs has gained too much momentum in the JS world | 18:45 |
| Merio | more info here: http://requirejs.org/ | 18:45 |
| tpb | Title: RequireJS (at requirejs.org) | 18:45 |
| *** carols has quit IRC | 18:47 | |
| Merio | rihnapstor: some more information on why this is better here --> http://singlepageappbook.com/maintainability1.html | 18:48 |
| tpb | <http://ln-s.net/+za_> (at singlepageappbook.com) | 18:48 |
| Merio | rihnapstor: now I really have to go, see you tomorrow? :) | 18:49 |
| rihnapstor | Merio: ok so lots to learning ,but its interesting that this stuff is new to me :) | 18:50 |
| rihnapstor | Merio: gn you were really helpful :) | 18:51 |
| Merio | rihnapstor: cool, learning is always good :) | 18:51 |
| Merio | rihnapstor: glad to help! See you tomorrow and have a nice.... whatever it is in your timezone ^__^ | 18:51 |
| Merio | same for you nikunj_ | 18:51 |
| Merio | bye! | 18:51 |
| rihnapstor | bye! there Merio | 18:52 |
| rihnapstor | :) | 18:52 |
| nikunj_ | bye | 18:52 |
| *** Merio has quit IRC | 18:52 | |
| *** carols has joined #melange | 18:54 | |
| *** jgsmith has joined #melange | 19:05 | |
| jgsmith | the email icon on the org homepage seems to be for the public mailing list and not the email address under "Public Info" (where it says "Enter an email address to be used by would-be members seeking addition information.") - is this a bug or should I change the public mailing list address to be the email people should use for more info so the email icon on the org homepage is what people can use for more info? | 19:05 |
| *** jenmylo has quit IRC | 19:07 | |
| *** carols has quit IRC | 19:08 | |
| *** nikunj_ has quit IRC | 19:10 | |
| *** carols has joined #melange | 19:10 | |
| *** antrik_ is now known as antrik | 19:29 | |
| *** harlan_ is now known as harlan | 19:38 | |
| *** harlan has quit IRC | 19:41 | |
| *** harlan has joined #melange | 19:41 | |
| piyushbansal | Lennie: Are you there ? | 19:46 |
| piyushbansal | I wanted to ask, if you asked me to attach the patch in the group mailing list as an attachment or embed it in the message ? | 19:47 |
| Lennie | piyushbansal, both | 19:47 |
| piyushbansal | Oh okay, thanks :) | 19:47 |
| Lennie | jgsmith, sounds like a potential bug | 19:47 |
| Lennie | jgsmith, one that must have been there for a year or 2 | 19:47 |
| Lennie | jgsmith, https://code.google.com/p/soc/issues/entry | 19:47 |
| tpb | Title: Google Project Hosting (at code.google.com) | 19:47 |
| piyushbansal | And one more thing, Lennie, Are the selenium tests written for firefox only ? | 19:47 |
| Lennie | would you mind :)? | 19:47 |
| jgsmith | Lennie: not a problem :-) | 19:48 |
| piyushbansal | Is it okay to configure these to run for chrome ? | 19:48 |
| piyushbansal | I also mean, if its possible to. | 19:48 |
| Lennie | piyushbansal, I'm not familiar with them. But if you can make them run for Chrome that would be nice :) | 19:48 |
| Lennie | piyushbansal, yes please | 19:48 |
| piyushbansal | Lennie : Okay, thanks :) | 19:48 |
| *** jenmylo has joined #melange | 19:50 | |
| *** jgsmith has quit IRC | 20:00 | |
| Lennie | piyushbansal, if you wouldn't mind applying the blank line suggestion to the Irc/MailTo tests that would be great | 20:00 |
| Lennie | makes it a lot easier to read :) | 20:00 |
| piyushbansal | Sorry, didn't get you ? | 20:01 |
| Lennie | You'll probably understand when you look at the response on the date validator | 20:02 |
| piyushbansal | Okay, got it | 20:02 |
| piyushbansal | Sorry I didn't look at the message you posted on the group | 20:02 |
| Lennie | piyushbansal, np :P | 20:02 |
| Lennie | piyushbansal, I just posted it | 20:02 |
| piyushbansal | I would make the changes that you suggested, thanks a lot | 20:03 |
| Lennie | I don't expect you to read them instantly | 20:03 |
| piyushbansal | Lennie: In the code I meant the program start day by today | 20:04 |
| piyushbansal | I agree that the comment is misleading, and I would quickly write something that is more apt. | 20:04 |
| *** Hamish_B has joined #melange | 20:04 | |
| piyushbansal | Thanks for pointing out | 20:04 |
| Hamish_B | !bugs | 20:05 |
| Hamish_B | where do we file bugs again? tx | 20:05 |
| piyushbansal | Lennie: About the off by one errors, I was more concerned about testing the cleaning logic, there already are tests written for validating date of birth , | 20:05 |
| piyushbansal | Or do you propose that I write them here as well ? | 20:06 |
| piyushbansal | Hamish_B : Hi | 20:06 |
| piyushbansal | Please find the issues at https://code.google.com/p/soc/issues/list | 20:06 |
| tpb | Title: Issues - soc - SoC (Spice of Creation) - Google Project Hosting (at code.google.com) | 20:06 |
| Hamish_B | cheers. hopefully it's an easy one. | 20:07 |
| Lennie | piyushbansal, hmm good point | 20:10 |
| Lennie | As long as you cover before, during and after it's good enough for me :) | 20:10 |
| Lennie | I'm off now for the day | 20:10 |
| piyushbansal | Yeah, I have covered total 6 cases | 20:10 |
| Lennie | great | 20:11 |
| piyushbansal | Two for each of the use cases that you've mentioned | 20:11 |
| Lennie | I also took a quick look at the other patch you send in | 20:11 |
| Lennie | made some comments :) | 20:11 |
| piyushbansal | Yeah, great :) | 20:11 |
| Lennie | Thanks for helping out | 20:11 |
| piyushbansal | I would have a look, make changes and update the patches | 20:11 |
| Lennie | yeah no rush | 20:11 |
| piyushbansal | Lennie: :D | 20:11 |
| Lennie | I don't think Leo will get to them till tomorrow | 20:11 |
| piyushbansal | Lennie: Oh, okay | 20:12 |
| Lennie | but you never know :) | 20:12 |
| Lennie | It's tests | 20:12 |
| Lennie | so maybe nathanielmanista will jump on it :P | 20:12 |
| piyushbansal | Lennie : hehe | 20:12 |
| piyushbansal | Lennie : If you have just a few more minutes, I would like to talk about some of the comments that you've made on the other patch | 20:14 |
| Lennie | sure | 20:14 |
| piyushbansal | If you're leaving, its okay, we can discuss another time, no hurry :) | 20:14 |
| Lennie | ask | 20:15 |
| piyushbansal | About the mail urls, yes its about mailto: | 20:15 |
| piyushbansal | Checking the more edge cases for channel validators, yeah that is a good point | 20:15 |
| piyushbansal | Also, if the mailto is returned true by the validator, then only we can asserttrue of the equality | 20:16 |
| piyushbansal | If we are returned an exception, that means it fails | 20:16 |
| piyushbansal | Since it can be just one of the two, checking for one ensures the negative of another | 20:16 |
| piyushbansal | In this case, assertequal ensures that there is no exception raise | 20:17 |
| piyushbansal | Which is exactly what we want to test. | 20:17 |
| piyushbansal | Lennie: correct me if I am wrong, I am new to the codebase, but I guess I am not being too off track here :D | 20:17 |
| Lennie | hmm | 20:19 |
| Lennie | I don't think I understand your point | 20:20 |
| piyushbansal | Oh, let me explain again, even I guess I wasn't able to express exactly what I was intending to say | 20:21 |
| piyushbansal | All I am saying is that about "Please ensure that the validator also passes when you give it a valid url.", I guess there are checks present | 20:22 |
| piyushbansal | I mean , I have checked that there is no exception raised, which means that the validator validated the correct mailto URl | 20:23 |
| *** jenmylo has quit IRC | 20:23 | |
| piyushbansal | Lennie: Is that what you wanted to point out in that comment ? | 20:23 |
| piyushbansal | Sorry, If I misunderstood | 20:23 |
| Lennie | oh no | 20:23 |
| Lennie | it uses a different validator for both | 20:23 |
| Lennie | look at the implementation | 20:23 |
| Lennie | if you give it mailto: it uses the validators.validate_email | 20:24 |
| piyushbansal | Yeah... | 20:24 |
| Lennie | if you give it something else like http://example.com/hereisawebmailinggroup | 20:24 |
| tpb | Title: Example Domain (at example.com) | 20:24 |
| Lennie | it uses validators.URLValidator() | 20:24 |
| Lennie | ergo you should test both | 20:24 |
| piyushbansal | Yeah, exactly, I have tested both | 20:24 |
| Lennie | Then I must have missed it ^_^ | 20:24 |
| piyushbansal | For IRC I have used URL validator | 20:24 |
| Lennie | hmm | 20:25 |
| piyushbansal | and for mailto, I extract mailto: string and test for a valid email | 20:25 |
| Lennie | clean_mailto should also accept http://someUrl | 20:25 |
| piyushbansal | Would that be fine, IMHO it should be | 20:25 |
| Lennie | I didn't see you test a URL for clean_mailTo | 20:25 |
| piyushbansal | Oh is it ? | 20:25 |
| Lennie | yes | 20:25 |
| Lennie | https://code.google.com/p/soc/source/browse/app/soc/logic/cleaning.py#497 | 20:25 |
| tpb | <http://ln-s.net/+zcN> (at code.google.com) | 20:25 |
| Lennie | Really off now :D | 20:26 |
| piyushbansal | Yeah, I have just done a email validation | 20:26 |
| piyushbansal | Thanks a lot for pointing out | 20:26 |
| piyushbansal | That was really nice of you to spend so much time, on this small patch | 20:26 |
| piyushbansal | Lennie: bye :) | 20:26 |
| *** carols has joined #melange | 20:29 | |
| nathanielmanista | desophos: Have you gone through everything on https://code.google.com/p/soc/wiki/GettingStarted? Run the test suite and perhaps deployed to a personal development project on App Engine? | 20:52 |
| tpb | <http://ln-s.net/+zcy> (at code.google.com) | 20:52 |
| *** desophos has quit IRC | 20:56 | |
| *** manugupt1 has quit IRC | 20:56 | |
| *** manugupt1 has joined #melange | 21:00 | |
| *** manugupt1 has joined #melange | 21:00 | |
| *** desophos has joined #melange | 21:11 | |
| *** carols has quit IRC | 21:21 | |
| *** carols has joined #melange | 21:26 | |
| *** carols has quit IRC | 21:50 | |
| * rihnapstor gn | 22:14 | |
| *** rihnapstor has quit IRC | 22:14 | |
| *** robbyoconnor has joined #melange | 23:07 | |
| *** r0bby has joined #melange | 23:11 | |
| *** robbyoconnor has quit IRC | 23:15 | |
| *** carols has joined #melange | 23:23 | |
| *** rafl has quit IRC | 23:24 | |
| *** rafl has joined #melange | 23:27 | |
| *** mang0 has quit IRC | 23:32 | |
| *** roonyH has joined #melange | 23:50 | |
| roonyH | Hi all | 23:52 |
| roonyH | @Lennie, Hi, Is Daniel the probable mentor for the Messaging System project available in IRC? | 23:52 |
| roonyH | i am a gsoc student btw | 23:52 |
| roonyH | @nathanielmanista Hi, Is Daniel the probable mentor for the Messaging System project available in IRC? | 23:54 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!