| *** tpb has joined #melange | 00:00 | |
| *** dmitrig01|afk has joined #melange | 01:14 | |
| *** ChanServ sets mode: +v dmitrig01|afk | 01:14 | |
| *** mithro has quit IRC | 01:15 | |
| *** dmitrig01|afk is now known as dmitrig01 | 01:33 | |
| *** dmitrig01 has quit IRC | 02:14 | |
| *** solydzajs has joined #melange | 03:23 | |
| *** ChanServ sets mode: +o solydzajs | 03:23 | |
| *** no_mind has left #melange | 03:28 | |
| *** solydzajs has quit IRC | 03:45 | |
| *** solydzajs has joined #melange | 03:46 | |
| *** ChanServ sets mode: +o solydzajs | 03:46 | |
| *** solydzajs has quit IRC | 03:56 | |
| *** r0bby has quit IRC | 03:57 | |
| *** lisppaste9 has quit IRC | 03:57 | |
| *** durin42 has quit IRC | 03:57 | |
| *** Landon has quit IRC | 03:57 | |
| *** r0bby has joined #melange | 03:58 | |
| *** lisppaste9 has joined #melange | 03:58 | |
| *** Landon has joined #melange | 03:58 | |
| *** durin42 has joined #melange | 03:58 | |
| *** irc.freenode.net sets mode: +v durin42 | 03:58 | |
| *** Lennie has joined #melange | 04:09 | |
| *** ChanServ sets mode: +v Lennie | 04:09 | |
| *** MatthewWilkes has joined #melange | 04:45 | |
| *** MatthewWilkes has quit IRC | 04:47 | |
| *** MatthewWilkes has joined #melange | 04:47 | |
| *** solydzajs has joined #melange | 05:45 | |
| *** ChanServ sets mode: +o solydzajs | 05:45 | |
| *** Merio has joined #melange | 06:04 | |
| *** MatthewWilkes has quit IRC | 06:08 | |
| *** MatthewWilkes has joined #melange | 06:09 | |
| *** mithro has joined #melange | 06:23 | |
| *** ChanServ sets mode: +v mithro | 06:23 | |
| *** mithro has quit IRC | 06:36 | |
| *** mithro has joined #melange | 06:37 | |
| *** ChanServ sets mode: +v mithro | 06:37 | |
| Lennie | phew | 07:07 |
|---|---|---|
| Lennie | I'm glad that's pushed :P | 07:07 |
| Lennie | time for lunch :D | 07:07 |
| Lennie | byebye | 07:07 |
| *** Lennie has quit IRC | 07:07 | |
| *** SRabbelier has joined #melange | 07:10 | |
| *** ChanServ sets mode: +v SRabbelier | 07:10 | |
| *** MatthewWilkes has quit IRC | 07:39 | |
| *** solydzajs has quit IRC | 07:58 | |
| *** solydzajs has joined #melange | 07:59 | |
| *** ChanServ sets mode: +o solydzajs | 07:59 | |
| *** Merio has quit IRC | 07:59 | |
| *** Lennie has joined #melange | 10:01 | |
| *** ChanServ sets mode: +v Lennie | 10:01 | |
| Lennie | solydzajs | 10:01 |
| Lennie | you around? | 10:02 |
| solydzajs | Lennie: yes | 10:02 |
| solydzajs | Lennie: what's up ? | 10:03 |
| Lennie | just wondering if you want to discuss the patch :p? | 10:03 |
| Lennie | before you have to go in 30 min | 10:03 |
| solydzajs | you will be online after match ? | 10:03 |
| Lennie | I might be | 10:04 |
| solydzajs | ok what time ? | 10:04 |
| Lennie | no idea | 10:04 |
| Lennie | it's an away match | 10:04 |
| solydzajs | before midnight ? | 10:04 |
| Lennie | probably yes | 10:04 |
| SRabbelier | lol :P | 10:04 |
| Lennie | but I can't guarantee you anything :P | 10:04 |
| solydzajs | ok let's discuss then | 10:04 |
| solydzajs | I will commit my timeline bug fix then too | 10:05 |
| Lennie | fine by me | 10:05 |
| Lennie | http://code.google.com/p/googleappengine/issues/detail?id=1007 | 10:05 |
| tpb | <http://ln-s.net/2kao> (at code.google.com) | 10:05 |
| Lennie | star the issue:P | 10:05 |
| SRabbelier | lol | 10:05 |
| Lennie | shameless plug ^_^ | 10:06 |
| solydzajs | I did that already | 10:06 |
| solydzajs | :-) | 10:06 |
| solydzajs | when you posted it | 10:06 |
| Lennie | hehe | 10:06 |
| Lennie | so you are the 2nd star :P | 10:06 |
| SRabbelier | I'm the third :P | 10:07 |
| solydzajs | :D | 10:07 |
| solydzajs | ok bbl | 10:07 |
| Lennie | bye | 10:07 |
| *** tlarsen has joined #melange | 10:48 | |
| *** ChanServ sets mode: +o tlarsen | 10:48 | |
| *** mib_6jkrz3 has joined #melange | 10:55 | |
| *** atulagrwl has joined #Melange | 10:55 | |
| *** mib_6jkrz3 has quit IRC | 10:57 | |
| *** dmitrig01|afk has joined #melange | 11:16 | |
| *** ChanServ sets mode: +v dmitrig01|afk | 11:16 | |
| *** Merio has joined #melange | 11:17 | |
| *** dmitrig01|afk has quit IRC | 11:24 | |
| *** solydzajs has quit IRC | 12:07 | |
| *** solydzajs has joined #melange | 12:08 | |
| *** ChanServ sets mode: +o solydzajs | 12:08 | |
| *** no_mind has joined #melange | 12:17 | |
| no_mind | hi | 12:18 |
| Lennie | hi | 12:27 |
| *** mithro has quit IRC | 12:38 | |
| *** penyaskito has quit IRC | 12:41 | |
| *** tanoku has joined #melange | 12:44 | |
| Lennie | byebye, time to build a wobot SRabbelier :P | 12:52 |
| *** Lennie has quit IRC | 12:53 | |
| *** mrs_spearce has joined #melange | 13:08 | |
| *** mrs_spearce has left #melange | 13:10 | |
| *** Merio has quit IRC | 13:58 | |
| *** atulagrwl has quit IRC | 15:03 | |
| SRabbelier | solydzajs, tlarsen: ping | 15:03 |
| tlarsen | SRabbelier: hello | 15:03 |
| SRabbelier | tlarsen: I have finished the final-last stage of a 'reference picker' :) | 15:03 |
| tlarsen | SRabbelier: OK. | 15:04 |
| SRabbelier | tlarsen: there is one downside | 15:04 |
| tlarsen | SRabbelier: Which is? | 15:04 |
| SRabbelier | tlarsen: in order to know what 'picker' to redirect to, I need to include an extra attribute in the model | 15:05 |
| SRabbelier | tlarsen: that is, for the soc.models.presence.Presence one, I have: home.redirect_url = 'document' | 15:05 |
| tlarsen | Can you just attach that attribute to the property? | 15:05 |
| SRabbelier | and also tos.redirect_url = 'document' | 15:05 |
| tlarsen | SRabbelier: That seems OK to me. | 15:05 |
| SRabbelier | tlarsen: for group_app, we have backup_admin.redirect_url = 'user' | 15:06 |
| tlarsen | SRabbelier: Is it not possible to determine the reference type from the ReferenceProperty, though? | 15:06 |
| SRabbelier | tlarsen: well, I can get to the property, but I guess you already knew that since Im retrieving redirect_url and all | 15:06 |
| SRabbelier | tlarsen: the problem is, the ReferenceProprty only holds reference_class=... | 15:07 |
| SRabbelier | and then another model instance | 15:07 |
| SRabbelier | what we could instead do | 15:07 |
| SRabbelier | is store the redirect_url as a property in the model | 15:07 |
| tlarsen | Isn't reference_class enough? | 15:07 |
| SRabbelier | I need to somehow translate from reference_class to reference_url, (so from soc.models.Document to 'document') | 15:07 |
| tlarsen | Why not add a constant to the Document Model class? | 15:08 |
| SRabbelier | tlarsen: that would work | 15:08 |
| SRabbelier | tlarsen: that's why I'm asking mostly | 15:08 |
| tlarsen | I think this is currently in the logic class right now, though, right? | 15:08 |
| SRabbelier | tlarsen: if you'd rather have that, or as a property to the model | 15:08 |
| SRabbelier | tlarsen: in view even | 15:08 |
| SRabbelier | tlarsen: as the url_name field | 15:08 |
| tlarsen | One nice thing about adding it as an attribute to the property is that its absence would mean "don't use a picker". | 15:08 |
| tlarsen | The presence of the attribute (found with hasattr()) would indicate that a picker should be used. | 15:09 |
| SRabbelier | tlarsen: exactly, that's how I do it currently | 15:09 |
| tlarsen | So, I think I like your idea of adding it as an attribute to the ReferenceProperty. | 15:09 |
| tlarsen | Only ReferenceProperties that want a picker UI used would specify the additional attribute. | 15:09 |
| SRabbelier | tlarsen: it does mean we repeat the url a gazzillion times though | 15:09 |
| SRabbelier | if we ever change from 'document' to 'doc' as url_name we have to replace it everywhere | 15:10 |
| tlarsen | I don't see how to avoid that while also not ending up with circular imports. | 15:10 |
| SRabbelier | tlarsen: how would you do it ignoring circular imports? | 15:10 |
| tlarsen | Maybe you need a constant in soc.models.document.Document that says what it is, and then say foo_ref.selector_url = soc.models.document.Document.REDIRECT_URL | 15:11 |
| tlarsen | (I'm just making the names up, I haven't thought about it enough...) | 15:11 |
| SRabbelier | tlarsen: another way to specify whether we want a picker | 15:11 |
| SRabbelier | tlarsen: is to say 'only make one if the field name ends in link_id' | 15:11 |
| SRabbelier | that's what I did first | 15:11 |
| SRabbelier | so home_link_id | 15:11 |
| tlarsen | The Model class that contains the ReferenceProperty is importing soc.models.document anyway, to get the Document class for the reference_class argument. | 15:11 |
| SRabbelier | is translated to 'home' | 15:11 |
| tlarsen | Ugh, no. | 15:12 |
| SRabbelier | ok :) | 15:12 |
| tlarsen | Don't use name-of-field stuff. | 15:12 |
| tlarsen | So, here is what I would suggest: | 15:12 |
| SRabbelier | what you said above makes sense | 15:12 |
| tlarsen | 1) Take all of these constant strings and put them in the Model classes. | 15:12 |
| tlarsen | 2) when setting the "redirect_url" (or whatever the attribute ends up being called) of a ReferenceProperty (in order to cause a pick-list UI to be used), just access that constant from the Model class | 15:13 |
| SRabbelier | ok | 15:13 |
| SRabbelier | can do :) | 15:13 |
| tlarsen | 3) maybe update the logic class to get the constant from the Model, since it is importing the Model class anyway. | 15:13 |
| SRabbelier | should be no more than 5 minutes of work :) | 15:13 |
| tlarsen | That way, the information only appears in the Model class module. | 15:13 |
| * SRabbelier nods | 15:13 | |
| SRabbelier | ok, sure :) | 15:13 |
| tlarsen | This improves the DRY without adding any dependencies that weren't already there. | 15:14 |
| SRabbelier | yup, very nice | 15:14 |
| tlarsen | Constant stuff, text messages (like example_text, help_text) stick to the model. Other stuff gets it from there. | 15:14 |
| tlarsen | You need not do this with *all* of the string constants in a logic class. Just the ones that are ending up used *outside* of that logic class. | 15:15 |
| SRabbelier | :D | 15:15 |
| SRabbelier | I like not having to do a lot of work :P | 15:15 |
| tlarsen | SRabbelier: Yeah, you make *massive* refactorings of the code base look so *easy*. :) | 15:17 |
| SRabbelier | hehe, that's what I'm good at though | 15:18 |
| SRabbelier | finding abstractions | 15:18 |
| SRabbelier | it's hard to come up with them beforehand | 15:18 |
| SRabbelier | I would have never thought of the whole params thing at the start | 15:18 |
| SRabbelier | I'd probably have told you it's a retarded idea :P | 15:18 |
| tlarsen | Yeah, that is why code gets cut-and-pasted first, as a prototyping step. | 15:19 |
| SRabbelier | ^__^ | 15:19 |
| tlarsen | Then, you pay off the technical debt that is accumulating in the codebase by refactoring (and writing tests, which we *aren't* doing). | 15:19 |
| SRabbelier | tlarsen: if I get my internship, a large part will be writing us a test suite :) | 15:20 |
| tlarsen | SRabbelier: Any idea who would be your intern host? | 15:20 |
| SRabbelier | tlarsen: spearce is willing to be a host | 15:21 |
| SRabbelier | tlarsen: he put my resume in the internal recommendation thing | 15:21 |
| SRabbelier | tlarsen: I hope I hear back from Google before end of next month though... I need to know what's up about that time | 15:22 |
| SRabbelier | tlarsen: omg, it's working | 15:30 |
| SRabbelier | tlarsen: document picker: SUCCESS! | 15:30 |
| tlarsen | SRabbelier: you are going to use it for the "home" and "tos" selection in Site settings (and other Presence), right? | 15:31 |
| SRabbelier | tlarsen: it's already working for those :D | 15:32 |
| tlarsen | SRabbelier: Nice. | 15:32 |
| SRabbelier | tlarsen: 20 files changed, 202 insertions(+), 41 deletions(-) | 16:03 |
| *** tlarsen has left #melange | 16:03 | |
| SRabbelier | full commitdiff: full | 16:04 |
| SRabbelier | http://pastebin.com/m1f58bb6d | 16:04 |
| tpb | Title: pastebin - collaborative debugging tool (at pastebin.com) | 16:04 |
| SRabbelier | solydzajs: ping | 16:25 |
| *** Lennie has joined #melange | 16:54 | |
| *** ChanServ sets mode: +v Lennie | 16:54 | |
| solydzajs | SRabbelier: pong | 17:40 |
| SRabbelier | solydzajs: wb | 17:40 |
| SRabbelier | solydzajs: we have a (limited) document picker | 17:40 |
| solydzajs | SRabbelier: reading back log | 17:44 |
| SRabbelier | solydzajs: ok :) | 17:52 |
| solydzajs | SRabbelier: reading done :-) | 18:00 |
| solydzajs | SRabbelier: congrats on document picker, I will go thru review in a minute | 18:00 |
| solydzajs | SRabbelier: what's next ? | 18:00 |
| SRabbelier | solydzajs: uhm... good question | 18:03 |
| solydzajs | SRabbelier: Orgs ? | 18:04 |
| SRabbelier | solydzajs: Lennie is working on that | 18:05 |
| Lennie | ? | 18:06 |
| Lennie | yeah | 18:06 |
| Lennie | I am doing important stuff for the orgs yeah | 18:06 |
| Lennie | but not directly yet | 18:06 |
| solydzajs | SRabbelier: can you do program visibility on/off switch ? | 18:07 |
| solydzajs | SRabbelier: that shouldn't take too long | 18:07 |
| SRabbelier | solydzajs: what should it do? | 18:08 |
| solydzajs | SRabbelier: in the program settings you should have on/off switch that indicates whether program is visible for anybody other than Hosts and Developers | 18:08 |
| solydzajs | SRabbelier: basically Leslie can create GHOP 2009 or GSoC 2009 and all the public views, sidebars etc should not be accessible if the program visibility is off | 18:09 |
| SRabbelier | solydzajs: ok... | 18:09 |
| SRabbelier | solydzajs: I'll look into that | 18:09 |
| solydzajs | SRabbelier: I don't expect that too take long, you ? | 18:10 |
| SRabbelier | dunno | 18:10 |
| SRabbelier | might be a lot of work | 18:10 |
| solydzajs | SRabbelier: investigate and let me know how long it will take you, we might have more important tasks | 18:12 |
| solydzajs | if you think it will take too long | 18:12 |
| SRabbelier | solydzajs: ok | 18:13 |
| solydzajs | SRabbelier: thx | 18:13 |
| *** mrs_spearce has joined #melange | 18:47 | |
| *** mrs_spearce has left #melange | 18:47 | |
| *** Lennie has quit IRC | 19:07 | |
| *** solydzajs_ has joined #melange | 19:59 | |
| *** mithro has joined #melange | 20:07 | |
| *** ChanServ sets mode: +v mithro | 20:07 | |
| *** mithro has quit IRC | 20:12 | |
| *** mithro_ has joined #melange | 20:12 | |
| *** ChanServ sets mode: +v mithro_ | 20:12 | |
| *** SRabbelier has quit IRC | 20:13 | |
| *** solydzajs has quit IRC | 20:17 | |
| *** penyaskito has joined #melange | 20:29 | |
| *** tanoku has quit IRC | 22:02 | |
| *** mithro_ has quit IRC | 22:26 | |
| *** mithro has joined #melange | 23:09 | |
| *** ChanServ sets mode: +v mithro | 23:09 | |
| *** mithro has quit IRC | 23:11 | |
| *** mithro_ has joined #melange | 23:11 | |
| *** ChanServ sets mode: +v mithro_ | 23:11 | |
| *** bono8106 has joined #melange | 23:30 | |
| *** bono8106 has left #melange | 23:32 | |
| *** mithro_ has quit IRC | 23:32 | |
| *** bono8106 has joined #melange | 23:34 | |
| *** danderson has joined #melange | 23:35 | |
| *** ChanServ sets mode: +o danderson | 23:35 | |
| * danderson waves | 23:35 | |
| * no_mind waves back at danderson | 23:35 | |
| danderson | hmm, quiet a this time of day | 23:37 |
| no_mind | yup | 23:37 |
| danderson | probably a sign I should get to bed, when I turn up after the US people leave :P | 23:37 |
| * danderson is in Europe | 23:37 | |
| no_mind | it must be night on that side of atlantic | 23:37 |
| danderson | here it's close to daybreak, a couple of hours to go | 23:38 |
| *** bono8106 has left #melange | 23:41 | |
| no_mind | here its already broad daylight... | 23:46 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!