*** tpb has joined #tp | 00:00 | |
*** ChanServ sets mode: +o tpb | 00:00 | |
*** bddebian has quit IRC | 00:13 | |
alanp | argh | 00:17 |
---|---|---|
alanp | why is it that when i move to a planet, i can still be 6000 away from it :( | 00:18 |
*** mithro has quit IRC | 00:21 | |
*** mithro has joined #tp | 00:22 | |
llnz | bbl | 00:35 |
*** llnz has quit IRC | 00:35 | |
*** jernejovc_ has joined #tp | 00:50 | |
*** nebaway is now known as nebajoth | 00:52 | |
*** jernejovc has quit IRC | 01:05 | |
tansell | back now | 01:12 |
*** llnz has joined #tp | 01:24 | |
llnz | demo1 restarted | 01:25 |
*** jnengland77 has quit IRC | 01:34 | |
*** cherez has quit IRC | 01:40 | |
alanp | llnz: ping | 01:48 |
*** cherez has joined #tp | 01:50 | |
tansell | cherez, ping? | 01:56 |
cherez | tansell: Pong. | 01:56 |
tansell | comments on 9002 | 01:56 |
cherez | Alright, thanks. | 01:58 |
alanp | llnz: nevermind | 01:58 |
*** nebajoth is now known as nebaway | 02:16 | |
llnz | hehe | 02:38 |
*** tansell--laptop has joined #tp | 02:46 | |
*** tansell_laptop has quit IRC | 02:48 | |
tansell | cherez, your other one has comments now | 02:51 |
tansell | Greywhind, ping? | 02:51 |
cherez | tansell: Thanks. | 02:51 |
CIA-26 | landon tpclient-pyogre * r886a5fc53d65 /src/ (4 files in 2 dirs): Move states are now supported by the round controls | 02:52 |
CIA-26 | landon tpclient-pyogre * rd98901175760 /src/battlemanager.py: No progression at all when ships are warping in as well as keeping the event queue clean when hopping between rounds | 02:52 |
tansell | epyon, I'm sure that normal C++ exception classes record the line number/filename information by default | 02:52 |
tansell | alanp, you should be generating battlexml | 02:53 |
tansell | cherez, you should run a server locally | 02:54 |
cherez | tansell: I'll be trying that tomorrow. | 02:55 |
* llnz thinks himself should finish up battlexml support | 02:55 | |
tansell | alanp, it's very good debugging output if you add loads of comments | 02:55 |
Greywhind | tansell: pong | 03:01 |
alanp | i know :( | 03:08 |
alanp | i just found that out today, unfortunately | 03:08 |
alanp | I will do it after | 03:08 |
* alanp doesn't know how he missed it | 03:09 | |
alanp | but i will do it regardless | 03:09 |
alanp | holy crap, i finally got fleet vs planet | 03:11 |
alanp | couple more test cases and i will commit and immediately go to sleep (after blog post, of course) :P | 03:11 |
CIA-26 | alanp tpserver-cpp-mtsec * r8d79492e0be2 /modules/games/mtsec/ (8 files): Planet vs. Fleet now somewhat working, I need to test and clean this up some more but it is working in a basic sense. | 03:21 |
alanp | phew | 03:22 |
alanp | work = cut out | 03:22 |
tansell | Greywhind, you had some stuff for me to look at? | 03:31 |
Greywhind | tansell: http://codereview.mithis.com/11001 | 03:35 |
tpb | Title: Issue 11001: Fixed pasting of orders in the order queue, along with libtpproto-py fix. - Code Review (at codereview.mithis.com) | 03:35 |
*** tansell--laptop has quit IRC | 03:37 | |
*** alanp_ has quit IRC | 03:40 | |
tansell | Greywhind, so - explain this to me? | 03:46 |
tansell | Greywhind, http://codereview.mithis.com/11001 | 03:50 |
tpb | Title: Issue 11001: Fixed pasting of orders in the order queue, along with libtpproto-py fix. - Code Review (at codereview.mithis.com) | 03:50 |
Greywhind | tansell: on the not worked before comment, yes, it should not have worked before | 03:51 |
Greywhind | tansell: the unreachable line, i'll remove | 03:52 |
Greywhind | tansell: you're right, i just need the subtype. I'll put that in instead of the whole order | 03:53 |
tansell | Greywhind, so your InsertBefore/InsertAfter right click options didn't work either? | 03:54 |
Greywhind | tansell: probably true | 04:02 |
Greywhind | tansell: although that code is in ObjectOrderTracker | 04:03 |
Greywhind | tansell: which isn't used by the Orders panel | 04:03 |
Greywhind | tansell: orders panel uses the Orders tracker and the Object tracker separately | 04:03 |
*** nash has quit IRC | 04:05 | |
tansell | oh? so this should be using the orders panel right? | 04:05 |
Greywhind | tansell: yes, i just fixed that code in case something else uses it | 04:06 |
tansell | can you put it in a separate CL then? | 04:09 |
Greywhind | tansell: i don't think it's really necessary - it's basically just making that function the same as the one right above it | 04:11 |
tansell | Greywhind, well put in a separate commit | 04:12 |
Greywhind | tansell: ok, i'll see what i can do | 04:12 |
tansell | git add --interactive is your friend | 04:24 |
*** llnz has quit IRC | 04:25 | |
*** llnz has joined #tp | 04:28 | |
*** Greywhind has quit IRC | 04:49 | |
*** cherez has quit IRC | 05:02 | |
*** cherez has joined #tp | 05:19 | |
*** llnz has quit IRC | 05:27 | |
*** llnz has joined #tp | 05:27 | |
*** jernejovc_ has quit IRC | 05:56 | |
*** JLP has joined #tp | 06:01 | |
*** JLP_ has quit IRC | 06:09 | |
llnz | JLP: ping? | 06:18 |
*** Eugene_ has joined #tp | 06:19 | |
tansell | tote, ping? | 06:19 |
*** jernejovc has joined #tp | 06:20 | |
*** jmtan has joined #tp | 06:21 | |
*** jmtan has quit IRC | 06:29 | |
*** Eugene_ has quit IRC | 06:32 | |
*** jmtan has joined #tp | 06:42 | |
*** jernejovc has quit IRC | 06:56 | |
*** jernejovc has joined #tp | 06:58 | |
*** jmtan1 has joined #tp | 07:24 | |
*** jmtan has quit IRC | 07:24 | |
tote | tansell: pong | 07:25 |
tote | tansell: u were right btw, ive found a few bugs :/ | 07:25 |
*** jmtan1 has quit IRC | 07:25 | |
*** tuna-fish has quit IRC | 07:35 | |
tansell | tote, hopefully nothing too serious? | 07:42 |
tote | nah only small bugs atm atleast | 07:44 |
*** jernejovc has quit IRC | 07:52 | |
tote | tansell: which ruleset contains most features? | 07:54 |
tansell | they all contain different features | 07:54 |
tansell | for example mtsec makes very use of designs | 07:55 |
tansell | while risk has wormholes | 07:55 |
tansell | and minisec is basic | 07:55 |
tansell | rfts has things like "variable" turns (IE you can do different actions each turn) | 07:55 |
tote | ok, i tested a risk game, and tried to connect with tpclient-pywx and i get this when i try to login: global name 'DescriptionError' is not defined | 07:56 |
* llnz wanders off | 08:01 | |
llnz | later all | 08:01 |
*** llnz has quit IRC | 08:01 | |
*** mithro has quit IRC | 08:18 | |
*** mithro has joined #tp | 08:40 | |
*** alanp_ has joined #tp | 08:48 | |
CIA-26 | joelboh tpclient-pyweb * r4c23a2d3c7f5 / (backend/middleman.py frontend/scripts/map.js): Fixed a bug that made it impossible to play a ruleset with wormholes. | 08:53 |
CIA-26 | joelboh tpclient-pyweb * rc6b5a2c53fa3 /frontend/scripts/map.js: Another fix for wormholes. | 09:02 |
*** nebaway is now known as nebajoth | 09:06 | |
CIA-26 | epyon tpserver-cpp-refactor * re759c8fc468e /tpserver/ (79 files): Frame -> OutputFrame for output frames | 09:10 |
CIA-26 | epyon tpserver-cpp-refactor * r37f14da95856 /tpserver/ (4 files): TcpConnection passes right Input/Output frames | 09:10 |
CIA-26 | epyon tpserver-cpp-refactor * r0e59c6249cac /tpserver/ (19 files): frame.h split into input and output files | 09:10 |
CIA-26 | epyon tpserver-cpp-refactor * r271ffbea1aea /tpserver/ (47 files): Removed unnceccesary frame.h includes | 09:10 |
CIA-26 | epyon tpserver-cpp-refactor * r2493b6b40609 /tpserver/ (adminconnection.h playerconnection.h): Removed unnceccesary frame.h includes from headers | 09:10 |
CIA-26 | epyon tpserver-cpp-refactor * r795135e23296 /tpserver/ (14 files): Unneccesary forward declarations and includes removed | 09:10 |
CIA-26 | epyon tpserver-cpp-refactor * rcffbb7b8a56d /modules/games/minisec/ (14 files): MiniSec now working with OutputFrame's | 09:10 |
CIA-26 | epyon tpserver-cpp-refactor * re7b7d1d56f5d /modules/games/mtsec/ (14 files): MTSec now working with OutputFrame's | 09:10 |
CIA-26 | epyon tpserver-cpp-refactor * r45e7181280b6 /modules/games/risk/ (8 files): Risk now working with OutputFrame's | 09:10 |
CIA-26 | epyon tpserver-cpp-refactor * reb32e9db024d /modules/games/rfts/ (14 files): RFTS now working with OutputFrame's | 09:10 |
CIA-26 | epyon tpserver-cpp-refactor * raa0f9a1ac703 /modules/games/tae/ (18 files): TAE now working with OutputFrame's | 09:10 |
epyon | that completes Input/Output frame transition... | 09:11 |
*** alanp_ has quit IRC | 09:27 | |
*** DTRemenak has joined #tp | 09:41 | |
*** nebajoth is now known as nebaway | 09:44 | |
*** alanp_ has joined #tp | 09:57 | |
*** DTRemenak|RDP has quit IRC | 09:58 | |
*** bddebian has joined #tp | 10:10 | |
bddebian | Howdy | 10:11 |
*** nebaway is now known as nebajoth | 10:54 | |
*** jmtan has joined #tp | 10:55 | |
*** alanp_ has quit IRC | 11:59 | |
*** alanp_ has joined #tp | 13:00 | |
*** Erroneous has joined #tp | 13:24 | |
*** jnengland77 has joined #tp | 13:30 | |
*** alanp__ has joined #tp | 13:32 | |
*** alanp has quit IRC | 13:48 | |
*** Landon has quit IRC | 14:52 | |
*** Landon has joined #tp | 14:53 | |
*** alanp_ has quit IRC | 14:59 | |
*** jnengland77 has quit IRC | 15:42 | |
*** cherez1 has joined #tp | 15:53 | |
*** cherez has quit IRC | 15:53 | |
*** llnz has joined #tp | 16:09 | |
*** Greywhind has joined #tp | 16:47 | |
llnz | morning all | 16:56 |
cherez1 | Morning. | 16:56 |
llnz | hi cherez1 | 17:01 |
cherez1 | Whoa. | 17:02 |
*** cherez1 is now known as cherez | 17:02 | |
*** jmtan has quit IRC | 17:12 | |
*** bddebian has quit IRC | 17:14 | |
*** nebajoth is now known as nebaway | 18:12 | |
*** nebaway is now known as nebajoth | 19:08 | |
*** nash has joined #tp | 19:16 | |
*** mithro has quit IRC | 19:29 | |
*** tansell-laptop has joined #tp | 19:38 | |
*** mhilmi has quit IRC | 19:52 | |
*** jnengland77 has joined #tp | 19:53 | |
*** cherez1 has joined #tp | 20:03 | |
*** cherez has quit IRC | 20:04 | |
*** Greywhind has quit IRC | 20:13 | |
*** nebajoth is now known as nebaway | 20:18 | |
*** nash has quit IRC | 20:23 | |
*** tansell_laptop has joined #tp | 20:31 | |
*** tansell-laptop has quit IRC | 20:33 | |
*** welterde has quit IRC | 20:46 | |
*** ezod has quit IRC | 20:46 | |
*** nash has joined #tp | 20:48 | |
epyon | nash: I'll be going on a week vacation friday | 20:48 |
nash | okay | 20:48 |
nash | can you give me a updated status report? | 20:48 |
*** cherez1 has quit IRC | 20:48 | |
*** jnengland77 has quit IRC | 20:48 | |
*** tote has quit IRC | 20:48 | |
*** matthewd has quit IRC | 20:48 | |
epyon | I'll post something for sure before leaving | 20:49 |
epyon | in brief - I'm in the middle of many things :> | 20:49 |
*** ezod has joined #tp | 20:49 | |
*** welterde has joined #tp | 20:49 | |
epyon | However I'm dedicated to finish them all | 20:49 |
*** cherez1 has joined #tp | 20:49 | |
*** jnengland77 has joined #tp | 20:49 | |
*** matthewd has joined #tp | 20:49 | |
*** tote has joined #tp | 20:49 | |
*** cherez1 has quit IRC | 20:50 | |
epyon | did a biggie recently with the split of Frame to Output/Input frame classes | 20:50 |
*** cherez has joined #tp | 20:50 | |
epyon | evaluations start the 17th, and end the 24th, so I'll have to fill mine in the 23rd after coming back | 20:52 |
epyon | nash: however I know my work will be much incomplete when I go on vacation. | 20:54 |
* epyon want's to continue as a part of the team though ^_^ | 20:55 | |
epyon | ... especially the untouched ASIO transition. | 20:55 |
nash | Okay | 20:56 |
nash | I'll look for the post ;-) | 20:56 |
nash | Have a good vacation | 20:56 |
epyon | try to choose "yes" on the survey :> | 20:56 |
epyon | oh, and I'll still be working till the 17th however. | 20:58 |
epyon | 15th* | 20:58 |
nash | heh | 20:58 |
nash | epyon: I'll flip a coin | 20:58 |
epyon | heads or tails? | 20:58 |
nash | heads, of course | 20:59 |
tansell_laptop | cherez, hope you are already writing that status report? | 20:59 |
*** tote has quit IRC | 21:01 | |
*** jnengland77 has quit IRC | 21:01 | |
*** matthewd has quit IRC | 21:01 | |
cherez | tansell_laptop: : Is that distinct from my weekly update? | 21:02 |
tansell_laptop | no | 21:02 |
*** tote has joined #tp | 21:02 | |
*** jnengland77 has joined #tp | 21:02 | |
*** matthewd has joined #tp | 21:02 | |
cherez | Then yes. | 21:03 |
tansell_laptop | cherez, we ready for a update then? | 21:16 |
tansell | cherez, poke? | 21:19 |
cherez | tansell: pongke? | 21:19 |
cherez | I'm making my update longer since I couldn't post last week. :/ | 21:19 |
cherez | Err... do you call something that's... not a singleton? | 21:20 |
llnz | object? class instance? | 21:22 |
*** nash has quit IRC | 21:22 | |
cherez | I'll go with object. | 21:24 |
tansell | cherez, so? | 21:30 |
cherez | tansell: Update posted. | 21:30 |
*** Greywhind has joined #tp | 21:31 | |
*** Erroneous has quit IRC | 21:32 | |
tansell | reading now | 21:32 |
tansell | cherez, did you get the comments I added to your CL? | 21:36 |
cherez | I was about to address those. | 21:36 |
tansell | cherez, so you really need some tests to find some of those bugs | 21:37 |
tansell | cherez, you should be running a local server | 21:38 |
tansell | debugging with a remote server is an insane idea | 21:38 |
tansell | cherez, so how much longer have you got? | 21:38 |
*** mithro has joined #tp | 21:39 | |
cherez | I'll be trying to set up a server tonight. | 21:39 |
cherez | Well, the firm "pencils down" date is next monday, so by that, it would be six days. | 21:39 |
tansell | it takes less then 5-10 minutes to get the server running | 21:39 |
cherez | Great. | 21:40 |
cherez | is the cpp server the "standard"? | 21:40 |
tansell | git clone git://git.thousandparsec.net/git/tpserver-cpp.git ; cd tpserver-cpp; ./autogen.sh; ./configure --prefix=/opt/tpserver-cpp ; make ; ./tpserver/tpserver -d -C ./quickstart-minisec.conf | 21:40 |
tansell | something like that should work | 21:40 |
tansell | so the suggested pencil down date was Monday | 21:41 |
cherez | Will I need to make sure all the libraries are installed? | 21:41 |
llnz | cherez: only requires boost and boost::signal, everything else is optional | 21:43 |
tansell | llnz, well you need guile | 21:51 |
*** bddebian has joined #tp | 21:52 | |
llnz | oh, true | 21:52 |
tansell | (or mzscheme - but guile is preferred) | 21:52 |
llnz | well... guile or mzscheme, aka plt-scheme | 21:53 |
*** Landon_ has joined #tp | 21:54 | |
*** cherez has quit IRC | 21:57 | |
*** Landon has quit IRC | 21:57 | |
*** Landon_ is now known as Landon | 21:57 | |
*** nash has joined #tp | 21:58 | |
*** nash has joined #tp | 21:59 | |
*** cherez has joined #tp | 22:00 | |
tansell | cherez - so what is coverage like for the stuff you have done? | 22:00 |
tansell | cherez, have you also looked at generation of documentation? | 22:00 |
cherez | In common everything but the SSL wrapper has pretty complete coverage. client doesn't have much yet since I've been wrestling with tpclient-pytext. | 22:03 |
cherez | I haven't looked at generation of documentation. | 22:03 |
tansell | cherez, it would be good to prove that you can generate decent documentation from your code | 22:04 |
tansell | so in the remaining week - I think we should aim to do | 22:04 |
tansell | a) have tpclient-pytext connecting and working with objects and orders | 22:04 |
tansell | b) have auto-generated documentation working and looking good | 22:04 |
tansell | c) have a auto-generated coverage report being created | 22:05 |
tansell | cherez, is there anything else you think we should have completed? | 22:05 |
cherez | I think that rounds it out well. | 22:06 |
cherez | The test script already generates a coverage report, though. | 22:06 |
tansell | cherez, I mean having it automatic as part of the website/checkin process | 22:07 |
cherez | Ah. | 22:07 |
tansell | cherez, I would also like you to collect some stats about stuff you have done | 22:07 |
tansell | IE how many lines of code you have written | 22:07 |
tansell | how many commits you have made, etc | 22:07 |
cherez | Does git do some magic help with that? | 22:09 |
tansell | cherez, I think there is a git-stats module that a GSoC did | 22:09 |
tansell | do a google or something | 22:09 |
tansell | cherez, I would also like you to do through and make sure the files are lint clean | 22:10 |
cherez | I guess that student had foresight that he'd be asked for those stats. | 22:10 |
cherez | Alright. | 22:10 |
tansell | http://www.logilab.org/card/pylintfeatures | 22:10 |
cherez | I've used it a few times. | 22:11 |
tansell | you'll probably need to customise the .pylintrc file to match the coding style | 22:11 |
tansell | but it would be good if you can make all files lint clean (by adding pylint: disable-msg=XXXX where needed) | 22:11 |
tansell | (or changing the rc file) | 22:12 |
tansell | anyway it's lunch time | 22:12 |
*** JLafont has joined #tp | 22:35 | |
*** alanp__ is now known as alanp | 22:46 | |
*** nebaway is now known as nebajoth | 23:02 | |
Greywhind | tansell: with the change to copy only the subtype and string, do you think my order copy/paste is good to go? | 23:20 |
tansell | point me to it | 23:20 |
tansell | I'll give it a quick once over now | 23:20 |
tansell | but I think it's probably good | 23:20 |
Greywhind | tansell: http://codereview.mithis.com/11001 | 23:21 |
tpb | Title: Issue 11001: Fixed pasting of orders in the order queue, along with libtpproto-py fix. - Code Review (at codereview.mithis.com) | 23:21 |
*** jmtan has joined #tp | 23:22 | |
tansell | Greywhind, did you split the stuff into two commits? | 23:22 |
Greywhind | tansell: i will when i do the --squash | 23:22 |
tansell | Greywhind, LGTM | 23:23 |
CIA-26 | Greywhind tpclient-pywx-tp04 * rf137af1fc1ee /windows/main/panelOrder.py: Fixed copying and pasting of orders in the order queue. | 23:26 |
CIA-26 | Greywhind tpclient-pywx-tp04 * r5fd16434dcfa /extra/StateTracker.py: Fixed method to insert orders in StateTracker.py | 23:26 |
*** nebajoth is now known as nebaway | 23:30 | |
CIA-26 | Greywhind tpclient-pywx-tp04 * r9585ec03cc07 /windows/main/winIdleFinder.py: Re-added 'object type' column to winIdleFinder.py, now works with tp04. | 23:31 |
Greywhind | tansell: can you look back at my media stuff? | 23:33 |
Greywhind | tansell: i'm uploading new CLs now | 23:33 |
Greywhind | tansell: http://codereview.mithis.com/9001/show | 23:33 |
tpb | Title: Issue 9001: Improved media support by centralizing media calls and adding a download manager. - Code Review (at codereview.mithis.com) | 23:33 |
tansell | Greywhind, sure | 23:34 |
Greywhind | tansell: http://codereview.mithis.com/10002/show | 23:35 |
tpb | Title: Issue 10002: Added threaded downloading, fixed up code in media.py - Code Review (at codereview.mithis.com) | 23:35 |
tansell | Greywhind, git stash is your friend | 23:38 |
tansell | Greywhind, so I'm still not happy with the mixin class | 23:42 |
Greywhind | tansell: what would you like done with it? | 23:47 |
tansell | adding comments now | 23:52 |
Greywhind | k | 23:52 |
*** bddebian has quit IRC | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!