*** tpb has joined #tp | 00:00 | |
*** ChanServ sets mode: +o tpb | 00:00 | |
*** tansell-laptop has joined #tp | 00:08 | |
*** tansell-laptop has quit IRC | 00:16 | |
*** tansell-laptop has joined #tp | 00:16 | |
*** alanp has quit IRC | 00:22 | |
llnz | bbl | 00:36 |
---|---|---|
*** llnz has quit IRC | 00:36 | |
*** alanp has joined #tp | 00:42 | |
*** Greywhind has quit IRC | 00:50 | |
*** gimpster has joined #tp | 00:53 | |
*** gimpster has quit IRC | 00:57 | |
*** mhilmi has quit IRC | 01:06 | |
*** jnengland771 has joined #tp | 02:04 | |
*** jnengland77 has quit IRC | 02:04 | |
alanp | could we have a "setPropertyValue(uint32_t propid, double propvalue)" in the Design class? | 02:33 |
alanp | IE: if i push it on my branch, does it have a shot at making it in? | 02:38 |
*** jnengland771 has quit IRC | 02:44 | |
*** tansell-laptop has quit IRC | 03:16 | |
*** nash has quit IRC | 03:22 | |
*** llnz has joined #tp | 03:41 | |
tansell | alanp, what do you mean? | 04:34 |
tansell | llnz, question for you for alanp | 04:35 |
*** jmtan has quit IRC | 05:06 | |
CIA-21 | llnz libtpproto-cpp * rffd965e51baf /tpproto/gamelayer.cpp: Fixed small issue with ordering of connecting and adding to eventloop. | 05:07 |
llnz | alanp: why do you want it? | 05:08 |
tansell | <alanp> could we have a "setPropertyValue(uint32_t propid, double propvalue)" in the Design class? | 05:43 |
tansell | <alanp> IE: if i push it on my branch, does it have a shot at making it in? | 05:43 |
llnz | tansell: i saw that | 05:44 |
tansell | oh sorry | 05:44 |
llnz | my reply is, "why do you want that function"? if it's reasonable, then it would get it | 05:45 |
*** mithro has quit IRC | 06:56 | |
*** CIA-21 has quit IRC | 07:54 | |
*** mithro has joined #tp | 08:03 | |
*** CIA-28 has joined #tp | 08:04 | |
* llnz wanders off | 08:41 | |
llnz | later all | 08:41 |
*** llnz has quit IRC | 08:41 | |
*** greenlion has joined #tp | 08:59 | |
*** JLP_ has joined #tp | 09:04 | |
*** JLP has quit IRC | 09:14 | |
*** nicola has joined #tp | 09:25 | |
*** Greywhind has joined #tp | 09:33 | |
*** nicola has quit IRC | 09:39 | |
*** peres has joined #tp | 09:40 | |
*** mithro has quit IRC | 10:05 | |
*** peres has quit IRC | 10:13 | |
*** alanp_ has joined #tp | 10:13 | |
*** jmtan has joined #tp | 10:22 | |
*** bddebian has joined #tp | 10:33 | |
bddebian | Heya | 10:42 |
*** verhoevenv has joined #tp | 11:13 | |
*** tuna-fish has joined #tp | 11:41 | |
*** tuna-fish has quit IRC | 11:58 | |
*** mhilmi has joined #tp | 12:38 | |
verhoevenv | ~any reac | 12:45 |
tpb | verhoevenv: I have not seen reac. | 12:45 |
verhoevenv | I suppose that's not how the bot works then. | 12:45 |
*** JLP has joined #tp | 13:10 | |
*** JLP_ has quit IRC | 13:12 | |
*** tote has quit IRC | 13:12 | |
*** tote has joined #tp | 13:19 | |
*** Erroneous has joined #tp | 13:31 | |
*** JLafont_ has joined #tp | 13:34 | |
*** welterde has quit IRC | 13:37 | |
*** JL has quit IRC | 13:37 | |
*** ezod has quit IRC | 13:37 | |
*** JL has joined #tp | 13:38 | |
*** ezod has joined #tp | 13:38 | |
*** welterde has joined #tp | 13:38 | |
*** alanp__ has joined #tp | 13:40 | |
*** alanp_ has quit IRC | 13:41 | |
*** alanp__ is now known as alanp_ | 13:45 | |
*** epyon has quit IRC | 13:47 | |
*** JLafont has joined #tp | 13:47 | |
*** epyon has joined #tp | 13:49 | |
*** JL has quit IRC | 13:53 | |
*** JLafont_ has quit IRC | 13:56 | |
*** greenlion has quit IRC | 14:00 | |
*** greenlion has joined #tp | 14:03 | |
*** welterde has quit IRC | 14:21 | |
*** ezod has quit IRC | 14:21 | |
*** ezod has joined #tp | 14:22 | |
*** jmtan has quit IRC | 14:36 | |
*** greenlion has quit IRC | 14:39 | |
*** alanp_ has quit IRC | 15:38 | |
*** welterde has joined #tp | 15:59 | |
*** llnz has joined #tp | 16:02 | |
llnz | morning all | 16:07 |
mhilmi | heym llnz | 16:10 |
mhilmi | hey | 16:10 |
llnz | hi mhilmi | 16:11 |
mhilmi | saw your fix posted, ty, guess it really was simple :P | 16:11 |
llnz | yeah | 16:13 |
alanp | llnz: hey, for the set property, i was thinking the easiest way to build a ship would be to subtract the productionpoints property | 16:13 |
alanp | IE: build order need 1000 points | 16:14 |
alanp | i have 100 available, decrement property by 100 | 16:14 |
alanp | let me know if that's a bad idea? | 16:14 |
llnz | well, there is only one instance of each design, so that's not a good idea | 16:14 |
llnz | unless i misunderstand | 16:14 |
alanp | hrm yeah | 16:15 |
alanp | what's the best way to go about it w/o local variables then? | 16:15 |
llnz | humm... | 16:18 |
llnz | the ship parts resource is how minisec does it | 16:20 |
llnz | oh | 16:20 |
llnz | how about the resources required list? | 16:21 |
llnz | (just called resources in order.h) | 16:22 |
alanp | i guess i could do a resource | 16:23 |
llnz | the planet wouldn't need an instance or value of the resource, just set in order on create and decrement in doOrder | 16:29 |
alanp | set the resource in the build order? | 16:33 |
llnz | yeah | 16:33 |
llnz | the order has a list of resources that will be consumed by the order | 16:34 |
alanp | cool | 16:34 |
alanp | that will work | 16:34 |
cherez | llnz: Ping? | 16:39 |
llnz | cherez: pong! | 16:39 |
cherez | llnz: Don't get too excited there. | 16:39 |
llnz | hehehe | 16:39 |
cherez | The TP04 documents mention a new protocol versioning scheme. | 16:40 |
cherez | I don't see this Frame Type Version anywhere in protocol.xml. | 16:40 |
llnz | have a look at the header frame | 16:41 |
llnz | it could probably do with a bit more documentation | 16:42 |
cherez | I was thinking something like actually giving the version number. | 16:43 |
cherez | As it is right now it's pretty hard to figure it out by parsing protocol.xml | 16:43 |
cherez | Also, is there a reason why spaces and tabs are freely intermixed in protocol.xml? | 16:44 |
llnz | for reference, as web page version of the protocol doc generated from protocol.xml: http://www.thousandparsec.net/tp/dev/documents/protocolxml.php | 16:44 |
tpb | <http://ln-s.net/JXj> (at www.thousandparsec.net) | 16:44 |
llnz | cherez: re tabs/spaces, xml allows it and some what done by mithro who prefers tabs, and some by me, where the tools i use happen to use spaces | 16:45 |
llnz | to indent | 16:45 |
cherez | Right, but if the frame type version is ever not '0' there isn't any good way for the protocol library to know that. | 16:46 |
llnz | it is not currently ever not the default | 16:46 |
llnz | double negative | 16:46 |
llnz | it's it always the default | 16:47 |
llnz | currently | 16:47 |
cherez | Well, if that ever changes the libraries will be upset with you. | 16:47 |
*** jnengland77 has joined #tp | 16:48 | |
llnz | afaik, there is no way in the xml to define it to be otherwise | 16:48 |
llnz | so it will have to be added to the dtd frist | 16:48 |
cherez | Alright. | 16:48 |
llnz | i don't think we will ever use it | 16:50 |
cherez | So I can assume it will be null forever? | 16:51 |
llnz | for now, that would be safe | 16:52 |
cherez | Sweet, that makes my job easy. | 16:52 |
cherez | Now to figure out a good way to test the correctness of the connection library.... :/ | 16:53 |
*** bddebian has quit IRC | 16:54 | |
*** JLafont has quit IRC | 17:08 | |
*** JLafont has joined #tp | 17:11 | |
*** jnengland77 has quit IRC | 17:31 | |
mhilmi | llnz: ping | 17:58 |
llnz | mhilmi: pong | 17:58 |
mhilmi | GameLayer::gameInfoCallback(Frame* frame) is empty and I think it is getting stuck here? Can you have a look. | 17:59 |
mhilmi | The connect callback is properly being executed now though and I receive the get the server features frame but I think it hangs after that | 18:00 |
llnz | the library does nothing after it receives the game info/features frame, until the client tells it to | 18:01 |
llnz | some work around gameinfo is still required, but not needed at the moment | 18:02 |
mhilmi | I try to logon after connecting - the status listener fires to connect status also, but it seems it just hangs before logging on, hrm I'll see if I can find where its getting stuck. | 18:03 |
mhilmi | still didn't add the protocol library itself to my build to be able to debug it... | 18:04 |
llnz | i think you will need to try to login after the status listener is told the connection is in the connected status | 18:05 |
mhilmi | I'll see what works, get back to you.. | 18:07 |
mhilmi | ah I fixed it, was just a problem with the Qt app not updating events before trying to logon, logged in now..! | 18:14 |
llnz | cool! | 18:16 |
alanp | llnz: i don't see resources in order.h? | 18:28 |
alanp | nm, i am clearly blind | 18:29 |
llnz | hehe, that's ok | 18:29 |
mhilmi | llnz: is it bad practice to store a username and pass as class variables? | 18:29 |
alanp | llnz: could we add a setResource to Order? | 18:30 |
llnz | mhilmi: maybe, but i don't think it's critical problem for TP | 18:30 |
llnz | alanp: it's protected, access directly in the subclass | 18:31 |
alanp | hmm | 18:31 |
mhilmi | ya im guessing either way you would be able to snoop the variables whether they are in a class scope or function scope.. | 18:31 |
alanp | llnz: ahh | 18:32 |
alanp | right | 18:32 |
alanp | thx | 18:32 |
*** verhoevenv has quit IRC | 18:46 | |
*** peres has joined #tp | 18:51 | |
*** nash has joined #tp | 18:53 | |
*** DTRemenak has quit IRC | 18:59 | |
*** tuna-fish has joined #tp | 19:20 | |
alanp | almost there..... | 19:23 |
alanp | epyon: ping | 19:30 |
*** tansell-laptop has joined #tp | 19:34 | |
*** peres has quit IRC | 19:54 | |
Greywhind | tansell-laptop: ping? | 19:56 |
tansell-laptop | Greywhind, pong | 19:56 |
Greywhind | tansell-laptop: do you think we might be able to meet a little earlier tomorrow than usual? maybe... 2 hours earlier? | 19:57 |
tansell-laptop | tommorrow? | 19:57 |
Greywhind | tansell-laptop: we usually meet on my wednesday/your thursday, don't we? | 19:58 |
tansell-laptop | yes | 19:58 |
Greywhind | tansell-laptop: so... what do you think? | 20:02 |
tansell-laptop | yes that should be okay | 20:03 |
Greywhind | ok | 20:03 |
Greywhind | thanks | 20:03 |
CIA-28 | alanp tpserver-cpp-mtsec * rc97628ac06f3 /modules/games/mtsec/ (build.cpp build.h planet.cpp planet.h): Build Order now working properly, settings turns based on ProductCost. | 20:07 |
alanp | phew | 20:08 |
alanp | i'm going to have to clean that up some bit :( | 20:08 |
llnz | cool | 20:09 |
alanp | i should put a note in it | 20:11 |
CIA-28 | alanp tpserver-cpp-mtsec * r9853868c39e9 /modules/games/mtsec/build.cpp: Note to self... | 20:13 |
alanp | llnz: using resources[] was a good idea | 20:13 |
alanp | not sure why i wanted to change that in the first place | 20:13 |
alanp | need to move everything to my MTSecRuleset namespace too at some point | 20:15 |
alanp | get rid of cstyle casts | 20:15 |
alanp | etc, etc | 20:15 |
*** Greywhind has quit IRC | 20:23 | |
cherez | tansell: http://codereview.mithis.com/3002/show http://codereview.mithis.com/10001/show http://codereview.mithis.com/5004/show | 20:36 |
tpb | Title: Issue 3002: Parser - Code Review (at codereview.mithis.com) | 20:36 |
tansell | cherez, I'm not seeing daily blog posts either? | 20:37 |
tansell | cherez, did you split 3002 like I asked? | 20:38 |
cherez | tansell: Yeah, but I don't know how to upload a cl relative to 2 different branches, and 3002 is dependent on the protocol.xml and structures branches. | 20:39 |
tansell | cherez, so upload the other two first | 20:40 |
tansell | then once they are committed | 20:40 |
tansell | re-upload 3002 | 20:40 |
cherez | tansell: You already LGTMed one; the other is 5004. | 20:41 |
tansell | cherez, well have you pushed the that LGTMed that one? | 20:41 |
cherez | No, I'll do that right now. | 20:42 |
*** tansell-laptop has quit IRC | 20:42 | |
tansell | cherez, you didn't reply to my comments in 5004? | 20:42 |
*** mithro has joined #tp | 20:48 | |
tansell | cherez, so why does 5004 *still* have the pack/unpack methods? | 20:49 |
cherez | tansell: Well, we aren't using the callback scheme yet, so I think they're useful functions at least until the callback has been implemented. | 20:50 |
*** tansell-laptop has joined #tp | 20:53 | |
tansell | libtpproto2-pyA rewrite of libtpproto-py...Steven Wallace5 weeks ago | 20:56 |
tansell | cherez, well it's almost meeting time | 20:57 |
CIA-28 | snwallace libtpproto2-py * r9e7d8d79b5e4 /tp/netlib/ (protocol.xml protocol3.xml): Latest versions of protocol.xml from the documents repository. | 20:58 |
tansell | from last week | 21:02 |
tansell | tansellso I would like to see the xstruct.py stuff merged ASAP | 21:02 |
tansell | tansellso it should be about a day's worth of work? | 21:02 |
tansell | cherezSounds about right. | 21:03 |
tansell | tansellbut the first thing to start on is the stringqueue stuff | 21:03 |
tansell | tansellthen on to class ConnectionCommon(object): | 21:03 |
tansell | tanselldo you think you can get to that by next week? | 21:03 |
tansell | cherezI think so. | 21:03 |
tansell | so where are we at regarding that plan? | 21:05 |
tansell | GSoC is rapidly coming to an end and we still have a huge amount of work to finish off for this project | 21:05 |
cherez | tansell: Only part of that which isn't done is ConnectionCommon; I didn't realize it would require some changes in Parser and objects_auto. | 21:10 |
cherez | I also think there needs to be some logic added to the frame receiving methods, but we can discuss that when I get that far. | 21:12 |
tansell | ahh shit | 21:21 |
tansell | http://search.twitter.com/search?q=gmail+down | 21:22 |
tpb | Title: gmail down - Twitter Search (at search.twitter.com) | 21:22 |
cherez | Gmail is working for me.... | 21:23 |
tansell | cherez, so we agreed on daily blog posts right? | 21:23 |
cherez | Right. | 21:24 |
tansell | so I see 14th, 15th, 17th and 20th | 21:25 |
tansell | what happened to 16th and 18th, 19th? | 21:25 |
cherez | I wasn't sure what to report on those days. | 21:27 |
*** Erroneous has quit IRC | 21:29 | |
tansell | cherez, so what did you do on those days? | 21:35 |
cherez | Mess with fixing the xstruct nested list bug, and fail. Try to find a good way to determine what thread has acquired a particular lock. | 21:37 |
tansell | so reporting stuff that failed to work is just as important as reporting success | 21:37 |
tansell | cherez, please also reply to the comments I put in your CLs | 21:40 |
tansell | even if it's just with "Done" | 21:40 |
cherez | Alright. | 21:40 |
tansell | as it'll let me better see you have seen my comments | 21:40 |
cherez | Alright. | 21:45 |
tansell | cherez, so how long until you finish? | 22:01 |
cherez | Finish...? | 22:01 |
tansell | GSoC | 22:12 |
tansell | IE how much time do you have left? | 22:12 |
tansell | and how are we going to split that up | 22:13 |
tansell | it seems to me that you have 3-4 weeks | 22:13 |
alanp | 3 weeks until clean up | 22:13 |
cherez | Oh, the "pencils down" date. | 22:15 |
cherez | I forgot that precedes the end of the program. | 22:15 |
tansell | there is still a shit load of stuff to do before then | 22:18 |
cherez | Time to develop a caffeine addiction. | 22:18 |
tansell | cherez, so what is the plan for the next 3 weeks? | 22:20 |
cherez | So I have common, client, server, GenericRS, and discover? | 22:21 |
tansell | yes | 22:24 |
tansell | GenericRS can be ignored I think | 22:24 |
tansell | so can discover | 22:24 |
tansell | we also have "port libtpclient-py to use libtpproto2-py" | 22:25 |
tansell | as that is final proof that the library actually works | 22:26 |
tansell | you might want to test with tpclient-pytext too | 22:26 |
cherez | Alright. | 22:26 |
cherez | So 3 modules and porting a library in 3 weeks.... | 22:32 |
*** Greywhind has joined #tp | 22:42 | |
alanp | cherez: i found an espresso maker @ walmart for $35... ;-) | 22:45 |
*** jmtan has joined #tp | 22:46 | |
cherez | alanp: Thanks. :) | 22:48 |
alanp | i consider it gsoc money well spent, hehe | 22:48 |
*** tansell_laptop has joined #tp | 22:52 | |
*** tansell-laptop has quit IRC | 22:54 | |
*** jnengland77 has joined #tp | 23:03 | |
*** nash has quit IRC | 23:06 | |
*** Greywhind has quit IRC | 23:30 | |
tansell | cherez, sorry went to lunch | 23:49 |
cherez | tansell: No worries. | 23:50 |
tansell | cherez, so you're going to have to put in a lot of work to get the stuff done | 23:50 |
*** bddebian has joined #tp | 23:55 | |
*** Greywhind has joined #tp | 23:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!