| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| *** peres has left #tp | 00:05 | |
| *** peres has joined #tp | 00:19 | |
| *** peres has joined #tp | 00:20 | |
| llnz | bbl | 00:32 |
|---|---|---|
| *** llnz has quit IRC | 00:32 | |
| tansell | Greywhind, in that nothing has mutliple order queues? | 00:41 |
| tansell | btw if an object only has one order queue | 00:41 |
| tansell | it would be a good idea to hide the order queue select dialog | 00:41 |
| Greywhind | tansell: hm... i suppose. | 00:42 |
| tansell | well the space is limited | 00:42 |
| Greywhind | tansell: do you know of any way i can test multiple order queues, or the order parameter types that aren't used yet? | 00:42 |
| tansell | Greywhind, two ways | 00:43 |
| tansell | add support into tpserver-cpp | 00:43 |
| tansell | add support into tpserver-py | 00:43 |
| tansell | oh - figure out a better testing methodology | 00:43 |
| tansell | so that's three ways | 00:43 |
| Greywhind | do you think i might be able to get Llnz to make something that i could test it with? | 00:43 |
| tansell | testing gui stuff sucks | 00:43 |
| tansell | Greywhind, you know C++ right?> | 00:44 |
| Greywhind | tansell: yes | 00:45 |
| tansell | Greywhind, feel free to hack away :P | 00:45 |
| Greywhind | tansell: i don't know if i'd be able to figure it out, but we'll see | 00:46 |
| tansell | chat with lee | 00:46 |
| Greywhind | will do | 00:46 |
| tansell | do notice that I never implimented a bunch of tp03 order types because they where never used | 00:46 |
| tansell | if you could figure out do actual testing, that would be really helpful | 00:47 |
| Greywhind | yeah, i've been working on trying to make some of the missing panel types | 00:47 |
| tansell | but I think it's going to be impossible | 00:47 |
| Greywhind | the genericreferencelist parameter looks rather complex. don't know if i'll be able to make that one without spending a lot of extra time at it | 00:47 |
| tansell | Greywhind, it's not as complicated as it might first seem | 00:48 |
| Greywhind | good to hear :) | 00:48 |
| Greywhind | once i have at least a little testing done on it, i'll look at submitting a big patch for review | 00:49 |
| tansell | okay | 00:51 |
| tansell | I think fixing up the starmap to work with this new order structure is probably the next move | 00:51 |
| Greywhind | tansell: yeah | 00:54 |
| *** jmtan has joined #tp | 01:02 | |
| tansell | hey jmtan | 01:06 |
| jmtan | hi tansell | 01:07 |
| tansell | how are things? | 01:07 |
| jmtan | the battleviewer should see more commits soon, i wasn't around yesterday but Landon was making progress on monday | 01:11 |
| tansell | okay great | 01:12 |
| *** llnz has joined #tp | 01:31 | |
| CIA-46 | llnz libtpproto-cpp * r42c13edb04d2 / (index.dox tpproto/gamelayer.cpp): | 01:53 |
| CIA-46 | Protect against segfault if EventLoop is not set. | 01:53 |
| CIA-46 | Also updated Doxygen main page to make the requirement for an eventloop | 01:53 |
| CIA-46 | before connection. | 01:53 |
| *** greenlion has joined #tp | 02:08 | |
| *** Noughmad has joined #tp | 02:17 | |
| Landon | ah hey jmtan, probably heading off to bed real soon but I was wondering what your idea on thsi was | 02:37 |
| Landon | I'm thinking to be able to progress through rounds (and go backwards, etc) I'll need a list of scenes or something like that | 02:38 |
| Landon | I'm not sure if that's something feasible in ogre though? storing a state to come back to it later | 02:39 |
| Landon | my other option seems to be having a forward/reverse method for each event, pass it a state and it "adds" itself or "subtracts" itself from the scene | 02:39 |
| Landon | s/state/scene | 02:39 |
| Landon | for now I think I'll try and focus on having transformation methods on each event | 02:41 |
| jmtan | yup, ogre is scenegraph based, so just store your scenes as nodes | 02:43 |
| jmtan | you can remove a node to hide the entire scene then | 02:43 |
| jmtan | what sort of transformation methods? | 02:45 |
| Landon | well, since I've changed the battlexml parser to give back a list of all events now, it could be something like | 02:45 |
| Landon | battle.round.events[i].forward(Scene) | 02:46 |
| Landon | and it would say, move the ship | 02:46 |
| Landon | and have a counterpart battle.round.events[i].reverse(Scene), which would move the ship from the destination back to the source | 02:47 |
| Landon | but if I can easily copy nodes, I'll do that instead | 02:47 |
| Landon | would probably be easier to have a list of those made before the battle and just progress through them as needed | 02:47 |
| jmtan | i guess the actual movements will be arbitrary, since only firing and damage are captured in battlexml | 02:52 |
| Landon | hm? | 02:55 |
| Landon | I thought there was movement in the DTD | 02:55 |
| jmtan | oh, ok | 02:56 |
| Landon | I guess it must not be implemented in the srvers yet | 02:57 |
| *** nash has quit IRC | 03:01 | |
| *** JLafont_ has quit IRC | 03:11 | |
| *** Greywhind has quit IRC | 03:59 | |
| *** llnz2 has joined #tp | 05:06 | |
| *** llnz has quit IRC | 05:13 | |
| *** llnz2 is now known as llnz | 05:13 | |
| *** jmtan has quit IRC | 06:39 | |
| *** tansell_laptop has quit IRC | 07:59 | |
| CIA-46 | joelboh tpclient-pyweb * r051ba3d929d2 /backend/ (application.py middleman.py): Added a cache update handler | 08:21 |
| *** greenlion has quit IRC | 08:28 | |
| *** greenlion has joined #tp | 08:29 | |
| * llnz wanders off | 08:42 | |
| llnz | later all | 08:42 |
| *** llnz has quit IRC | 08:42 | |
| epyon | Is there a reason why EXTRACT_ALL is turned off in Doxygen? | 08:55 |
| epyon | and second question, how do I push to a branch? | 09:01 |
| * epyon is lost in git :/ | 09:05 | |
| tote | epyon: git push url branch (i think) | 09:13 |
| epyon | my question is what is the difference between git push and git commit :/ | 09:17 |
| tote | when you do git commit, you commit your changes to your local working copy (the one you cloned), then when you do git push you upload those commits to the server | 09:19 |
| epyon | hmm, so what's the point of doing commits if you're working on atomic commit way? | 09:21 |
| epyon | You need to do commit then push each time? | 09:21 |
| tote | yes commit and push, atleast thats what im doing and it seems to work :) | 09:21 |
| tote | im new to git too :) | 09:22 |
| epyon | svn is sooo much user-friendly D: | 09:22 |
| ezod | epyon: git is a distributed vcs | 09:25 |
| ezod | you're using it in a sort of non-distributed way so it seems redundant | 09:26 |
| shenki | as a person who has to use svn at work, i feel that "svn is sooo much user-friendly" is the most inaccurate statement i've heard in a while :) | 09:27 |
| epyon | shenki: I'm using svn for practically everything now, including but not limited to the windows registry :P | 09:46 |
| * epyon is wondering why vector length returns doubles | 09:47 | |
| shenki | epyon: so you could tell me how to see the diff between two reivsions of svn:externals? | 09:48 |
| epyon | uint64_t should be enough for everybody -_- | 09:48 |
| epyon | shenki: vendor branch? | 09:48 |
| shenki | epyon: huh? | 09:48 |
| epyon | use vendor branches :) | 09:49 |
| shenki | i don't understand | 09:49 |
| epyon | http://svnbook.red-bean.com/en/1.1/ch07s05.html | 09:49 |
| tpb | Title: Vendor branches (at svnbook.red-bean.com) | 09:49 |
| epyon | and then do a normal svn diff on them | 09:50 |
| shenki | err... that's not the question tho | 09:50 |
| shenki | if i was going to re-architect the way the repository worked, i would use git :) | 09:50 |
| shenki | but i can't | 09:50 |
| epyon | If you store the url as a vendor branch and not as a svn:external, you'll be able to run snv diff on it | 09:51 |
| shenki | yep | 09:51 |
| shenki | so the answer to my question is: you can't? | 09:51 |
| shenki | that's the conclusion i came to | 09:51 |
| epyon | Just like you can't make git do coffee. | 09:51 |
| shenki | i don't want to diff the contents of the externals... i want to see what my co-worker broke when he updated externals right before a release | 09:52 |
| shenki | (true story) | 09:52 |
| epyon | svn:externals is not the tool for the job. Vendor branches is | 09:52 |
| shenki | in this case, he siwtched from using a tag to using 'trunk -r 123' | 09:52 |
| epyon | If you don't keep something under a version control system you shouldn't be surprised that it doesn't store version info :P | 09:52 |
| shenki | but svn:externals is stored as a revision in svn | 09:53 |
| shenki | when i propedit, i then commit it which creates a new revision | 09:54 |
| shenki | if there's a new revision, why can't i see what the difference is between those revisions? | 09:54 |
| epyon | methinks you get the idea wrong | 09:54 |
| epyon | anyway, I still don't know why Vector.length returns double -_- | 09:54 |
| shenki | the work around is to do svn propget svn:externals > ver1, then checkout the old revision, and do svn propget svn:externals > ver2, then do 'diff -up ver1 ver2' | 09:55 |
| *** mithro has quit IRC | 10:30 | |
| epyon | who broke the risk ruleset? | 10:41 |
| epyon | anyway, I'm still at a loss when pushing to branches D: | 10:49 |
| ezod | epyon: what do you want to do? | 10:51 |
| ezod | you already made a commit, but want to push it to a different branch than you are currently on? | 10:52 |
| CIA-46 | alanp tpserver-cpp-refactor * r7a7c21df9fee /AUTHORS: Added myself to the AUTHORS file as per Aaron | 10:54 |
| CIA-46 | alanp tpserver-cpp-refactor * r11ae51e7d72a /AUTHORS: | 10:54 |
| CIA-46 | Revert "Added myself to the AUTHORS file as per Aaron" | 10:54 |
| CIA-46 | This reverts commit 7a7c21df9fee817f3dfddbc28006d4fbf87f5e88. | 10:54 |
| CIA-46 | mavrinac tpserver-cpp-refactor * r104409969059 /AUTHORS: | 10:54 |
| CIA-46 | Revert "Added myself to the AUTHORS file as per Aaron" | 10:54 |
| CIA-46 | This reverts commit 7a7c21df9fee817f3dfddbc28006d4fbf87f5e88. | 10:54 |
| CIA-46 | noegnud tpserver-cpp-refactor * rbbb02f7f76dd /autogen.sh: | 10:54 |
| CIA-46 | Added conditions to autogen.sh to check for glibtoolize if libtoolize is not available. This | 10:54 |
| CIA-46 | will allow autogen.sh to work on Mac OS X, which calls it glibtoolize. | 10:54 |
| CIA-46 | llnz tpserver-cpp-refactor * r5491891d28ea /tpserver/main.cpp: | 10:54 |
| CIA-46 | Added headers needed for MacOS (probably others too). | 10:54 |
| CIA-46 | Thanks greywhind. | 10:54 |
| CIA-46 | llnz tpserver-cpp-refactor * rc45a3d5a2c3d /configure.ac: | 10:54 |
| CIA-46 | Pass the guile CFLAGS and LDFLAGS to the AC_CHECK_LIB for guile. | 10:54 |
| CIA-46 | Should fix greywhind's MacOS configure issue. | 10:54 |
| CIA-46 | llnz tpserver-cpp-refactor * r3820bd41f1be /configure.ac: Fix the previous mistake in passing flags to the guile lib test. | 10:54 |
| CIA-46 | epyon tpserver-cpp-refactor * r9e5de1b4c034 /tpserver/referenceobjectparam.h: | 10:54 |
| CIA-46 | Include guard fixed. | 10:54 |
| CIA-46 | (also a test of commit access) | 10:54 |
| CIA-46 | llnz tpserver-cpp-refactor * r138206c6edf7 /tpserver/ (4 files): | 10:54 |
| CIA-46 | Added Media ObjectParameter to tpserver-cpp. | 10:54 |
| CIA-46 | Had not yet been added. Needs users in the rulesets. | 10:54 |
| CIA-46 | llnz tpserver-cpp-refactor * rf4d0ba84e4b2 /tpserver/game.cpp: | 10:54 |
| CIA-46 | Updated default media base url. | 10:54 |
| CIA-46 | We moved to subversion a while ago. | 10:54 |
| CIA-46 | llnz tpserver-cpp-refactor * r438e8c4b425b /.gitignore: Added the docs directory to gitignore | 10:55 |
| CIA-46 | llnz tpserver-cpp-refactor * rb5b35fda15cf /modules/games/minisec/ (10 files): | 10:55 |
| CIA-46 | Pull out the ParameterGroupID and ParameterID values as constants in Minisec. | 10:55 |
| CIA-46 | Should make adding media parameters easier. | 10:55 |
| CIA-46 | llnz tpserver-cpp-refactor * rf9844cb0a6e2 /modules/games/minisec/ (6 files): | 10:55 |
| CIA-46 | Added media parameters to SpaceObject in Minisec. | 10:55 |
| CIA-46 | Had to update all the ParameterGroupIDs. Needs to still be set. | 10:55 |
| CIA-46 | This adds two parameters, called "Icon" and "Media", that are for the icon and main media | 10:55 |
| CIA-46 | respectively, as they are not currently together in the media repo. | 10:55 |
| CIA-46 | llnz tpserver-cpp-refactor * r92426643ea79 /modules/games/minisec/ (build.cpp minisec.cpp minisec.h splitfleet.cpp): | 10:55 |
| CIA-46 | Add media to minisec objects. | 10:55 |
| CIA-46 | Looks like the Names and subclasses should be moved to core. | 10:55 |
| CIA-46 | llnz tpserver-cpp-refactor * re9a6d285805f /modules/games/minisec/minisec.cpp: | 10:55 |
| CIA-46 | (27 lines omitted) | 10:55 |
| ezod | i take it you just wanted to merge master into your branch? | 10:55 |
| epyon | err ... no D: | 10:56 |
| ezod | well... looks like you did :P | 10:56 |
| epyon | I just wanted to push a commit -_- | 10:56 |
| ezod | well if you merged in master it would have to push all those commits to your branch also | 10:57 |
| epyon | no f* clue why this happened --- | 10:57 |
| ezod | did you do a git merge origin/master previous to your own commit? | 10:57 |
| ezod | (i.e. to get the latest changes from master into your branch) | 10:57 |
| epyon | err no? | 10:58 |
| * epyon is hopelessly confused with git | 10:59 | |
| epyon | I just followed a tutorial actually | 10:59 |
| * epyon wonders if his commit actually got pushed at all | 10:59 | |
| ezod | updated vector3d? | 11:09 |
| ezod | http://git.thousandparsec.net/gitweb/gitweb.cgi?p=tpserver-cpp.git;a=shortlog;h=refs/heads/refactor | 11:09 |
| tpb | <http://ln-s.net/3IUd> (at git.thousandparsec.net) | 11:09 |
| ezod | it certainly looks as though you merged master :) | 11:10 |
| ezod | which is fine | 11:10 |
| *** peres has left #tp | 11:17 | |
| epyon | ezod, seems it's not fine because it doesn't compile :/ | 11:30 |
| CIA-46 | epyon tpserver-cpp-refactor * r0bface703882 / (4 files in 2 dirs): | 11:51 |
| CIA-46 | Message class update | 11:51 |
| CIA-46 | * doxymented the class, and fixed spaces/tabs | 11:51 |
| CIA-46 | * typedefed Reference and Reference set | 11:51 |
| CIA-46 | * propagated the typedefs to the rest of server | 11:51 |
| CIA-46 | * changed addReference to take a RefSysType value | 11:51 |
| ezod | epyon: well, because of the nature of your project, you will probably need to be careful merging master | 12:13 |
| ezod | changes there could break your stuff | 12:13 |
| ezod | although you'd have to deal with that eventually anyway | 12:13 |
| epyon | something is inherently broken with the design of the message board system -_- | 12:21 |
| CIA-46 | epyon tpserver-cpp-refactor * rb3c4eed8d501 /tpserver/ (board.cpp board.h): | 12:27 |
| CIA-46 | Board class update | 12:27 |
| CIA-46 | * doxyfication, tabs/spaces and a few style corrections | 12:27 |
| CIA-46 | epyon tpserver-cpp-refactor * r782dd618f53f /tpserver/board.cpp: * addMessage was unneccessary complex | 12:27 |
| *** greenlion has quit IRC | 12:32 | |
| ezod | epyon: whoa, it looks like origin/refactor is out of sync with refactor? don't know what that means, poke mithro about it | 12:39 |
| epyon | ezod: yeah, will have to | 12:40 |
| epyon | ezod: any idea when I can catch him | 12:40 |
| epyon | ? | 12:40 |
| ezod | epyon: 6 or 7 hours from now maybe? | 12:41 |
| ezod | tansell: ping | 12:41 |
| *** Erroneous has joined #tp | 13:19 | |
| *** Vadtec is now known as Betwix | 13:55 | |
| *** Betwix is now known as Vadtec | 13:55 | |
| *** Greywhind has joined #tp | 13:59 | |
| *** greenlion has joined #tp | 14:15 | |
| *** greenlion has quit IRC | 14:23 | |
| *** greenlion has joined #tp | 14:33 | |
| *** verhoevenv has joined #tp | 14:53 | |
| *** greenlion has quit IRC | 15:09 | |
| *** greenlion has joined #tp | 15:09 | |
| *** alanp has joined #tp | 15:22 | |
| *** welterde has quit IRC | 15:25 | |
| *** welterde has joined #tp | 15:26 | |
| *** Noughmad has quit IRC | 15:33 | |
| *** llnz has joined #tp | 16:05 | |
| *** greenlion has quit IRC | 16:14 | |
| *** greenlion has joined #tp | 16:20 | |
| *** alanp has quit IRC | 16:58 | |
| mhilmi | llnz: ping | 17:28 |
| llnz | mhilmi: pong | 17:28 |
| mhilmi | hey :) | 17:29 |
| mhilmi | im having some issues building my client - I'm getting errors in the boost library when I try to create an SimpleEventLoop object. | 17:30 |
| mhilmi | Seen anything like that? | 17:31 |
| mhilmi | I'll post the output. | 17:31 |
| mhilmi | http://pastebin.com/d4be356c9 | 17:33 |
| tpb | Title: pastebin - collaborative debugging tool (at pastebin.com) | 17:33 |
| mhilmi | Dunno - get a couple weird errors, one in boost signals_common.hpp and one in gcc typeinfo? Could this be some compatibility/version problem/ | 17:35 |
| llnz | yes, odd | 17:36 |
| llnz | but i don't think you can use simple event loop | 17:36 |
| llnz | you need to write a new subclass of eventloop that connects up to and uses the QT event loop | 17:37 |
| mhilmi | I'll try to do that .. however the eventloop class itself also uses the problematic boost signals that is causing the error | 17:40 |
| mhilmi | ill see if i can find something out on the boost forums | 17:40 |
| mhilmi | and look into the qt event loop .. | 17:40 |
| Greywhind | llnz: ping? | 17:52 |
| llnz | Greywhind: pong | 17:59 |
| Greywhind | llnz: so i'm working on multiple order queues, and support for more order attributes | 18:00 |
| Greywhind | llnz: but there's no ruleset that i can find that uses those | 18:00 |
| llnz | no, because there was no client that supported it, there are no rulesets that use multiple queues | 18:01 |
| Greywhind | llnz: is there any way i can test these things? | 18:01 |
| llnz | humm... | 18:02 |
| *** JLafont has joined #tp | 18:02 | |
| llnz | you could hack up one of the rulesets to add multiple queues to an object | 18:05 |
| Greywhind | llnz: where would i look to do that? | 18:06 |
| llnz | choose a ruleset (minisec for example), change the object description for the planet object type to add another orderqueue | 18:13 |
| llnz | find where they are created (two places), create the other order queues | 18:13 |
| llnz | test | 18:13 |
| *** Landon_ has joined #tp | 18:15 | |
| *** Landon has quit IRC | 18:15 | |
| *** Landon_ is now known as Landon | 18:15 | |
| llnz | if you ask nicely, I could be conviced to create a branch to tpserver-cpp that has that in it for you | 18:16 |
| Greywhind | llnz: well, i don't want to make you do work. i'll try to figure it out. | 18:20 |
| llnz | Greywhind: I should have time to do it tonight, if it would be helpful | 18:21 |
| llnz | you might find bugs in tpserver-cpp | 18:21 |
| Greywhind | llnz: i appreciate the offer - if i can't figure out how to get it working, maybe i'll ask you later if you can try it? | 18:22 |
| *** JLafont has quit IRC | 18:22 | |
| llnz | sure, i have 5.5 hours of work to go today (only 10:20am here), so plenty of time | 18:22 |
| Greywhind | llnz: ok, thanks | 18:22 |
| *** alanp__ is now known as alanp | 18:23 | |
| *** greenlion has quit IRC | 18:30 | |
| *** greenlion has joined #tp | 18:37 | |
| CIA-46 | joelboh tpclient-pyweb * raa82ca4ed154 / (3 files in 2 dirs): | 18:40 |
| CIA-46 | Backend handler get_objects and cache_update is now working. Frontend is | 18:40 |
| CIA-46 | now doing a cache_update on login and displays placeholders on the map | 18:40 |
| CIA-46 | for objects returned by get_objects. | 18:40 |
| *** greenlion has quit IRC | 18:43 | |
| *** JLafont has joined #tp | 18:51 | |
| epyon | llnz: seems as I broke the refactor branch, could you help out? git-related, not code related :/ | 19:10 |
| *** nash has joined #tp | 19:26 | |
| CIA-46 | joelboh tpclient-pyweb * r7b8701a7b096 /backend/application.py: Messed up regex for matching handlers, fixed now. | 19:36 |
| CIA-46 | joelboh tpclient-pyweb * r6cf94445b62c / (4 files in 4 dirs): Added logout capabilites. | 19:36 |
| llnz | epyon: what is the issue you are having? | 19:41 |
| *** alanp has quit IRC | 19:44 | |
| *** zzorn has quit IRC | 19:44 | |
| *** mhilmi has quit IRC | 19:44 | |
| *** gau_veldt has quit IRC | 19:44 | |
| epyon | refactor doesn't seem to be in sync with master | 19:44 |
| epyon | and my local repo doesn't even compile :/ | 19:44 |
| epyon | also I'm unsure wether I'm actually pushing to refator or master | 19:45 |
| *** alanp has joined #tp | 19:48 | |
| *** zzorn has joined #tp | 19:48 | |
| *** mhilmi has joined #tp | 19:48 | |
| *** gau_veldt has joined #tp | 19:48 | |
| llnz | epyon: you have been pushing to refactor branch | 19:55 |
| llnz | origin/master and origin/refactor will now be different (refactor a few commits ahead) | 19:56 |
| llnz | as to why it's not compiling, pastebin the error | 19:56 |
| * llnz doesn't have a box here to test sorry | 19:57 | |
| llnz | while i'm at work that is | 19:57 |
| epyon | llnz: the errors are in files I havn't even remotely touched, so it seems that there are some sync errors | 19:58 |
| epyon | make[4]: *** No rule to make target `tinystr.cpp', needed by `tinystr.lo'. Stop. | 19:59 |
| llnz | oh | 20:00 |
| llnz | anytime a Makefile.am file changes, you have to run ./autogen.sh and ./configure again | 20:00 |
| llnz | one of the changes to master you merged into your tree has one of those changes | 20:00 |
| epyon | I'm checking that right now | 20:01 |
| epyon | oh and btw I have a few questions | 20:01 |
| llnz | sure | 20:02 |
| epyon | why isn't JAVADOC_AUTOBRIEF and EXTRACT_ALL set to YES in the Doxyfile? | 20:07 |
| epyon | Makes the doxygen output useless.... | 20:08 |
| llnz | no idea, defaults from kdevelop | 20:08 |
| llnz | how does it make it useless? | 20:10 |
| epyon | Well it generates documentation ONLY for the documented classes. Which is about 10 in tp-server :P | 20:11 |
| epyon | Most of them third party | 20:11 |
| llnz | ahh | 20:12 |
| llnz | having extract_all off was the motivation to finish documenting all of libtpproto-cpp | 20:13 |
| epyon | no difference now actually, since I'll be going through all of the server files now | 20:14 |
| *** mithro has joined #tp | 20:25 | |
| Greywhind | llnz: ping? | 20:43 |
| llnz | Greywhind: pong | 20:43 |
| Greywhind | llnz: i've been trying to add a second order queue to the planet that's created when you join minisec | 20:43 |
| Greywhind | i've done this: | 20:44 |
| Greywhind | OrderQueue *planetoq = new OrderQueue(); OrderQueue *planetoq2 = new OrderQueue(); planetoq->setObjectId(planet->getID()); planetoq->addOwner(player->getID()); planetoq2->setObjectId(planet->getID()); planetoq2->addOwner(player->getID()); OrderQueueObjectParam* oqop = static_cast<OrderQueueObjectParam*>(planet->getParameterByType(obpT_Order_Queue)); oqop->setQueueId(planetoq->getQueueId()); | 20:44 |
| Greywhind | OrdrQueueObjgectParam* oqop2 = static_cast<OrderQueueObjectParam*>(planet->getParameterByType(obpT_Order_Queue)); oqop2->setQueueId(planetoq2->getQueueId()); game->getOrderManager()->addOrderQueue(planetoq); game->getOrderManager()->addOrderQueue(planetoq2); | 20:44 |
| epyon | Woah, block of code with static_cast's D: | 20:44 |
| Greywhind | it was like that before i changed it, i swear ;P | 20:45 |
| llnz | epyon: yes, i know, i have started to move that way | 20:45 |
| epyon | Double woak D: | 20:45 |
| Greywhind | but anyway, it doesn't seem to have any effect on the number of order queues the object has | 20:45 |
| epyon | Anyway it's great to code something fun again ;> | 20:46 |
| * epyon left his job monday ^_^ | 20:46 | |
| llnz | Greywhind: currently that code adds the second orderqueue to the same orderqueue parameter | 20:46 |
| Greywhind | llnz: i see. what file would i look in to change that? | 20:46 |
| llnz | in planet.cpp, you need to add another orderqueue id, note what ID (groupid,paramid tuple) it would get, and use that id to get the orderqueue parameter | 20:47 |
| Greywhind | llnz: well, the thing is, it seems to be using obj->getParameter(ORDERGRPID,ORDERQPARAMID) | 20:48 |
| Greywhind | but i can't figure out where obj, ORDERGRPID, or ORDERQPARAMID are set | 20:48 |
| llnz | Greywhind: probably planet.h (if not in planet.cpp) | 20:49 |
| llnz | btw, did you find both places where planets are created? | 20:49 |
| Greywhind | llnz: nope, not in either planet.cpp or planet.h | 20:49 |
| Greywhind | they're just referenced there | 20:49 |
| Greywhind | llnz: i found the place where the initial planets are created and the one where planets are added when a player joins | 20:50 |
| llnz | good | 20:50 |
| CIA-46 | epyon tpserver-cpp-refactor * rfebe6f8fd611 /Doxyfile: | 20:50 |
| CIA-46 | Minor Doxyfile change | 20:50 |
| CIA-46 | * added JAVADOC_AUTOBRIEF as suggested on tp-devel | 20:50 |
| llnz | ah, ownedobject.h/cpp | 20:50 |
| epyon | llnz: also, who designed the board system in tpserver-cpp? | 20:51 |
| llnz | me | 20:51 |
| llnz | though, the design of the boards in the protocol was mithro, iirc | 20:51 |
| epyon | the idea that Board doesn't own messages but allows adding an managing seems... wierd :/ | 20:51 |
| epyon | and a final question, is there a reason why getDistanceSq in Vector3d returns a double instead of an int64_t? Can the distances be really that big that squared they'd overflow an int64_t? | 20:53 |
| llnz | epyon: yes, they can be that big, anything larger than int32_t size will overflow it | 20:54 |
| llnz | the universe can be very big | 20:54 |
| llnz | (and sparse) | 20:54 |
| epyon | llnz: but you use int64_t... | 20:55 |
| llnz | there probably was a reason to use board in that way | 20:55 |
| llnz | anything larger than int32_t squared will overflow a int64_t | 20:56 |
| llnz | larger than int32_t will, when squared, overflow a int64_t | 20:56 |
| epyon | Actually you'd need numbers greater than 3037000499 | 20:57 |
| epyon | is that possible? | 20:57 |
| llnz | and since we are using int64_t for coordinates... | 20:57 |
| epyon | the point is that you're loosing on numerical stability by those double typecasts | 20:58 |
| epyon | possible bug-source | 20:58 |
| llnz | true, but there isn't any type size large enough | 20:59 |
| epyon | O.o | 20:59 |
| * epyon will look into that | 20:59 | |
| * epyon will look into the boards too | 20:59 | |
| llnz | int64_t is a long long | 21:00 |
| llnz | i think you will find that the reason for the boards is because of the way they are stored in persistence | 21:00 |
| llnz | slots was a bad idea | 21:01 |
| llnz | orders have the same sort of problem (except they get more attention because they are important) | 21:01 |
| epyon | Still too soon to judge for me | 21:01 |
| epyon | Tommorow I'll be doxyfing the reast of the board system, so maybe things will get more clear | 21:02 |
| llnz | suggestions are welcome, I need something similar for orders and messages on the client side in libtpporot-cpp | 21:03 |
| llnz | in someways the protocol isn't very smart around them | 21:04 |
| epyon | as for style, I'm keeping it basically the same (except forcing 2 spaces indent everywhere) | 21:09 |
| epyon | The only major thing is renaming some private and local variables to have more meaningful names | 21:09 |
| llnz | i feel that 4 space indent might be better | 21:09 |
| epyon | and, please forgive me, adding a space between ) and { :> | 21:09 |
| llnz | my indenting style has change several times over time | 21:10 |
| llnz | that's ok | 21:10 |
| epyon | Mine was always 4 spaces | 21:10 |
| epyon | I'll take back on my whitespace heavy style, however I'd still suggest a space after and before keywords ( "if (blah)" and "} else {" ) | 21:11 |
| epyon | It seems to be quite common | 21:11 |
| llnz | ok | 21:11 |
| epyon | :D | 21:11 |
| epyon | ok, I'll be off to sleep now, I'll resume tommorow | 21:12 |
| epyon | g'night all! | 21:12 |
| llnz | ok, cya later | 21:12 |
| Greywhind | llnz: i've been working on this for hours, and I still can't seem to get it right. would you be willing to look at it at some point? | 21:14 |
| llnz | sure | 21:14 |
| Greywhind | llnz: thanks much | 21:14 |
| *** mithro has quit IRC | 21:16 | |
| *** mithro has joined #tp | 21:17 | |
| tansell | hey Greywhind | 21:17 |
| Greywhind | tansell: hello | 21:17 |
| tansell | not having much luck with tpserver-cpp? | 21:17 |
| Greywhind | tansell: nope | 21:17 |
| *** verhoevenv has quit IRC | 21:28 | |
| cherez | mithro: Ping? | 21:33 |
| *** jmtan has joined #tp | 22:45 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!