Tuesday, 2009-06-02

*** tpb has joined #tp00:00
*** ChanServ sets mode: +o tpb00:00
tansellGreywhind, back now00:18
tansellsorry I was of doing work00:18
Greywhindtansell: no problem00:18
Greywhindsee my changes to 200200:18
tansellGreywhind, I can see your comments00:18
tansellGreywhind, looking at it now00:19
tansellGreywhind, you seem to have missed the following comment00:21
tansellhttp://codereview.mithis.com/2002/diff/6/1004#newcode13700:21
tansellLine 137:00:21
tansellWould it be better to have a generic method which does the for loop part of00:21
tansellthese functions?00:21
tpb<http://ln-s.net/3Fy$> (at codereview.mithis.com)00:21
Greywhindtansell: i'm not sure i can make it generic... i could look into it00:21
tansellthose functions look very similar00:22
tansellI'm still unsure why you need the second loop00:23
Greywhindwell, it's there in case the media list has an extra layer of wrapper00:23
Greywhindi can remove it if all the rulesets will follow Minisec's example for how media will be contained00:24
tansellGreywhind, can you show me in a diagram?00:24
Greywhindtansell: i can try00:24
tansellthat would be great00:24
tansellGreywhind, we probably want to support username/password00:28
tansellas it's likely that some 'media' might be behind protection00:29
Greywhindtansell: ok... i'll see if i can look into that00:30
tansellurllib supports username/password00:30
Greywhindtansell: http://pastebin.com/d104d405e00:30
tpbTitle: pastebin - collaborative debugging tool (at pastebin.com)00:30
*** Vadtec has quit IRC00:31
*** alanp has quit IRC00:31
*** edison has quit IRC00:31
*** jnengland77 has joined #tp00:31
tansellGreywhind, what are the Icon: - are they group structures themselves?00:32
Greywhindtansell: yes, they're the root GroupStructures00:32
tansellI'm pretty sure we don't support nested group structures00:32
tansellbrb00:32
*** alanp has joined #tp00:33
Greywhindtansell: oh, i think i made a mistake in the drawing actually00:36
*** edison has joined #tp00:37
*** Vadtec has joined #tp00:37
Greywhindtansell: but if we don't support nested GroupStructures, i guess this might be irrelevant00:38
Greywhindtansell: here's the corrected version: http://pastebin.com/d44a9256700:38
tpbTitle: pastebin - collaborative debugging tool (at pastebin.com)00:38
*** edison has quit IRC00:39
*** edison has joined #tp00:39
*** tansell--laptop has quit IRC00:48
*** tansell--laptop has joined #tp00:48
tansell--laptopback00:48
*** jmtan has joined #tp00:51
tansell--laptopGreywhind, so I don't think we support nested GroupStructures00:53
tansell--laptopcheck the protocol documents00:54
Greywhindtansell--laptop: ok00:54
Greywhindtansell--laptop: ping?01:42
tansellGreywhind, pong01:44
Greywhindtansell: so... it looks like urllib supports username and password through http://username:[email protected]01:44
Greywhindis that right?01:44
tansellGreywhind, yeah01:45
Greywhindtansell: should i manually construct that URL format from the base media URL then?01:46
tansellyes01:46
tansellyou can use the urllib to do the split/combind01:46
Greywhindurllib.parse.urlsplit(urlstring)?01:48
tansellyeah that should help01:50
shenkitansell: (offtopic) is it possible to install to my home directory using setuptools?01:50
tansellshenki, not easily in my knowledge01:52
tanselleasy-install might be able too01:56
*** jnengland77 has quit IRC01:57
Greywhindtansell: http://codereview.mithis.com/200202:45
tpbTitle: Issue 2002: Added functions to get media lists to objectutils, used these lists in panelPicture.py. - Code Review (at codereview.mithis.com)02:45
tansellGreywhind, where does self.waitingimages initialised?02:48
Greywhindtansell: in __init__02:48
tanselloh I see02:48
tansellsorry was diffing the patches02:48
Greywhindno problem02:48
tanselllooks okay02:49
Greywhindi tested it without any images cached, and it works02:49
*** zzorn-afk has quit IRC02:50
Greywhindtansell: i'm going to --squash and push then, k?02:50
tansellGreywhind, yeah go ahead02:50
tansellGreywhind, you should also check it works okay if you don't have an internet connection02:51
CIA-46Greywhind libtpclient-py-tp04 * r5e6e2a5cee04 /tp/client/threads.py: Fixed error when files list is empty in MediaThread.02:51
CIA-46Greywhind libtpclient-py-tp04 * r6b73b0cc035f /tp/client/ (media.py threads.py): Fixed login with username and password to media server.02:51
Greywhindtansell: hmm... i'll check at some point02:51
Greywhindi'll try it now, i guess02:51
Greywhindbrb02:51
Greywhindtansell: well, it looks like it doesn't crash02:53
Greywhindacts about as well as you could expect without any internet02:53
tansellgreat02:53
tansellwhat icon are you using if the object is unknown verse downloading?02:53
Greywhindno icon02:53
Greywhindin either case02:54
Greywhindtansell: is that a problem? i wouldn't see it as one.02:54
tansellmaybe there needs to be a way to tell if the icons are downloading or if they don't exist02:55
Greywhindtansell: i don't see an icon that could be used for that in the media directory02:58
Greywhindtansell: i could scale one of the other images down and add a new one02:58
tansellGreywhind, no - might need to figure out one02:58
tansellI would make a little question mark for unknown02:59
Greywhindtansell: maybe scale down downloading.gif?02:59
Greywhindtansell: or unknown.png02:59
tansellwhats downloading.gif?03:00
Greywhindit's a loading circle03:00
tansellpossibly, but I don't think the icons can be animated03:00
Greywhindtansell: i could take just one frame03:01
Greywhindbut we could scale down unknown.png instead03:01
Greywhindand use that for unknown objects03:01
tansellsee what looks good03:03
tansellI think you'll find it will be unreconisable at that size03:03
Greywhindi can clearly see the question mark03:04
CIA-46Greywhind tpclient-pywx-tp04 * r0f879fa3d75e /libtpclient-py: Updated libtpclient-py to newest version, with media changes.03:11
CIA-46Greywhind tpclient-pywx-tp04 * rd869bd8361cd /libtpclient-py: Updated libtpclient-py to make use of newest threads.py changes for media.03:11
CIA-46Greywhind tpclient-pywx-tp04 * r6a73562e6a0d /libtpclient-py: Updated libtpclient-py to make use of MediaThread files fix.03:11
CIA-46Greywhind tpclient-pywx-tp04 * rbb1e60aaf81a /libtpclient-py: Updated libtpclient-py to use media login change.03:11
CIA-46Greywhind tpclient-pywx-tp04 * r0dacf031e16e / (5 files in 4 dirs): Added media support to panelPicture and panelSystem.03:11
*** greenlion has joined #tp03:23
tansellGreywhind, you could have also squashed the libtpclient-py updates03:25
*** nash has quit IRC03:30
Greywhindtansell: well, i committed them individually to tp04 itself because otherwise the git cl upload wouldn't have worked03:30
tansellGreywhind, not a huge problem03:31
Greywhindsorry 'bout that.03:31
Greywhindanyway, my blog post is up, and i'm going to stop for tonight03:31
tansellhave a good night03:32
Greywhindsee you late03:32
Greywhindyou too03:32
*** Greywhind has quit IRC03:49
*** Greywhind has joined #tp03:51
*** Greywhind has quit IRC04:32
*** Vadtec has quit IRC04:53
*** edison has quit IRC04:53
*** edison has joined #tp04:54
*** Vadtec has joined #tp04:54
*** llnz has joined #tp05:30
*** tuna-fish has quit IRC06:06
*** jmtan has quit IRC06:13
*** JLP has joined #tp06:50
*** JLP_ has quit IRC07:03
*** JLP_ has joined #tp07:14
*** JLP has quit IRC07:25
*** alanp has quit IRC07:47
*** jmtan has joined #tp07:53
*** jmtan1 has joined #tp08:21
*** sladegen has joined #tp08:23
*** jmtan has quit IRC08:39
* llnz wanders off08:39
llnzlater all08:39
*** llnz has quit IRC08:39
*** peres has joined #tp09:12
*** bddebian has joined #tp10:10
*** tuna-fish has joined #tp11:44
*** peres has left #tp12:02
*** jmtan1 has left #tp12:57
*** verhoevenv has joined #tp13:10
*** Greywhind has joined #tp13:13
totei've cloned libtpproto-py a couple of weeks ago, and today i did a git fetch, after that i did a git status and got this message:13:32
toteYour branch is behind 'origin/master' by 3 commits, and can be fast-forwarded.13:32
totewhat does it mean and how do fast-forward and should i do it?13:32
toteah i should use git pull instead of fetch?13:39
ezodtote: i think so, yes13:46
ezodthat will fetch and update13:46
*** verhoevenv has quit IRC14:36
*** Erroneous has joined #tp15:40
*** llnz has joined #tp16:07
*** cherez1 has joined #tp16:32
*** cherez has quit IRC16:33
*** cherez1 is now known as cherez16:38
cherezmithro: Ping?16:41
*** bddebian has quit IRC16:42
llnzcherez: it's a bit early for him yet16:53
*** cherez1 has joined #tp16:54
*** cherez has quit IRC16:59
*** cherez1 is now known as cherez17:17
*** alanp has joined #tp17:19
*** jnengland77 has joined #tp17:38
CIA-46joelboh tpclient-pyweb * ra1ac97f52c13 /app/ (__init__.py application.py middleman.py tpclient-pyweb.wsgi): Created a simple base for the backend to be built upon.18:06
*** jnengland77 has quit IRC18:24
alanp./configure: line 18270: syntax error near unexpected token `avahiclient,'18:25
alanp./configure: line 18270: `PKG_CHECK_MODULES(avahiclient, avahi-client > 0.6.0,'18:25
alanp?18:25
*** JLafont has quit IRC18:34
*** JLafont has joined #tp18:37
llnzalanp: do you have package-config installed?18:45
llnzpkg-config, or whatever it's called18:46
alanpllnz: yes19:02
llnzodd, try running ./autogen.sh again19:03
*** greenlion has quit IRC19:10
*** bddebian has joined #tp20:18
mithromorning people20:24
llnzhi mithro20:26
cherezMorning.20:26
cherezmithro: If you have no more suggestions for http://codereview.mithis.com/2001, I'll push it.20:27
tansellcherez, where is your blog located these days?20:29
tansellcherez, did you fix the stuff in my comments?20:30
cherezYeah.20:30
chereztansell: The blog is at http://tpproto2.blogspot.com/, I was just writing my report for this week.20:30
tansellGreywhind, ping?20:32
cherezI also ported the tests to unittest, I'll make a branch and put it up for code review after the report.20:32
Greywhindtansell: pong20:37
tansellGreywhind, just looking at the system graphics20:38
Greywhindtansell: ok20:38
Greywhindi'm working on Starmap graphics, to see if it works reasonably well20:38
tansellGreywhind, I'm sure I cleared out the white backgrounds20:39
Greywhindtansell: hmm... maybe it's not recognizing transparency?20:40
Greywhindit did that even before i started changing things20:40
tansellGreywhind, it might be that versions in the media repository are old?20:40
Greywhindtansell: could be20:40
tansellGreywhind, the tp icon seems to be working properly20:41
Greywhindtansell: yeah, the ones in my graphics directory are transparent20:41
tansellif you look in ./graphics/*-icon.png20:41
tansellyou will see that they are transparent20:41
tansellGreywhind, I'll set you up an account on the media svn repository20:42
*** Vadtec has quit IRC20:43
*** Vadtec has joined #tp20:51
*** alanp_ has joined #tp20:56
*** alanp has quit IRC20:56
tansellcherez, ping?21:00
chereztansell: Pong.21:00
tansellcherez, all done?21:01
cherezFinishing the writing.21:01
cherezAlright, I have a summary of what I did for the xstruct module.21:05
tanselllink me?21:06
cherezhttp://tpproto2.blogspot.com/2009/06/update-for-june-2nd.html21:07
tpb<http://ln-s.net/3GFr> (at tpproto2.blogspot.com)21:07
cherezIt looks a lot less impressive than my fingers felt it should have been after I typed out the raw strings for every test. :(21:09
tansellcherez, so what is the plan for next week?21:14
chereztansell: http://tpproto2.blogspot.com/2009/06/plans-for-june-9th.html21:16
tpb<http://ln-s.net/3GFv> (at tpproto2.blogspot.com)21:16
cherezBasically, I'll be doing with structures what I did with xstruct.21:16
tansellso I think that should only take you a day or two21:18
tanselldo you have coverage information about xstruct?21:18
cherezNot yet, I'm going to look for tools to generate that.21:19
cherezI guess that would also be part of my plans for next week.21:20
CIA-46cherez libtpproto2-py * r27ec9372dc65 / (testxstruct.py tp/netlib/xstruct.py): Failure tests.21:27
*** Erroneous has quit IRC21:28
Greywhindtansell: any news on the transparency?21:29
tansellcherez, so coverage is an important measure of how successful you are at testing21:30
tansellGreywhind, yeah the media in svn is out of date21:30
Greywhindtansell: any way to fix it?21:30
tansellcherez, how do you know if you need more testing?21:31
tansellGreywhind, yes - I'll give you a username/password and you can updated it21:31
Greywhindtansell: ok21:31
chereztansell: By looking at the code coverage?21:32
Greywhindtansell: http://codereview.mithis.com/200621:32
tpbTitle: Issue 2006: Fixed old method of finding homeworld, added new getResources() method to objectutils. - Code Review (at codereview.mithis.com)21:33
tansellcherez, yeah21:33
Greywhindtansell: http://codereview.mithis.com/200721:33
tpbTitle: Issue 2007: Added media support to the Systems-level overlay on the Starmap. - Code Review (at codereview.mithis.com)21:33
tansellcherez, IE how do you know that the xstruct stuff is done21:34
tansellcherez, I think you should look into coverage ASAP21:34
cherezI'm reading over it now.21:35
tansellso for next week I would like to see the following21:35
tansell * coverage reports before and after21:35
tansell * all the stuff in structures working21:36
tansell * and a start of testing the parser21:37
tanselldoes that seem okay?21:37
cherezYeah.21:37
chereztansell: By the way, http://codereview.mithis.com/200821:37
tpbTitle: Issue 2008: Switched unit tests to use the unittest module. - Code Review (at codereview.mithis.com)21:37
tansellcherez, do they still work with py.test?21:38
tansellcherez, you probably want to split that into two separate function calls21:39
tansellcherez, easier to debug when something goes wrong21:40
cherezNot at present. I'll have to figure out how to make the frameworks work together.21:40
tansellcherez,  have you looked at nose?21:42
Greywhindthis repository is rather large :P21:42
chereztansell: Not in much depth, but I have.21:43
tansellGreywhind, yeah it's about 300mb21:44
tansellopps21:45
tansellaround 1.5G21:45
chereztansell: is there anything in particular about Nose that is important here?21:45
tansellcherez, it's just a nicer test runner then the default unittest one21:46
chereztansell: I got a coverage report on xstruct.22:03
cherezThere are a few things it pointed out I need to add tests for, and a few bits of code that I'm not sure will ever be run.22:04
tanselllike?22:04
cherezThe hexbytes function doesn't look to be used anywhere.22:04
tansellcan you upload the report?22:05
tansellcherez, the hexbyte function is helpful for debugging xstruct strings :)22:05
cherezAnd there are some tests in the internal functions for input which are redundant to tests in pack and unpack.22:06
Greywhindtansell: i don't seem to have the defense, mine, or scanner icons22:06
cherezHow do you want the report uploaded?22:06
cherezA pastebin? Or should be in a repository?22:06
tansellcherez, just upload it somewhere you have access too22:07
tansellthe output is html right?22:08
tansellGreywhind, probably never used22:08
tansellfeel free to fix them up22:08
cherezThis one is plain text, I know the tool supports html, but I haven't tried it yet.22:08
Greywhindtansell: ok, i'll remove the backgrounds from them22:09
cherezI just have an annotated version of xstruct.22:09
tansellcherez, well I can give you ability to upload to http://www.thousandparsec.net/~cherez if you have nowhere else to upload too22:10
cherezWell, I could fiddle with my router and use my box to host.22:11
cherezMy internet tends to be a little shaky, though.22:11
tansellcherez, okay - i'll do it after lunch22:13
tansellbblr22:13
cherezAlright, thanks.22:14
*** jmtan has joined #tp22:43
*** alanp_ is now known as alanp22:44
Greywhindtansell: ping?23:11
Landonhey jmtan23:12
Landonjust letting you know, progress this week will be very slow, I hit some snags moving into the house and haven't had time to get stuff like internet set up yet23:13
jmtansure, you're moving house after all, get your stuff in order first :)23:16
Landonturned out they weren't ready for me to move up on the first :P23:20
Landonstill doing house repair all over23:20
jmtanare you staying at the house now?23:21
Landonyeah, they had at least one of the rooms completely finished heh23:22
Landonleeching from a neighbors wireless >.>23:22
jmtanthank goodness for default router settings eh23:24
tansellback now23:30
tansellGreywhind, pong23:34
Greywhindtansell: what was that you said about removing the media from the tpclient package?23:34
tansellGreywhind, well the icons are downloaded now23:34
tansellso they shouldn't be shipped with the client23:35
Greywhindtansell: ah.23:35
*** sladegen has quit IRC23:35
CIA-46greywhind * r71 media/client/common/object-icons/ (9 files): Updated icons to make backgrounds transparent.23:36
tansellLandon, of course you should be able to develop without internet access23:36
Greywhindtansell: ok, transparent icons are in23:37
tansellgreat! - do they work?23:38
Greywhindyep23:38
Greywhindtansell: i'm going to go write my summary now23:39
*** sladegen has joined #tp23:41
tansellGreywhind, great - they are good to read23:41
Landontansell: yeah, need to get the desktop set up after the carpets dry from steam cleaning23:53
Landonhopefully I have the ogre docs on there somewhere :P23:54
Landonalthough hmm, I don't think I'll need those for a while23:55

Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!