| *** tpb has joined #tp | 00:00 | |
| *** ChanServ sets mode: +o tpb | 00:00 | |
| Landon | I was also wondering about copying stuff over to the battleviewer repo or if you think it'd be best to work on it in the 3d client repo, since it depends on plenty in there | 00:02 |
|---|---|---|
| Landon | it seems installing the gem package worked... now everything is even more cryptic | 00:05 |
| Landon | on running the client, it starts up normally and then dies with : | 00:06 |
| Landon | ./tp/client/threads.py:25: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6 self.message = "" | 00:06 |
| Landon | (two lines) | 00:06 |
| jmtan | i guess it's better to work with the 3d client repo, since it will be merged eventually | 00:07 |
| Landon | alright | 00:08 |
| jmtan | which file are you running? | 00:09 |
| Landon | tpclient-pyogre | 00:09 |
| Landon | ah nevermind | 00:10 |
| Landon | tried test_battle and got a traceback | 00:10 |
| Landon | I think I've almost got it now | 00:15 |
| Landon | trying to figure out where its getting the path for the libraries from though | 00:15 |
| Landon | oh, lots of places i could be :\ | 00:16 |
| Landon | ah I dont think this will work out, I'd have to either recompile it or find some way to trim the installation down a lot | 00:17 |
| Landon | my home directory is too small for itas it is now | 00:17 |
| jmtan | when will you be able to use your normal desktop? | 00:18 |
| Landon | about the first, when I moveback to manhattan | 00:22 |
| Landon | I can somewhat use it now though | 00:22 |
| Greywhind | tansell: i updated the issue in response to your comments | 00:29 |
| Greywhind | http://codereview.mithis.com/3 | 00:29 |
| tpb | Title: Issue 3: Fixed the code that determines whether an object can move in panelStarMap.py to work with tp04. - Code Review (at codereview.mithis.com) | 00:29 |
| *** mithro_ has quit IRC | 00:30 | |
| *** mithro_ has joined #tp | 00:30 | |
| tansell | Greywhind, back now | 00:40 |
| tansell | Greywhind, comments submitted | 00:44 |
| *** jnengland77 has quit IRC | 01:00 | |
| tansell | Greywhind, I assume you have probably headed to bed? | 01:12 |
| llnz | bbl | 01:14 |
| *** llnz has quit IRC | 01:14 | |
| *** tansell--laptop has joined #tp | 01:16 | |
| *** tansell_laptop has quit IRC | 01:18 | |
| Greywhind | tansell: http://codereview.mithis.com/3 | 01:26 |
| tpb | Title: Issue 3: Fixed the code that determines whether an object can move in panelStarMap.py to work with tp04. - Code Review (at codereview.mithis.com) | 01:26 |
| Greywhind | nope, i'm still here | 01:26 |
| tansell | LGTM | 01:26 |
| Greywhind | k | 01:26 |
| CIA-46 | Greywhind tpclient-pywx-tp04 * rdd0e536176b8 /windows/main/overlays/Systems.py: Small fix to draw a line between each coordinate of an icon with multiple coordinates. | 01:30 |
| CIA-46 | Greywhind tpclient-pywx-tp04 * r5b8cf164f7e7 / (extra/objectutils.py windows/main/panelStarMap.py): Fixed the code that determines whether an object can move in panelStarMap.py to work with tp04. | 01:30 |
| tansell | Greywhind, did you forget to squash? | 01:37 |
| Greywhind | tansell: no, they're supposed to be separate commits | 01:42 |
| tansell | okay | 01:43 |
| cherez | mithro: Ping? | 02:35 |
| tansell | cherez, pong | 02:35 |
| cherez | Any comments on the failure tests I added? | 02:36 |
| tansell | opps | 02:36 |
| tansell | I didn't see it - URL? | 02:36 |
| cherez | http://codereview.mithis.com/1001/show | 02:39 |
| tpb | Title: Issue 1001: Fixed floating point numbers and added float and timestamp tests. - Code Review (at codereview.mithis.com) | 02:39 |
| tansell | cherez, this should be a new CL | 02:46 |
| cherez | How do I do that? | 02:47 |
| tansell | cherez, did you start a new branch as the GitCL suggests? | 02:49 |
| cherez | I did not. | 02:50 |
| tansell | cherez, that would be the problem | 03:05 |
| tansell | you can do a | 03:05 |
| tansell | git branch mynewbranch HEAD~1 | 03:06 |
| tansell | git merge tp04 | 03:06 |
| cherez | tp04? | 03:12 |
| tansell | opps | 03:15 |
| tansell | I mean master :) | 03:15 |
| tansell | working with greywhind to much :) | 03:15 |
| cherez | Alright. | 03:17 |
| *** nash has quit IRC | 03:19 | |
| *** peres has joined #tp | 03:29 | |
| *** mithro_ has quit IRC | 03:38 | |
| *** mithro_ has joined #tp | 03:39 | |
| *** llnz has joined #tp | 03:41 | |
| tansell | cherez, any luck? | 03:46 |
| cherez | I hope? | 03:51 |
| cherez | http://codereview.mithis.com/2001 | 03:51 |
| tpb | Title: Issue 2001: Failure tests. - Code Review (at codereview.mithis.com) | 03:51 |
| tansell | hrm, I wonder why your creating Issue 2001 | 04:04 |
| tansell | cherez, that is a 1 line change | 04:05 |
| tansell | you need a | 04:06 |
| tansell | git-branch --track master -f origin/master | 04:06 |
| tansell | probably | 04:06 |
| tansell | well I have to head off to a SLUG meeting | 04:10 |
| tansell | I won't be back for 2-3 hours | 04:10 |
| tansell | just some feedback from what I saw earlier | 04:11 |
| tansell | you need to test numbers which are too big | 04:11 |
| tansell | and negative | 04:11 |
| tansell | (IE if it's a unsigned number, giving it an negative number should result in an error) | 04:12 |
| tansell | Same with a SInt, -2 should cause it to fail, but -1 should work | 04:12 |
| *** tansell--laptop has quit IRC | 04:36 | |
| *** mithro_ has quit IRC | 04:36 | |
| *** greenlion has joined #tp | 04:42 | |
| *** llnz2 has joined #tp | 05:21 | |
| *** llnz has quit IRC | 05:22 | |
| *** llnz2 is now known as llnz | 05:22 | |
| *** bcarlyon|laptop has quit IRC | 05:30 | |
| * llnz wanders off | 06:25 | |
| llnz | later all | 06:25 |
| *** llnz has quit IRC | 06:25 | |
| *** jmtan has quit IRC | 08:28 | |
| *** jmtan has joined #tp | 08:30 | |
| *** jmtan has quit IRC | 09:07 | |
| *** verhoevenv has joined #tp | 09:38 | |
| *** verhoevenv_ has joined #tp | 10:00 | |
| *** verhoevenv has quit IRC | 10:01 | |
| *** mithro_ has joined #tp | 10:09 | |
| mithro_ | hey verhoevenv_ | 10:11 |
| mithro_ | I haven't see any commits from reac yet | 10:11 |
| verhoevenv_ | Heya mithro_ | 10:11 |
| verhoevenv_ | No, but he's keeping me up to date, having some compaitibility issues right now. | 10:12 |
| mithro_ | verhoevenv_: shouldn't he have sorted them out by now? | 10:12 |
| mithro_ | I mean GSoC has been started for a week | 10:13 |
| mithro_ | remeber that GSoC is suppose to be kinda like a full time job | 10:13 |
| *** mithro_ is now known as mithro | 10:13 | |
| mithro | verhoevenv_: did you ever finish minisec support? | 10:14 |
| verhoevenv_ | Mmm, I know. If he hasn't produced anything by the end of the week he'll have to suffer a tough talk and we'll try to work something out. | 10:15 |
| verhoevenv_ | re minisec: no, not really. | 10:15 |
| verhoevenv_ | It's at I guess 80% or something but I don't have the time right now. | 10:15 |
| mithro | verhoevenv_: maybe that should be reac's first task? | 10:16 |
| verhoevenv_ | mithro: Hmm, I don't know. His main objective should be to increase the performance, creating a new ruleset is not really the aim. | 10:19 |
| mithro | well if it's 80% done, i should only take him a day or two full time to finish it no? | 10:20 |
| mithro | and it would get him familiar with the code | 10:20 |
| verhoevenv_ | I'm also trying to create a tutorial in parallel, basically documenting the process. | 10:21 |
| verhoevenv_ | So I'd rather keep it to myself, really. | 10:21 |
| mithro | if that is what you think is best, then thats okay | 10:22 |
| mithro | I just think we should have a real work done by the end of the week | 10:23 |
| mithro | verhoevenv_: I have been using codereview with cherez and Greywhind | 10:27 |
| mithro | See codereview.mithis.com | 10:27 |
| verhoevenv_ | Err. I never worked with code review or that tool myself. | 10:29 |
| verhoevenv_ | There are issues, patches for that get send in via this tool, comments can be added and when okay the patches get applied? Or what? | 10:30 |
| mithro | it's a "pre submit" code review | 10:34 |
| mithro | so basically a person uploads their patch to the tool first | 10:34 |
| mithro | you comment on it | 10:34 |
| mithro | they fix the problems and upload a new version | 10:34 |
| mithro | then eventually they submit it patch | 10:34 |
| mithro | http://www.thousandparsec.net/wiki/GitCL | 10:35 |
| tpb | Title: GitCL - Thousand Parsec Wiki (at www.thousandparsec.net) | 10:35 |
| verhoevenv_ | I see. | 10:37 |
| verhoevenv_ | Mmm, I'm not too familiar with the process. I'll keep a close watch on tp-cvs, if any problems show up we can alwyas work them out. | 10:38 |
| *** mithro has quit IRC | 11:28 | |
| *** verhoevenv has joined #tp | 11:43 | |
| *** verhoevenv__ has joined #tp | 11:45 | |
| *** verhoevenv has quit IRC | 11:56 | |
| *** verhoevenv has joined #tp | 11:58 | |
| *** verhoevenv_ has quit IRC | 11:59 | |
| *** verhoevenv_ has joined #tp | 12:00 | |
| *** verhoevenv__ has quit IRC | 12:13 | |
| *** verhoevenv has quit IRC | 12:15 | |
| *** verhoevenv_ has quit IRC | 12:31 | |
| *** verhoevenv has joined #tp | 12:34 | |
| *** verhoevenv has quit IRC | 12:44 | |
| *** verhoevenv has joined #tp | 12:49 | |
| *** alanp has joined #tp | 12:58 | |
| CIA-46 | alanp tpserver-cpp-mtsec * rd86d196f4dcc /modules/games/mtsec/ (6 files): Importing the version of tinyxml that Risk uses. This will be used to import Components and possibly Props from XML. | 13:15 |
| *** peres has quit IRC | 13:34 | |
| *** verhoevenv_ has joined #tp | 13:57 | |
| *** peres has joined #tp | 13:57 | |
| *** verhoevenv has quit IRC | 13:57 | |
| *** peres has quit IRC | 13:57 | |
| *** mhilmi has joined #tp | 14:03 | |
| *** tuna-fish has quit IRC | 14:15 | |
| *** verhoevenv has joined #tp | 15:08 | |
| *** verhoevenv_ has quit IRC | 15:21 | |
| *** alanp has quit IRC | 15:34 | |
| *** Erroneous has quit IRC | 18:02 | |
| *** Erroneous has joined #tp | 18:03 | |
| *** greenlion has quit IRC | 18:15 | |
| *** zzorn__ has joined #tp | 18:56 | |
| *** zzorn___ has joined #tp | 19:01 | |
| *** verhoevenv has quit IRC | 19:01 | |
| *** zzorn___ has quit IRC | 19:04 | |
| *** llnz has joined #tp | 19:06 | |
| Greywhind | llnz: ping? | 19:55 |
| llnz | Greywhind: pong | 20:30 |
| Greywhind | llnz: you were the one planning to add some media to objects in minisec? | 20:30 |
| *** llnz has quit IRC | 20:32 | |
| *** llnz has joined #tp | 20:36 | |
| Greywhind | llnz: did you see my message? | 20:37 |
| llnz | nope, sorry | 20:38 |
| Greywhind | [17:30] Greywhind : llnz: you were the one planning to add some media to objects in minisec? | 20:38 |
| llnz | yes | 20:39 |
| Greywhind | llnz: could you tell me a bit more about how that will be structured? | 20:39 |
| llnz | i'm not sure yet | 20:39 |
| llnz | probably two media parameters in a paramgroup | 20:40 |
| Greywhind | i'm currently assuming it will be a list of ObjectParamMedia properties | 20:40 |
| llnz | one called icon (for the icon) and one for the detail image/model | 20:40 |
| Greywhind | ok | 20:41 |
| Greywhind | so basically, to generalize, any number of ObjectParamMedia URLs in a group | 20:42 |
| Greywhind | it would be nice if we could have a specific way of specifying icon vs. full image that remains constant across rulesets, but that might be too much to ask? | 20:43 |
| llnz | should be possible | 20:52 |
| Greywhind | that would be cool | 20:53 |
| llnz | it could be just a matter of organising the media | 20:58 |
| *** llnz has quit IRC | 20:59 | |
| *** llnz has joined #tp | 21:02 | |
| *** llnz has quit IRC | 21:11 | |
| *** llnz2 has joined #tp | 21:11 | |
| *** llnz2 is now known as llnz | 21:11 | |
| CIA-46 | Greywhind tpclient-pywx-tp04 * rf6de7b6c7923 /extra/objectutils.py: Small fix for supported order types listing in objectutils. | 22:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!