*** tpb has joined #melange | 00:00 | |
*** dmitrig01 is now known as dmitrig01|afk | 00:07 | |
*** SRabbelier has joined #melange | 01:09 | |
*** ChanServ sets mode: +v SRabbelier | 01:09 | |
*** dmitrig01|afk has quit IRC | 01:28 | |
*** mithro has quit IRC | 04:00 | |
*** mithro has joined #melange | 08:41 | |
*** ChanServ sets mode: +v mithro | 08:41 | |
*** Sidnei_ has joined #melange | 09:23 | |
*** MatthewWilkes has joined #melange | 09:27 | |
*** Sidnei has quit IRC | 09:29 | |
*** webchick has joined #melange | 10:42 | |
*** mithro has quit IRC | 11:07 | |
*** tlarsen has joined #melange | 11:35 | |
*** ChanServ sets mode: +o tlarsen | 11:35 | |
*** solydzajs has joined #melange | 11:38 | |
*** ChanServ sets mode: +v solydzajs | 11:38 | |
tlarsen | solydzajs: Good afternoon. | 11:39 |
---|---|---|
solydzajs | tlarsen: Hi there. | 11:39 |
solydzajs | tlarsen: conference call in 20min right ? | 11:39 |
solydzajs | tlarsen: I deployed latest version of Melange to melange-dev.appspot.com | 11:40 |
tlarsen | solydzajs: OK. | 11:43 |
tlarsen | solydzajs: We need to work out some sort of release process for each of these 2-week sprints. | 11:44 |
tlarsen | I would like to start branching, maybe on Friday, for each demo. | 11:44 |
tlarsen | We have *lots* of commits on the weekend and Monday morning. :) | 11:44 |
solydzajs | tlarsen: yes I agree. That's a good idea | 11:45 |
tlarsen | It looks like our sprints are going to be 2 weeks each. | 11:45 |
solydzajs | tlarsen: can you mention that during conference call too ? | 11:45 |
tlarsen | As for what to demo, we had a *lot* of technical debt and spent a lot of time refactoring. That took longer than we expected. | 11:46 |
solydzajs | Yes correct | 11:46 |
solydzajs | btw Sverre will be online in 5-10 minutes | 11:46 |
tlarsen | Also, I spent too much time trying to get the dynamic Question stuff working, so I didn't finish the "hacked' Terms of Service feature. | 11:46 |
tlarsen | I need a day or two more, now that I've figured out how to do it. | 11:46 |
solydzajs | tlarsen: I have just as_table to commit, and I will move to Invitations | 11:47 |
solydzajs | since Invitation will be used everywhere | 11:47 |
solydzajs | and are also needed for Clubs | 11:47 |
tlarsen | I will add a ReferenceProperty to HomeSettings that points to a "terms" Quiz. | 11:48 |
solydzajs | ok sounds good | 11:48 |
tlarsen | I think we need to do a little bit of refactoring around link_name and partial_path first, though. | 11:48 |
tlarsen | I think we need a Linkable class that contains those two fields. | 11:48 |
solydzajs | tlarsen: Sorry for not yet replying to your post about nick_name and link_name confusion I will reply today | 11:49 |
tlarsen | We have them and their descriptions spread out in too many places. | 11:49 |
tlarsen | The PolyModel stuff still works even if there are intermediate classes. | 11:49 |
solydzajs | yep | 11:50 |
solydzajs | I gonna move all the Person properties to Role model | 11:50 |
solydzajs | and delete Person model tho | 11:50 |
solydzajs | since we don't need both of them right ? | 11:51 |
tlarsen | Correct. | 11:52 |
solydzajs | ok. | 11:53 |
*** SRabbelier1 has joined #melange | 11:55 | |
SRabbelier1 | tlarsen: do you have skype installed yet? (www.skype.com) | 11:55 |
solydzajs | tlarsen: ok started on that already. Should be ready soon. Most of the fixes will be in __doc__ tho :-) | 11:55 |
*** Lennie has joined #melange | 11:56 | |
solydzajs | SRabbelier1: are we using free Skype to Skype conference calls or should we call this number that was listed in meeting information ? | 11:56 |
SRabbelier1 | solydzajs: skype please | 11:57 |
Lennie | evening :) | 11:57 |
Lennie | atleast for me | 11:57 |
solydzajs | SRabbelier1: I guess it's up to Chris :-) | 11:57 |
SRabbelier1 | solydzajs: He said that 'Skype is good' during the meeting | 11:57 |
solydzajs | Lennie: hi :-) evening here too :-) | 11:57 |
solydzajs | tlarsen: do you have Chris on Skype ? | 11:57 |
SRabbelier1 | so I guess we need to know if Todd is good to go | 11:57 |
solydzajs | yep | 11:59 |
SRabbelier1 | I see a cdibona on skype | 12:00 |
durin42 | heh, skype call? | 12:00 |
SRabbelier1 | durin42: yes | 12:00 |
SRabbelier1 | durin42: you got an invite | 12:00 |
* durin42 has a job and therefore can't do skype | 12:00 | |
durin42 | SRabbelier1: no, I didn't. | 12:00 |
SRabbelier1 | durin42: yes you did :P | 12:01 |
durin42 | SRabbelier1: um? | 12:01 |
SRabbelier1 | durin42: at your [email protected] address | 12:01 |
durin42 | SRabbelier1: there's nothing on my calendar at this time | 12:01 |
SRabbelier1 | durin42: weird | 12:01 |
durin42 | and I can't do skype during the day anyway, seeing as I have a job | 12:01 |
SRabbelier1 | durin42: hehe | 12:01 |
durin42 | job gets in the way quite a lot | 12:02 |
SRabbelier1 | durin42: quit the job, work for google! | 12:02 |
solydzajs | yep but invite was send to you :-) | 12:02 |
durin42 | never saw such an invite, alas | 12:02 |
* SRabbelier1 is looking at "Awaiting response: [email protected]" | 12:03 | |
durin42 | SRabbelier1: Wouldn't mind that, but I'd have to actually have the job first | 12:03 |
solydzajs | ups | 12:03 |
solydzajs | during | 12:03 |
durin42 | SRabbelier1: resend the invite | 12:03 |
solydzajs | it's during | 12:03 |
solydzajs | Chris typed it wrong | 12:03 |
durin42 | ha | 12:03 |
SRabbelier1 | durin42: nah: [email protected] | 12:03 |
SRabbelier1 | durin42: I just typoed | 12:03 |
durin42 | SRabbelier1: hm, looking in the spam box | 12:04 |
durin42 | or maybe gmail intercepted it and I never saw it | 12:04 |
solydzajs | tlarsen: ready for Skype call ? | 12:04 |
durin42 | weird, calendar doesn't see it either | 12:04 |
durin42 | what's the call about? | 12:05 |
tlarsen | We are already on the call. | 12:05 |
tlarsen | Dial-in number:866.457.4646 | 12:06 |
tlarsen | International Dial-in number:617.224.4646 | 12:06 |
SRabbelier1 | tlarsen: I thought we were using skype.... | 12:06 |
solydzajs | tlarsen: ok. | 12:07 |
tlarsen | No call. | 12:07 |
tlarsen | Chris will talk to us again in 2 weeks. | 12:07 |
SRabbelier1 | tlarsen: no call, wah? | 12:08 |
SRabbelier1 | tlarsen: what happend? | 12:08 |
tlarsen | We don't really have something to show him, at least not what he was expecting. | 12:08 |
SRabbelier1 | tlarsen: http://srabbelier-melange.appspot.com/host/create_invite | 12:08 |
tlarsen | He isn't really thrilled, but I attempted to explain. | 12:08 |
tpb | <http://ln-s.net/2SKu> (at srabbelier-melange.appspot.com) | 12:08 |
SRabbelier1 | tlarsen: you have been ill the past week | 12:08 |
SRabbelier1 | tlarsen: and Pawel has been busy with other things | 12:08 |
tlarsen | Yeah, I know, and we are a bit disorganized. | 12:08 |
tlarsen | So, we need to talk about this next 2-week interval. | 12:09 |
tlarsen | I am feeling better, by the way. :) | 12:09 |
SRabbelier1 | tlarsen: so why not now? | 12:09 |
SRabbelier1 | tlarsen: he doens't want to know why we're not done and stuff? | 12:09 |
solydzajs | tlarsen: ok one second trying to call but need to find keypad in Skype | 12:09 |
tlarsen | SRabbelier1: He expects me to handle it. | 12:10 |
tlarsen | No, he does not want to talk today. | 12:10 |
SRabbelier1 | tlarsen: ok | 12:10 |
tlarsen | solydzajs: There will be no call with Chris today. | 12:10 |
* SRabbelier1 goes -_-" | 12:10 | |
solydzajs | tlarsen: oh ok. So I don't have to call anymore :-) | 12:10 |
tlarsen | SRabbelier1: You have to make me a developer before I can use that link. :) | 12:10 |
tlarsen | solydzajs: No, no call today. | 12:10 |
SRabbelier1 | tlarsen: sure | 12:10 |
SRabbelier1 | tlarsen: you need to create a profile first then :P | 12:10 |
tlarsen | solydzajs: However, we need to try to get more organized. I don't like to disappoint Chris more than once. :) | 12:11 |
tlarsen | I did, but I am not a Developer. | 12:11 |
SRabbelier1 | tlarsen: afaik I've been the only one working on the Request stuff we promised to show him today | 12:11 |
solydzajs | tlarsen: ok, so he's disappointed ? | 12:11 |
SRabbelier1 | tlarsen: I got a lot done, but I can't pull this on my own... | 12:11 |
tlarsen | solydzajs: Ummm, yeah. He's my boss, so I can handle it. | 12:12 |
tlarsen | SRabbelier1: No one is asking you to. | 12:12 |
tlarsen | SRabbelier1: we just need to get a little more organized, and solydzajs and I were talking about that earlier on the channel. | 12:12 |
SRabbelier1 | tlarsen: what do we need to change? | 12:12 |
tlarsen | SRabbelier1: Since we know we are going to have a meeting with him every two weeks, I want to start cutting a release branch before the meeting. | 12:12 |
tlarsen | SRabbelier1: I need time to experiment with what we are going to show him, rather than have a pile of commits happen the weekend before the Monday meeting. | 12:13 |
solydzajs | tlarsen: agreed on that. | 12:13 |
SRabbelier1 | tlarsen: a release branch? dear god | 12:13 |
solydzajs | so we freeze stuff on Friday and have a discussion on Friday what to show and list the changes that are really important | 12:14 |
tlarsen | solydzajs: Yes. | 12:14 |
solydzajs | +1 on that | 12:14 |
SRabbelier1 | -1 on that | 12:14 |
SRabbelier1 | but eh | 12:14 |
SRabbelier1 | I'll deal | 12:14 |
durin42 | O | 12:14 |
tlarsen | solydzajs: We freeze on Friday at some set time (it could be AM on Friday for me, for example, and I would cut the branch). | 12:14 |
durin42 | I think that's a good idea, honestly | 12:14 |
solydzajs | tlarsen: ok sounds good. | 12:14 |
SRabbelier1 | what's the intention of the branch? | 12:14 |
durin42 | demos need to be previewed | 12:14 |
tlarsen | solydzajs: Then, we would have an IRC meeting to go over the progress. | 12:15 |
SRabbelier1 | do we keep it after the demo | 12:15 |
SRabbelier1 | or can we throw it away after the demo | 12:15 |
tlarsen | SRabbelier1: we can delete the branch after the demo. | 12:15 |
durin42 | SRabbelier1: so we can keep committing to trunk after the demo | 12:15 |
SRabbelier1 | tlarsen: ok, then I'm +0 | 12:15 |
tlarsen | SRabbelier1: but, it costs nothing to keep them. | 12:15 |
solydzajs | SRabbelier1: branch can be also a revision number for us :-) | 12:15 |
tlarsen | durin42: Yes, commits to trunk/ will be continuous. | 12:15 |
tlarsen | durin42: The branch will be stabilized for the demo. | 12:15 |
durin42 | tlarsen: yeah, my sentence came out all garbled | 12:15 |
durin42 | right | 12:15 |
Lennie | Personally speaking, I think that's good for the executives ^^ | 12:15 |
tlarsen | durin42: We can fix some bugs in trunk/ and cherry-pick the changes into the branch, but that's it. | 12:16 |
SRabbelier1 | tlarsen: nono, other way around | 12:16 |
SRabbelier1 | tlarsen: you fix the bugs in the branch, and merge/cherry-pick into master | 12:16 |
SRabbelier1 | tlarsen: you can't properly test your fixes if you're doing them on master | 12:16 |
tlarsen | SRabbelier1: Either way, up-integrate, down-integrate, I don't really care. | 12:16 |
SRabbelier1 | tlarsen: since it might have a major rehaul or whanot | 12:16 |
tlarsen | SRabbelier1: as long as fixes made in the branch end up back in trunk/ | 12:17 |
tlarsen | Lennie: Yes, I didn't want to waste Chris' time this morning being partially prepared. | 12:17 |
SRabbelier1 | tlarsen: right | 12:17 |
tlarsen | Admittedly, I have not given the amount of time to Melange that I needed to these past two weeks. | 12:18 |
SRabbelier1 | tlarsen: right | 12:18 |
solydzajs | tlarsen: ok I think we should spend some time today to schedule what we want to do in upcoming 1,5 week, then leave 0,5 week for polishing and fixing. | 12:18 |
tlarsen | I was sick for a week, and then the contractors (*all of them*!) decided to show up at the job site. | 12:18 |
tlarsen | solydzajs: Agreed. We have some *bad* technical debt that we need to get rid of right away. | 12:18 |
tlarsen | solydzajs: Then, we need to stop major refactoring for a while. | 12:18 |
solydzajs | tlarsen: I totally understand, I was not so active lately either, but that should change now. | 12:19 |
durin42 | I've gotten hgsubversion to a point where I don't want to build some of the new features, so I'll be spending more time on testing melange | 12:19 |
durin42 | (don't want to build them for now, that is) | 12:19 |
tlarsen | solydzajs: we turned off all of the phone ringers in the entire house, except for one turned down quiet at my wife's desk. :) | 12:19 |
solydzajs | tlarsen: :-) wow | 12:19 |
tlarsen | solydzajs: She is going to screen *all* of the calls and contractor visits to the guest house front door. It has been maddening for the phone to ring or the door to knock every 15 minutes. | 12:20 |
SRabbelier1 | tlarsen: what do you mean with a "*bad* technical debt"? | 12:20 |
tlarsen | SRabbelier1: we have some stuff that touches nearly all the code that we really need to fix now. | 12:20 |
tlarsen | SRabbelier1: the link_name, partial_path stuff. | 12:20 |
SRabbelier1 | tlarsen: mhhh... but that's not technically difficult | 12:20 |
SRabbelier1 | tlarsen: it's just a rename | 12:20 |
SRabbelier1 | tlarsen: it can be done in 5 minutes | 12:21 |
tlarsen | SRabbelier1: that is not what "technical debt" means. | 12:21 |
solydzajs | tlarsen: good, otherwise you won't have time for coding at all :-) | 12:21 |
SRabbelier1 | tlarsen: ok, mhh, I don't understand then I think | 12:21 |
tlarsen | SRabbelier1: it doesn't mean it is technically difficult, it just means that it was done hacky, or is being ignored, and it is going to cause other features to be more difficult to implement later. | 12:21 |
SRabbelier1 | tlarsen: aah, yes, 'code cruft/rot', right? | 12:21 |
tlarsen | SRabbelier1: my proposal is to insert a Linkable Model class in the hierarchy that contains link_path and link_id fields. | 12:22 |
tlarsen | SRabbelier1: We have this concept, and the comments, duplicated in three Model classes currently. | 12:22 |
SRabbelier1 | tlarsen: right, I replied to your mail | 12:22 |
SRabbelier1 | tlarsen: I am +1 on creating one for Linkname | 12:22 |
SRabbelier1 | tlarsen: but -0 on one for partial_path, I don't think we'll have many others using it | 12:23 |
SRabbelier1 | and if we do, there's always time to do it then | 12:23 |
tlarsen | SRabbelier1: I think that we have so many entities that get referred to by a complex path, like google/gsoc2009/asf/faqs, that it is a fundamental property of our data model. | 12:24 |
tlarsen | Classes always have the option *not* to inherit from Linkable. | 12:24 |
SRabbelier1 | tlarsen: ok, do you want users to have a partial_path too then? | 12:24 |
solydzajs | SRabbelier1: no I think users should only have link_name | 12:25 |
SRabbelier1 | solydzajs: so we'll have both a Linkable, and a... Pathable? :P | 12:25 |
tlarsen | solydzajs: I think we can just have it be empty for Users. | 12:26 |
solydzajs | ok | 12:26 |
* SRabbelier1 doesn't like that | 12:27 | |
SRabbelier1 | it feels hacky | 12:27 |
tlarsen | I will commit the Linkable class shortly, with documentation, and you all can critique it however you like. | 12:27 |
tlarsen | Anyway, I would like to get these things out of the way: | 12:27 |
MatthewWilkes | The idea of specifying the path as text seems a little odd to me, it's like faking a structured site. Would it not make sense to have something closer to containment with an object at /foo knowing how to find /foo/bar? | 12:27 |
* MatthewWilkes is infected by graph-traversal based frameworks | 12:28 | |
SRabbelier1 | MatthewWilkes: yeah, I was thinking about that too | 12:28 |
SRabbelier1 | MatthewWilkes: the main problem is | 12:28 |
SRabbelier1 | MatthewWilkes: Document needs to be able to belong to a lot of things | 12:28 |
SRabbelier1 | MatthewWilkes: basically to any entity | 12:28 |
SRabbelier1 | oh | 12:28 |
SRabbelier1 | wait | 12:28 |
SRabbelier1 | it's not a problem | 12:28 |
SRabbelier1 | it could just have a reference to something that knows how to construct the prefix | 12:28 |
SRabbelier1 | mhhh... | 12:29 |
SRabbelier1 | MatthewWilkes: that could work :) | 12:29 |
tlarsen | SRabbelier1: Can you do this transitively? | 12:29 |
SRabbelier1 | tlarsen: errm, ofcourse, we're already doing it in {Home/Site}Settings | 12:30 |
tlarsen | SRabbelier1: Document asks Group (which in this example happens to be an Org), and Organization asks Program for its part of the link, and Program asks Sponsor... | 12:30 |
SRabbelier1 | tlarsen: exactly :) | 12:30 |
SRabbelier1 | tlarsen: so all anybody needs to have is a link_id | 12:31 |
SRabbelier1 | and things are properly constructed from there | 12:31 |
tlarsen | Sponsor returns 'google' (its "link ID"), and Program returns 'google/gsoc2009', and Organization returns 'google/gsoc2009/asf' | 12:31 |
SRabbelier1 | tlarsen: right | 12:31 |
tlarsen | SRabbelier1: I like this idea very much. | 12:31 |
SRabbelier1 | MatthewWilkes: is that what you had in mind? | 12:31 |
tlarsen | But, you should still be able to "construct" one as a string, say, for the Developer forms where they want to edit anything. | 12:31 |
SRabbelier1 | tlarsen: yeah, I was thinking about it earlier, but haven't brought it up, thinking it would be yet another (unwanted?) refactor | 12:31 |
SRabbelier1 | tlarsen: why? | 12:31 |
SRabbelier1 | tlarsen: why not just select the type it belongs to | 12:32 |
SRabbelier1 | (say org) | 12:32 |
SRabbelier1 | and then you get a list of orgs | 12:32 |
SRabbelier1 | or | 12:32 |
SRabbelier1 | you just select the type | 12:32 |
SRabbelier1 | and then -type in- the link_id | 12:32 |
SRabbelier1 | and it looks it up itself | 12:32 |
MatthewWilkes | SRabbelier1: Yep, sounds right | 12:32 |
tlarsen | SRabbelier1: OK. | 12:33 |
SRabbelier1 | so we do need Linkable | 12:33 |
SRabbelier1 | it just needs some logic around it | 12:33 |
SRabbelier1 | I would really like to remove the old view code | 12:34 |
SRabbelier1 | it had Lennard searching for why things weren't working for 15 minutes | 12:34 |
SRabbelier1 | it would also clean up our tree by a lot | 12:35 |
SRabbelier1 | I already cleaned out templates/ | 12:35 |
solydzajs | SRabbelier1: what are you working on right now ? | 12:36 |
SRabbelier1 | solydzajs: the Invite to Host stuff | 12:37 |
solydzajs | SRabbelier1: ok, how is this going ? | 12:37 |
SRabbelier1 | solydzajs: see my PoC at srabbelier-melange | 12:37 |
SRabbelier1 | solydzajs: after my recent work on making user generic, it was almost trivial to get a page where you can select whom you want to invite | 12:37 |
SRabbelier1 | I'll add a button to the sponsor page, to invite someone to become a host | 12:38 |
SRabbelier1 | it will redirect to /host/invite/<sponsor name> | 12:38 |
solydzajs | Ok, looks good | 12:38 |
SRabbelier1 | there you select someone (in the same view you know from /user/list) | 12:38 |
solydzajs | when do you want to commit that ? | 12:38 |
solydzajs | I like it :-) | 12:38 |
SRabbelier1 | and you get redirected to /host/invite/<sponsor name>/<user id> | 12:38 |
SRabbelier1 | either that | 12:39 |
solydzajs | that's what we talked about during our meeting at Mentor Summit ;-) | 12:39 |
SRabbelier1 | or that should perform the invite | 12:39 |
SRabbelier1 | yes, it is | 12:39 |
solydzajs | it's all on the blackboard photos :-) | 12:39 |
solydzajs | I should publish them today | 12:39 |
SRabbelier1 | this is what I've been working to for the past two/three weeks | 12:39 |
SRabbelier1 | solydzajs: you should have 2 weeks ago!!! | 12:39 |
SRabbelier1 | :P | 12:39 |
solydzajs | SRabbelier1: I know :-) | 12:39 |
SRabbelier1 | solydzajs: it's ok :) | 12:39 |
SRabbelier1 | solydzajs: I had it all in my head anyway | 12:39 |
solydzajs | SRabbelier1: I will put on melange-dev today for sure man :-) | 12:40 |
SRabbelier1 | solydzajs: sweet :) | 12:40 |
SRabbelier1 | I need help though | 12:40 |
tlarsen | This is why we need to branch on Friday AM CST and then have an IRC meeting to go over what is ready to demo. | 12:40 |
SRabbelier1 | I can't get the /user/edit to work | 12:40 |
solydzajs | tlarsen: +1 :-) | 12:40 |
solydzajs | SRabbelier1: in your generic User version ? | 12:41 |
SRabbelier1 | yes | 12:41 |
SRabbelier1 | see also my RHF to the list | 12:41 |
solydzajs | yep it's queued up :-) | 12:41 |
SRabbelier1 | ok, good | 12:41 |
SRabbelier1 | then we can show that to Chris in 2 weeks | 12:41 |
SRabbelier1 | anyway | 12:42 |
SRabbelier1 | Lennie has made food (smells good), so I am having dinner for a bit | 12:42 |
solydzajs | I will have a look at it in a bit | 12:42 |
solydzajs | I will go home now, eat some dinner too and I should be online around 22PM (in 3h) | 12:42 |
solydzajs | 10PM I mean | 12:43 |
solydzajs | :-) | 12:43 |
solydzajs | 22:00 | 12:43 |
solydzajs | :-) | 12:43 |
solydzajs | tlarsen: so let's talk in 3h regarding plans for upcoming 1,5 week ok ? | 12:43 |
Lennie | dinner time :) | 12:44 |
*** Lennie is now known as Lennie|Food | 12:44 | |
SRabbelier1 | solydzajs: +1 | 12:44 |
solydzajs | SRabbelier1: you will be online in 3h ? | 12:44 |
solydzajs | Lennie|Food: you should join too :-) | 12:45 |
SRabbelier1 | solydzajs: sure, will be there | 12:45 |
SRabbelier1 | solydzajs: lennie says he'll be there | 12:45 |
solydzajs | SRabbelier1: ok great :-) I guess you too will be seating next to each other :D | 12:45 |
*** solydzajs has quit IRC | 12:46 | |
tlarsen | For those of you that are still around, I submitted an soc/models/linkable.py that has my initial thoughts. Please take some time to comment today. | 13:05 |
*** Sidnei_ has left #melange | 13:07 | |
SRabbelier1 | tlarsen: saw it | 13:09 |
SRabbelier1 | tlarsen: will review in a min | 13:09 |
*** Lennie|Food is now known as Lennie | 13:13 | |
SRabbelier1 | tlarsen: LGTM | 13:20 |
SRabbelier1 | tlarsen: that's exactly what I had in mind | 13:20 |
SRabbelier1 | tlarsen: the SelfReferenceProperty is fancy | 13:20 |
*** SRabbelier1 has quit IRC | 13:58 | |
Lennie | so | 14:07 |
Lennie | I sent Sverre home ^^ | 14:07 |
Lennie | back in 2h for meeting then :) | 14:07 |
*** Lennie is now known as Lennie|Gone | 14:08 | |
*** tlarsen is now known as tlarsen|afk | 14:38 | |
SRabbelier | he did, I'm back now :) | 15:01 |
Lennie|Gone | ^^ | 15:22 |
*** Lennie|Gone is now known as Lennie | 15:53 | |
*** solydzajs has joined #melange | 15:57 | |
*** ChanServ sets mode: +v solydzajs | 15:57 | |
Lennie | [+solydzajs] SRabbelier1: ok great :-) I guess you too will be seating next to each other :D | 15:57 |
Lennie | I sent him home :P | 15:57 |
SRabbelier | solydzajs: the bastid | 15:57 |
Lennie | :) | 15:58 |
SRabbelier | gah | 15:58 |
SRabbelier | I forgot the administrative password for my first computer (that my dad is now using) | 15:58 |
solydzajs | Lennie: hehe :-) | 15:59 |
Lennie | solydzajs: Are we going to have a talk about the next weeks :)? | 16:11 |
solydzajs | Lennie: yep we can start right now | 16:12 |
SRabbelier | solydzajs: heh, you know, with the Linkable thing, we can actually have mutable link_names and have them be key names as well | 16:12 |
solydzajs | Lennie: Todd is not around but we can talk in 3 :-) | 16:12 |
Lennie | l | 16:12 |
Lennie | *k | 16:12 |
Lennie | whiteboard pictures nice :P | 16:13 |
SRabbelier | solydzajs: gql("WHERE scope = :1", user_that_wants_to_rename.id) | 16:13 |
SRabbelier | Lennie: I wrote it! | 16:13 |
Lennie | SRabbelier: Nice :P | 16:14 |
Lennie | http://gl.ict.usc.edu/Research/3DDisplay/ | 16:17 |
Lennie | ftw :) | 16:17 |
tpb | Title: ICT Graphics Lab (at gl.ict.usc.edu) | 16:17 |
solydzajs | ok Lennie , SRabbelier IRC meeting in 12 minutes ok ? 10:30, it will take about 15-20 minutes ok ? | 16:18 |
SRabbelier | solydzajs: sure | 16:19 |
Lennie | sure sure :) | 16:19 |
Lennie | solydzajs: I think we should also finish up on the link_name nick_name discussion for users | 16:19 |
Lennie | solydzajs: As Todd said it's getting long :P | 16:19 |
solydzajs | Lennie: yep I want to reply to this thread today too | 16:20 |
Lennie | SRabbelier: The witheboard practice at the Uni helped :P? | 16:21 |
SRabbelier | Lennie: hehe, yeah :D | 16:21 |
Lennie | SRabbelier: Not that we needed it, stupid teachers :P | 16:21 |
solydzajs | Lennie: this 3D display I saw already it's old :-) | 16:22 |
Lennie | solydzajs: :(, I'm oldschool :P | 16:22 |
solydzajs | Lennie: no you're just not tracking those things :-) | 16:23 |
Lennie | solydzajs: That would be the most logic conclusion :0 | 16:23 |
Lennie | SRabbelier: He's a Vulcan I tell you! | 16:23 |
SRabbelier | Lennie: he is, did you see his ears? | 16:23 |
Lennie | SRabbelier: Pics :D? | 16:23 |
SRabbelier | Lennie: vulcan, no doubt about it | 16:23 |
Lennie | solydzajs: It's your task to know about this 3d stuff right :P? Since you are in that User Interface Group, if I remember correctly :) | 16:26 |
Lennie | solydzajs: Although it's probably more about touch then looks :P | 16:26 |
solydzajs | Lennie: yep :-) it's more about touch, but we usually track all the new technologies in related fields :-) | 16:29 |
Lennie | solydzajs: Nice nice :) | 16:29 |
solydzajs | ok guys | 16:40 |
SRabbelier | ok | 16:41 |
solydzajs | ready ? | 16:41 |
SRabbelier | sure | 16:41 |
SRabbelier | Lennie: good to go? | 16:41 |
Lennie | r :) | 16:41 |
solydzajs | ok SRabbelier , you are working on invitation right ? | 16:41 |
solydzajs | SRabbelier: it's going to be generic correct ? so we can easily reuse it later as we discussed already during Mentor Summit ? | 16:42 |
SRabbelier | solydzajs: ofcourse, you know me ;) | 16:42 |
solydzajs | how busy you are till Sunday and how many hours you think you will have for Melange work till then ? + how much time do you need to finish invitation ? | 16:43 |
SRabbelier | solydzajs: quite busy, there are pc's breaking down around me (many thanks to AVG) | 16:43 |
solydzajs | and what else you have not yet committed but you started to work on | 16:43 |
SRabbelier | solydzajs: that's the last of my queue | 16:43 |
solydzajs | SRabbelier: please try to put realistic schedule and hours numbers | 16:43 |
SRabbelier | solydzajs: heh, maybe I'll have it done end of the week :) | 16:44 |
solydzajs | SRabbelier: but done you mean ? I would be able to invite somebody as Host and also reuse this functionality in other places ? | 16:44 |
solydzajs | SRabbelier: will it send invitation email to invited person ? | 16:44 |
SRabbelier | solydzajs: yes, that's what I mean by done | 16:45 |
SRabbelier | solydzajs: note, end of the week = Sunday | 16:45 |
solydzajs | SRabbelier: ok | 16:45 |
SRabbelier | solydzajs: I'll leave the email thing to lennard ;) | 16:45 |
solydzajs | SRabbelier: ok | 16:45 |
Lennie | SRabbelier: Fine by me, I havent checked for bugs today so :P | 16:45 |
solydzajs | SRabbelier: one more question how does Edit Main Site Settings work ? | 16:46 |
SRabbelier | solydzajs: atm, you need to create a site settings with partial path 'site' and id 'home' | 16:46 |
solydzajs | ok is this going to change ? | 16:46 |
SRabbelier | when we get the Linkable change in, I reckon it should just be a leaf node with no scope=None | 16:47 |
SRabbelier | solydzajs: ofcourse it is | 16:47 |
SRabbelier | solydzajs: it's not quite user friendly is it :P | 16:47 |
SRabbelier | solydzajs: there needs to be a check if a Site Settings exists, if it doesn't, a create page should be displayed instead | 16:47 |
SRabbelier | solydzajs: problem is, atm we can't pass initial values to create | 16:47 |
solydzajs | SRabbelier: ok I will have a look at it (put it to my todo list), you please focus on Invitations and invitations only, you are easily distracted by other shiny features :-) | 16:48 |
SRabbelier | solydzajs: not shiney features, rotting code | 16:48 |
Lennie | solydzajs: He's easily distracted during college too ^^ | 16:48 |
solydzajs | :-) | 16:48 |
SRabbelier | solydzajs: the user refactoring I actually had to do before I could do invitations | 16:48 |
SRabbelier | the site/home settings refactor I admit, could have waited | 16:49 |
solydzajs | SRabbelier: I understand I'm just kidding :-) | 16:49 |
SRabbelier | solydzajs: okies :) | 16:49 |
solydzajs | SRabbelier: ok so your focus till Sunday is on Invitations and Invitations only ?;-) | 16:49 |
SRabbelier | solydzajs: unless something else comes up? :P | 16:49 |
solydzajs | SRabbelier: well tested, well commented and generic + example of usage for Invite a Host :-) | 16:49 |
solydzajs | SRabbelier: nothing else comes up for you :-) | 16:50 |
SRabbelier | solydzajs: heh, we'll see :) | 16:50 |
SRabbelier | solydzajs: the commented part I can try | 16:50 |
SRabbelier | solydzajs: the tested part depends on if durin42 (hint hint) will be available to help me out | 16:50 |
solydzajs | SRabbelier: you can also commit changes more often, you don't have to wait till it's fully working | 16:50 |
SRabbelier | solydzajs: so far most of my work has been refactoring, so it wasn't really an option | 16:51 |
SRabbelier | solydzajs: I did that with the user code though, I committed part of that before it was done :) | 16:51 |
solydzajs | SRabbelier: ok but the stuff you have on your deployed melange instance | 16:51 |
solydzajs | SRabbelier: is something that could be committed already right ? | 16:52 |
SRabbelier | solydzajs: sure, I was going to, but didn't get around to it | 16:52 |
SRabbelier | solydzajs: why do you want me to though? | 16:52 |
solydzajs | SRabbelier: ok good | 16:52 |
SRabbelier | solydzajs: I use git, I commit locally all the time ;) | 16:52 |
SRabbelier | solydzajs: I like being able to change my commits around till I feel confident about them | 16:53 |
solydzajs | SRabbelier: it's better for contributors (like me, Todd, etc.) to see what are the upcoming changes even when the are not fully functional | 16:53 |
SRabbelier | solydzajs: get in the habbit of tracking my public repo? ;) | 16:53 |
solydzajs | SRabbelier: but it's up to you :-) | 16:53 |
solydzajs | SRabbelier: do you have RSS feed for it by chance > | 16:53 |
SRabbelier | solydzajs: google code needs to hurry up and support mercurial | 16:53 |
solydzajs | ? | 16:53 |
SRabbelier | solydzajs: yes | 16:54 |
solydzajs | SRabbelier: soon soon :-) | 16:54 |
SRabbelier | solydzajs: http://repo.or.cz/w/Melange.git | 16:54 |
tpb | Title: Public Git Hosting - Melange.git/summary (at repo.or.cz) | 16:54 |
solydzajs | ok this works for me then ;-) | 16:54 |
solydzajs | no need for often commits :-) | 16:54 |
SRabbelier | solydzajs: good :) | 16:54 |
solydzajs | if you put all your local changes to this public repo :-) | 16:55 |
SRabbelier | solydzajs: I always do this | 16:55 |
SRabbelier | solydzajs: I do it among other reasons, to synch between my laptop and my desktop | 16:55 |
solydzajs | SRabbelier: ok great | 16:56 |
solydzajs | SRabbelier: you are all set :-) | 16:56 |
solydzajs | Lennie: you there ?;-) | 16:56 |
Lennie | solydzajs: Ofcourse :D | 16:56 |
SRabbelier | solydzajs: you might want to subscribe to http://repo.or.cz/w/Melange.git?a=rss;h=refs/heads/role-invites as well | 16:56 |
tpb | <http://ln-s.net/2SQZ> (at repo.or.cz) | 16:56 |
SRabbelier | solydzajs: I use topic branches a lot ;) | 16:56 |
durin42 | SRabbelier: why not github? | 16:57 |
SRabbelier | durin42: never bothered | 16:57 |
solydzajs | SRabbelier: how can I see list of your branches ? | 16:57 |
SRabbelier | durin42: if you like, I can set up at github | 16:57 |
Lennie | solydzajs: Is it going to be possible to prepopulate the create fields, would be nice for invites :) | 16:58 |
durin42 | SRabbelier: I just prefer github's pretty to the lack thereof on repo.or.cz | 16:58 |
durin42 | SRabbelier: then again, hg.durin42.com is where the hg clone is | 16:58 |
durin42 | so... *shrug* | 16:58 |
SRabbelier | Lennie: ofcourse it will be, I need it for invites :P | 16:58 |
SRabbelier | durin42: -nod- | 16:58 |
Lennie | SRabbelier: k | 16:58 |
solydzajs | Lennie: how are you doing with time for Melange ? | 16:58 |
SRabbelier | solydzajs: http://repo.or.cz/w/Melange.git?a=heads | 16:58 |
tpb | Title: Public Git Hosting - Melange.git/heads (at repo.or.cz) | 16:58 |
SRabbelier | solydzajs: it has an rss feed too ;) | 16:59 |
Lennie | solydzajs: Bad this week, university + wrath of lich king release :P | 16:59 |
Lennie | solydzajs: about 8-10 hours I think :) | 16:59 |
SRabbelier | solydzajs: (note that I did not synch from my laptop yet, so you cannot see my latest work atm) | 16:59 |
SRabbelier | Lennie: addict ;) | 16:59 |
solydzajs | Lennie: ok so basically you will work on some bug fixes and send some patches in ? | 16:59 |
Lennie | solydzajs: And email for SRabbelier | 16:59 |
solydzajs | Lennie: ok great | 16:59 |
Lennie | solydzajs: I dont have anything specific at the moment :) | 16:59 |
Lennie | solydzajs: Not that I care, somone has to manually test stuff :P | 17:00 |
Lennie | *someone | 17:00 |
SRabbelier | yeah, until durin42 gets those tests on the road :P | 17:00 |
durin42 | someone should write automated tests rather than do it by hand ;) | 17:00 |
Lennie | Usability tests :P | 17:01 |
solydzajs | durin42: you said you gonna have some more time for Melange in the upcoming week right ? You are going to work on tests ? | 17:01 |
durin42 | solydzajs: that's the plan | 17:01 |
solydzajs | durin42: ok great | 17:01 |
SRabbelier | solydzajs: how about you? | 17:01 |
SRabbelier | solydzajs: that as_table stuff has been in your queue for at least a week now ;) | 17:02 |
solydzajs | SRabbelier: yep it needs some code cleaning. I have a queue of few other things. I'm going to create a Program model soon too. | 17:03 |
solydzajs | SRabbelier: I have couple things I need to fix in your recent commits | 17:04 |
SRabbelier | solydzajs: so, where do you put your uncommitted changes? | 17:04 |
SRabbelier | solydzajs: yeah, i probably broke former_ids again | 17:04 |
solydzajs | SRabbelier: test and fix those former_ids (lower, upper case issue is still not totally fixed) | 17:04 |
SRabbelier | solydzajs: I just could not make out how to do the merge, I figured it'd be easier if I left it to you ;) | 17:04 |
SRabbelier | solydzajs: can you do the former id stuff? | 17:06 |
solydzajs | SRabbelier: yep will do it. I will do what is on my todo list (including former ids) and then move to Programs I think | 17:07 |
SRabbelier | solydzajs: ok, awesome | 17:07 |
SRabbelier | solydzajs: hopefully I can start working on finishing Host :) | 17:07 |
SRabbelier | (next week or so) | 17:07 |
solydzajs | SRabbelier: I might add stuff there too :-) gonna see | 17:08 |
SRabbelier | solydzajs: it'll be part of the 'invite a host' I reckon | 17:09 |
solydzajs | SRabbelier: ok good | 17:09 |
*** tlarsen|afk is now known as tlarsen | 17:09 | |
SRabbelier | tlarsen: wb | 17:09 |
Lennie | tlarsen: welcome back | 17:09 |
SRabbelier | Lennie: ninja-ed | 17:10 |
Lennie | solydzajs: Maybe we can talk about users now? | 17:10 |
Lennie | solydzajs: Since Todd is here | 17:10 |
SRabbelier | Lennie: we need to talk about what Todd is going to do first ;) | 17:10 |
SRabbelier | Lennie: unless that involves said users | 17:10 |
Lennie | SRabbelier: Good point :P | 17:10 |
solydzajs | SRabbelier: Todd is going to finish Terms of Service first | 17:10 |
Lennie | solydzajs: Hard coded quiz object right? | 17:11 |
solydzajs | solydzajs: yep I think that's the plan, but maybe tlarsen can answer that :-) | 17:11 |
* tlarsen has been reading the back-scroll... | 17:13 | |
SRabbelier | always fun | 17:13 |
tlarsen | Lennie: Yes. | 17:13 |
tlarsen | Lennie: We need to get the Linkable stuff done first, since it is going to be a far-reaching change that will break stuff. | 17:13 |
Lennie | tlarsen: Talking about commit 1008? | 17:14 |
solydzajs | tlarsen: I will look at your Linkable commit right now | 17:14 |
tlarsen | I also want to put some of the sidebar stuff into the Model view classes. I want to add a method that returns preconstructed menus that are then combined with the static stuff. | 17:14 |
Lennie | tlarsen: Looked nice to me, have to read it a bit more thorough to reach a solid conclusion | 17:14 |
tlarsen | I think it is silly that we keep updating soc/logic/site/map.py when the menu changes should be localized to the soc/logic/model code that is changing instead. | 17:15 |
SRabbelier | tlarsen: yes, this is what I said during the last meeting | 17:15 |
tlarsen | SRabbelier: And yet, your recent changes add to site/map.py instead of adding a method. :) | 17:16 |
tlarsen | SRabbelier: I was thinking something along the lines of getSidebar(). | 17:16 |
SRabbelier | tlarsen: what do you mean, which recent changes? | 17:16 |
SRabbelier | tlarsen: I cleaned up SiteSettings so that 'site_main' is just a function call instead of passing kwargs :) | 17:17 |
tlarsen | SRabbelier: I'm just saying that lots of recent commits add stuff to the site by putting them in site/map.py, instead of us getting sidebar menu structure and urlpatterns from the new classes. | 17:17 |
SRabbelier | tlarsen: well, it wasn't there currently | 17:17 |
SRabbelier | tlarsen: if it was I would have used it | 17:17 |
tlarsen | SRabbelier: I am talking about the commits that I have been going through that were committed since Friday. | 17:17 |
SRabbelier | tlarsen: I did not have the time to refactor that too | 17:17 |
tlarsen | SRabbelier: Yes, I realize. We talked about it, but I haven't seen any attempts to do it the way we talked about. | 17:18 |
tlarsen | SRabbelier: I don't think it is a refactor, per se. | 17:18 |
SRabbelier | tlarsen: it'd be cleaner if it was though | 17:18 |
tlarsen | SRabbelier: Just add a method that returns the sidebar structure for that set of views, and patch that into site/sidebar.py. | 17:18 |
tlarsen | SRabbelier: I think we can do this incrementally. | 17:18 |
SRabbelier | tlarsen: please be my guest and lead the way ;) | 17:18 |
tlarsen | SRabbelier: not some huge refactor that touches lots of code. | 17:19 |
SRabbelier | tlarsen: no, not lots of code, just map.py and the views/models/*.py | 17:19 |
tlarsen | SRabbelier: Sigh. You know more about the new code than I do. You wrote it. But, sure, I'll take a stab at it. | 17:19 |
solydzajs | tlarsen: getMenuItem maybe instead of getSidebar ? | 17:19 |
SRabbelier | tlarsen: you need to get to know the new code too though :) | 17:19 |
SRabbelier | tlarsen: do you want working "Invite a Host", or to have this sitemap stuff done first... | 17:20 |
SRabbelier | I cannot do both first : | 17:20 |
SRabbelier | :P | 17:20 |
tlarsen | solydzajs: Yes, getMenuItem(). | 17:20 |
tlarsen | solydzajs: Then, we just pull stuff out of site/sidebar.py and replace it with calls to getMenuItem() from the correct view singletons, right? | 17:20 |
solydzajs | tlarsen: yes I think that would be nice. | 17:21 |
tlarsen | SRabbelier: I am not asking you to change what you are doing. Just don't add anything more to site/map.py. | 17:21 |
tlarsen | SRabbelier: let's figure out how to represent what is in site/map.py in the new code, and only make things show up in urlpatterns and the sidebar menu *that* way. (whatever "that" way is...) | 17:21 |
*** mithro has joined #melange | 17:22 | |
*** ChanServ sets mode: +v mithro | 17:22 | |
SRabbelier | tlarsen: mhhh, I was thiking of something like this | 17:22 |
tlarsen | SRabbelier: Once I have an example that works, I can go and replicate that pattern for all of the existing ones. | 17:22 |
* SRabbelier gets a whiteboard... | 17:22 | |
SRabbelier | instead of having to change site/sidebar.py all the time | 17:23 |
SRabbelier | wouldn't it be better to create a singleton somewhere, aptly named 'sitemap', with a few public functions similar to what we use now in map.py | 17:23 |
SRabbelier | so that you can do | 17:24 |
SRabbelier | sitemap.addSite(self) | 17:24 |
tlarsen | Yes, the other code should "register" its place in the sidebar, breadcrumb, and urlpatterns structure. | 17:24 |
tlarsen | I think that would be addPage(). | 17:24 |
SRabbelier | right | 17:24 |
tlarsen | Or addView() or something. | 17:24 |
SRabbelier | so instead of editing http://code.google.com/p/soc/source/browse/trunk/app/soc/logic/site/sidebar.py?r=1002 | 17:24 |
tpb | <http://ln-s.net/2SQw> (at code.google.com) | 17:24 |
SRabbelier | we just put the sitemap.addPage call in the view model | 17:25 |
tlarsen | Yes, that is what should happen. | 17:25 |
tlarsen | Keep in mind that some of these need to be callables that return a menu structure. | 17:25 |
SRabbelier | tlarsen: why do push | 17:25 |
tlarsen | They will be dynamic and need to produce MenuItem structures based on the contents of the Datastore, when they are called at sidebar menu display time. | 17:26 |
SRabbelier | tlarsen: aah, like that | 17:26 |
SRabbelier | tlarsen: yes, this I agree on | 17:26 |
SRabbelier | tlarsen: so we add a property, cachable | 17:26 |
tlarsen | So, I think views should be able to: | 17:26 |
SRabbelier | sitemap.addSite(self, cachable=True) | 17:26 |
SRabbelier | if cachable, the sitemap can construct that part of the map on lazy init | 17:26 |
tlarsen | 1) register a top-level "menu name" and a callable that produces a MenuItem (that object also contains the sub-menus if any). | 17:26 |
SRabbelier | if it's not cachable, it just keeps that part of the menu structure in memory indefinitely, and asks it for it's contents every time the side menu is requested | 17:27 |
tlarsen | I still don't think it is a "Site" that is added... | 17:27 |
SRabbelier | meh, sorry, addpage | 17:27 |
tlarsen | But, yes, the cacheability is good. | 17:27 |
SRabbelier | please, I really don't care about names | 17:27 |
tlarsen | OK, if the first argument is 'self', what sort of interface does that 'self' provide? One that looks like a MenuItem? | 17:28 |
tlarsen | That would be my suggestion... | 17:28 |
SRabbelier | tlarsen: nono, why? | 17:28 |
SRabbelier | tlarsen: just give it a self.views.models.foo module | 17:28 |
tlarsen | Then what are you registering? | 17:29 |
tlarsen | OK, then that module needs to be able to produce sidebar menus and urlpatterns? | 17:29 |
SRabbelier | tlarsen: yes | 17:29 |
SRabbelier | tlarsen: but! | 17:29 |
tlarsen | Let's remember what the current site/map.py provides: | 17:29 |
SRabbelier | tlarsen: if possible, it should leave that to a function in base.py or such | 17:29 |
tlarsen | 1) urlpatterns that bind URLs to views | 17:29 |
tlarsen | 2) sidebar menu structure. | 17:29 |
SRabbelier | tlarsen: only if there need be a dynamic entry we should write code, otherwise it should just be some fields defined | 17:30 |
SRabbelier | tlarsen: yes, we can re-use part of that code | 17:30 |
tlarsen | If we are going to eliminate site/map.py, then we need something that produces the urlpatterns and something that produces the sidebar menu (and that sidebar structure would also be used for breadcrumbs, but that is internal to each view). | 17:30 |
SRabbelier | tlarsen: we can generate the breadcrumb in the same way we generate the sidebar menu | 17:31 |
SRabbelier | tlarsen: the urlpatterns should be defined in the soc.views.models.* module | 17:31 |
SRabbelier | tlarsen: something simple like a map should do | 17:31 |
tlarsen | I agree that the urlpatterns should be defined there, but what will collect them all and present them to Django? | 17:32 |
SRabbelier | tlarsen: correct them? | 17:32 |
* SRabbelier is lost now | 17:32 | |
SRabbelier | (do they get grades? :D) | 17:32 |
tlarsen | "collect" | 17:33 |
SRabbelier | 0.o | 17:33 |
SRabbelier | I'm blind | 17:33 |
SRabbelier | sorry | 17:33 |
tlarsen | In soc/logic/site/map.py, getDjangoUrlPatterns() returns all of the Url objects to Django. | 17:33 |
SRabbelier | it's 23:30 here! | 17:33 |
SRabbelier | yup | 17:33 |
SRabbelier | have urls.py just call sitemap.getDjangoUrlPatterns | 17:33 |
tlarsen | These need to be returned all at once, when the app first starts up. | 17:33 |
SRabbelier | can we guarantee sitemap is done initializing by then? | 17:34 |
tlarsen | So, the registry should be placed in site/map.py, but what initializes it? | 17:34 |
SRabbelier | iow, will all singletons be instantiated by then? | 17:34 |
tlarsen | Keep in mind that your singletons do not exist until the module is imported. | 17:34 |
tlarsen | SRabbelier: that is exactly what I am getting at. | 17:34 |
SRabbelier | tlarsen: bummer | 17:34 |
SRabbelier | tlarsen: import them all with reflection? :D | 17:35 |
SRabbelier | we do have an __import__ statement at our disposal :P | 17:35 |
SRabbelier | s/statement/method/ | 17:35 |
ibot | SRabbelier meant: we do have an __import__ method at our disposal :P | 17:35 |
tlarsen | Why not just require that the import be added to site/map.py each time there is a new view module? | 17:36 |
solydzajs | Importing them all at startup is not stupid tho, will speed it up :-) | 17:36 |
SRabbelier | eep :( | 17:36 |
SRabbelier | tlarsen: I thought we wanted to avoid that | 17:36 |
SRabbelier | for files in "soc/views/models": | 17:36 |
SRabbelier | __import__ file # pseudo code | 17:36 |
SRabbelier | wouldn't that work? | 17:36 |
SRabbelier | I mean, it's not even that ugly | 17:36 |
tlarsen | SRabbelier: I don't mind 10 imports replacing 50 manually declared Page objects. | 17:36 |
tlarsen | SRabbelier: It is still a *big* win. | 17:36 |
SRabbelier | tlarsen: yes, this is true | 17:36 |
solydzajs | true | 17:36 |
Lennie | +1 | 17:36 |
SRabbelier | tlarsen: even better if we can do it without the imports though :) | 17:36 |
SRabbelier | tlarsen: later worry | 17:37 |
SRabbelier | tlarsen: we can do it with manual imports in urls.py like we used to | 17:37 |
tlarsen | Yes, incremental clean-ups, rather than the magical silver bullet. | 17:37 |
SRabbelier | :) | 17:37 |
SRabbelier | ok | 17:37 |
SRabbelier | so in urls.py we put all the imports | 17:37 |
SRabbelier | when those are done, we will know sitemap is fully initialized | 17:37 |
tlarsen | I would rather the "Django" file urls.py not change. | 17:37 |
SRabbelier | oh, ok, sure | 17:37 |
SRabbelier | stuff it in map.py | 17:37 |
SRabbelier | I don't care much | 17:38 |
SRabbelier | anwyay | 17:38 |
tlarsen | Just put the imports in site/map.py, and importing that in urls.py will do the trick. | 17:38 |
SRabbelier | sitemap wil lbe initialized | 17:38 |
SRabbelier | so we can ask for the django urls | 17:38 |
tlarsen | SRabbelier: The point is to get the urlpatterns in the individual view modules close to where they are used. | 17:38 |
SRabbelier | which can be constructed properly, using the paramter supplied earlier | 17:38 |
SRabbelier | sitemap.addPage(self, cachable=foo, add_sitebar=True) | 17:39 |
SRabbelier | add some sanity checks if you want in addPage | 17:39 |
tlarsen | That way, if code needs to generate patterns (or generate sidebar structure) it can. | 17:39 |
SRabbelier | tlarsen: yes, that's what I want too | 17:39 |
SRabbelier | tlarsen: teh santiy check should check if there's no regexp in the url | 17:40 |
SRabbelier | but I want it to be explicit that you want to show up in the sidebar | 17:40 |
SRabbelier | oh, wait | 17:40 |
* MatthewWilkes wishes zope.component worked in GAE, perfect for this usecase | 17:40 | |
SRabbelier | MatthewWilkes: +1 | 17:41 |
SRabbelier | it shouldn't be an arg to addPag | 17:41 |
SRabbelier | since you can export multiple views | 17:41 |
tlarsen | SRabbelier: I'd really rather not supply a lot of parameters to the sitemap registry. | 17:41 |
SRabbelier | so it should be a field in the value side of the dictionary | 17:41 |
SRabbelier | tlarsen: yeah, we can drop cachable too and put it in the dict | 17:41 |
tlarsen | SRabbelier: it is best if the 'self' passed to the registry just provides some methods that answer those questions. | 17:41 |
SRabbelier | tlarsen: cachable should be per-view too | 17:41 |
SRabbelier | tlarsen: sure | 17:42 |
tlarsen | SRabbelier: e.g. isInSidebar() and isCachable(). | 17:42 |
SRabbelier | tlarsen: mhhhh, nono, the self can export multiple views | 17:42 |
tlarsen | Then that is not what I had in mind, I suppose. | 17:42 |
SRabbelier | for example | 17:42 |
tlarsen | I have been thinking in terms of Page objects, which are per-view. | 17:42 |
SRabbelier | yes, but soc.views.models.* are not Page objects anyway, so those Page objects should just be generated from the data contained in the soc.views.models* object | 17:43 |
tlarsen | SRabbelier: I think we have two separate use cases here, that are getting mixed up because I combined urlpatterns info *and* sidebar structure in my Page objects. | 17:44 |
tlarsen | SRabbelier: Let's get rid of the concept of the Page object for the sake of discussion for a bit. | 17:45 |
tlarsen | SRabbelier: We really have two different problems to solve: | 17:45 |
SRabbelier | let's go for a Nodei nstead | 17:45 |
SRabbelier | since we're creating a tree, yes? | 17:45 |
SRabbelier | a Node can have children | 17:45 |
tlarsen | 1) have an soc.views.models.* class return the urlpatterns that it needs registered | 17:45 |
tlarsen | 2) have an soc.views.models.* class provide a method that will produce, on demand, the MenuItem (so that some sidebar menus can be dynamic) | 17:46 |
tlarsen | Caching for #2 should be done *inside* the soc.views.models.* class. | 17:46 |
SRabbelier | tlarsen: ah, why not | 17:46 |
tlarsen | If it doesn't need to be dynamic, it lazy-generates a MenuItem object once, caches it, and returns that every time. | 17:46 |
tlarsen | If it needs dynamic sidebar contents, it creates it each time getMenuItem() is called. | 17:47 |
SRabbelier | tlarsen: ok | 17:47 |
SRabbelier | tlarsen: and it can just add any sub-items to the MenuItem as it desires? | 17:47 |
tlarsen | SRabbelier: I think the soc.views.models.* class is in the best position to know what is cachable and what is not. | 17:47 |
SRabbelier | tlarsen: right, ofcourse :) | 17:47 |
tlarsen | SRabbelier: it can even cache *some* sub-menus and not others, for example. | 17:47 |
SRabbelier | tlarsen: right | 17:48 |
tlarsen | SRabbelier: I guess I'd like to see this partially implemented before we add any more views. | 17:48 |
SRabbelier | tlarsen: ok, so this is your priority? | 17:48 |
tlarsen | Once there is one agreed on interface, anyone can refactor existing views as needed. | 17:48 |
*** scorche has quit IRC | 17:49 | |
tlarsen | SRabbelier: I'd just like to see one example, before I go off and start refactoring everything. | 17:49 |
tlarsen | SRabbelier: That way, we are all sure that we are on the same page. | 17:49 |
tlarsen | (pun intended) | 17:49 |
SRabbelier | heh | 17:49 |
SRabbelier | tlarsen: go ahead, put it on codereviews, I'll have a look at it and let you know if that's what I have in mind | 17:49 |
*** scorche has joined #melange | 17:50 | |
Lennie | that's it :)? | 17:50 |
SRabbelier | Lennie: I'm good, time for bed, yes? | 17:51 |
Lennie | SRabbelier: Yeah almost ^^ | 17:51 |
solydzajs | :-) | 17:51 |
tlarsen | SRabbelier: OK, I'm going to add two interfaces, one that returns a list of Django Url objects, and one that returns a MenuItem. | 17:51 |
SRabbelier | tlarsen: sounds good to me | 17:51 |
SRabbelier | tlarsen: I agree that they should be seperate | 17:51 |
tlarsen | I will come up with something tonight or tomorrow morning (depending on how my evening goes...). | 17:51 |
tlarsen | I will likely just commit it if it works. | 17:52 |
SRabbelier | tlarsen: the current solution of adding the Django Urls to the sitemap (things like 'user/edit/<link name pattern>' being under the site_home thing) feels icky | 17:52 |
tlarsen | (I will blend the old and new ways, not breaking anything.) | 17:52 |
SRabbelier | tlarsen: ok | 17:52 |
tlarsen | SRabbelier: Yes, agreed. It was a hack to keep the stuff in urls.py and the sidebar menu structure together. | 17:52 |
SRabbelier | tlarsen: right, let's correct that :) | 17:53 |
tlarsen | SRabbelier: It was an intermediate point to moving each view's information about that closer to the view. | 17:53 |
solydzajs | ok guys, can somebody please write a short summary of your discussion and upcoming changes and post it on melange-dev ? | 17:53 |
Lennie | that would be nice | 17:53 |
SRabbelier | we need a wiki :P | 17:53 |
solydzajs | SRabbelier: we are slowly fixing everything :-) | 17:53 |
tlarsen | solydzajs: The IRC log isn't good enough? :) | 17:53 |
solydzajs | SRabbelier: we have a wiki ;-) | 17:53 |
SRabbelier | solydzajs: yes, we are | 17:53 |
tlarsen | SRabbelier: http://code.google.com/p/soc/wiki | 17:54 |
tpb | Title: soc - Google Code (at code.google.com) | 17:54 |
SRabbelier | solydzajs: this is true, but it cerates an svn commit fore ach change :P | 17:54 |
tlarsen | SRabbelier: yes, that is annoying. | 17:54 |
solydzajs | tlarsen: well it's ok, | 17:54 |
tlarsen | Let's use Sites. | 17:54 |
SRabbelier | anyway | 17:54 |
tlarsen | Just a sec. | 17:54 |
solydzajs | tlarsen: :-) | 17:54 |
SRabbelier | I'm off to bed now | 17:54 |
tlarsen | http://sites.google.com/a/googleopensourceprograms.com | 17:54 |
SRabbelier | I'll write up something tomorrow | 17:54 |
tpb | <http://ln-s.net/2SRQ> (at sites.google.com) | 17:54 |
solydzajs | tlarsen: we have sites on googleopensourceprograms.com right ? | 17:54 |
Lennie | SRabbelier nn | 17:54 |
solydzajs | tlarsen: yep exacly +1 | 17:54 |
SRabbelier | tlarsen: fancy that | 17:54 |
tlarsen | solydzajs: Every committer has access to that. | 17:54 |
*** mithro has quit IRC | 17:55 | |
tlarsen | SRabbelier: I hope you remember your password. :) | 17:55 |
solydzajs | tlarsen: yep I know, I'm using Google Apps for your domain on other domains too | 17:55 |
Lennie | tlarsen: n1 :P | 17:55 |
SRabbelier | tlarsen: sure, yay Google Chrome | 17:55 |
Lennie | if you'd read about him forgetting admin pw that is :) | 17:55 |
tlarsen | Feel free to check this stuff as "public" by the way. | 17:55 |
tlarsen | Lennie: That is exactly what I was referring to. :) | 17:56 |
SRabbelier | hehe | 17:56 |
SRabbelier | that was 5 years ago :P | 17:56 |
SRabbelier | actually | 17:56 |
SRabbelier | I think the manufacturer shipped it with that pwd | 17:56 |
SRabbelier | that's what I read in microsoft's KB | 17:56 |
SRabbelier | anyway, let's schedule a meeting this sunday, yes? | 17:56 |
SRabbelier | to discuss what all we got done | 17:56 |
SRabbelier | btw, the next conference call needs to move half an hour forward | 17:57 |
solydzajs | yes let's schedule for sunday | 17:57 |
SRabbelier | I can't make it home in half an hour, and I can't keep bothering Lennard ;) | 17:57 |
Lennie | I'm not gonna make dinner for sverre everyday :p | 17:57 |
solydzajs | I will schedule it and invite you all | 17:57 |
solydzajs | sunday around 7-8PM | 17:57 |
SRabbelier | Lennie: (dinner was really good ;)) | 17:57 |
SRabbelier | solydzajs: +1 | 17:57 |
Lennie | solydzajs, can you send me a calendar invite too? | 17:57 |
solydzajs | Lennie: yep of course I will send to all | 17:58 |
SRabbelier | tlarsen: can you ping Chris about moving the biweekly call forward 30-60 minutes? | 17:58 |
Lennie | not sure I was part of all ^^ | 17:58 |
tlarsen | SRabbelier: no meetings for me on Sundays, sorry. | 17:58 |
solydzajs | tlarsen: SRabbelier is working on generic Invitations till Sunday | 17:58 |
tlarsen | SRabbelier: earlier on Monday? | 17:58 |
solydzajs | tlarsen: ok let's make it on Monday | 17:58 |
tlarsen | SRabbelier: it is already 9:00 AM for him. | 17:58 |
SRabbelier | tlarsen: then wouldn't 9:30 or 10:00 be better for him? ;) | 17:58 |
solydzajs | tlarsen: Monday 1PM your time ? | 17:59 |
tlarsen | SRabbelier: Oh, you want to move it *later*. | 17:59 |
SRabbelier | tlarsen: yes, that's what I'm saying, forward? | 17:59 |
tlarsen | 10:00 AM his time is noon my time. | 17:59 |
tlarsen | CST is PDT+2 | 17:59 |
tlarsen | Err, PST+2 | 17:59 |
* SRabbelier wonders by what definition forward means earlier :P | 17:59 | |
* Lennie ponders about going forward faster then light | 17:59 | |
tlarsen | SRabbelier: "forward" == "advance" | 17:59 |
SRabbelier | tlarsen: ah, yes, in that context I see it meaning earlier | 17:59 |
tlarsen | SRabbelier: If you want to "move a meeting forward" you want to "advance" it. | 18:00 |
SRabbelier | context['that'] = earlier? :P | 18:00 |
solydzajs | ok guys I gonna schedule a meeting for Monday at 8PM UTC +1 | 18:00 |
* SRabbelier shakes head at crazy americans | 18:00 | |
SRabbelier | solydzajs: yes, that would be good | 18:00 |
SRabbelier | tlarsen: will you ask if Chris is ok with doing the meeting an (half) hour later? | 18:00 |
tlarsen | SRabbelier: Yes, I will ask him. That would be at 9:30 AM PST, right? Anyone have a world time link? | 18:01 |
SRabbelier | tlarsen: sure, will fetch one | 18:02 |
solydzajs | tlarsen: 9:30 AM MTV time, 12:30 Alabama time, 6:30PM NL/PL time | 18:02 |
SRabbelier | solydzajs: ok | 18:02 |
SRabbelier | 10AM MTV time would be perfect though | 18:02 |
SRabbelier | cos that way I can get something to eat before the call :P | 18:02 |
Lennie | SRabbelier: Coders dont need food | 18:02 |
SRabbelier | but if it's not an option 9:30AM MTV time is an option | 18:02 |
SRabbelier | Lennie: you know this to be a lie :P | 18:02 |
solydzajs | tlarsen: our internal Monday meeting will be at 11AM MTV time, 1PM Alabama, 8PM NL/PL time | 18:03 |
Lennie | SRabbelier: Sverre needs food :) | 18:03 |
SRabbelier | Lennie: does this mean I'm not a coder? :( | 18:03 |
SRabbelier | solydzajs: +1 | 18:03 |
Lennie | solydzajs: ++ | 18:03 |
tlarsen | At this time? | 18:03 |
tlarsen | http://www.timeanddate.com/worldclock/meetingdetails.html?year=2008&month=11&day=24&hour=17&min=30&sec=0&p1=37&p2=64&p3=224 | 18:03 |
tpb | <http://ln-s.net/2SRY> (at www.timeanddate.com) | 18:03 |
SRabbelier | tlarsen: but preferring http://www.timeanddate.com/worldclock/meetingdetails.html?year=2008&month=11&day=24&hour=18&min=00&sec=0&p1=37&p2=64&p3=224 | 18:03 |
tpb | <http://ln-s.net/2SR_> (at www.timeanddate.com) | 18:04 |
SRabbelier | (considering that I need f00d!) | 18:04 |
solydzajs | both work for me | 18:04 |
SRabbelier | oh | 18:05 |
SRabbelier | btw | 18:05 |
SRabbelier | we has a bug | 18:05 |
SRabbelier | in validating e-mail | 18:05 |
SRabbelier | annoying google app engine cuts off the @gmail.com part | 18:05 |
solydzajs | SRabbelier: yep I know because we don't add emails to former_ids but User objects | 18:06 |
solydzajs | SRabbelier: it's not a bug | 18:06 |
SRabbelier | so when I edit someone's user page (if they have a @gmail.com account), it'll show just the prefix | 18:06 |
solydzajs | SRabbelier: it's the way we display them | 18:06 |
SRabbelier | it makes it impossible to do /user/edit/tlarsen, and just hit 'save' | 18:06 |
SRabbelier | (one would expect that to do nothing, since you didn't change anything | 18:06 |
SRabbelier | instead it will give an error that 'tlarsen' is not a valid e-mail address) | 18:06 |
solydzajs | SRabbelier: oh weird | 18:07 |
SRabbelier | solydzajs: possibly my fault with the user refactoring | 18:07 |
SRabbelier | Lennie: interested in looking at that perhaps? | 18:07 |
solydzajs | SRabbelier: I will have a look at it | 18:07 |
solydzajs | SRabbelier: but tomorrow | 18:07 |
Lennie | SRabbelier: Guess not :) | 18:07 |
SRabbelier | solydzajs: you have a huge queue though | 18:07 |
SRabbelier | solydzajs: why not let Lennie do it ;) | 18:07 |
solydzajs | sure Lennie do it :-) | 18:08 |
solydzajs | I'm fine with that | 18:08 |
Lennie | grmbl ^^ | 18:08 |
Lennie | sure | 18:08 |
Lennie | I'll add it to my list :) | 18:08 |
solydzajs | ok great | 18:08 |
Lennie | Drop a bugreport in my email SRabbelier ^^ | 18:08 |
SRabbelier | Lennie: pfff, I'll poke you tomorrow | 18:09 |
Lennie | SRabbelier: So I know how to reproduce :D | 18:09 |
SRabbelier | Lennie: a lot easier to just show you :P | 18:09 |
Lennie | ^^ | 18:09 |
Lennie | Lazy me :) | 18:09 |
SRabbelier | ok | 18:09 |
SRabbelier | bed calls | 18:09 |
SRabbelier | g'night people | 18:09 |
solydzajs | good night | 18:09 |
SRabbelier | cheers! | 18:09 |
SRabbelier | solydzajs: thank you for hosting this meeting | 18:09 |
solydzajs | tlarsen: is 1PM meeting on Monday ok with you ? | 18:09 |
solydzajs | SRabbelier: always man :-) heh | 18:10 |
tlarsen | solydzajs: This coming Monday? Sure. | 18:10 |
SRabbelier | solydzajs: cheers :) | 18:10 |
Lennie | tlarsen: Hopefully we can talk about that long user thread then :) | 18:10 |
solydzajs | tlarsen: yep, our internal IRC meeting to see the progress since today. | 18:10 |
tlarsen | I don't have a problem with meetings during CST working hours, unless I already have a Google meeting, and those are usually on Friday. | 18:10 |
solydzajs | tlarsen: ok good, then I will invite you all and schedule it for Monday | 18:10 |
tlarsen | Chris said OK to moving the meeting to 18:00 UTC. | 18:10 |
solydzajs | tlarsen: ok great. | 18:11 |
Lennie | solydzajs: Cool, I'll see the invite pop-up in my calendar then :D | 18:11 |
Lennie | iGoogle homepage, best ever! | 18:11 |
tlarsen | Lennie: To what email address should the invite be sent? | 18:11 |
*** SRabbelier has quit IRC | 18:11 | |
solydzajs | Lennie: you can always add reminders :-) I have SMS and Email reminders for our biweekly meetings | 18:11 |
Lennie | tlarsen: [email protected] | 18:12 |
tlarsen | What is your full name? | 18:12 |
Lennie | Lennard de Rijk | 18:12 |
Lennie | Leonardus Johannes Vincentcius de Rijk, if you'd really want the full name :P | 18:12 |
solydzajs | wow | 18:12 |
solydzajs | :-) | 18:12 |
solydzajs | crazy NLs :-) | 18:13 |
Lennie | Crazy Roman Catholics :P | 18:13 |
Lennie | but lets just keep it on Lennard shall we :D | 18:13 |
solydzajs | true I'm catholic too so my first name is Pawel, second is Lukasz, third is Mateusz :-) | 18:13 |
solydzajs | Pawel Lukasz Mateusz Solyga | 18:13 |
solydzajs | :D | 18:13 |
solydzajs | heh | 18:13 |
Lennie | :) | 18:13 |
solydzajs | but Mateusz is only used at church sometimes | 18:14 |
solydzajs | Lukasz is needed sometimes for paperwork | 18:14 |
Lennie | Lukasz is a cool name, only we would leave out the z :) | 18:14 |
solydzajs | Pawel is used everywhere :-) | 18:14 |
Lennie | :) | 18:15 |
Lennie | think thats it for tonight then | 18:16 |
Lennie | unless you guys have something to add :D | 18:16 |
Lennie | or ask | 18:17 |
solydzajs | that's it | 18:17 |
solydzajs | have a good night | 18:17 |
Lennie | k cool | 18:17 |
Lennie | nn | 18:17 |
*** Lennie has quit IRC | 18:18 | |
solydzajs | tlarsen: g'night | 18:34 |
*** solydzajs has quit IRC | 18:38 | |
*** MatthewWilkes has quit IRC | 19:11 | |
*** tlarsen has quit IRC | 19:14 | |
*** penyaskito_ has joined #melange | 19:51 | |
*** tansell has joined #melange | 22:54 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!