*** tpb has joined #melange | 02:57 | |
lh | solydzajs: no worries. | 02:58 |
---|---|---|
lh | since i timed out half way through | 02:58 |
lh | _Allen_ or solydzajs - can you publish the meeting logs as a text file? I'll send them to the list | 02:59 |
solydzajs | lh: ok one sec :-) | 03:00 |
lh | solydzajs: thank you | 03:00 |
mithro | http://www.thousandparsec.net/~irc/logm/ | 03:01 |
tpb | Title: IRC logs (at www.thousandparsec.net) | 03:01 |
mithro | just for nextime | 03:01 |
lh | mithro: you rock, thank you | 03:02 |
_Allen_ | lh: done with the logs | 03:03 |
_Allen_ | lh: how to send it to you/ | 03:03 |
_Allen_ | ? | 03:03 |
mithro | just finished fixing search | 03:04 |
solydzajs | _Allen_: I'm sending right now :-) | 03:04 |
lh | _Allen_: just email as text file to melange-soc-dev | 03:04 |
mithro | http://www.thousandparsec.net/~irc/logm/search?q=logs | 03:04 |
tpb | <http://ln-s.net/2KMs> (at www.thousandparsec.net) | 03:04 |
lh | ok all this works too | 03:04 |
_Allen_ | solydzajs: ok | 03:04 |
_Allen_ | lh: ok | 03:04 |
lh | _Allen_: thank you very much | 03:05 |
mithro | might as well get atleast one thing done this weekend | 03:05 |
_Allen_ | lh: my pleasure :) | 03:05 |
lh | mithro: woot! | 03:06 |
solydzajs | done | 03:06 |
_Allen_ | solydzajs: thanks | 03:07 |
lh | i still think we should use ibot | 03:10 |
lh | but these logs are awesome for now | 03:10 |
lh | mithro: tyvm | 03:10 |
mithro | tyvm? | 03:10 |
lh | thank you very much | 03:10 |
mithro | oh | 03:10 |
mithro | my acronym foo is week, stupid dyslexia | 03:11 |
lh | no worries, i will always gladly expand for you | 03:12 |
mithro | well, talk to you tommorrow | 03:12 |
lh | mithro: sleep well | 03:12 |
* lh will brb | 03:12 | |
_Allen_ | solydzajs: please let me know once you made me the committer | 03:13 |
solydzajs | _Allen_: Todd will do that since I don't have rights :-) | 03:14 |
solydzajs | _Allen_: This will happen today | 03:14 |
_Allen_ | solydzajs: ah.. thanks | 03:14 |
* SRabbelier|Uni is back for a sec | 03:16 | |
lh | SRabbelier|Uni: we are going to start plotting demo on list | 03:16 |
lh | todd is checking mail right now | 03:16 |
SRabbelier|Uni | ok, cool | 03:17 |
* SRabbelier|Uni is brb again | 03:21 | |
SRabbelier|Uni | lh: +1 on the logs | 03:30 |
lh | SRabbelier|Uni: exactly. this needs to live forever. | 03:31 |
_Allen_ | SRabbelier|Uni: opps, I can not access the mailing list... | 03:34 |
SRabbelier|Uni | _Allen_: how come? | 03:35 |
_Allen_ | SRabbelier|Uni: 403 forbidden | 03:36 |
_Allen_ | SRabbelier|Uni: no detail info.. | 03:36 |
_Allen_ | brb | 03:37 |
*** _Allen_ has left #melange | 03:37 | |
*** solydzajs has quit IRC | 03:38 | |
*** _Allen_ has joined #melange | 03:41 | |
*** lh has quit IRC | 03:44 | |
*** lh has joined #melange | 03:44 | |
*** ChanServ sets mode: +o lh | 03:44 | |
*** mithro has quit IRC | 03:58 | |
*** lh has quit IRC | 04:01 | |
*** _Allen_` has joined #melange | 04:15 | |
*** _Allen_` has quit IRC | 04:15 | |
*** _Allen_ has quit IRC | 04:33 | |
*** _Allen_ has joined #melange | 04:47 | |
_Allen_ | SRabbelier|Uni: hey | 05:04 |
SRabbelier|Uni | _Allen_: hey again | 05:07 |
_Allen_ | SRabbelier|Uni: what can I help about your refactor? | 05:10 |
SRabbelier|Uni | _Allen_: I'm waiting for Todd and Pawel's comments first | 05:10 |
SRabbelier|Uni | going to try to actually get it working now :) | 05:11 |
_Allen_ | SRabbelier|Uni: ok | 05:11 |
_Allen_ | SRabbelier|Uni: if you have any idears or someting that need I do, tell whenever when I am hung on | 05:14 |
_Allen_ | SRabbelier|Uni: tell --> tell me | 05:14 |
SRabbelier|Uni | _Allen_: s/hung // :P | 05:16 |
_Allen_ | SRabbelier|Uni: while I am on this channel, :) | 05:16 |
SRabbelier|Uni | better :) | 05:17 |
_Allen_ | SRabbelier|Uni: do we have another discussion tommorrow? | 09:48 |
durin42 | SRabbelier|Uni: around now | 10:26 |
durin42 | SRabbelier|Uni: http://y99k.com/irc-away-nicks.txt | 10:27 |
*** tlarsen has joined #melange | 10:47 | |
*** ChanServ sets mode: +o tlarsen | 10:47 | |
SRabbelier|Uni | durin42: heya | 10:48 |
*** SRabbelier|Uni is now known as SRabbelier | 10:49 | |
SRabbelier | durin42: on the away nick, that was cos I wanted to be able to sign in from Uni with my SRabbelier nick ;) | 10:49 |
durin42 | Ah | 10:49 |
SRabbelier | durin42: but not having to sign out here | 10:49 |
SRabbelier | durin42: you gonna review my awesome refactorings? :D | 10:50 |
*** lh has joined #melange | 10:53 | |
*** ChanServ sets mode: +o lh | 10:53 | |
*** webchick has joined #melange | 10:56 | |
lh | heard from pawel, he's going to be late | 10:57 |
lh | oh yes and morning/evening all | 10:57 |
SRabbelier | lh: oh, how come? | 10:57 |
SRabbelier | morning :) | 10:57 |
SRabbelier | slept well? | 10:57 |
lh | SRabbelier: unknown | 10:57 |
lh | SRabbelier: yes! | 10:57 |
SRabbelier | lol, ok | 10:58 |
durin42 | goooooooood morning everyone! | 10:58 |
* durin42 wasn't awake but is now thanks to tea | 10:58 | |
SRabbelier | durin42: tea? dragon power tea or what? :P | 10:58 |
lh | durin42: good morning | 10:58 |
tlarsen | After this meeting, I will probably be away the rest of the day. Sorry. | 10:59 |
lh | tlarsen: no worries | 10:59 |
tlarsen | I connected up the 12v aux battery backwards in my Prius and blew the 100A fuse. | 10:59 |
SRabbelier | ouch | 10:59 |
lh | oh my. is the car ok? | 10:59 |
tlarsen | I am really praying I did not damage the DC/DC inverter. | 10:59 |
durin42 | SRabbelier: just generic green tea | 10:59 |
SRabbelier | durin42: whatever floats your boat :) | 10:59 |
tlarsen | lh: that is a 4-figure repair, and I'd have to have the car towed in, since it is disabled at my house. | 11:00 |
lh | tlarsen: that's expensive. :( | 11:00 |
durin42 | tlarsen: one hopes the fuse saved it | 11:00 |
* lh looks for demo stuff on list | 11:00 | |
tlarsen | durin42: The only other case of this I could find online only lost the fuse. | 11:00 |
tlarsen | durin42: It is a complete pain-in-the-ass "fuse". It is wired in. It took me three hours last night to detach it. | 11:00 |
durin42 | ugh | 11:01 |
* tlarsen *can* work on cars (and has since a teenager) but *hates* to be *required* to do it. | 11:01 | |
lh | tlarsen: that's awesome | 11:01 |
lh | so we're here to talk about what we want to demo at the mentor summit | 11:02 |
lh | pawel sent a starting set of ideas to melange-soc-dev | 11:02 |
tlarsen | So, how did you all like getting occasional emails from me from the ridgetops of the Appalachian Mountains when my G1 phone would work? | 11:02 |
durin42 | tlarsen: I feel you, I work on cars too | 11:02 |
lh | tlarsen: it was awesome. i love mine. | 11:02 |
SRabbelier | tlarsen: you have a G1 phone? | 11:03 |
SRabbelier | lh: no fair! | 11:03 |
tlarsen | SRabbelier: Yes. | 11:03 |
lh | http://groups.google.com/group/melange-soc-dev/browse_thread/thread/6d2cc9eb66fc7596 | 11:03 |
tpb | <http://ln-s.net/2KS6> (at groups.google.com) | 11:03 |
lh | everyone want to take a look? | 11:03 |
SRabbelier | lh: just read it | 11:03 |
lh | SRabbelier: i have two. one for demos and one for me. no one touches my andy | 11:03 |
lh | SRabbelier: cool | 11:03 |
lh | everyone else take a few mins to read in case they have not | 11:03 |
SRabbelier | lh: hehe, sweet :) | 11:04 |
*** TimRiker has joined #melange | 11:04 | |
lh | all hail TimRiker | 11:04 |
*** ibot has joined #melange | 11:04 | |
TimRiker | ~save | 11:04 |
ibot | saved user and chan files | 11:04 |
SRabbelier | TimRiker: I hear you're our log guy? :D | 11:05 |
TimRiker | lh: bot addeded. sorry I didn't get online much yesterday. :) | 11:05 |
lh | TimRiker: you rock, dude. | 11:05 |
* lh hands TimRikera laurel wreath | 11:05 | |
lh | hrm | 11:05 |
TimRiker | lh: got a couple shirts in the mail though, thx! :) | 11:05 |
lh | a laurel wreath even | 11:05 |
lh | rock! | 11:05 |
* lh loves the swag love | 11:05 | |
TimRiker | ~wreath lh | 11:05 |
lh | TimRiker: many many thanks | 11:05 |
* ibot hands lh a laurel wreath and nods in gratitude. | 11:05 | |
lh | i love ibot | 11:05 |
lh | :) | 11:06 |
TimRiker | ~logs | 11:06 |
ibot | All conversations are logged to http://ibot.rikers.org/channel, where "channel" is replaced by the URL-encoded channel name, such as %23freenode for #freenode. Lines starting with spaces are not logged. | 11:06 |
lh | okay folks, we now have perma logging thanks to mr. riker | 11:06 |
lh | folks one sec someone at my desk | 11:06 |
_Allen_ | TimRiker: wreath | 11:06 |
lh | please talk about pawel's mail | 11:06 |
lh | :) | 11:06 |
SRabbelier | I'm not sure what the 'apple' is doing in there :P | 11:07 |
tlarsen | It is fabulous. It touched a deep part of me. :) | 11:07 |
TimRiker | if you're not familiar with ibot... /msg ibot help is a good place to start. | 11:07 |
SRabbelier | but it looks good :) | 11:08 |
TimRiker | what's with tpb? that bot is messaging me with error lines. | 11:09 |
SRabbelier | TimRiker: what's it saying? | 11:09 |
_Allen_ | 10 minutes left before the electric power off | 11:09 |
TimRiker | <tpb> Error: "where" is not a valid command. | 11:10 |
SRabbelier | _Allen_: oh? | 11:10 |
_Allen_ | SRabbelier: it's 23:10 in my country now | 11:10 |
SRabbelier | _Allen_: the power goes of at 23:20? | 11:10 |
_Allen_ | SRabbelier: exactly at 23:30 | 11:10 |
SRabbelier | _Allen_: the power jsut goes off? | 11:11 |
_Allen_ | SRabbelier: power cut | 11:11 |
SRabbelier | _Allen_: how come? | 11:11 |
_Allen_ | SRabbelier: it is the rule of my school | 11:12 |
SRabbelier | _Allen_: lol... ok :P | 11:12 |
_Allen_ | SRabbelier: so this is another discussion? | 11:12 |
*** madrazr has joined #melange | 11:12 | |
SRabbelier | _Allen_: uhm, we're gonna talk about the demo now | 11:13 |
_Allen_ | SRabbelier: sorry that I can not participate | 11:13 |
tlarsen | I think we need to get the Question/Answer/Questionnaire/Response stuff done before the summit. | 11:13 |
SRabbelier | tlarsen: is there a lot of specific logic for those? | 11:13 |
tlarsen | lh: the Terms of Service, Organization applications, etc. are implemented in terms of this. | 11:13 |
tlarsen | No, here is the plan: | 11:14 |
tlarsen | In the (Site/Sponsor/Organization) Settings, you can: | 11:14 |
tlarsen | 1) pick a Questionnaire that has already been created. | 11:14 |
tlarsen | 2) within that Questionnaire, pick the question that represents the "I agree" question | 11:15 |
SRabbelier | tlarsen: similar to how in SiteSetting a Document is selected? | 11:15 |
lh | TimRiker: thank you for the help hint | 11:15 |
tlarsen | 3) within that Question, select the "I agree" affirmative answer | 11:15 |
tlarsen | SRabbelier: | 11:15 |
tlarsen | SRabbelier: Yes. | 11:15 |
lh | _Allen_: will you be online later? | 11:15 |
tlarsen | The Settings entity would store three things: | 11:16 |
tlarsen | 1) ReferenceProperty to the selected Questionnaire | 11:16 |
_Allen_ | lh: 9 hours later | 11:16 |
tlarsen | 2) StringProperty of the "I agree" Question short_name, or maybe even a ReferenceProperty to the Question entity | 11:16 |
_Allen_ | lh: sorry that I need off now | 11:16 |
SRabbelier | _Allen_: will see you later then | 11:17 |
lh | _Allen_: we have another meeting in 8 hrs - i can push it back if you want to participate | 11:17 |
tlarsen | 3) something to record what the "I agree" answer value needs to be | 11:17 |
lh | _Allen_: no problem | 11:17 |
* lh is happy to do the demo at the summit btw | 11:17 | |
tlarsen | SRabbelier: I am going to commit drafts of the Question, Answer, Questionnaire, and Response Models today. | 11:17 |
_Allen_ | lh: that's good | 11:17 |
SRabbelier | tlarsen: I was just reading that mail :) | 11:18 |
tlarsen | SRabbelier: I had them very fleshed out at one point, but I lost the code somehow, so I will have to re-write it. | 11:18 |
lh | _Allen_: will do. | 11:18 |
tlarsen | SRabbelier: I will then create issues in the issue tracker describing these pieces. | 11:18 |
SRabbelier | tlarsen: ok, sounds good; you're meaning just the model and logic code, no view code yet? | 11:18 |
tlarsen | SRabbelier: actually, I only had the Models. | 11:18 |
_Allen_ | lh: also feel free to hold that before I come back, I can see the log | 11:18 |
tlarsen | SRabbelier: I will commit something today. | 11:18 |
SRabbelier | tlarsen: ok, that's np :) | 11:19 |
_Allen_ | lh: hold --> start | 11:19 |
tlarsen | SRabbelier: the required logic was going to be described in a series of issues. | 11:19 |
tlarsen | SRabbelier: A UI is needed as well, to: | 11:19 |
lh | _Allen_: okay, but that's an hour before you are back, we will wait for you | 11:19 |
lh | :) | 11:19 |
SRabbelier | tlarsen: ok, makes sense; would be good for _Allen_ to work on | 11:19 |
tlarsen | 1) create Questions | 11:19 |
tlarsen | 2) create Questionnaires that combine a series of Questions | 11:19 |
_Allen_ | lh: ok, :) | 11:20 |
_Allen_ | see u guys | 11:20 |
tlarsen | 3) let users create Responses containing specific Answers to the Questions in a given Questionnaire | 11:20 |
*** _Allen_ has left #melange | 11:20 | |
SRabbelier | tlarsen: how much different from soc.logic.models.questionaires.getOrInsertFromFields... would the create part be? | 11:20 |
SRabbelier | tlarsen: is there a lot of additional stuff needeD? | 11:20 |
tlarsen | SRabbelier: You'll have to wait and see the Model :) | 11:20 |
SRabbelier | tlarsen: ok, will wait for that :) | 11:20 |
tlarsen | SRabbelier: A lot of the fields are *not* required, since the Question Model supports many types of questions. | 11:21 |
tlarsen | SRabbelier: Now that we have inheritance via PolyModel, I'm thinking about having a small hierarchy. | 11:21 |
tlarsen | SRabbelier: That wasn't available to me before, and the Question Model got unnecessarily complex. | 11:21 |
SRabbelier | tlarsen: the Questions will be stored in teh Questionairy in a ListProperty? | 11:21 |
lh | TimRiker: when will the melange logs show up at ibot.rikers.org? | 11:22 |
tlarsen | SRabbelier: No, in a many-to-many relation between Question and Questionnaire. | 11:22 |
SRabbelier | tlarsen: ok, so a question can appear in multiple questionaires? | 11:22 |
tlarsen | Questions can be reused in other Questionnaires. | 11:22 |
* SRabbelier nods | 11:23 | |
SRabbelier | ok, makes sense | 11:23 |
SRabbelier | so we'll have a 'list questions' view etc.? | 11:23 |
lh | please make sure to build this so that hosts can easily add/remove questions for questionairres | 11:24 |
lh | i dont want to bug devs for this every time | 11:24 |
SRabbelier | lh: that's easy to do with a many-to-many relation :) | 11:24 |
tlarsen | lh: It is completely run-time dynamic. | 11:24 |
tlarsen | lh: That is why it is so complicated to describe. | 11:24 |
*** penyaskito has quit IRC | 11:24 | |
tlarsen | lh: We couldn't possibly have something like Melange work with code changes being required to change or create Questionnaires. | 11:25 |
tlarsen | lh: They will be a sort of Document (Work, actually) that can be created on-the-fly. | 11:25 |
lh | tlarsen: that's very very good | 11:25 |
tlarsen | Ugh, I have 45 emails related to Melange that I still haven't answered, despite reading my emails on the trail. :( | 11:26 |
SRabbelier | tlarsen: I'm looking forward to your reviews :) | 11:26 |
SRabbelier | I managed to get all but the 'edit' part working generic | 11:26 |
SRabbelier | (for Sponsors) | 11:26 |
SRabbelier | and I haven't got edit workign cos I didnt' have time to start on that yet :P | 11:27 |
lh | ahem | 11:33 |
lh | conversation has stopped | 11:33 |
lh | lets keep it going here folks | 11:33 |
* SRabbelier is not sure what to discuss atm :) | 11:33 | |
durin42 | sorry, I vanished because of random bugs I wrote two weeks ago. | 11:33 |
durin42 | Did I miss anything I should have paid attention to? | 11:34 |
lh | durin42: no worries. any time to look at the test suite? | 11:34 |
lh | durin42: no you were fine. | 11:34 |
durin42 | lh: on the agenda for tonight | 11:34 |
lh | SRabbelier: how much work is left on the sponsors area | 11:34 |
lh | durin42: awesome. :) | 11:34 |
lh | thank you! | 11:34 |
SRabbelier | lh: for the refactored view stuff? | 11:34 |
lh | SRabbelier: yes | 11:34 |
durin42 | lh: with the MBP in the shop, I can't do hgsubversion stuff as well | 11:34 |
SRabbelier | lh: I think about an hour of work at most | 11:34 |
lh | durin42: MBP? | 11:34 |
* tlarsen prefers email threads for stuff like this, rather than IRC | 11:34 | |
lh | SRabbelier: ok cool | 11:35 |
durin42 | lh: MacBook Pro, aka 'a steev' | 11:35 |
SRabbelier | lh: the concept is up for review though | 11:35 |
lh | tlarsen: i know, but some people prefer this way. we will do both to make sure we have effective logs and discussions | 11:35 |
lh | durin42: understood | 11:35 |
lh | SRabbelier: what do you mean by concept up for review? | 11:35 |
SRabbelier | lh: the 1602 codereview | 11:35 |
tlarsen | lh: For me, it is like 10 conversations going on at once, very hard to follow. | 11:35 |
SRabbelier | lh: it's "pseudo code" | 11:35 |
tlarsen | lh: I guess I will just read the logs later. | 11:36 |
TimRiker | lh: logs run nightly, so tomorrow. | 11:36 |
lh | tlarsen: is it going by too fast for you? | 11:36 |
lh | TimRiker: thank you | 11:36 |
lh | :) | 11:36 |
tlarsen | TimRiker: I can read the back-scroll in my own client, but thanks. | 11:36 |
lh | SRabbelier: checking code review | 11:36 |
SRabbelier | lh: -nod- | 11:36 |
lh | tlarsen: it also logs online forever and ever and stuff. ++ | 11:36 |
tlarsen | lh: No, it is just that no one has the floor and three different conversations are intertwined. | 11:36 |
SRabbelier | lh: the views/model/sponsor.py module will get smaller as we make the django templates more generic | 11:37 |
lh | and has some other features that i dont understand but that sound really good | 11:37 |
lh | tlarsen: i see. | 11:37 |
lh | ok | 11:37 |
lh | serializing | 11:37 |
lh | durin42: you have test suites. anything else on your mind? | 11:37 |
lh | everyone, durin42 has the floor | 11:37 |
tlarsen | lh: it is just as annoying as when three separate conversations are going on in the same face-to-face meeting room. :) | 11:37 |
*** solydzajs has joined #melange | 11:38 | |
lh | tlarsen: it's the way of the open source team. and we are now both talking over durin42 too. :) | 11:38 |
durin42 | I'm going to look into various nose plugins for handling GAE stuff | 11:38 |
solydzajs | hi all | 11:38 |
lh | durin42: cool. | 11:38 |
solydzajs | sorry for being late | 11:38 |
durin42 | from what I've seen, they all have elements of suck | 11:38 |
durin42 | so I'll probably just write something basic we can use | 11:38 |
lh | solydzajs: hey. durin42 is updating us right now. | 11:38 |
SRabbelier | durin42: that would be good, seems like GAE has some particularities that need dealing with for testing | 11:38 |
lh | durin42: cool. what does this do exactly? | 11:38 |
durin42 | lh: makes it possible for people to write tests of the actual views and utility functions | 11:38 |
lh | durin42: very good, thanks for the explanation. | 11:39 |
lh | durin42: anything else on your mind? | 11:39 |
durin42 | Not really. | 11:39 |
solydzajs | durin42: I was also looking into pymox for mocking | 11:39 |
SRabbelier | solydzajs: yeah, that might be usefull with the django stuff | 11:40 |
durin42 | solydzajs: To be perfectly honest, I find a "real" mocking library superfluous with Python | 11:40 |
lh | ok you two get two minutes to talk about testing | 11:40 |
lh | then we are going to ask SRabbelier to update on what he's up to | 11:41 |
lh | then solydzajs | 11:41 |
* SRabbelier nods | 11:41 | |
lh | tlarsen has asked that we continue discussing the demo on list, so we will honor that request | 11:41 |
durin42 | I'd rather keep our deps down, and I don't see what pymox gets us. | 11:41 |
tlarsen | I have to agree with durin42 here. | 11:41 |
solydzajs | durin42: ;-) there is some project for using nose with appengine already | 11:41 |
solydzajs | durin42: http://code.google.com/p/nose-gae/ | 11:41 |
tpb | Title: nose-gae - Google Code (at code.google.com) | 11:41 |
tlarsen | It is so easy to mock even existing classes in Python. | 11:42 |
durin42 | solydzajs: I know, but I don't know if JP and Kumar are maintaining it | 11:42 |
durin42 | (I work with the guys that wrote that, the problem as I see it is that we'd have to install it globally) | 11:42 |
solydzajs | durin42: probably not :-) | 11:42 |
durin42 | Thus me looking into just having a 't.py' or something that sets up the environment and then calls nose's test runner | 11:43 |
SRabbelier | durin42: if it's only a simple file? | 11:43 |
tlarsen | durin42: Ummm, t.py? | 11:44 |
tlarsen | durin42: A more descriptive file name, perhaps? :) | 11:44 |
durin42 | tlarsen: or runtests.py or whatever | 11:44 |
durin42 | I'm working over a 1.5 second typing lag here, so cut me a bit of slack ;) | 11:44 |
durin42 | Anywho, that's the state of automated testing. With any luck, we'll have a usable testing framework by the end of the week. | 11:45 |
solydzajs | durin42: btw did you see the link I sent to the group about testing recipe ? | 11:45 |
durin42 | solydzajs: I did, but have not looked at it. I've been knee deep in subversion ctypes stuff until today or so. | 11:45 |
solydzajs | durin42: oh ok :-) | 11:45 |
durin42 | I'll be starting on this stuff around dinnertime for people in Chicago. | 11:46 |
lh | have we talked about testing enough? looks like we have..... | 11:46 |
durin42 | I think so. | 11:46 |
solydzajs | yep | 11:47 |
lh | okay next | 11:48 |
lh | SRabbelier: what's on your mind? | 11:48 |
SRabbelier | did everybody have a look at, or at least see http://codereviews.googleopensourceprograms.com/1602 ? | 11:49 |
tpb | <http://ln-s.net/2KTD> (at codereviews.googleopensourceprograms.com) | 11:49 |
* lh looks at sverre's code review | 11:49 | |
lh | SRabbelier: do you need people to review and comment before proceeding? | 11:50 |
solydzajs | SRabbelier: yes I did, but didn't have time to review yet | 11:50 |
SRabbelier | lh: well, I can finish it up to actual working code | 11:50 |
tlarsen | lh: for some things, YES. | 11:50 |
SRabbelier | lh: but before I start refactoring more modules I'd like it to be reviewed | 11:50 |
tlarsen | lh: For major new things, we need to discuss things. | 11:50 |
tlarsen | lh: Also, SRabbelier I believe indicated that this was speculative. | 11:50 |
SRabbelier | tlarsen: speculative? | 11:51 |
* SRabbelier is not sure what that means :$ | 11:51 | |
tlarsen | SRabbelier: OK, maybe not that particular review. | 11:51 |
lh | speculative means that it is not necessarily what you want to do, it is just an idea | 11:51 |
lh | okay, so | 11:51 |
lh | tlarsen: do you want to review and comment on 1602 now? | 11:51 |
SRabbelier | ok, -nods- | 11:51 |
SRabbelier | tlarsen: 1602 is what I think would be good, but I'm open for suggestions on how to do it better | 11:52 |
tlarsen | lh: During this meeting? I don't think that is a good idea. | 11:52 |
tlarsen | lh: You can't just mandate a code review. | 11:52 |
tlarsen | lh: We aren't going to pair-program over IRC, sorry. | 11:52 |
SRabbelier | tlarsen: for example the I'm using dicts to store some values, but it's probably a bit overkill | 11:52 |
lh | tlarsen: i am suggesting assigning action items for following this meeting. | 11:52 |
* SRabbelier saw some very awesome Eclipse plugin for pair programming the other day at solydzajs's reader | 11:52 | |
tlarsen | SRabbelier: I am working my way through a huge backlog of stuff you just committed on *Sunday*. | 11:52 |
tlarsen | SRabbelier: I was caught up on Saturday evening. :) | 11:53 |
lh | tlarsen: since you are not available due to car problems, is there someone you would like to review instead? i would suggest solydzajs | 11:53 |
tlarsen | lh: I want to review this. | 11:53 |
SRabbelier | tlarsen: -nods-, right, that was mostly in reply to your and pawels' suggestions I think, hopefully it'll mostly be LGTM's, no major changes | 11:53 |
solydzajs | tlarsen: I still have some commits to do regarding your comments to my commits from a week ago :-) | 11:53 |
tlarsen | lh: And I will *make* the time. | 11:53 |
lh | tlarsen: okay, great. can you give SRabbelier an ETA on a review? | 11:53 |
SRabbelier | solydzajs: -reads that a few times- | 11:53 |
tlarsen | lh: SRabbelier and I don't see some things eye-to-eye, and I at least want to get my specific $0.02 in. | 11:53 |
tlarsen | lh: Today. | 11:54 |
lh | tlarsen: that's a good thing. | 11:54 |
lh | tlarsen: okay, any idea when today? just because we are all in different time zones | 11:54 |
solydzajs | lh: yep it's better for tlarsen to review this, cause this is major change | 11:54 |
lh | solydzajs: agreed. just trying to get an idea of timing. | 11:54 |
tlarsen | lh: Before 3 AM Tuesday morning, CDT. | 11:55 |
lh | tlarsen: rocking. | 11:55 |
SRabbelier | tlarsen: ok, then I'll finish it up to where all sponsor views are actually with the new code in place, and put that up for review | 11:55 |
lh | SRabbelier: this means by tuesday afternoon your time you will have comments. can you prioritize your other work around this needed review? | 11:55 |
tlarsen | lh: My wife puts on a sleep mask and ear plugs, so I can work all night if needed. :) | 11:55 |
SRabbelier | after that I'll take a break to work on school stuff | 11:55 |
lh | tlarsen: rock on. :) | 11:55 |
* lh makes note: buy fashion earplugs for mrs. tlarsen | 11:55 | |
solydzajs | :-) | 11:56 |
tlarsen | lh: Ewwww... | 11:56 |
* SRabbelier chuckles | 11:56 | |
SRabbelier | tlarsen: it's called "sleepign, in stylleeee" | 11:56 |
lh | exactly | 11:56 |
lh | ok | 11:56 |
lh | SRabbelier: do you know what you need to do in between now and tlarsen's review of 1602? | 11:57 |
SRabbelier | lh: I don't have any other work atm except that (and the review) | 11:57 |
solydzajs | SRabbelier: start working on generic profiles | 11:57 |
solydzajs | SRabbelier: Roles | 11:57 |
SRabbelier | solydzajs: can you define that better? | 11:57 |
lh | SRabbelier: there you go, help pawel. | 11:57 |
SRabbelier | solydzajs: what is needed for those? | 11:58 |
*** mithro has joined #melange | 11:59 | |
*** ChanServ sets mode: +v mithro | 11:59 | |
*** lh changes topic to "Want to make Summer of Code and the Highly Open Participation Contest better? Melange is the next generation GSoC and GHOP web app - Code and more at http://code.google.com/p/soc/ - Want to contribute? Start here: http://code.google.com/p/soc/wiki/GettingStarted - Logs at http://ibot.rikers.org/%23melange within 24 hours" | 11:59 | |
solydzajs | SRabbelier: Generic Profile Form that can be reused in all Roles Profiles, Generic Logic for Profiles (saving in datastore etc) and user view/public view | 11:59 |
SRabbelier | solydzajs: ok, so like my earlier Person related commits? | 11:59 |
solydzajs | SRabbelier: yes like your earlier not finished commits :D | 12:00 |
SRabbelier | s/commits/review/ | 12:00 |
ibot | SRabbelier meant: solydzajs: ok, so like my earlier Person related review? | 12:00 |
SRabbelier | *LAUGHS* | 12:00 |
SRabbelier | omgomg! | 12:00 |
SRabbelier | that is too awesome | 12:00 |
SRabbelier | s/too/totally | 12:00 |
solydzajs | so we have too bots now for logging :-) | 12:00 |
SRabbelier | s/too/two/ ? | 12:00 |
* SRabbelier figures you need to include teh trailing slash | 12:01 | |
SRabbelier | s/teh/the/ | 12:01 |
SRabbelier | did I break it? 0.o | 12:01 |
lh | SRabbelier: focus! | 12:01 |
SRabbelier | solydzajs: ok, I can do that | 12:01 |
lh | SRabbelier: sounds like you have some unfinished coding work to get done. | 12:01 |
SRabbelier | solydzajs: with the new logic and view code it'll be easier | 12:01 |
SRabbelier | lh: I suspended it till after generic logic was done | 12:02 |
SRabbelier | lh: actually, the generic logic code came from working on that module | 12:02 |
lh | SRabbelier: so can you finish it now? | 12:02 |
SRabbelier | lh: yes | 12:03 |
lh | SRabbelier: there you go. | 12:03 |
lh | SRabbelier: anything else on your mind? | 12:03 |
SRabbelier | I'll do the (trivial) logic stuff first | 12:03 |
SRabbelier | and then wait to do the view code till after todd's review | 12:03 |
lh | SRabbelier: sounds good. | 12:03 |
SRabbelier | good thing I didn't delete that branch :P | 12:04 |
lh | okay | 12:05 |
lh | SRabbelier: you done? | 12:05 |
solydzajs | ok good | 12:05 |
tlarsen | Ugh, stupid IRC bot tricks. | 12:05 |
tlarsen | It will be a feature on Letterman before you know it. | 12:05 |
SRabbelier | lh: sure, I'm good to get started | 12:05 |
lh | SRabbelier: good. | 12:05 |
lh | tlarsen: what's on your mind for the next couple of days besides catching up on commits and commenting on CL 1602 for SRabbelier | 12:06 |
tlarsen | Besides taking another week off because the 50-mile hike was tortuous? | 12:06 |
SRabbelier | lh, tlarsen: well, and the fix-ups for r733 I reckon | 12:06 |
tlarsen | SRabbelier: Yes, undoing a bunch of stuff I didn't like in r733. :) | 12:06 |
SRabbelier | tlarsen: we're a concencus community though | 12:07 |
tlarsen | tlarsen: No, really. I want to get the Question/Answer and Questionnaire/Response models defined. | 12:07 |
SRabbelier | tlarsen: I think reverts should be after community concencus | 12:07 |
tlarsen | SRabbelier: Yes, but you didn't have consensus when you committed. :) | 12:07 |
lh | tlarsen: another week off is good. | 12:07 |
tlarsen | lh: one of the hazards of review-before-commit: commit wars! | 12:07 |
lh | tlarsen: you can't always wait for consensus to committ. | 12:07 |
lh | tlarsen: this is a war i am willing to fight. :) | 12:08 |
tlarsen | lh: Yes, and the one who didn't have consensus when he committed can't get upset when someone patches over them. | 12:08 |
tlarsen | lh: I will put my code where my mouth is. | 12:08 |
tlarsen | lh: I outlined in graphic detail in the previous discussion what I plan to do and why. | 12:08 |
lh | tlarsen: that is totally true. | 12:08 |
tlarsen | lh: Existing functionality was *removed* by r733. | 12:08 |
SRabbelier | tlarsen: see my reply to your comments in r733 | 12:09 |
lh | tlarsen: and did it cause breakage? | 12:09 |
tlarsen | lh: I will restore it in the current framework of r733. | 12:09 |
SRabbelier | tlarsen: and also CL1602 | 12:09 |
SRabbelier | tlarsen: I believe that will explain why I think it won't be needed | 12:09 |
tlarsen | lh: No, but it removed my ability to customize the login prompts per-page, which I was planning to do as soon as I had time. | 12:09 |
lh | tlarsen: can this be worked around? | 12:09 |
SRabbelier | tlarsen: right, but with the new view refactor you won't have to | 12:09 |
tlarsen | lh: The current UI is pretty lame regarding asking the user to login when they are not. | 12:09 |
SRabbelier | tlarsen: you can define it in teh base classes | 12:09 |
tlarsen | Sigh. | 12:09 |
lh | okay. so tlarsen, can you look at CL1602 first, then comment on r733? | 12:10 |
tlarsen | lh: The point is this: the functionality was removed, and justification for it being there was provided in the review-after-commit, but no justification of similar weight and coherency was provided as to why it should not be added back. But, yes, I will look at 1602 first. | 12:11 |
lh | tlarsen: thank you. perhaps that would be helpful. | 12:11 |
tlarsen | lh: consensus is meaningless when some of the parties do not justify their position with facts. | 12:11 |
lh | SRabbelier: you may also want to add more detail to r733 too | 12:11 |
lh | tlarsen: we're working on fixing that now, aren't we? :) | 12:11 |
SRabbelier | tlarsen: you read my latest comments to r733? | 12:11 |
tlarsen | lh: Why, yes, we are. | 12:11 |
lh | tlarsen: ++ | 12:12 |
tlarsen | lh: But, please don't be good cop to my bad cop, OK? | 12:12 |
lh | tlarsen: i'm not. i am facilitating. | 12:12 |
tlarsen | lh: So, you won't mind being disintermediated, then? | 12:12 |
lh | tlarsen: what does that mean? | 12:12 |
* lh uses google | 12:12 | |
tlarsen | lh: This discussion was going just fine in the code review thread. | 12:12 |
* tlarsen fucking hates IRC | 12:13 | |
SRabbelier | tlarsen: if you read my reply, please comment :) | 12:13 |
lh | tlarsen: this is how open source works todd | 12:13 |
tlarsen | It doesn't show when someone else is typing like Jabber does. | 12:13 |
lh | tlarsen: i dont think the discussion should not take place on list too. | 12:13 |
tlarsen | That is the primary reason why people type over each other. | 12:13 |
lh | there has to be a tool that accomodates. | 12:13 |
lh | tlarsen: i am happy to read on list comments too, but can't read them all. this meeting helps me keep in sync. other people, i hope, find it useful. | 12:14 |
tlarsen | lh: "this is how open source works" is also why asbestos underwear is required. :) | 12:14 |
solydzajs | i'm back, so where are we at ? | 12:14 |
durin42 | lh: TBQH, I hate irc too. It's a time drain, and sucks for having coherent conversations most of the time. | 12:16 |
* SRabbelier must be too young | 12:16 | |
tlarsen | durin42: exactly. | 12:16 |
solydzajs | how about we make a Skype conference call next time ? | 12:16 |
lh | durin42: to each their own | 12:16 |
lh | solydzajs: i like this idea. | 12:17 |
SRabbelier | solydzajs: +1 on that | 12:17 |
lh | tlarsen: thoughts? | 12:17 |
SRabbelier | does everybody have a mic/headset? | 12:17 |
solydzajs | SRabbelier: I do | 12:17 |
tlarsen | solydzajs: How about we just use Jabber, with the "someone is typing" indicator? | 12:17 |
SRabbelier | tlarsen: skype has that -nods- | 12:17 |
solydzajs | tlarsen: we can do that too, make a gtalk group chat | 12:17 |
SRabbelier | solydzajs: that would work | 12:17 |
durin42 | does pidgin support grouptalk on gtalk? | 12:18 |
SRabbelier | durin42: not really | 12:18 |
durin42 | (and if so, does Adium?) | 12:18 |
SRabbelier | durin42: only half | 12:18 |
SRabbelier | durin42: you get the invite, but last time I tried it didn't know what to do with it | 12:18 |
lh | i dont give a crap what tool we use. | 12:18 |
lh | you guys figure that out | 12:18 |
SRabbelier | I'm fine with whatever is good for you | 12:19 |
lh | i want tlarsen to be happy with our tool choice. sounds like jabber works well for him. however, skype offers voice. | 12:20 |
* SRabbelier doesn't have a jabber profile | 12:20 | |
SRabbelier | how do you make one? | 12:20 |
SRabbelier | jabber.com or such? | 12:20 |
solydzajs | SRabbelier: you have gmail.com | 12:20 |
SRabbelier | solydzajs: that works? | 12:20 |
solydzajs | SRabbelier: GTalk is based on XMPP and has group chat | 12:20 |
lh | do we all agree that our next meeting with be on GChat? | 12:21 |
lh | if so is there a way to bridge that so that our meeting still gets logged to our regular logs | 12:21 |
SRabbelier | lh: I'm good with gchat | 12:21 |
lh | okay. | 12:21 |
lh | GChat it is | 12:22 |
lh | i will paste the logs in channel so they get logged by ibot | 12:22 |
lh | okay | 12:22 |
lh | so | 12:22 |
lh | solydzajs: what are you up to right now? | 12:22 |
SRabbelier | tlarsen: on the email=id thing, it works only because str(id) returns id.email() | 12:23 |
tlarsen | SRabbelier: Yes, but id.email() is explicit and conveys *intent*. | 12:24 |
SRabbelier | tlarsen: Pawel asked me to do a patch to clean all those up and us id.email() everywhere | 12:24 |
tlarsen | SRabbelier: That is important in readable code. | 12:24 |
SRabbelier | tlarsen: right, I agree | 12:24 |
tlarsen | SRabbelier: Yes, please fix this. | 12:24 |
solydzajs | lh: after recent code reviews, I'm working on Delete Document feature and when I commit that I will move to Promote to Host probably | 12:25 |
lh | solydzajs: sounds good. | 12:25 |
tlarsen | SRabbelier: we have pretty much established "id" in the code meaning Google Account (as a users.User object). | 12:25 |
SRabbelier | tlarsen: ok, then let's go with that everywhere | 12:25 |
SRabbelier | tlarsen: I'll double check the code to see if it's not abused anywhere | 12:25 |
lh | ok gentlemen | 12:26 |
lh | i am 30 minutes late for another meeting | 12:26 |
lh | _Allen_ requested that we move our next meeting back so he could attend | 12:26 |
lh | does this work for all? | 12:26 |
lh | http://tinyurl.com/melangemondaymeeting | 12:26 |
tpb | Title: The World Clock - Time Zone Converter - U.S.A. California San Francisco vs Poland Warsaw (at tinyurl.com) | 12:26 |
SRabbelier | lh: 3am in the morning? | 12:27 |
SRabbelier | :P | 12:27 |
SRabbelier | why is our next meeting so soon though? | 12:27 |
solydzajs | 3 AM doesn't work for me :-) | 12:27 |
SRabbelier | solydzajs: same here | 12:27 |
lh | hrm. | 12:28 |
lh | SRabbelier: it was our regularly scheduled meeting | 12:28 |
lh | i will just check in with _Allen_ tonight | 12:28 |
lh | do we need that meeting at all? | 12:28 |
SRabbelier | not me personally | 12:28 |
lh | solydzajs: you need it? | 12:29 |
lh | tlarsen: you need it? | 12:29 |
lh | durin42: you need it? | 12:29 |
solydzajs | lh: tlarsen wrote _Allen_ what he could work on, so I think he will be fine when he reads his inbox :-) | 12:29 |
tlarsen | lh: No I do not. | 12:29 |
tlarsen | lh: I believe these are mostly for you. :) | 12:29 |
lh | tlarsen: done, today is canceled | 12:30 |
lh | i will still check in with _Allen_ | 12:30 |
*** mithro has quit IRC | 12:30 | |
lh | tlarsen: i scheduled them because people wanted to make sure i was commenting. :) so i hope they are good for more than just me. | 12:30 |
tlarsen | lh: I'm sure he will check his email once power is restored. | 12:30 |
solydzajs | Is there anything else to discuss ? I would like to get back to work and do some coding :-) | 12:31 |
* SRabbelier would like to get to dinner himself :P | 12:32 | |
lh | SRabbelier: go eat | 12:32 |
lh | tlarsen: always nice to say hello too | 12:32 |
lh | solydzajs: i think we are done | 12:32 |
lh | anyone have anything to add? | 12:32 |
SRabbelier | lh: I like them, it's nice to make sure we all stay in touch | 12:33 |
SRabbelier | uhm, "Eta Beta Pi" (eat a better pie :P) | 12:33 |
lh | SRabbelier: cool. | 12:33 |
lh | SRabbelier: wtf dude. :p | 12:33 |
SRabbelier | :D | 12:33 |
lh | alright | 12:33 |
* lh goes to other meeting | 12:33 | |
SRabbelier | lh: ok, ttyl | 12:34 |
* tlarsen definitely prefers the store-and-forward nature of email, given his ridiculously hectic schedule. | 12:34 | |
solydzajs | okie dokie guys :-) | 12:36 |
solydzajs | I'm going back to coding | 12:36 |
solydzajs | ciao | 12:37 |
tlarsen | Sigh. I am continuing to code review. | 12:37 |
* tlarsen puts on his Code Review Monkey hat. | 12:37 | |
solydzajs | yay | 12:38 |
solydzajs | ttyl | 12:38 |
solydzajs | i'm going offline | 12:38 |
solydzajs | :-) | 12:38 |
*** solydzajs has quit IRC | 12:38 | |
tlarsen | SRabbelier: was this committed? http://codereviews.googleopensourceprograms.com/1601 | 12:39 |
tpb | <http://ln-s.net/2KUU> (at codereviews.googleopensourceprograms.com) | 12:39 |
tlarsen | SRabbelier: If so, has the review been marked "closed"? | 12:39 |
SRabbelier | tlarsen: mhhh, yes, it has been committed, didn't close it yet since you hadn't commented on that version; I'll close it now | 12:40 |
*** mithro has joined #melange | 12:47 | |
*** ChanServ sets mode: +v mithro | 12:47 | |
*** madrazr has quit IRC | 12:55 | |
SRabbelier | tlarsen: pawel and I suggested earlier for the reviewer today to fix style mistakes instead of pointing them out, since now it takes trice the time; once for you to point them out, once for me to fix them, then once more for you to see if they were fixed to satistfaction | 13:13 |
SRabbelier | tlarsen: style, spelling, indentation, little things like that | 13:14 |
tlarsen | SRabbelier: Sorry, but when I am code reviewing, I point out everything. I don't know until I am done that I will end up with only style mistakes. | 13:15 |
tlarsen | So, I send out what I have already taken the time to type. | 13:15 |
tlarsen | SRabbelier: when I am focused on the code, I see everything (or, I am not focused enough and miss important stuff). | 13:16 |
tlarsen | SRabbelier: Sorry, but that is the way my brain works. :) | 13:16 |
tlarsen | SRabbelier: I don't know how to do two different kinds of code review. I don't think the burden should be on the reviewer, since review-before-commit would catch this and the burden would still be on the committer. | 13:17 |
tlarsen | SRabbelier: it is part of the price that is paid for review-after-commit. | 13:17 |
tlarsen | SRabbelier: That being said, when I see stuff in existing files that I am modifying, I'll just fix it. | 13:17 |
tlarsen | SRabbelier: This is one of the reasons we do not do review-after-commit at Google, ever (except for to-be-reviewed *emergencies*). | 13:17 |
SRabbelier | tlarsen: ok, I understand, no problem :) | 13:31 |
SRabbelier | tlarsen: thanks for the explanation :) | 13:31 |
tlarsen | SRabbelier: The point is that the committer, not the reviewer, is responsible for correctly reviewer comments. | 13:34 |
SRabbelier | tlarsen: yes, I agree on the responsibility part -nod- | 13:34 |
tlarsen | I have *tons* of reviews sent to me each week. If I had to *fix* as well as review, I'd just stop reviewing. :) | 13:35 |
tlarsen | (Melange plus Google internal code reviews) | 13:35 |
SRabbelier | tlarsen: -nod-, yeah, I can imagine | 13:35 |
*** mithro has quit IRC | 14:00 | |
tlarsen | SRabbelier: OK, first thoughts on 1602 sent. | 14:26 |
SRabbelier | tlarsen: thanks, -reads- | 14:26 |
tlarsen | Sorry it took so long. | 14:27 |
tlarsen | SRabbelier: I had a lot to say, I suppose. | 14:27 |
SRabbelier | tlarsen: I don't see a TODo above existing code? | 14:27 |
SRabbelier | it's ok, :) | 14:27 |
SRabbelier | tlarsen: oh, on the silly import naming scheme, sometimes it just breaks for no reason | 14:28 |
SRabbelier | tlarsen: when you do "from soc.logic import models" and then later on models.settings, it says there's no settings module | 14:28 |
tlarsen | Please respond in the code review tool and not on IRC. | 14:28 |
tlarsen | Thanks. | 14:28 |
tlarsen | Yes, you need: | 14:28 |
tlarsen | from soc.logic.models import settings | 14:29 |
tlarsen | Then just use settings.Foo() | 14:29 |
tlarsen | Or: | 14:29 |
tlarsen | from soc.logic import models | 14:29 |
tlarsen | import soc.logic.models.settings | 14:29 |
tlarsen | and then models.settings will work. | 14:29 |
SRabbelier | tlarsen: aaaah, ok! | 14:29 |
SRabbelier | tlarsen: thank you! | 14:29 |
* SRabbelier goes to clean up code | 14:29 | |
SRabbelier | tlarsen: how about a script that detects things like that; do you know of one? | 14:31 |
tlarsen | pychecker? | 14:31 |
SRabbelier | tlarsen: mhh, I remember you mentioning it earlier, was there a reason we're not really using it? | 14:32 |
tlarsen | I am all out of round tuits. | 14:33 |
SRabbelier | round tuits? | 14:33 |
tlarsen | "I will do it when I get around to it..." | 14:51 |
tlarsen | "a round tuit" | 14:51 |
SRabbelier | lol, ok | 14:51 |
tlarsen | http://www.myrtlewoodgallery.com/get_a_round_tuit.htm | 14:51 |
tpb | <http://ln-s.net/2KWs> (at www.myrtlewoodgallery.com) | 14:51 |
tlarsen | I have lots of the square ones these days. | 14:52 |
SRabbelier | tlarsen: cute, never heard that one :) | 14:52 |
*** mithro has joined #melange | 14:53 | |
*** ChanServ sets mode: +v mithro | 14:53 | |
*** mithro has quit IRC | 15:25 | |
SRabbelier | tlarsen: replied :) | 15:42 |
SRabbelier | tlarsen: thanks for the detailed review | 15:42 |
*** TimRiker has quit IRC | 16:49 | |
*** TimRiker has joined #melange | 17:04 | |
*** TimRiker has left #melange | 17:05 | |
*** lh has quit IRC | 17:16 | |
*** solydzajs has joined #melange | 17:17 | |
*** ChanServ sets mode: +v solydzajs | 17:17 | |
solydzajs | tlarsen: ping | 17:18 |
SRabbelier | tlarsen: replying now, then going to bed :) | 17:18 |
solydzajs | tlarsen: "Pawel, what about the more-generic HomeSettings class that already exists in soc/models/home_settings.py?" You mean to replace SiteSettings with HomeSettings ?because right now SiteSettings inherits from HomeSettings | 17:19 |
*** James--Crook has joined #melange | 18:03 | |
*** James--Crook has left #melange | 18:21 | |
SRabbelier | time for bed | 18:33 |
SRabbelier | g'night | 18:33 |
SRabbelier | holy cr*p | 18:34 |
SRabbelier | solydzajs: damn Pawel, please tell me you used a script to sort those imports? | 18:36 |
solydzajs | SRabbelier: yo :-) | 18:36 |
solydzajs | SRabbelier: no | 18:36 |
solydzajs | SRabbelier: why ?;-) | 18:36 |
SRabbelier | solydzajs: cos I hate manual labor like that :P | 18:37 |
SRabbelier | solydzajs: nice job! | 18:37 |
solydzajs | SRabbelier: it was my break (no need to use brain ;-) ) :D | 18:37 |
SRabbelier | solydzajs: thanks for applying Todd's suggestions, I did not have time to code at all today, have been doing code review (well, it was really design the app I guess) all day | 18:38 |
SRabbelier | solydzajs: hehe, sweet :) | 18:38 |
solydzajs | sure no problem | 18:38 |
solydzajs | I just need to clear my inbox | 18:38 |
solydzajs | :-) | 18:38 |
solydzajs | so I'm fixing what ever I can | 18:38 |
solydzajs | :-) | 18:38 |
SRabbelier | solydzajs: awesome :) | 18:39 |
SRabbelier | solydzajs: btw, implicit LGTM on everything that I don't comment on :P | 18:40 |
solydzajs | SRabbelier: ok :-) | 18:40 |
SRabbelier | (downside of that ofcourse is if for some reason I don't have time to review, a LGTM is unjustifiedly assumed :P) | 18:41 |
SRabbelier | anyway | 18:41 |
SRabbelier | I must really be off to bed now | 18:41 |
SRabbelier | solydzajs: ps: will you code the _as_table template? | 18:41 |
solydzajs | SRabbelier: hopefully tomorrow | 18:41 |
SRabbelier | solydzajs: really? awesome! | 18:42 |
SRabbelier | hopefully we can generalize even more views that way :) | 18:42 |
solydzajs | SRabbelier: hope so | 18:42 |
SRabbelier | g'night then :) | 18:43 |
SRabbelier | tlarsen: thanks for the reviews (it felt more like design than review though :), that's good I think) | 18:43 |
solydzajs | g'night | 18:45 |
*** SRabbelier has quit IRC | 19:11 | |
*** solydzajs has quit IRC | 19:24 | |
*** _Allen_ has joined #melange | 19:36 | |
*** tansell has joined #melange | 20:10 | |
tlarsen | _Allen_: I have not yet gotten to creating those Question, Answer, etc. models. I will have to do it tomorrow morning. | 20:17 |
tlarsen | _Allen_: I spent all day getting caught up on outstanding code reviews that piled up while I was on vacation last week. | 20:17 |
tlarsen | _Allen_: The Question and Answer stuff is at the top of my TODO list, though, so I will work on it first thing tomorrow. | 20:18 |
tlarsen | I've got to sign off now. | 20:18 |
*** tlarsen has quit IRC | 20:18 | |
_Allen_ | tlarsen: that's ok | 20:18 |
*** penyaskito has joined #melange | 21:14 | |
*** lh has joined #melange | 21:26 | |
*** ChanServ sets mode: +o lh | 21:26 | |
lh | _Allen_: ping | 21:26 |
_Allen_ | lh: morning | 21:43 |
lh | _Allen_: how are you? | 21:45 |
lh | we are not really meeting tonight | 21:45 |
lh | everyone is sleeping | 21:45 |
lh | but i did want to check in on you | 21:45 |
_Allen_ | lh: fine | 21:45 |
_Allen_ | lh: I just got up | 21:46 |
_Allen_ | lh: and I am reading the IRC log | 21:46 |
_Allen_ | lh: that's ok | 21:47 |
lh | _Allen_: very cool on reading the logs | 21:47 |
_Allen_ | lh: so, will we use Gtalk on later meeting? | 21:47 |
lh | _Allen_: sure can | 21:52 |
lh | we will work that out | 21:52 |
lh | i have to go get dinner, bbl | 21:52 |
_Allen_ | lh: see u | 21:52 |
*** webchick has quit IRC | 22:51 | |
*** _Allen_ has left #melange | 22:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!